Rewrite the app's entry and leaf components; drop the empty upsell #122

Merged

jcoffey-dev merged 1 commits from phase2/leaves into main 2026-10-19 00:54:23 +00:00

Conversation 0 Commits 1 Files Changed 17

+175 -236

jcoffey-dev commented 2026-10-19 00:52:13 +00:00

Owner

Copy link

Copy source

Phase 2, part 2. Stacked on #121, so merge that first.

• Rewritten: main.tsx, App, the i18n setup, index.css's theme mapping and base styles, the not-found and loading pages, ProtectedRoute, the lazy admin panel, the form edition context, the Sievepad button, the logo and the env types. Routes, strings, storage keys and the look are unchanged.
• Removed: EnterpriseUpsell. inbuxa has one edition with everything in it, so it never opened. The section menu, sidebar, top bar and list no longer hold state for it.

	Not upstream's	Upstream lines left	Dual headers
previous PR	78.0%	16,404 in 85 files	70
this PR	78.6%	15,965 in 72 files	57

Visual check: see #121. That check covered the whole phase 2 stack and found no change in the UI.

Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

Phase 2, part 2. Stacked on #121, so merge that first. - **Rewritten:** `main.tsx`, `App`, the i18n setup, `index.css`'s theme mapping and base styles, the not-found and loading pages, `ProtectedRoute`, the lazy admin panel, the form edition context, the Sievepad button, the logo and the env types. Routes, strings, storage keys and the look are unchanged. - **Removed:** `EnterpriseUpsell`. inbuxa has one edition with everything in it, so it never opened. The section menu, sidebar, top bar and list no longer hold state for it. | | Not upstream's | Upstream lines left | Dual headers | |---|---|---|---| | previous PR | 78.0% | 16,404 in 85 files | 70 | | this PR | 78.6% | 15,965 in 72 files | 57 | **Visual check:** see #121. That check covered the whole phase 2 stack and found no change in the UI. Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

jcoffey-dev added 2 commits 2026-10-19 00:52:13 +00:00

Rewrite the small helpers and their tests ... 1360abd6df

Sizes and durations, the list filter, development logging, the logo cache,
last visited pages, the Sieve playground link, JMAP error messages, the
JMAP list helper, cn, the base path, the document title and the buffered
value hooks are rewritten from what they do, with new tests written first:
debug, the logo cache, last visited, JMAP errors and the JMAP list helper
had none. Behavior, exports and strings are unchanged; the playground link
keeps its format and last visited keeps its storage key.

Rewrite the app's entry and leaf components; drop the empty upsell ... 683ac7dcbe

main.tsx, App, the i18n setup, index.css's theme mapping and base styles,
the not-found and loading pages, ProtectedRoute, the lazy admin panel, the
form edition context, the Sievepad button, the logo and the env types are
rewritten in our own words. Routes, strings, storage keys and the look are
unchanged.

EnterpriseUpsell goes: inbuxa has one edition with everything in it, so it
never opened. The menu, sidebar, top bar and list no longer hold state for
it; a locked item (which never occurs) simply does nothing.

jcoffey-dev referenced this pull request 2026-10-19 00:52:19 +00:00

Rewrite the config files; drop what nothing uses #123

jcoffey-dev merged commit 9ed49246e7 into main 2026-10-19 00:54:23 +00:00

jcoffey-dev deleted branch phase2/leaves 2026-10-19 00:54:24 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

Dependency updates

documentation

Docs, README or site copy

duplicate

Already tracked elsewhere

enhancement

New feature or improvement

good first issue

Good for newcomers

help wanted

Contributions welcome

invalid

Not a valid issue

needs info

Waiting on the reporter for details

question

Needs an answer, not a code change

security

Security issue or hardening

translation

New language or translation fixes

wontfix

Will not be worked on

priority

p1

High priority

priority

p2

Medium priority

priority

p3

Low priority

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jcoffey-dev (John Coffey)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#122