Rewrite the small helpers and their tests #121

Merged

jcoffey-dev merged 1 commits from phase2/libs into main

2026-10-19 00:54:21 +00:00

jcoffey-dev commented

2026-10-19 00:52:06 +00:00

Owner

Phase 2 of the console rewrite, part 1.

These are rewritten from what they do, with new tests written first:

sizes and durations
the list filter
development logging
the logo cache
last visited pages
the Sieve playground link
JMAP error messages
the JMAP list helper
cn, the base path, the document title and the buffered-value hooks

Debug, the logo cache, last visited, JMAP errors and the JMAP list helper had no tests before. Upstream's duration, list filter and playground tests are replaced by ours. The suite goes from 694 to 692 tests: upstream checked one duration case per test, and ours run more cases through table-driven tests. Behavior, exports and strings are unchanged. The playground link keeps its format, and last visited keeps its storage key.

	Not upstream's	Upstream lines left	Dual headers
main	76.6%	17,435 in 100 files	85
this PR	78.0%	16,404 in 85 files	70

Visual check: I screenshotted all 163 pages in light and dark on a local preview, plus the open menus, command palette, a dialog, a select, a combobox and toasts, and diffed them pixel by pixel against phase 1. This covers the whole phase 2 stack. Nothing in the UI changed: the only differences were live data (the dashboard clock and greeting, a connection count, and the audit log row for the run's own sign-in).

Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

Phase 2 of the console rewrite, part 1. These are rewritten from what they do, with new tests written first: - sizes and durations - the list filter - development logging - the logo cache - last visited pages - the Sieve playground link - JMAP error messages - the JMAP list helper - `cn`, the base path, the document title and the buffered-value hooks Debug, the logo cache, last visited, JMAP errors and the JMAP list helper had no tests before. Upstream's duration, list filter and playground tests are replaced by ours. The suite goes from 694 to 692 tests: upstream checked one duration case per test, and ours run more cases through table-driven tests. Behavior, exports and strings are unchanged. The playground link keeps its format, and last visited keeps its storage key. | | Not upstream's | Upstream lines left | Dual headers | |---|---|---|---| | main | 76.6% | 17,435 in 100 files | 85 | | this PR | 78.0% | 16,404 in 85 files | 70 | **Visual check:** I screenshotted all 163 pages in light and dark on a local preview, plus the open menus, command palette, a dialog, a select, a combobox and toasts, and diffed them pixel by pixel against phase 1. This covers the whole phase 2 stack. Nothing in the UI changed: the only differences were live data (the dashboard clock and greeting, a connection count, and the audit log row for the run's own sign-in). Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

jcoffey-dev added 1 commit 2026-10-19 00:52:07 +00:00

Rewrite the small helpers and their tests

ci / build (pull_request) Skipped

Details

ci / notices (pull_request) Successful in 1m31s

Details

ci / publish (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 1m50s

Details

1360abd6df

Sizes and durations, the list filter, development logging, the logo cache,
last visited pages, the Sieve playground link, JMAP error messages, the
JMAP list helper, cn, the base path, the document title and the buffered
value hooks are rewritten from what they do, with new tests written first:
debug, the logo cache, last visited, JMAP errors and the JMAP list helper
had none. Behavior, exports and strings are unchanged; the playground link
keeps its format and last visited keeps its storage key.

jcoffey-dev referenced this pull request

2026-10-19 00:52:13 +00:00

Rewrite the app's entry and leaf components; drop the empty upsell #122

jcoffey-dev referenced this pull request

2026-10-19 00:52:19 +00:00

Rewrite the config files; drop what nothing uses #123

jcoffey-dev merged commit c55f158a16 into main

2026-10-19 00:54:21 +00:00

jcoffey-dev deleted branch phase2/libs

2026-10-19 00:54:22 +00:00