Restoring a kept user (inbuxa:DeletedAccount/set with restore: true) replaced its existing password credential, and refused when it had none. So a user created without a password could be destroyed from Deleted Accounts but never restored.
The new password is now set the way setting one on a live account does (UserAccount::set_password): it replaces the password credential, or becomes one. Its expiry follows the server default as before, and the other credentials stay. A new password is still required for every restored user (UD-17).
Test: the undelete test (acceptance test 14) now also restores a user created with no password and signs in with the new one.
Checked locally: cargo check -p jmap -p tests --tests and cargo fmt. The undelete integration test is running locally, and I'll report its result here.
Fixes #326.
Restoring a kept user (`inbuxa:DeletedAccount/set` with `restore: true`) replaced its existing password credential, and refused when it had none. So a user created without a password could be destroyed from Deleted Accounts but never restored.
The new password is now set the way setting one on a live account does (`UserAccount::set_password`): it replaces the password credential, or becomes one. Its expiry follows the server default as before, and the other credentials stay. A new password is still required for every restored user (UD-17).
Test: the undelete test (acceptance test 14) now also restores a user created with no password and signs in with the new one.
Checked locally: `cargo check -p jmap -p tests --tests` and `cargo fmt`. The undelete integration test is running locally, and I'll report its result here.
Restoring a kept user replaced the password credential it had with the
new password, and refused when there was none: "The kept account has no
password credential." A user created without a password could be
destroyed from Deleted Accounts, but never restored.
The new password is now set the way setting one on a live account does:
it replaces the password credential, or becomes one when there isn't
one. Its expiry follows the server's default as before, and the other
credentials stay.
The undelete test restores a user created with no password and signs in
with the new one. Reported on the forum (t/232, post 8).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #326.
Restoring a kept user (
inbuxa:DeletedAccount/setwithrestore: true) replaced its existing password credential, and refused when it had none. So a user created without a password could be destroyed from Deleted Accounts but never restored.The new password is now set the way setting one on a live account does (
UserAccount::set_password): it replaces the password credential, or becomes one. Its expiry follows the server default as before, and the other credentials stay. A new password is still required for every restored user (UD-17).Test: the undelete test (acceptance test 14) now also restores a user created with no password and signs in with the new one.
Checked locally:
cargo check -p jmap -p tests --testsandcargo fmt. The undelete integration test is running locally, and I'll report its result here.The undelete integration test passes locally on RocksDB (
system::undelete::undelete_tests, 1 passed, 15 s), including the new no-password restore.