Reported on the forum (https://community.coffeylabs.org/t/232, post 8). A user created with no password, deleted, then restored from Deleted Accounts: with the password box empty the console says it can't be empty, and with a password the server refuses with "The kept account has no password credential." The account can be destroyed but never restored.
Cause: restore_account (crates/jmap/src/inbuxa/deleted_account.rs, ~line 403) requires a new password for every user, then looks for an existing Credential::Password to put it in. A user that never had one has nothing to replace, so the restore stops there.
Fix:
When the kept user has no password credential, add one with the new password instead of refusing.
Decide whether a user with no password may come back with none (one that only signs in another way). If so, the password is optional for those, and the console's Deleted Accounts dialog says so instead of insisting on one.
Test: a kept user with no password restores with a new password and can sign in with it. Add the case to the UD spec's test list.
Reported on the forum (https://community.coffeylabs.org/t/232, post 8). A user created with no password, deleted, then restored from Deleted Accounts: with the password box empty the console says it can't be empty, and with a password the server refuses with "The kept account has no password credential." The account can be destroyed but never restored.
Cause: `restore_account` (`crates/jmap/src/inbuxa/deleted_account.rs`, ~line 403) requires a new password for every user, then looks for an existing `Credential::Password` to put it in. A user that never had one has nothing to replace, so the restore stops there.
Fix:
- When the kept user has no password credential, add one with the new password instead of refusing.
- Decide whether a user with no password may come back with none (one that only signs in another way). If so, the password is optional for those, and the console's Deleted Accounts dialog says so instead of insisting on one.
- Test: a kept user with no password restores with a new password and can sign in with it. Add the case to the UD spec's test list.
Fixed in #330 (cca787f7). Restoring a kept user now sets the new password the same way setting one on a live account does: it replaces the password credential, or adds one when there isn’t one. The undelete test restores a user created with no password and signs in with the new one. Ships in the next server rc.
Fixed in #330 (cca787f7). Restoring a kept user now sets the new password the same way setting one on a live account does: it replaces the password credential, or adds one when there isn’t one. The undelete test restores a user created with no password and signs in with the new one. Ships in the next server rc.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Reported on the forum (https://community.coffeylabs.org/t/232, post 8). A user created with no password, deleted, then restored from Deleted Accounts: with the password box empty the console says it can't be empty, and with a password the server refuses with "The kept account has no password credential." The account can be destroyed but never restored.
Cause:
restore_account(crates/jmap/src/inbuxa/deleted_account.rs, ~line 403) requires a new password for every user, then looks for an existingCredential::Passwordto put it in. A user that never had one has nothing to replace, so the restore stops there.Fix:
Fixed in #330 (
cca787f7). Restoring a kept user now sets the new password the same way setting one on a live account does: it replaces the password credential, or adds one when there isn’t one. The undelete test restores a user created with no password and signs in with the new one. Ships in the next server rc.