Security fixes for 27.1-rc.16 #90

Merged
jcoffey-dev merged 2 commits from sec/batch-6 into main 2026-11-18 01:20:24 +00:00
2 Commits
Author SHA1 Message Date
jcoffey-dev 1f032276f0 Deps: certificate checks no longer trust distrusted emSign intermediates
ci / test (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 7m32s
ci / announce (pull_request) Skipped
The lockfile pinned rustls-webpki 0.103.15 and webpki-root-certs 1.0.9,
which still accept certificates chained through emSign intermediates that
are now distrusted (RUSTSEC-2026-0382, RUSTSEC-2026-0383). inbuxa-migrate
signs in to source mail servers over TLS with administrator credentials
(IMAP, JMAP, DAV, HTTP), so someone on the path holding such a certificate
could pose as the source and capture them.

rustls-webpki is now 0.103.17 and webpki-root-certs 1.0.12; nothing else
in the lockfile moves.

Test: cargo audit reported both advisories before; it reports neither now,
and cargo test --locked passes.
2026-11-17 14:59:24 -07:00
jcoffey-dev 1c80f28cb6 Import: never send the shared profile's key to a source server
import jmap read the shared ~/.config/inbuxa profile, which names the
inbuxa server and holds its API key, and fell back to that key whenever no
flag or INBUXA_MIGRATE_* variable gave one -- even with a bare
--auth-bearer, which is documented to prompt. But import jmap reads FROM a
source server, often another provider's, so the inbuxa key went as a
bearer token to whatever --url named. An operator with a default profile
who ran import jmap against another server handed that server (or anyone
who controlled or watched the URL) an inbuxa administrator key.

import jmap no longer reads the profile: --url is required again,
--profile is gone from it, and the source's credentials come from a flag,
an INBUXA_MIGRATE_* variable or the prompt. import-directory, which does
write to the inbuxa server, keeps the profile, but now sends its key only
to the profile's own origin; a --url with another scheme, host or port gets
no key from the profile. The --url help, the README, usage.md and the
missing-secret message no longer describe import as writing to inbuxa.

Test: import_jmap_never_takes_the_url_or_key_from_the_profile and
import_directory_sends_the_profile_key_only_to_the_profile_url failed
before (the profile's url and key were used for import jmap, and the key
went to another --url on import-directory); both pass now.
2026-11-17 14:57:25 -07:00