The dashboard counted a DMARC report as "with warnings" if any row had SPF or DKIM failing, so forwarded mail (SPF fail, DKIM pass) was a warning there while the DMARC reports page called the same messages passed (reported in forum t/232). Now a report has warnings only when a row fails DMARC, meaning neither aligned SPF nor aligned DKIM passed, which is how the reports page already counts. The counts on the event don't change.
Unit tests for the rule, plus smtp::reporting::analyze, the build and --no-run of the workspace tests, all pass locally.
The dashboard counted a DMARC report as "with warnings" if any row had SPF or DKIM failing, so forwarded mail (SPF fail, DKIM pass) was a warning there while the DMARC reports page called the same messages passed (reported in forum t/232). Now a report has warnings only when a row fails DMARC, meaning neither aligned SPF nor aligned DKIM passed, which is how the reports page already counts. The counts on the event don't change.
Unit tests for the rule, plus `smtp::reporting::analyze`, the build and `--no-run` of the workspace tests, all pass locally.
Fixes #391
A DMARC report counted as "with warnings" when any row had SPF or DKIM
failing, or a quarantine or reject disposition. DMARC passes when
either aligned result passes, so forwarded mail (SPF fail, DKIM pass)
showed as a warning on the dashboard while the console's reports page
counted the same messages as passed.
A report is now with warnings only when a row fails DMARC: neither the
aligned SPF nor the aligned DKIM result passed. The pass, fail and
disposition counts on the event are unchanged.
Fixes#391
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The dashboard counted a DMARC report as "with warnings" if any row had SPF or DKIM failing, so forwarded mail (SPF fail, DKIM pass) was a warning there while the DMARC reports page called the same messages passed (reported in forum t/232). Now a report has warnings only when a row fails DMARC, meaning neither aligned SPF nor aligned DKIM passed, which is how the reports page already counts. The counts on the event don't change.
Unit tests for the rule, plus
smtp::reporting::analyze, the build and--no-runof the workspace tests, all pass locally.Fixes #391