DMARC reports: a warning means a message failed DMARC #392

Merged
jcoffey-dev merged 1 commits from fix/dmarc-report-warnings into main 2026-11-13 19:19:54 +00:00
Owner

The dashboard counted a DMARC report as "with warnings" if any row had SPF or DKIM failing, so forwarded mail (SPF fail, DKIM pass) was a warning there while the DMARC reports page called the same messages passed (reported in forum t/232). Now a report has warnings only when a row fails DMARC, meaning neither aligned SPF nor aligned DKIM passed, which is how the reports page already counts. The counts on the event don't change.

Unit tests for the rule, plus smtp::reporting::analyze, the build and --no-run of the workspace tests, all pass locally.

Fixes #391

The dashboard counted a DMARC report as "with warnings" if any row had SPF or DKIM failing, so forwarded mail (SPF fail, DKIM pass) was a warning there while the DMARC reports page called the same messages passed (reported in forum t/232). Now a report has warnings only when a row fails DMARC, meaning neither aligned SPF nor aligned DKIM passed, which is how the reports page already counts. The counts on the event don't change. Unit tests for the rule, plus `smtp::reporting::analyze`, the build and `--no-run` of the workspace tests, all pass locally. Fixes #391
jcoffey-dev added 1 commit 2026-11-13 19:10:07 +00:00
DMARC reports: a warning means a message failed DMARC
ci / fork-checks (pull_request) Skipped
ci / build (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 9m28s
02a7f2886e
A DMARC report counted as "with warnings" when any row had SPF or DKIM
failing, or a quarantine or reject disposition. DMARC passes when
either aligned result passes, so forwarded mail (SPF fail, DKIM pass)
showed as a warning on the dashboard while the console's reports page
counted the same messages as passed.

A report is now with warnings only when a row fails DMARC: neither the
aligned SPF nor the aligned DKIM result passed. The pass, fail and
disposition counts on the event are unchanged.

Fixes #391
jcoffey-dev merged commit 8be2ef7d0c into main 2026-11-13 19:19:54 +00:00
jcoffey-dev deleted branch fix/dmarc-report-warnings 2026-11-13 19:19:54 +00:00
Sign in to join this conversation.