inbuxa/inbuxa-server
1
1 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 54 Wiki Activity Sponsor

Milter: keep the reply code and text in delivery traces #293

Merged
jcoffey-dev merged 2 commits from fix/milter-reply-code-trace into main 2026-11-05 04:46:21 +00:00
Conversation 0 Commits 2 Files Changed 2
+69 -19
jcoffey-dev commented 2026-11-05 04:18:21 +00:00
Owner
Copy link
Copy source

When a milter rejects with a custom reply, the client sees the code and text but the trace only says "Reply code". This records both, so you can see why from the trace. SMTP replies don't change.

The first commit is Stefan's patch from #289, thanks Stefan. The second records the code as a number, as outbound traces do, trims the line ending, keeps the fields off the other actions, and adds the modification notice.

Closes #289

When a milter rejects with a custom reply, the client sees the code and text but the trace only says "Reply code". This records both, so you can see why from the trace. SMTP replies don't change. The first commit is Stefan's patch from #289, thanks Stefan. The second records the code as a number, as outbound traces do, trims the line ending, keeps the fields off the other actions, and adds the modification notice. Closes #289
jcoffey-dev added 2 commits 2026-11-05 04:18:21 +00:00
Preserve Milter SMTP reply code and text in delivery traces 2e8e9c4fcd 
Populate the existing Code and Details trace fields for Milter ReplyCode actions without changing the SMTP response. Extend the existing session test to check the actual emitted event and complete reply.
Milter reply traces: numeric code, no empty fields
github/ci (branch) GitHub Actions
Details
ci / fork-checks (pull_request) Skipped
Details
ci / build (pull_request) Skipped
Details
ci / github (pull_request) Successful in 5s
Details
50fab51d51 
Record Code as a number, as outbound SMTP traces do, and trim the line
ending off Details. Only the reply-code event gets the two fields, so text
logs don't show "(null)" for them on the other actions. Add the
modification notice.
jcoffey-dev merged commit 11279c6e1e into main 2026-11-05 04:46:21 +00:00
jcoffey-dev deleted branch fix/milter-reply-code-trace 2026-11-05 04:46:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Dependency updates
 documentation
Docs, README or site copy
 duplicate
Already tracked elsewhere
 enhancement
New feature or improvement
 good first issue
Good for newcomers
 help wanted
Contributions welcome
 invalid
Not a valid issue
 needs info
Waiting on the reporter for details
 question
Needs an answer, not a code change
 security
Security issue or hardening
 translation
New language or translation fixes
 wontfix
Will not be worked on
priority
p1
High priority
priority
p2
Medium priority
priority
p3
Low priority
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#293