Silence the unused h3 warning in the vendored hickory resolver #248

Merged

jcoffey-dev merged 1 commits from fix/hickory-h3-warning into main

2026-10-30 04:48:22 +00:00

jcoffey-dev commented

2026-10-30 04:40:12 +00:00

Owner

Every build printed unused variable: h3 from vendor/hickory-dns/hickory-resolver/src/name_server.rs. The variable was gated on __tls instead of __h3, so builds with TLS but without HTTP/3 (ours) created it and never used it.

hickory's main already has #[cfg(feature = "__h3")] on that line; release/0.26, which our copy comes from, doesn't yet. VENDORED.md's Changes section now lists it, so a re-vendor past the fix drops it.

Checked: cargo check -p hickory-resolver has no warnings, and the vendored crates also build cleanly with h3-ring, quic-ring, https-ring and tls-ring on.

Every build printed `unused variable: h3` from `vendor/hickory-dns/hickory-resolver/src/name_server.rs`. The variable was gated on `__tls` instead of `__h3`, so builds with TLS but without HTTP/3 (ours) created it and never used it. hickory's `main` already has `#[cfg(feature = "__h3")]` on that line; `release/0.26`, which our copy comes from, doesn't yet. VENDORED.md's Changes section now lists it, so a re-vendor past the fix drops it. Checked: `cargo check -p hickory-resolver` has no warnings, and the vendored crates also build cleanly with `h3-ring`, `quic-ring`, `https-ring` and `tls-ring` on.

jcoffey-dev added 1 commit 2026-10-30 04:40:12 +00:00

Silence the unused h3 warning in the vendored hickory resolver

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 7m48s

Details

eb712823f7

NameServer::new created its h3 connection state under the __tls feature
instead of __h3, so every build with TLS and without HTTP/3 (ours)
warned about an unused variable. hickory's main has the corrected cfg;
release/0.26, which this copy comes from, doesn't yet. VENDORED.md
records the change so a re-vendor past it drops it.

Checked with and without HTTP/3: no warnings either way.

jcoffey-dev merged commit 05bcc6adba into main

2026-10-30 04:48:22 +00:00

jcoffey-dev deleted branch fix/hickory-h3-warning

2026-10-30 04:48:22 +00:00

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#248