Clear the warnings in test builds #218

Merged

jcoffey-dev merged 1 commits from chore/test-build-warnings into main

2026-10-28 02:44:15 +00:00

jcoffey-dev commented

2026-10-28 02:37:05 +00:00

Owner

Test builds printed five warnings of ours. Four of them were noise, and that noise hid real warnings.

new_install_privacy_defaults and the scheduler's CheckDomainTasks looked unused, because their callers are cfg(not(feature = "test_mode")). They now allow(dead_code) in test builds only. Production does call both.
live.rs: fetch_update is deprecated as of Rust 1.99. try_update is the same call under its new name, and it builds on CI's 1.98 too (checked in the CI image).
Two test servers that are never mutated lose their mut.

The one warning left is in vendored hickory-resolver: an h3 variable gated on __tls instead of __h3. VENDORED.md keeps that copy unchanged, so it stays. The fix belongs in hickory itself.

Checked: cargo build -p inbuxa and cargo test --workspace --no-run show no warnings outside vendor/; fork checks, fork tool tests and cargo fmt --all --check pass.

Test builds printed five warnings of ours. Four of them were noise, and that noise hid real warnings. - `new_install_privacy_defaults` and the scheduler's `CheckDomainTasks` looked unused, because their callers are `cfg(not(feature = "test_mode"))`. They now `allow(dead_code)` in test builds only. Production does call both. - `live.rs`: `fetch_update` is deprecated as of Rust 1.99. `try_update` is the same call under its new name, and it builds on CI's 1.98 too (checked in the CI image). - Two test servers that are never mutated lose their `mut`. The one warning left is in vendored hickory-resolver: an `h3` variable gated on `__tls` instead of `__h3`. `VENDORED.md` keeps that copy unchanged, so it stays. The fix belongs in hickory itself. Checked: `cargo build -p inbuxa` and `cargo test --workspace --no-run` show no warnings outside vendor/; fork checks, fork tool tests and `cargo fmt --all --check` pass.

jcoffey-dev added 1 commit 2026-10-28 02:37:05 +00:00

Clear the warnings in test builds

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 6m45s

Details

0c37044d99

- new_install_privacy_defaults and the scheduler's CheckDomainTasks
  looked unused in test builds, whose callers are
  cfg(not(feature = "test_mode")); allow dead_code there only.
- live.rs: fetch_update is deprecated as of Rust 1.99; try_update is the
  same call under its new name (present in CI's 1.98 too).
- Two test servers that are never mutated lose their `mut`.

The one warning left is in vendored hickory-resolver (an `h3` variable
gated on `__tls` instead of `__h3`). VENDORED.md keeps that copy
unchanged, so it stays.

jcoffey-dev merged commit a91e596584 into main

2026-10-28 02:44:15 +00:00

jcoffey-dev deleted branch chore/test-build-warnings

2026-10-28 02:44:15 +00:00

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#218