Format the tree with rustfmt, and check it in CI #216

Merged

jcoffey-dev merged 1 commits from chore/rustfmt-pass into main

2026-10-28 02:21:30 +00:00

jcoffey-dev commented

2026-10-28 02:13:39 +00:00

Owner

One cargo fmt --all over the workspace, and a cargo fmt --all --check step in CI on both forges, before the build.

Why: the tree had drifted from rustfmt, so formatting any one changed file reformatted dozens of untouched ones, and every fix needed those hunks taken back out by hand. With the tree formatted and CI checking it, a change's diff is only its own lines.

What changed:

Formatting only, 167 files. No code changes.
Formatted with the CI image's rustfmt (Rust 1.98.1). Local 1.99 gives the same output.
The AGPL notice went onto the two upstream files that this edits for the first time (notice-check.py --fix).
Vendored crates are outside the workspace and aren't touched.
The Gitea image has no rustfmt, so the step adds the component first. GitHub's toolchain install now includes it.

Checked locally: all fork checks, cargo fmt --all --check in the CI image, cargo build -p inbuxa --locked, and cargo test --workspace --locked --no-run.

Open branches will need cargo fmt --all once after this lands.

One `cargo fmt --all` over the workspace, and a `cargo fmt --all --check` step in CI on both forges, before the build. **Why:** the tree had drifted from rustfmt, so formatting any one changed file reformatted dozens of untouched ones, and every fix needed those hunks taken back out by hand. With the tree formatted and CI checking it, a change's diff is only its own lines. **What changed:** - Formatting only, 167 files. No code changes. - Formatted with the CI image's rustfmt (Rust 1.98.1). Local 1.99 gives the same output. - The AGPL notice went onto the two upstream files that this edits for the first time (`notice-check.py --fix`). - Vendored crates are outside the workspace and aren't touched. - The Gitea image has no rustfmt, so the step adds the component first. GitHub's toolchain install now includes it. **Checked locally:** all fork checks, `cargo fmt --all --check` in the CI image, `cargo build -p inbuxa --locked`, and `cargo test --workspace --locked --no-run`. Open branches will need `cargo fmt --all` once after this lands.

jcoffey-dev added 1 commit 2026-10-28 02:13:39 +00:00

Format the tree with rustfmt, and check it in CI

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 7m46s

Details

6b3ba85dc8

cargo fmt --all over the workspace, with the rustfmt of the CI image
(1.98.1); 1.99's output is the same. Formatting only: 167 files, no code
changes, plus the AGPL notice on the two upstream files this touched first.
Vendored crates are outside the workspace and stay as they are.

The tree had drifted, so formatting any one changed file reformatted
dozens of untouched ones. CI now runs cargo fmt --all --check before the
build on both forges.

jcoffey-dev merged commit bd52e7c404 into main

2026-10-28 02:21:30 +00:00

jcoffey-dev deleted branch chore/rustfmt-pass

2026-10-28 02:21:30 +00:00

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#216