Scheduled reports: fixed deliverability findings in words #182

Merged

jcoffey-dev merged 1 commits from fix/report-fixed-findings-in-words into main

2026-10-09 19:51:59 +00:00

jcoffey-dev commented

2026-10-09 19:44:47 +00:00

Owner

The Deliverability section of a scheduled report printed a fixed finding's internal key (Fixed: domain:example.org:spf:192.0.2.10), and its CSV row left the detail empty.

Only the keys are kept between runs (Report.failing), so fixed_text() turns a key back into a sentence: Fixed: SPF for example.org didn't let 192.0.2.10 send. Past tense, because a finding also disappears when its address or domain is removed. Covers every key kind failing_facts() writes; IPv6 addresses keep their colons; an unknown key prints as it is. No stored-format change.

Local: cargo test -p services --lib inbuxa_scheduled_reports (5 passed, new fixed_findings_read_as_words), rustfmt, fork checks (name, notice, context, privacy, expr-schema, unittest).

The Deliverability section of a scheduled report printed a fixed finding's internal key (`Fixed: domain:example.org:spf:192.0.2.10`), and its CSV row left the detail empty. Only the keys are kept between runs (`Report.failing`), so `fixed_text()` turns a key back into a sentence: `Fixed: SPF for example.org didn't let 192.0.2.10 send`. Past tense, because a finding also disappears when its address or domain is removed. Covers every key kind `failing_facts()` writes; IPv6 addresses keep their colons; an unknown key prints as it is. No stored-format change. Local: `cargo test -p services --lib inbuxa_scheduled_reports` (5 passed, new `fixed_findings_read_as_words`), rustfmt, fork checks (name, notice, context, privacy, expr-schema, unittest).

jcoffey-dev added 1 commit 2026-10-09 19:44:48 +00:00

Scheduled reports: fixed deliverability findings in words

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 7m5s

Details

c4895134eb

A finding that stopped failing printed its internal key in the report
("Fixed: domain:example.org:spf:192.0.2.10"), and its CSV row had no
detail. Only the keys are kept between runs, so fixed_text() turns a key
back into a sentence ("Fixed: SPF for example.org didn't let 192.0.2.10
send"), in the past tense because a finding also goes when its address or
domain does. IPv6 addresses keep their colons; an unknown key prints as it
is.

jcoffey-dev merged commit 615dc34a44 into main

2026-10-09 19:51:59 +00:00

jcoffey-dev deleted branch fix/report-fixed-findings-in-words

2026-10-09 19:51:59 +00:00

jcoffey-dev referenced this pull request

2026-10-10 04:54:55 +00:00

Release 2026.10.10.1 #185

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#182