inbuxa/inbuxa-server
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 27 Wiki Activity Sponsor

Refuse an empty JMAP id instead of reading it as id 0 #145

Merged
jcoffey-dev merged 2 commits from fix/empty-jmap-id into main 2026-10-05 21:26:52 +00:00
Conversation 0 Commits 2 Files Changed 1
+15
2 Commits
Author SHA1 Message Date
jcoffey-dev a19d9eec89 Add the modification notice to the files this changes
ci / github (pull_request) Skipped
Details
ci / fork-checks (pull_request) Successful in 15s
Details
ci / build (pull_request) Successful in 5m18s
Details
github/ci (branch) GitHub Actions
Details
2026-10-05 14:20:44 -07:00
jcoffey-dev 9429f1de00 Refuse an empty JMAP id instead of reading it as id 0
ci / github (pull_request) Skipped
Details
github/ci (branch) GitHub Actions
Details
ci / fork-checks (pull_request) Failing after 50s
Details
ci / build (pull_request) Canceled after 5m40s
Details 
An Email/set with mailboxIds {"": true} was accepted and filed the
message in the Inbox. Id::from_str returned 0 for an empty string, and
document 0 is each collection's first: the Inbox for mail. RFC 8620
§1.2 ids are 1 to 255 characters, so "" is refused now, and every
caller already treats a refused id as invalid or not found.

Over-long ids still parse as they did; upstream's test accepts them on
purpose. Found while probing group mailboxes on a scratch server
(specs/multi-account.md, G3).

types tests, jmap_tests and imap_tests pass (RocksDB).
 2026-10-05 14:15:39 -07:00