Sieve: match any key, and :regex dates as regular expressions #236
Assignees
jcoffey-dev (John Coffey)
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: inbuxa/inbuxa-server#236
Reference in new issue
Block a user
Two Sieve matching bugs, both inherited from upstream sieve-rs 0.7.3.
stringdepended on key order. It compared each key against every source, but itsbreakon a match only left the loop over sources, so the next key overwrote the result.string :is "a" ["a", "b"]was false while["b", "a"]was true. RFC 5229 makes a test true when any key matches. It now stops at the first match.date :regexandcurrentdate :regexweren't regular expressions. They called the:matchescomparator, so"^20[0-9]{2}$"was read as a wildcard pattern and never matched a year. They now use the regex comparator, with the same size limit and cache as every other test.A user's filter that hit either bug silently misfiled mail.
Tested:
sieve_tests_match_any_key_and_regex_datesin crates/common: passes, and fails without the fix.cargo fmt --all --checkis clean.Found by batch 3 group M (OPPORTUNITIES); the date one turned up while checking the other tests for the same loop.
string compared each key against every source, but its break on a match only left the loop over sources, so the next key overwrote the result: string :is "a" ["a", "b"] was false while ["b", "a"] was true. RFC 5229 makes a test true when any key matches. It now stops at the first match. date :regex and currentdate :regex called the :matches comparator, so a regular expression was read as a wildcard pattern and "^20[0-9]{2}$" never matched a year. They now use the regex comparator, with its size limit and cache, like every other test. sieve_tests_match_any_key_and_regex_dates in crates/common covers both and fails without the fix. Upstream's svtests (restored in full) pass.