Compare commits
5
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4cb42f28f3 | ||
|
|
2c684be5c9 | ||
|
|
19eb25a426 | ||
|
|
999ae12cc7 | ||
|
|
5853831bad |
Vendored
+279
-30
@@ -13,20 +13,27 @@ use crate::{
|
||||
storage::Storage,
|
||||
telemetry::Telemetry,
|
||||
},
|
||||
ipc::{QueueEvent, RegistryChange},
|
||||
ipc::{BroadcastEvent, QueueEvent, RegistryChange},
|
||||
network::security::{BlockedIps, IpWithTtl},
|
||||
};
|
||||
use ahash::AHashMap;
|
||||
use directory::Directories;
|
||||
use registry::{
|
||||
schema::{prelude::ObjectType, structs::BlockedIp},
|
||||
types::error::{Error, Warning},
|
||||
types::{
|
||||
error::{Error, Warning},
|
||||
id::ObjectId,
|
||||
},
|
||||
};
|
||||
use std::sync::Arc;
|
||||
use store::{LookupStores, registry::bootstrap::Bootstrap, write::now};
|
||||
|
||||
pub struct ReloadResult {
|
||||
/// Errors that kept the reload from being applied.
|
||||
pub errors: Vec<Error>,
|
||||
/// inbuxa: errors in objects that already failed when the running
|
||||
/// settings were built; logged, but they don't refuse a reload.
|
||||
pub known_errors: Vec<Error>,
|
||||
pub warnings: Vec<Warning>,
|
||||
pub replaced_core: bool,
|
||||
}
|
||||
@@ -114,42 +121,60 @@ impl Server {
|
||||
directories: directory.directories,
|
||||
};
|
||||
|
||||
// Parse tracers
|
||||
// inbuxa: upstream swapped the core only when the whole build
|
||||
// was free of errors, while boot runs with whatever built. So one
|
||||
// object that failed (a DNS lookup that timed out, say) refused
|
||||
// every later reload, cluster-wide when the reload came from
|
||||
// ReloadSettings, and the running settings went stale. Now a
|
||||
// reload is refused only for errors in objects that built when
|
||||
// the running settings were built: those would be lost by
|
||||
// applying it. Objects that already failed then are missing
|
||||
// from the running settings anyway, as at boot, so their
|
||||
// errors are reported but don't hold the reload back.
|
||||
let tracers = Telemetry::parse(&mut bootstrap, &storage).await;
|
||||
let core = Box::pin(Core::parse(&mut bootstrap, storage)).await;
|
||||
let mut servers = Listeners::parse(&mut bootstrap).await;
|
||||
|
||||
if bootstrap.errors.is_empty() {
|
||||
let core = Box::pin(Core::parse(&mut bootstrap, storage)).await;
|
||||
if !self.has_new_build_errors(&bootstrap.errors) {
|
||||
servers
|
||||
.parse_tcp_acceptors(&mut bootstrap, self.inner.clone())
|
||||
.await;
|
||||
|
||||
if bootstrap.errors.is_empty() {
|
||||
let mut servers = Listeners::parse(&mut bootstrap).await;
|
||||
servers
|
||||
.parse_tcp_acceptors(&mut bootstrap, self.inner.clone())
|
||||
.await;
|
||||
if !self.has_new_build_errors(&bootstrap.errors) {
|
||||
// Update core
|
||||
self.inner.shared_core.store(core.into());
|
||||
|
||||
if bootstrap.errors.is_empty() {
|
||||
// Update core
|
||||
self.inner.shared_core.store(core.into());
|
||||
// Update tracers
|
||||
tracers.update();
|
||||
|
||||
// Update tracers
|
||||
// Reload queue settings
|
||||
self.inner
|
||||
.ipc
|
||||
.queue_tx
|
||||
.send(QueueEvent::ReloadSettings)
|
||||
.await
|
||||
.ok();
|
||||
|
||||
tracers.update();
|
||||
self.record_build_errors(&bootstrap.errors);
|
||||
|
||||
// Reload queue settings
|
||||
self.inner
|
||||
.ipc
|
||||
.queue_tx
|
||||
.send(QueueEvent::ReloadSettings)
|
||||
.await
|
||||
.ok();
|
||||
|
||||
return Ok(ReloadResult {
|
||||
errors: bootstrap.errors,
|
||||
warnings: bootstrap.warnings,
|
||||
replaced_core: true,
|
||||
});
|
||||
}
|
||||
return Ok(ReloadResult {
|
||||
errors: Vec::new(),
|
||||
known_errors: bootstrap.errors,
|
||||
warnings: bootstrap.warnings,
|
||||
replaced_core: true,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
let (known_errors, errors) = std::mem::take(&mut bootstrap.errors)
|
||||
.into_iter()
|
||||
.partition(|error| self.is_known_build_error(error));
|
||||
return Ok(ReloadResult {
|
||||
errors,
|
||||
known_errors,
|
||||
warnings: bootstrap.warnings,
|
||||
replaced_core: false,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -163,7 +188,7 @@ impl ReloadResult {
|
||||
}
|
||||
|
||||
pub fn log(&self) {
|
||||
for error in &self.errors {
|
||||
for error in self.errors.iter().chain(&self.known_errors) {
|
||||
error.log();
|
||||
}
|
||||
for warning in &self.warnings {
|
||||
@@ -176,8 +201,232 @@ impl From<Bootstrap> for ReloadResult {
|
||||
fn from(bootstrap: Bootstrap) -> Self {
|
||||
Self {
|
||||
errors: bootstrap.errors,
|
||||
known_errors: Vec::new(),
|
||||
warnings: bootstrap.warnings,
|
||||
replaced_core: false,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// inbuxa: which objects failed to build for the running settings
|
||||
impl Server {
|
||||
/// Records the objects that failed to build for the settings now running.
|
||||
pub fn record_build_errors(&self, errors: &[Error]) {
|
||||
*self.inner.data.build_errors.lock() = errors.iter().filter_map(error_object).collect();
|
||||
}
|
||||
|
||||
fn is_known_build_error(&self, error: &Error) -> bool {
|
||||
error_object(error).is_some_and(|id| self.inner.data.build_errors.lock().contains(&id))
|
||||
}
|
||||
|
||||
fn has_new_build_errors(&self, errors: &[Error]) -> bool {
|
||||
errors.iter().any(|error| !self.is_known_build_error(error))
|
||||
}
|
||||
}
|
||||
|
||||
fn error_object(error: &Error) -> Option<ObjectId> {
|
||||
match error {
|
||||
Error::Validation { object_id, .. }
|
||||
| Error::Build { object_id, .. }
|
||||
| Error::NotFound { object_id } => Some(*object_id),
|
||||
Error::Internal { object_id, .. } => *object_id,
|
||||
}
|
||||
}
|
||||
|
||||
// inbuxa: upstream applied a registry write to the running settings only on
|
||||
// an explicit x:Action ReloadSettings (Directory and Authentication aside), so
|
||||
// a new MtaDeliverySchedule, say, stayed unknown ("Queue strategy not found")
|
||||
// until someone reloaded. Writes to objects the settings are built from now
|
||||
// reload them, here and across the cluster, as ReloadSettings does.
|
||||
|
||||
/// Coalesces the full reloads that registry writes trigger: a write waits for
|
||||
/// a reload that started after it was stored, and joins one if it can, so a
|
||||
/// burst of writes costs a reload or two rather than one each.
|
||||
#[derive(Default)]
|
||||
pub struct SettingsReloadGate {
|
||||
requested: std::sync::atomic::AtomicU64,
|
||||
state: tokio::sync::Mutex<SettingsReloadState>,
|
||||
}
|
||||
|
||||
#[derive(Default)]
|
||||
struct SettingsReloadState {
|
||||
completed: u64,
|
||||
refused: Option<String>,
|
||||
}
|
||||
|
||||
/// The reload a write to `object` calls for: the object to reload, or None
|
||||
/// when the running settings don't hold that object (accounts, domains and
|
||||
/// other data read as needed, stores, which take a restart, and objects with
|
||||
/// reload actions of their own, such as applications).
|
||||
pub fn write_reload_target(object: ObjectType) -> Option<ObjectType> {
|
||||
match object {
|
||||
ObjectType::Certificate => Some(ObjectType::Certificate),
|
||||
ObjectType::MemoryLookupKey
|
||||
| ObjectType::MemoryLookupKeyValue
|
||||
| ObjectType::HttpLookup
|
||||
| ObjectType::StoreLookup => Some(ObjectType::StoreLookup),
|
||||
ObjectType::BlockedIp | ObjectType::AllowedIp => Some(ObjectType::BlockedIp),
|
||||
ObjectType::AcmeProvider
|
||||
| ObjectType::AddressBook
|
||||
| ObjectType::AiModel
|
||||
| ObjectType::Asn
|
||||
| ObjectType::Authentication
|
||||
| ObjectType::Cache
|
||||
| ObjectType::Calendar
|
||||
| ObjectType::CalendarAlarm
|
||||
| ObjectType::CalendarScheduling
|
||||
| ObjectType::ClusterRole
|
||||
| ObjectType::DataRetention
|
||||
| ObjectType::Directory
|
||||
| ObjectType::DkimReportSettings
|
||||
| ObjectType::DmarcReportSettings
|
||||
| ObjectType::DnsResolver
|
||||
| ObjectType::DsnReportSettings
|
||||
| ObjectType::Email
|
||||
| ObjectType::EventTracingLevel
|
||||
| ObjectType::FileStorage
|
||||
| ObjectType::Http
|
||||
| ObjectType::HttpForm
|
||||
| ObjectType::Imap
|
||||
| ObjectType::Jmap
|
||||
| ObjectType::Metrics
|
||||
| ObjectType::MtaConnectionStrategy
|
||||
| ObjectType::MtaDeliverySchedule
|
||||
| ObjectType::MtaExtensions
|
||||
| ObjectType::MtaHook
|
||||
| ObjectType::MtaInboundSession
|
||||
| ObjectType::MtaInboundThrottle
|
||||
| ObjectType::MtaMilter
|
||||
| ObjectType::MtaOutboundStrategy
|
||||
| ObjectType::MtaOutboundThrottle
|
||||
| ObjectType::MtaQueueQuota
|
||||
| ObjectType::MtaRoute
|
||||
| ObjectType::MtaStageAuth
|
||||
| ObjectType::MtaStageConnect
|
||||
| ObjectType::MtaStageData
|
||||
| ObjectType::MtaStageEhlo
|
||||
| ObjectType::MtaStageMail
|
||||
| ObjectType::MtaStageRcpt
|
||||
| ObjectType::MtaSts
|
||||
| ObjectType::MtaTlsStrategy
|
||||
| ObjectType::MtaVirtualQueue
|
||||
| ObjectType::NetworkListener
|
||||
| ObjectType::OidcProvider
|
||||
| ObjectType::ReportSettings
|
||||
| ObjectType::Search
|
||||
| ObjectType::Security
|
||||
| ObjectType::SenderAuth
|
||||
| ObjectType::Sharing
|
||||
| ObjectType::SieveSystemInterpreter
|
||||
| ObjectType::SieveSystemScript
|
||||
| ObjectType::SieveUserInterpreter
|
||||
| ObjectType::SieveUserScript
|
||||
| ObjectType::SpamClassifier
|
||||
| ObjectType::SpamDnsblServer
|
||||
| ObjectType::SpamDnsblSettings
|
||||
| ObjectType::SpamFileExtension
|
||||
| ObjectType::SpamPyzor
|
||||
| ObjectType::SpamRule
|
||||
| ObjectType::SpamSettings
|
||||
| ObjectType::SpamTag
|
||||
| ObjectType::SpfReportSettings
|
||||
| ObjectType::SystemSettings
|
||||
| ObjectType::TaskManager
|
||||
| ObjectType::TlsReportSettings
|
||||
| ObjectType::Tracer
|
||||
| ObjectType::WebDav
|
||||
| ObjectType::WebHook => Some(object),
|
||||
_ => None,
|
||||
}
|
||||
}
|
||||
|
||||
impl Server {
|
||||
/// Applies a stored registry write to `object` to the running settings,
|
||||
/// and on success tells the other nodes to do the same. Returns None when
|
||||
/// the write needs no reload, Some(Ok(())) when it was applied, and
|
||||
/// Some(Err(reason)) when the reload was refused (the write stays stored;
|
||||
/// ReloadSettings reports the same errors).
|
||||
pub async fn reload_after_write(&self, object: ObjectType) -> Option<Result<(), String>> {
|
||||
let target = write_reload_target(object)?;
|
||||
let change = RegistryChange::Reload(target);
|
||||
|
||||
if matches!(
|
||||
target,
|
||||
ObjectType::Certificate | ObjectType::StoreLookup | ObjectType::BlockedIp
|
||||
) {
|
||||
// Cheap, and limited to their own objects
|
||||
let result = self.reload_and_broadcast(change).await;
|
||||
return Some(result);
|
||||
}
|
||||
|
||||
let gate = &self.inner.data.settings_reload;
|
||||
let ticket = gate
|
||||
.requested
|
||||
.fetch_add(1, std::sync::atomic::Ordering::SeqCst)
|
||||
+ 1;
|
||||
let mut state = gate.state.lock().await;
|
||||
if state.completed >= ticket {
|
||||
// A reload that started after this write was stored has run
|
||||
return Some(state.refused.clone().map_or(Ok(()), Err));
|
||||
}
|
||||
let covers = gate.requested.load(std::sync::atomic::Ordering::SeqCst);
|
||||
let result = self.reload_and_broadcast(change).await;
|
||||
state.completed = covers;
|
||||
state.refused = result.clone().err();
|
||||
Some(result)
|
||||
}
|
||||
|
||||
async fn reload_and_broadcast(&self, change: RegistryChange) -> Result<(), String> {
|
||||
match Box::pin(self.reload_registry(change)).await {
|
||||
Ok(reload) if !reload.has_errors() => {
|
||||
reload.log();
|
||||
self.cluster_broadcast(BroadcastEvent::RegistryChange(change))
|
||||
.await;
|
||||
Ok(())
|
||||
}
|
||||
Ok(reload) => {
|
||||
reload.log();
|
||||
let reason = describe_reload_errors(&reload.errors);
|
||||
trc::event!(
|
||||
Registry(trc::RegistryEvent::BuildWarning),
|
||||
Details = "Settings didn't reload after a registry write",
|
||||
Reason = reason.clone(),
|
||||
);
|
||||
Err(reason)
|
||||
}
|
||||
Err(err) => {
|
||||
let reason = err.to_string();
|
||||
trc::error!(err.details("Failed to reload settings after a registry write"));
|
||||
Err(reason)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// inbuxa: a refused reload's errors in a sentence: the first one, naming its
|
||||
/// object, and how many more there are.
|
||||
pub fn describe_reload_errors(errors: &[Error]) -> String {
|
||||
let mut description = match errors.first() {
|
||||
Some(Error::Build { object_id, message }) => format!("{object_id}: {message}"),
|
||||
Some(Error::Validation { object_id, errors }) => format!(
|
||||
"{object_id}: {}",
|
||||
errors
|
||||
.iter()
|
||||
.map(|err| err.to_string())
|
||||
.collect::<Vec<_>>()
|
||||
.join("; ")
|
||||
),
|
||||
Some(Error::Internal {
|
||||
object_id: Some(object_id),
|
||||
error,
|
||||
}) => format!("{object_id}: {error}"),
|
||||
Some(Error::Internal { error, .. }) => error.to_string(),
|
||||
Some(Error::NotFound { object_id }) => format!("{object_id} was not found"),
|
||||
None => String::new(),
|
||||
};
|
||||
let more = errors.len().saturating_sub(1);
|
||||
if more > 0 {
|
||||
description.push_str(&format!(" ({more} more in the server log.)"));
|
||||
}
|
||||
description
|
||||
}
|
||||
|
||||
@@ -93,9 +93,11 @@ impl Data {
|
||||
registry_id_gen: id_generator.clone(),
|
||||
span_id_gen: id_generator,
|
||||
queue_status: true.into(),
|
||||
settings_reload: Default::default(),
|
||||
applications,
|
||||
logos: Default::default(),
|
||||
smtp_connectors: TlsConnectors::try_new().failed("Failed to build TLS connectors"),
|
||||
build_errors: Default::default(),
|
||||
asn_geo_data: Default::default(),
|
||||
}
|
||||
}
|
||||
@@ -234,9 +236,11 @@ impl Default for Data {
|
||||
span_id_gen: Default::default(),
|
||||
registry_id_gen: Default::default(),
|
||||
queue_status: true.into(),
|
||||
settings_reload: Default::default(),
|
||||
applications: WebApplications::new(),
|
||||
logos: Default::default(),
|
||||
smtp_connectors: TlsConnectors::try_new().unwrap(),
|
||||
build_errors: Default::default(),
|
||||
asn_geo_data: Default::default(),
|
||||
lookup_stores: Default::default(),
|
||||
}
|
||||
|
||||
@@ -16,7 +16,6 @@ use mail_auth::common::resolver::ToReverseName;
|
||||
use nlp::classifier::model::{CcfhClassifier, FhClassifier};
|
||||
use registry::schema::{
|
||||
enums::{ExpressionVariable, ModelSize},
|
||||
prelude::ObjectType,
|
||||
structs::{
|
||||
self, SpamDnsblServer, SpamDnsblSettings, SpamFileExtension, SpamPyzor, SpamRule,
|
||||
SpamSettings, SpamTag,
|
||||
@@ -25,10 +24,10 @@ use registry::schema::{
|
||||
use sieve::SpamStatus;
|
||||
use std::{
|
||||
net::{IpAddr, SocketAddr},
|
||||
time::Duration,
|
||||
sync::Arc,
|
||||
time::{Duration, Instant},
|
||||
};
|
||||
use store::registry::{RegistryObject, bootstrap::Bootstrap};
|
||||
use tokio::net::lookup_host;
|
||||
use utils::{cache::CacheItemWeight, glob::GlobMap};
|
||||
|
||||
#[derive(rkyv::Archive, rkyv::Deserialize, rkyv::Serialize, Debug, Default)]
|
||||
@@ -157,7 +156,11 @@ pub struct FtrlParameters {
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct PyzorConfig {
|
||||
pub address: SocketAddr,
|
||||
// inbuxa: the server is resolved when a message is checked, not while the
|
||||
// settings are built (see PyzorConfig::address)
|
||||
pub host: String,
|
||||
pub port: u16,
|
||||
pub resolved: Arc<parking_lot::Mutex<Option<(SocketAddr, Instant)>>>,
|
||||
pub timeout: Duration,
|
||||
pub min_count: u64,
|
||||
pub min_wl_count: u64,
|
||||
@@ -474,31 +477,15 @@ impl PyzorConfig {
|
||||
return None;
|
||||
}
|
||||
|
||||
let port = pyzor.port;
|
||||
let host = pyzor.host;
|
||||
let address = match lookup_host(format!("{host}:{port}"))
|
||||
.await
|
||||
.map(|mut a| a.next())
|
||||
{
|
||||
Ok(Some(address)) => address,
|
||||
Ok(None) => {
|
||||
bp.build_error(
|
||||
ObjectType::SpamPyzor.singleton(),
|
||||
"Invalid address: No addresses found.",
|
||||
);
|
||||
return None;
|
||||
}
|
||||
Err(err) => {
|
||||
bp.build_error(
|
||||
ObjectType::SpamPyzor.singleton(),
|
||||
format!("Invalid address: {}", err),
|
||||
);
|
||||
return None;
|
||||
}
|
||||
};
|
||||
|
||||
// inbuxa: upstream resolved the host here and reported a failed lookup
|
||||
// as a build error, so a DNS hiccup on one node refused every settings
|
||||
// reload on it (and, from the node that ran ReloadSettings, across the
|
||||
// cluster). The lookup now happens when a message is checked; a
|
||||
// failure there is logged as a Pyzor error for that message.
|
||||
PyzorConfig {
|
||||
address,
|
||||
host: pyzor.host,
|
||||
port: pyzor.port as u16,
|
||||
resolved: Default::default(),
|
||||
timeout: pyzor.timeout.into_inner(),
|
||||
min_count: pyzor.block_count,
|
||||
min_wl_count: pyzor.allow_count,
|
||||
@@ -508,6 +495,35 @@ impl PyzorConfig {
|
||||
}
|
||||
}
|
||||
|
||||
// inbuxa: how long a resolved Pyzor address is reused
|
||||
const PYZOR_RESOLVE_TTL: Duration = Duration::from_secs(300);
|
||||
|
||||
impl PyzorConfig {
|
||||
/// The server's address: the host itself when it is an IP address,
|
||||
/// otherwise the first address it resolves to, reused for five minutes.
|
||||
pub async fn address(&self) -> std::io::Result<SocketAddr> {
|
||||
if let Ok(ip) = self.host.parse::<IpAddr>() {
|
||||
return Ok(SocketAddr::new(ip, self.port));
|
||||
}
|
||||
if let Some((address, resolved_at)) = *self.resolved.lock()
|
||||
&& resolved_at.elapsed() < PYZOR_RESOLVE_TTL
|
||||
{
|
||||
return Ok(address);
|
||||
}
|
||||
let address = tokio::net::lookup_host((self.host.as_str(), self.port))
|
||||
.await?
|
||||
.next()
|
||||
.ok_or_else(|| {
|
||||
std::io::Error::new(
|
||||
std::io::ErrorKind::NotFound,
|
||||
format!("{} has no addresses", self.host),
|
||||
)
|
||||
})?;
|
||||
*self.resolved.lock() = Some((address, Instant::now()));
|
||||
Ok(address)
|
||||
}
|
||||
}
|
||||
|
||||
impl ClassifierConfig {
|
||||
pub async fn parse(bp: &mut Bootstrap) -> Option<Self> {
|
||||
let classifier = bp.setting_infallible::<structs::SpamClassifier>().await;
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use self::resolver::Policy;
|
||||
@@ -22,7 +24,7 @@ use registry::schema::{
|
||||
};
|
||||
use smtp_proto::*;
|
||||
use std::{
|
||||
net::{SocketAddr, ToSocketAddrs},
|
||||
net::{IpAddr, SocketAddr},
|
||||
str::FromStr,
|
||||
time::Duration,
|
||||
};
|
||||
@@ -384,19 +386,16 @@ impl SessionConfig {
|
||||
Some(Milter {
|
||||
enable: bp.compile_expr(id, &milter.ctx_enable()),
|
||||
id,
|
||||
addrs: format!("{}:{}", milter.hostname, milter.port)
|
||||
.to_socket_addrs()
|
||||
.map_err(|err| {
|
||||
bp.build_error(
|
||||
id,
|
||||
format!(
|
||||
"Unable to resolve milter hostname {}: {}",
|
||||
milter.hostname, err
|
||||
),
|
||||
)
|
||||
})
|
||||
.ok()?
|
||||
.collect(),
|
||||
// inbuxa: upstream resolved the hostname here (a
|
||||
// blocking lookup) and made a failure a build error,
|
||||
// which refused the whole settings reload. An IP
|
||||
// address is kept as is; a name is resolved on each
|
||||
// connection (MilterClient::connect).
|
||||
addrs: milter
|
||||
.hostname
|
||||
.parse::<IpAddr>()
|
||||
.map(|ip| vec![SocketAddr::new(ip, milter.port as u16)])
|
||||
.unwrap_or_default(),
|
||||
hostname: milter.hostname,
|
||||
port: milter.port as u16,
|
||||
timeout_connect: milter.timeout_connect.into_inner(),
|
||||
|
||||
@@ -161,11 +161,17 @@ pub struct Data {
|
||||
pub span_id_gen: SnowflakeIdGenerator,
|
||||
pub registry_id_gen: SnowflakeIdGenerator,
|
||||
pub queue_status: AtomicBool,
|
||||
// inbuxa: coalesces the settings reloads registry writes trigger
|
||||
pub settings_reload: cache::reload::SettingsReloadGate,
|
||||
|
||||
pub applications: WebApplications,
|
||||
pub logos: Mutex<AHashMap<Box<str>, LogoCache>>,
|
||||
|
||||
pub smtp_connectors: TlsConnectors,
|
||||
|
||||
// inbuxa: the objects that failed to build when the running settings
|
||||
// were built, at boot or by the last applied reload (see reload_registry)
|
||||
pub build_errors: Mutex<AHashSet<registry::types::id::ObjectId>>,
|
||||
}
|
||||
|
||||
#[derive(Clone)]
|
||||
|
||||
@@ -240,6 +240,9 @@ impl BootManager {
|
||||
.parse_tcp_acceptors(&mut bootstrap, inner.clone())
|
||||
.await;
|
||||
|
||||
// inbuxa: a reload isn't refused over objects that failed here
|
||||
inner.build_server().record_build_errors(&bootstrap.errors);
|
||||
|
||||
BootManager {
|
||||
inner,
|
||||
bootstrap,
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use super::ahash_is_empty;
|
||||
@@ -71,6 +73,23 @@ pub struct SetResponse<T: JmapObject> {
|
||||
#[serde(rename = "notDestroyed")]
|
||||
#[serde(skip_serializing_if = "VecMap::is_empty")]
|
||||
pub not_destroyed: VecMap<MaybeInvalid<Id>, SetError<T::Property>>,
|
||||
|
||||
// inbuxa: on a registry write that changes the running settings, whether
|
||||
// the server applied it
|
||||
#[serde(rename = "x:settingsReload")]
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub settings_reload: Option<SettingsReload>,
|
||||
}
|
||||
|
||||
/// inbuxa: the settings reload that followed a registry write.
|
||||
#[derive(Debug, Clone, serde::Serialize)]
|
||||
pub struct SettingsReload {
|
||||
/// The running settings (here and, through the cluster, on every node)
|
||||
/// include the write.
|
||||
pub applied: bool,
|
||||
/// Why they don't, when they don't.
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub description: Option<String>,
|
||||
}
|
||||
|
||||
impl<'de, T: JmapObject> DeserializeArguments<'de> for SetRequest<'de, T> {
|
||||
@@ -199,6 +218,7 @@ impl<T: JmapObject> SetResponse<T> {
|
||||
not_created: VecMap::new(),
|
||||
not_updated: VecMap::new(),
|
||||
not_destroyed: VecMap::new(),
|
||||
settings_reload: None,
|
||||
})
|
||||
} else {
|
||||
Err(trc::JmapEvent::RequestTooLarge.into_err())
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use crate::registry::mapping::{RegistrySetResponse, map_bootstrap_error};
|
||||
@@ -99,7 +101,7 @@ pub(crate) async fn action_set(
|
||||
} else {
|
||||
set.response
|
||||
.not_created
|
||||
.append(id, map_bootstrap_error(result.errors));
|
||||
.append(id, reload_refused(result.errors));
|
||||
}
|
||||
}
|
||||
Action::InvalidateCaches => {
|
||||
@@ -573,3 +575,14 @@ async fn dmarc_troubleshoot(
|
||||
|
||||
Some(request)
|
||||
}
|
||||
|
||||
/// inbuxa: a refused reload names the object that stopped it and says the
|
||||
/// settings weren't applied; upstream passed on the first error's bare message
|
||||
/// ("Invalid address: ..."), which read like a problem with the request.
|
||||
fn reload_refused(errors: Vec<registry::types::error::Error>) -> SetError<Property> {
|
||||
let description = format!(
|
||||
"Settings were not reloaded. {}",
|
||||
common::cache::reload::describe_reload_errors(&errors)
|
||||
);
|
||||
map_bootstrap_error(errors).with_description(description)
|
||||
}
|
||||
|
||||
@@ -38,7 +38,7 @@ use directory::core::secret::{hash_secret, is_password_hash};
|
||||
use http_proto::HttpSessionData;
|
||||
use jmap_proto::{
|
||||
error::set::{SetError, SetErrorType},
|
||||
method::set::{SetRequest, SetResponse},
|
||||
method::set::{SetRequest, SetResponse, SettingsReload},
|
||||
object::registry::Registry,
|
||||
references::resolve::ResolveCreatedReference,
|
||||
request::{IntoValid, MaybeInvalid},
|
||||
@@ -931,30 +931,28 @@ impl RegistrySet for Server {
|
||||
}
|
||||
};
|
||||
|
||||
// inbuxa: DIR-17: a directory or the server default applies on the
|
||||
// next request, here and on every node
|
||||
if matches!(
|
||||
object_type,
|
||||
ObjectType::Directory | ObjectType::Authentication
|
||||
) && let Ok(response) = &result
|
||||
// inbuxa: a write to an object the running settings are built from
|
||||
// applies at once, here and on every node (DIR-17 did this for
|
||||
// directories and the server default; now it covers every such object)
|
||||
let mut result = result;
|
||||
if let Ok(response) = &mut result
|
||||
&& (!response.created.is_empty()
|
||||
|| !response.updated.is_empty()
|
||||
|| !response.destroyed.is_empty())
|
||||
&& let Some(reload) = self.reload_after_write(object_type).await
|
||||
{
|
||||
let change = common::ipc::RegistryChange::Reload(ObjectType::Directory);
|
||||
match Box::pin(self.reload_registry(change)).await {
|
||||
Ok(reload) if !reload.has_errors() => {
|
||||
self.cluster_broadcast(common::ipc::BroadcastEvent::RegistryChange(change))
|
||||
.await;
|
||||
}
|
||||
Ok(_) => trc::event!(
|
||||
Registry(trc::RegistryEvent::BuildWarning),
|
||||
Details = "Settings didn't reload after a directory change",
|
||||
),
|
||||
Err(err) => {
|
||||
trc::error!(err.details("Failed to reload directories"));
|
||||
}
|
||||
}
|
||||
response.settings_reload = Some(match reload {
|
||||
Ok(()) => SettingsReload {
|
||||
applied: true,
|
||||
description: None,
|
||||
},
|
||||
Err(reason) => SettingsReload {
|
||||
applied: false,
|
||||
description: Some(format!(
|
||||
"Saved, but the running settings were not reloaded. {reason}"
|
||||
)),
|
||||
},
|
||||
});
|
||||
}
|
||||
result
|
||||
}
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use common::config::smtp::session::Milter;
|
||||
@@ -25,7 +27,19 @@ impl MilterClient<TcpStream> {
|
||||
pub async fn connect(config: &Milter, session_id: u64) -> Result<Self> {
|
||||
tokio::time::timeout(config.timeout_command, async {
|
||||
let mut last_err = Error::Disconnected;
|
||||
for addr in &config.addrs {
|
||||
// inbuxa: a hostname is resolved here, per connection, rather
|
||||
// than while the settings are built
|
||||
let resolved;
|
||||
let addrs = if config.addrs.is_empty() {
|
||||
resolved = tokio::net::lookup_host((config.hostname.as_str(), config.port))
|
||||
.await
|
||||
.map_err(Error::Io)?
|
||||
.collect::<Vec<_>>();
|
||||
&resolved
|
||||
} else {
|
||||
&config.addrs
|
||||
};
|
||||
for addr in addrs {
|
||||
match TcpStream::connect(addr).await {
|
||||
Ok(stream) => {
|
||||
return Ok(MilterClient {
|
||||
|
||||
@@ -48,19 +48,24 @@ pub(crate) async fn pyzor_check(
|
||||
// Send message to address. inbuxa: in tests, a fixed table answers
|
||||
// instead of a public server (test_response).
|
||||
#[cfg(not(feature = "test_mode"))]
|
||||
let response = pyzor_send_message(config.address, config.timeout, &request).await;
|
||||
let response = match tokio::time::timeout(config.timeout, config.address()).await {
|
||||
Ok(Ok(address)) => pyzor_send_message(address, config.timeout, &request).await,
|
||||
Ok(Err(err)) => Err(err),
|
||||
Err(_) => Err(std::io::Error::new(
|
||||
std::io::ErrorKind::TimedOut,
|
||||
"Timed out resolving the Pyzor server",
|
||||
)),
|
||||
};
|
||||
#[cfg(feature = "test_mode")]
|
||||
let response = std::io::Result::Ok(test_response(&request));
|
||||
|
||||
response
|
||||
.map(Into::into)
|
||||
.map_err(|err| {
|
||||
trc::SpamEvent::PyzorError
|
||||
.into_err()
|
||||
.ctx(trc::Key::Url, config.address.to_string())
|
||||
.reason(err)
|
||||
.details("Pyzor failed")
|
||||
})
|
||||
response.map(Into::into).map_err(|err| {
|
||||
trc::SpamEvent::PyzorError
|
||||
.into_err()
|
||||
.ctx(trc::Key::Url, format!("{}:{}", config.host, config.port))
|
||||
.reason(err)
|
||||
.details("Pyzor failed")
|
||||
})
|
||||
}
|
||||
|
||||
/// inbuxa: the answers tests get, by digest, instead of a public server's,
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use crate::{
|
||||
@@ -11,6 +13,7 @@ use crate::{
|
||||
server::TestServerBuilder,
|
||||
},
|
||||
};
|
||||
use common::BuildServer;
|
||||
use imap_proto::ResponseType;
|
||||
use registry::{
|
||||
schema::{
|
||||
@@ -18,7 +21,8 @@ use registry::{
|
||||
prelude::{ObjectType, Property, SocketAddr},
|
||||
structs::{
|
||||
ClusterListenerGroup, ClusterListenerGroupProperties, ClusterRole, ClusterTaskGroup,
|
||||
Coordinator, Imap, NatsCoordinator, NetworkListener, RedisStore,
|
||||
Coordinator, Imap, MtaDeliverySchedule, MtaVirtualQueue, NatsCoordinator,
|
||||
NetworkListener, RedisStore,
|
||||
},
|
||||
},
|
||||
types::map::Map,
|
||||
@@ -209,6 +213,45 @@ pub async fn cluster_tests() {
|
||||
Some("John Doe")
|
||||
);
|
||||
|
||||
// inbuxa: a settings write applies on every node, no ReloadSettings
|
||||
let queue_id = admin
|
||||
.registry_create_object(MtaVirtualQueue {
|
||||
name: "clusterq".into(),
|
||||
threads_per_node: 1,
|
||||
description: None,
|
||||
})
|
||||
.await;
|
||||
admin
|
||||
.registry_create_object(MtaDeliverySchedule {
|
||||
name: "cluster-autoreload".into(),
|
||||
queue_id,
|
||||
..Default::default()
|
||||
})
|
||||
.await;
|
||||
for (node_id, test) in servers.iter().enumerate() {
|
||||
let started = std::time::Instant::now();
|
||||
while !test
|
||||
.server
|
||||
.inner
|
||||
.build_server()
|
||||
.core
|
||||
.smtp
|
||||
.queue
|
||||
.queue_strategy
|
||||
.contains_key("cluster-autoreload")
|
||||
{
|
||||
assert!(
|
||||
started.elapsed() < std::time::Duration::from_secs(5),
|
||||
"node {node_id} didn't pick up the new delivery schedule"
|
||||
);
|
||||
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
|
||||
}
|
||||
println!(
|
||||
"Node {node_id} has the new delivery schedule after {} ms",
|
||||
started.elapsed().as_millis()
|
||||
);
|
||||
}
|
||||
|
||||
// Run IMAP idle tests across nodes
|
||||
let mut node1_client = imap_client("[email protected]", "this is john's secret", 1).await;
|
||||
let mut node2_client = imap_client("[email protected]", "this is john's secret", 2).await;
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use crate::{
|
||||
@@ -75,7 +77,7 @@ async fn milter_session() {
|
||||
else_: "true".into(),
|
||||
..Default::default()
|
||||
},
|
||||
hostname: "127.0.0.1".into(),
|
||||
hostname: "localhost".into(), // inbuxa: resolved when the session connects
|
||||
port: 9332,
|
||||
use_tls: false,
|
||||
stages: Map::new(vec![MtaStage::Data]),
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
||||
*
|
||||
* Modified by Coffey Labs in 2026 for INBUXA.
|
||||
*/
|
||||
|
||||
use crate::utils::server::TestServer;
|
||||
@@ -40,15 +42,23 @@ pub mod vrfy;
|
||||
const EVENT_TIMEOUT: Duration = Duration::from_secs(5);
|
||||
|
||||
impl TestServer {
|
||||
// inbuxa: registry writes reload the settings, and each reload sends the
|
||||
// queue a ReloadSettings; read_event, try_read_event and assert_no_events
|
||||
// pass over those (expect_reload_settings still waits for one)
|
||||
pub async fn read_event(&mut self) -> QueueEvent {
|
||||
if let Some(event) = self.queue_events.pop_front() {
|
||||
return event;
|
||||
while let Some(event) = self.queue_events.pop_front() {
|
||||
if !event.is_reload_settings() {
|
||||
return event;
|
||||
}
|
||||
}
|
||||
|
||||
match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
|
||||
Ok(Some(event)) => event,
|
||||
Ok(None) => panic!("Channel closed."),
|
||||
Err(_) => panic!("No queue event received."),
|
||||
loop {
|
||||
match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
|
||||
Ok(Some(event)) if event.is_reload_settings() => (),
|
||||
Ok(Some(event)) => return event,
|
||||
Ok(None) => panic!("Channel closed."),
|
||||
Err(_) => panic!("No queue event received."),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -78,26 +88,39 @@ impl TestServer {
|
||||
}
|
||||
|
||||
pub async fn try_read_event(&mut self) -> Option<QueueEvent> {
|
||||
if let Some(event) = self.queue_events.pop_front() {
|
||||
return Some(event);
|
||||
while let Some(event) = self.queue_events.pop_front() {
|
||||
if !event.is_reload_settings() {
|
||||
return Some(event);
|
||||
}
|
||||
}
|
||||
|
||||
match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
|
||||
Ok(Some(event)) => Some(event),
|
||||
Ok(None) => panic!("Channel closed."),
|
||||
Err(_) => None,
|
||||
loop {
|
||||
match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
|
||||
Ok(Some(event)) if event.is_reload_settings() => (),
|
||||
Ok(Some(event)) => return Some(event),
|
||||
Ok(None) => panic!("Channel closed."),
|
||||
Err(_) => return None,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub fn assert_no_events(&mut self) {
|
||||
if let Some(event) = self.queue_events.pop_front() {
|
||||
if let Some(event) = self
|
||||
.queue_events
|
||||
.iter()
|
||||
.find(|event| !event.is_reload_settings())
|
||||
{
|
||||
panic!("Expected empty queue but got {event:?}");
|
||||
}
|
||||
self.queue_events.clear();
|
||||
|
||||
match self.queue_rx.try_recv() {
|
||||
Err(TryRecvError::Empty) => (),
|
||||
Ok(event) => panic!("Expected empty queue but got {event:?}"),
|
||||
Err(err) => panic!("Queue error: {err:?}"),
|
||||
loop {
|
||||
match self.queue_rx.try_recv() {
|
||||
Ok(event) if event.is_reload_settings() => (),
|
||||
Err(TryRecvError::Empty) => break,
|
||||
Ok(event) => panic!("Expected empty queue but got {event:?}"),
|
||||
Err(err) => panic!("Queue error: {err:?}"),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,189 @@
|
||||
/*
|
||||
* SPDX-FileCopyrightText: 2026 Coffey Labs
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only
|
||||
*/
|
||||
|
||||
// inbuxa: a registry write to an object the running settings are built from
|
||||
// applies without an x:Action ReloadSettings, and the set response says so.
|
||||
|
||||
use crate::utils::{
|
||||
jmap::JmapResponse,
|
||||
server::{TestServer, TestServerBuilder},
|
||||
};
|
||||
use common::BuildServer;
|
||||
use registry::schema::{
|
||||
enums::TracingLevel,
|
||||
prelude::ObjectType,
|
||||
structs::{
|
||||
CertificateManagement, DkimManagement, DnsManagement, Domain, Expression,
|
||||
MtaDeliverySchedule, MtaStageAuth, MtaVirtualQueue, Tracer, TracerStdout,
|
||||
},
|
||||
};
|
||||
use serde_json::Value;
|
||||
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
pub async fn settings_reload_tests() {
|
||||
let mut test = TestServerBuilder::new("settings_reload_tests")
|
||||
.await
|
||||
.with_default_listeners()
|
||||
.await
|
||||
.with_object(MtaStageAuth {
|
||||
require: Expression {
|
||||
else_: "false".to_string(),
|
||||
..Default::default()
|
||||
},
|
||||
..Default::default()
|
||||
})
|
||||
.await
|
||||
.build()
|
||||
.await;
|
||||
|
||||
let admin = test
|
||||
.create_user_account(
|
||||
"admin",
|
||||
"[email protected]",
|
||||
"these_pretzels_are_making_me_thirsty",
|
||||
&[],
|
||||
"Admin",
|
||||
)
|
||||
.await;
|
||||
test.account("admin")
|
||||
.assign_roles_to_account(admin.id(), &["user", "system"])
|
||||
.await;
|
||||
test.insert_account(admin);
|
||||
|
||||
test_write_applies(&test).await;
|
||||
|
||||
if test.is_reset() {
|
||||
test.temp_dir.delete();
|
||||
}
|
||||
}
|
||||
|
||||
async fn test_write_applies(test: &TestServer) {
|
||||
println!("Running settings reload after registry writes...");
|
||||
let admin = test.account("[email protected]");
|
||||
|
||||
// A delivery schedule is in use as soon as it is saved
|
||||
let response = admin
|
||||
.registry_create([MtaVirtualQueue {
|
||||
name: "autorld".into(),
|
||||
threads_per_node: 2,
|
||||
description: None,
|
||||
}])
|
||||
.await;
|
||||
assert_applied(&response);
|
||||
let queue_id = response.created_id(0);
|
||||
assert!(!has_schedule(test, "autoreload-schedule"));
|
||||
let response = admin
|
||||
.registry_create([MtaDeliverySchedule {
|
||||
name: "autoreload-schedule".into(),
|
||||
queue_id,
|
||||
..Default::default()
|
||||
}])
|
||||
.await;
|
||||
assert_applied(&response);
|
||||
assert!(has_schedule(test, "autoreload-schedule"));
|
||||
|
||||
// Destroyed, it's gone at once too
|
||||
let schedule_id = response.created_id(0);
|
||||
let response = admin
|
||||
.registry_destroy(ObjectType::MtaDeliverySchedule, [schedule_id])
|
||||
.await;
|
||||
assert_applied(&response);
|
||||
assert!(!has_schedule(test, "autoreload-schedule"));
|
||||
|
||||
// Concurrent writes all end up in the running settings
|
||||
let names = (0..8)
|
||||
.map(|i| format!("autoreload-{i}"))
|
||||
.collect::<Vec<_>>();
|
||||
let mut writes = Vec::new();
|
||||
for name in &names {
|
||||
writes.push(admin.registry_create([MtaDeliverySchedule {
|
||||
name: name.clone(),
|
||||
queue_id,
|
||||
..Default::default()
|
||||
}]));
|
||||
}
|
||||
let mut schedule_ids = Vec::new();
|
||||
for response in futures::future::join_all(writes).await {
|
||||
assert_applied(&response);
|
||||
schedule_ids.push(response.created_id(0));
|
||||
}
|
||||
for name in &names {
|
||||
assert!(has_schedule(test, name), "{name} missing");
|
||||
}
|
||||
// Several objects in one request: one reload
|
||||
let response = admin
|
||||
.registry_destroy(ObjectType::MtaDeliverySchedule, schedule_ids.iter())
|
||||
.await;
|
||||
assert_applied(&response);
|
||||
for name in &names {
|
||||
assert!(!has_schedule(test, name), "{name} still present");
|
||||
}
|
||||
|
||||
// A write whose reload fails is stored, and the response says the
|
||||
// settings weren't reloaded: only one console tracer is allowed.
|
||||
let response = admin
|
||||
.registry_create([
|
||||
Tracer::Stdout(TracerStdout {
|
||||
enable: true,
|
||||
level: TracingLevel::Error,
|
||||
..Default::default()
|
||||
}),
|
||||
Tracer::Stdout(TracerStdout {
|
||||
enable: true,
|
||||
level: TracingLevel::Error,
|
||||
..Default::default()
|
||||
}),
|
||||
])
|
||||
.await;
|
||||
let reload = settings_reload(&response).expect("x:settingsReload missing");
|
||||
assert_eq!(reload["applied"], Value::Bool(false), "{response:?}");
|
||||
let description = reload["description"].as_str().unwrap_or_default();
|
||||
assert!(
|
||||
description.starts_with("Saved, but the running settings were not reloaded. ")
|
||||
&& description.contains("Only one console tracer is allowed"),
|
||||
"{description}"
|
||||
);
|
||||
let tracer_ids = [response.created_id(0), response.created_id(1)];
|
||||
let response = admin
|
||||
.registry_destroy(ObjectType::Tracer, tracer_ids.iter())
|
||||
.await;
|
||||
assert_applied(&response);
|
||||
|
||||
// Data that isn't part of the running settings doesn't reload them
|
||||
let response = admin
|
||||
.registry_create([Domain {
|
||||
name: "autoreload.example.org".into(),
|
||||
certificate_management: CertificateManagement::Manual,
|
||||
dns_management: DnsManagement::Manual,
|
||||
dkim_management: DkimManagement::Manual,
|
||||
..Default::default()
|
||||
}])
|
||||
.await;
|
||||
assert!(settings_reload(&response).is_none(), "{response:?}");
|
||||
}
|
||||
|
||||
fn settings_reload(response: &JmapResponse) -> Option<&Value> {
|
||||
response.pointer("/methodResponses/0/1/x:settingsReload")
|
||||
}
|
||||
|
||||
fn assert_applied(response: &JmapResponse) {
|
||||
assert_eq!(
|
||||
settings_reload(response),
|
||||
Some(&serde_json::json!({"applied": true})),
|
||||
"{response:?}"
|
||||
);
|
||||
}
|
||||
|
||||
fn has_schedule(test: &TestServer, name: &str) -> bool {
|
||||
test.server
|
||||
.inner
|
||||
.build_server()
|
||||
.core
|
||||
.smtp
|
||||
.queue
|
||||
.queue_strategy
|
||||
.contains_key(name)
|
||||
}
|
||||
@@ -11,6 +11,7 @@ pub mod authentication;
|
||||
pub mod ai;
|
||||
pub mod ai_calibration;
|
||||
pub mod authorization;
|
||||
pub mod auto_reload; // inbuxa: registry writes apply at once
|
||||
pub mod branding;
|
||||
pub mod crypto;
|
||||
pub mod delivery;
|
||||
@@ -20,6 +21,7 @@ pub mod monitoring;
|
||||
pub mod oidc;
|
||||
pub mod purge;
|
||||
pub mod quota;
|
||||
pub mod reload; // inbuxa: reloads and build errors
|
||||
pub mod security;
|
||||
pub mod task;
|
||||
pub mod tenant;
|
||||
|
||||
@@ -0,0 +1,213 @@
|
||||
/*
|
||||
* SPDX-FileCopyrightText: 2026 Coffey Labs
|
||||
*
|
||||
* SPDX-License-Identifier: AGPL-3.0-only
|
||||
*/
|
||||
|
||||
// inbuxa: a settings reload isn't held back by a DNS lookup, or by objects
|
||||
// that already failed when the running settings were built; an error in an
|
||||
// object that built then still refuses it, and says which object.
|
||||
|
||||
use crate::utils::server::{TestServer, TestServerBuilder};
|
||||
use common::{BuildServer, config::mailstore::spamfilter::PyzorConfig, ipc::RegistryChange};
|
||||
use registry::schema::{
|
||||
enums::TracingLevel,
|
||||
prelude::{ObjectType, Property},
|
||||
structs::{Action, Expression, MtaStageAuth, SpamPyzor, Tracer, TracerStdout},
|
||||
};
|
||||
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
pub async fn reload_tests() {
|
||||
let mut test = TestServerBuilder::new("reload_tests")
|
||||
.await
|
||||
.with_default_listeners()
|
||||
.await
|
||||
.with_object(MtaStageAuth {
|
||||
require: Expression {
|
||||
else_: "false".to_string(),
|
||||
..Default::default()
|
||||
},
|
||||
..Default::default()
|
||||
})
|
||||
.await
|
||||
.build()
|
||||
.await;
|
||||
|
||||
let admin = test
|
||||
.create_user_account(
|
||||
"admin",
|
||||
"[email protected]",
|
||||
"these_pretzels_are_making_me_thirsty",
|
||||
&[],
|
||||
"Admin",
|
||||
)
|
||||
.await;
|
||||
test.account("admin")
|
||||
.assign_roles_to_account(admin.id(), &["user", "system"])
|
||||
.await;
|
||||
test.insert_account(admin);
|
||||
|
||||
test_unresolvable_pyzor(&test).await;
|
||||
test_build_errors(&test).await;
|
||||
|
||||
if test.is_reset() {
|
||||
test.temp_dir.delete();
|
||||
}
|
||||
}
|
||||
|
||||
async fn test_unresolvable_pyzor(test: &TestServer) {
|
||||
println!("Running reload with an unresolvable Pyzor host...");
|
||||
let admin = test.account("[email protected]");
|
||||
|
||||
// Upstream resolved the host while building the settings and refused the
|
||||
// reload when that failed.
|
||||
admin
|
||||
.registry_update_setting(
|
||||
SpamPyzor {
|
||||
enable: true,
|
||||
host: "pyzor.invalid".into(),
|
||||
port: 24441,
|
||||
..Default::default()
|
||||
},
|
||||
&[Property::Enable, Property::Host, Property::Port],
|
||||
)
|
||||
.await;
|
||||
admin.reload_settings().await;
|
||||
|
||||
let pyzor = running_pyzor(test);
|
||||
assert_eq!(pyzor.host, "pyzor.invalid");
|
||||
assert_eq!(pyzor.port, 24441);
|
||||
assert!(pyzor.address().await.is_err());
|
||||
|
||||
// An IP address needs no lookup
|
||||
admin
|
||||
.registry_update_setting(
|
||||
SpamPyzor {
|
||||
host: "192.0.2.1".into(),
|
||||
..Default::default()
|
||||
},
|
||||
&[Property::Host],
|
||||
)
|
||||
.await;
|
||||
admin.reload_settings().await;
|
||||
assert_eq!(
|
||||
running_pyzor(test).address().await.unwrap().to_string(),
|
||||
"192.0.2.1:24441"
|
||||
);
|
||||
}
|
||||
|
||||
async fn test_build_errors(test: &TestServer) {
|
||||
println!("Running reload with build errors...");
|
||||
let admin = test.account("[email protected]");
|
||||
let pyzor_ratio = running_pyzor(test).ratio;
|
||||
assert_ne!(pyzor_ratio, 0.25);
|
||||
|
||||
// Two console tracers: only one is allowed, so the build of one of them
|
||||
// fails. Neither existed when the running settings were built.
|
||||
let mut tracer_ids = Vec::new();
|
||||
for _ in 0..2 {
|
||||
tracer_ids.push(
|
||||
admin
|
||||
.registry_create_object(Tracer::Stdout(TracerStdout {
|
||||
enable: true,
|
||||
level: TracingLevel::Error,
|
||||
..Default::default()
|
||||
}))
|
||||
.await,
|
||||
);
|
||||
}
|
||||
admin
|
||||
.registry_update_setting(
|
||||
SpamPyzor {
|
||||
ratio: 0.25.into(),
|
||||
..Default::default()
|
||||
},
|
||||
&[Property::Ratio],
|
||||
)
|
||||
.await;
|
||||
|
||||
// A new error refuses the reload and names the object
|
||||
let err = admin
|
||||
.registry_create_object_expect_err(Action::ReloadSettings)
|
||||
.await;
|
||||
let description = err.description.clone().unwrap_or_default();
|
||||
assert!(
|
||||
description.starts_with("Settings were not reloaded. ")
|
||||
&& description.contains("Tracer")
|
||||
&& description.contains("Only one console tracer is allowed"),
|
||||
"{err:?}"
|
||||
);
|
||||
assert_eq!(running_pyzor(test).ratio, pyzor_ratio);
|
||||
|
||||
// Had the running settings been built with that tracer failing, as a
|
||||
// restart now would, the same error doesn't hold the reload back.
|
||||
let result = Box::pin(
|
||||
test.server
|
||||
.reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
|
||||
)
|
||||
.await
|
||||
.unwrap();
|
||||
assert!(!result.replaced_core);
|
||||
assert_eq!(result.errors.len(), 1, "{:?}", result.errors);
|
||||
test.server.record_build_errors(&result.errors);
|
||||
|
||||
admin.reload_settings().await;
|
||||
assert_eq!(running_pyzor(test).ratio, 0.25);
|
||||
let result = Box::pin(
|
||||
test.server
|
||||
.reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
|
||||
)
|
||||
.await
|
||||
.unwrap();
|
||||
assert!(result.replaced_core);
|
||||
assert!(result.errors.is_empty());
|
||||
assert_eq!(result.known_errors.len(), 1);
|
||||
|
||||
// Once fixed, the object is no longer known to fail, so a new error
|
||||
// there refuses the reload again.
|
||||
admin
|
||||
.registry_destroy(ObjectType::Tracer, tracer_ids.iter())
|
||||
.await
|
||||
.assert_destroyed(&tracer_ids);
|
||||
admin.reload_settings().await;
|
||||
let result = Box::pin(
|
||||
test.server
|
||||
.reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
|
||||
)
|
||||
.await
|
||||
.unwrap();
|
||||
assert!(result.replaced_core);
|
||||
assert!(result.errors.is_empty() && result.known_errors.is_empty());
|
||||
|
||||
for _ in 0..2 {
|
||||
tracer_ids.push(
|
||||
admin
|
||||
.registry_create_object(Tracer::Stdout(TracerStdout {
|
||||
enable: true,
|
||||
level: TracingLevel::Error,
|
||||
..Default::default()
|
||||
}))
|
||||
.await,
|
||||
);
|
||||
}
|
||||
admin
|
||||
.registry_create_object_expect_err(Action::ReloadSettings)
|
||||
.await;
|
||||
let tracer_ids = tracer_ids.split_off(2);
|
||||
admin
|
||||
.registry_destroy(ObjectType::Tracer, tracer_ids.iter())
|
||||
.await
|
||||
.assert_destroyed(&tracer_ids);
|
||||
admin.reload_settings().await;
|
||||
}
|
||||
|
||||
fn running_pyzor(test: &TestServer) -> PyzorConfig {
|
||||
test.server
|
||||
.inner
|
||||
.build_server()
|
||||
.core
|
||||
.spam
|
||||
.pyzor
|
||||
.clone()
|
||||
.expect("Pyzor enabled")
|
||||
}
|
||||
Reference in New Issue
Block a user