CI on pull requests #31

Merged
jcoffey-dev merged 2 commits from ci/pull-request-checks into main 2026-10-15 02:54:40 +00:00
Owner

The repo had no workflow on pull requests, so a PR never got a status and land-delete.py waited on it forever (#30).

One job on the light runner, same pinned Go image and checkout as release.yml:

  • go.mod names no module (standard library only, specs/installer.md §8.1)
  • gofmt -l
  • go vet for amd64 and arm64 (the terminal layer's syscalls differ by arch)
  • go test -count=1 ./...
  • govulncheck@latest, as in ihasmail-oneshot

A backstop, not the gate: changes are still built and tested locally, and the e2e VM cases stay a manual pre-release step. All steps pass locally.

Its first run found something: the release image is Go 1.26.8, and govulncheck reports 9 standard-library advisories the installer reaches (GO-2026-6603, -6605, -6607, -6608, -6610..-6613, -6617: net/http, net/textproto, crypto/tls; fixed in 1.26.9). The other Go repos moved to 1.26.9 on 2026-10-09; this one was missed, so v2026.10.14's binaries carry them. Second commit: go.mod go 1.26.9 and the same image digest as oneshot/stalwart-migrator (d9c68c2c…), in ci.yml and release.yml. govulncheck on 1.26.9: no vulnerabilities.

The repo had no workflow on pull requests, so a PR never got a status and land-delete.py waited on it forever (#30). One job on the `light` runner, same pinned Go image and checkout as release.yml: - go.mod names no module (standard library only, specs/installer.md §8.1) - gofmt -l - go vet for amd64 and arm64 (the terminal layer's syscalls differ by arch) - go test -count=1 ./... - govulncheck@latest, as in ihasmail-oneshot A backstop, not the gate: changes are still built and tested locally, and the e2e VM cases stay a manual pre-release step. All steps pass locally. **Its first run found something:** the release image is Go 1.26.8, and govulncheck reports 9 standard-library advisories the installer reaches (GO-2026-6603, -6605, -6607, -6608, -6610..-6613, -6617: net/http, net/textproto, crypto/tls; fixed in 1.26.9). The other Go repos moved to 1.26.9 on 2026-10-09; this one was missed, so v2026.10.14's binaries carry them. Second commit: go.mod `go 1.26.9` and the same image digest as oneshot/stalwart-migrator (d9c68c2c…), in ci.yml and release.yml. govulncheck on 1.26.9: no vulnerabilities.
jcoffey-dev added 1 commit 2026-10-15 02:48:17 +00:00
jcoffey-dev added 1 commit 2026-10-15 02:50:34 +00:00
jcoffey-dev merged commit d09c7f945d into main 2026-10-15 02:54:40 +00:00
jcoffey-dev deleted branch ci/pull-request-checks 2026-10-15 02:54:40 +00:00
Sign in to join this conversation.