inbuxa/inbuxa-admin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 22 Wiki Activity Sponsor

Received reports: read the report lists as the server sends them #89

Merged
jcoffey-dev merged 1 commits from fix/report-lists-are-maps into main 2026-10-06 16:23:32 +00:00
Conversation 0 Commits 1 Files Changed 5
+76 -19
jcoffey-dev commented 2026-10-06 16:18:57 +00:00
Owner
Copy link
Copy source

Fixes the errors on Inbound DMARC Reports and TLS Reports after #88 went live.

The server sends every objectList as a map keyed by index ({"0": {...}}), not an array, so the summary cards threw on real reports when iterating records, DKIM/SPF results, TLS policies and failure details. #88's preview used array-shaped sample data, so it didn't show up there.

  • read those lists with the existing jmapMapToArray (accepts both shapes)
  • skip a report without a policy domain
  • anything unexpected now shows as an error inside the card instead of breaking the page
  • two tests use the wire shape (maps keyed by index)

No new strings. Checked locally: typecheck, lint, i18n:check, 616 tests, build, notice-check.

Fixes the errors on Inbound DMARC Reports and TLS Reports after #88 went live. The server sends every objectList as a map keyed by index (`{"0": {...}}`), not an array, so the summary cards threw on real reports when iterating records, DKIM/SPF results, TLS policies and failure details. #88's preview used array-shaped sample data, so it didn't show up there. - read those lists with the existing `jmapMapToArray` (accepts both shapes) - skip a report without a policy domain - anything unexpected now shows as an error inside the card instead of breaking the page - two tests use the wire shape (maps keyed by index) No new strings. Checked locally: typecheck, lint, i18n:check, 616 tests, build, notice-check.
jcoffey-dev added 1 commit 2026-10-06 16:18:57 +00:00
Received reports: read the report lists as the server sends them
ci / build (pull_request) Skipped
Details
ci / notices (pull_request) Successful in 1m3s
Details
ci / publish (pull_request) Skipped
Details
github/ci (branch) GitHub Actions
Details
ci / github (pull_request) Successful in 1m37s
Details
71918cd6a4 
The server sends every objectList as a map keyed by index, not an array,
so the summary cards threw on real reports (records, DKIM and SPF
results, TLS policies and failures). Read them with jmapMapToArray, skip
a report without a policy domain, and show anything unexpected as an
error in the card instead of breaking the page.
jcoffey-dev merged commit 3270190077 into main 2026-10-06 16:23:32 +00:00
jcoffey-dev deleted branch fix/report-lists-are-maps 2026-10-06 16:23:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Dependency updates
 documentation
Docs, README or site copy
 duplicate
Already tracked elsewhere
 enhancement
New feature or improvement
 good first issue
Good for newcomers
 help wanted
Contributions welcome
 invalid
Not a valid issue
 needs info
Waiting on the reporter for details
 question
Needs an answer, not a code change
 security
Security issue or hardening
 translation
New language or translation fixes
 wontfix
Will not be worked on
priority
p1
High priority
priority
p2
Medium priority
priority
p3
Low priority
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#89