inbuxa/inbuxa-admin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 22 Wiki Activity Sponsor

Lists page on without a total, and don't keep a stale one #61

Merged
jcoffey-dev merged 1 commits from fix/list-without-total into main 2026-09-29 05:00:19 +00:00
Conversation 0 Commits 1 Files Changed 2
+11 -8
jcoffey-dev commented 2026-09-29 04:43:05 +00:00
Owner
Copy link
Copy source

The console half of the Logs "of 5000" fix. Goes with inbuxa-server #117, which now leaves the total out when it can't know it.

DynamicList:

  • The total is cleared when a reply has none. Before, it kept the previous page's.
  • Next is enabled after a full page when there's no total. Before, no total meant no Next, which would have stranded logs on page 1.
  • The count reads "Showing 26-40 log entries" without "of N". The old "Showing N items" string, now unused, is gone from en.json, and the new one is added.

Lists that report a total behave exactly as before.

Checked:

  • 533 tests pass; typecheck, lint and i18n:check are clean.
  • In Chrome against a local server built from #117 with 40 log entries: page 1 read "Showing 1-25 log entries" with Next on; page 2 read "Showing 26-40 log entries" with Next off and Previous on.

English: one new string (list.showingRange), one removed.

The console half of the Logs "of 5000" fix. **Goes with inbuxa-server #117**, which now leaves the total out when it can't know it. `DynamicList`: - **The total is cleared** when a reply has none. Before, it kept the previous page's. - **Next** is enabled after a full page when there's no total. Before, no total meant no Next, which would have stranded logs on page 1. - **The count reads "Showing 26-40 log entries"** without "of N". The old "Showing N items" string, now unused, is gone from `en.json`, and the new one is added. Lists that report a total behave exactly as before. **Checked:** - 533 tests pass; typecheck, lint and `i18n:check` are clean. - In Chrome against a local server built from #117 with 40 log entries: page 1 read "Showing 1-25 log entries" with Next on; page 2 read "Showing 26-40 log entries" with Next off and Previous on. English: one new string (`list.showingRange`), one removed.
jcoffey-dev added 1 commit 2026-09-29 04:43:06 +00:00
Lists page on without a total, and don't keep a stale one
ci / build (pull_request) Successful in 1m16s
Details
ci / publish (pull_request) Skipped
Details
d3429b8aa8
jcoffey-dev merged commit 7853899489 into main 2026-09-29 05:00:19 +00:00
jcoffey-dev deleted branch fix/list-without-total 2026-09-29 05:00:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Dependency updates
 documentation
Docs, README or site copy
 duplicate
Already tracked elsewhere
 enhancement
New feature or improvement
 good first issue
Good for newcomers
 help wanted
Contributions welcome
 invalid
Not a valid issue
 needs info
Waiting on the reporter for details
 question
Needs an answer, not a code change
 security
Security issue or hardening
 translation
New language or translation fixes
 wontfix
Will not be worked on
priority
p1
High priority
priority
p2
Medium priority
priority
p3
Low priority
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#61