Reset to default on each Settings page with changed values #52

Merged

jcoffey-dev merged 1 commits from feature/reset-to-default into main

2026-09-28 23:47:20 +00:00

jcoffey-dev commented

2026-09-28 23:45:48 +00:00

Owner

The last item from the settings-reorg spec's Applies to every form: "Reset to default" on each page that has changed values.

The button. A Settings page (a singleton form) shows Reset to default beside Cancel and Save whenever one of its fields differs from its default. It uses the same rule as the changed tag on a field and the Overview's count, so the three always agree.
The dialog lists each field it would put back, with its value now and its default in words (e.g. Spam threshold 4 → 5). Server-set fields are left out.
Nothing is written straight away. Fill in defaults puts the defaults into the form. It then shows Unsaved changes, and only Save writes them; Cancel, or leaving, keeps the server as it was.
changedFields() is the new helper in features/settings/changedFromDefault.ts. countChanged() for the Overview now uses it too. As a result, a field listed twice on one page no longer counts twice, and server-set fields no longer count at all.

Checked:

New unit tests: what's listed, server-set fields left out, and an empty list when nothing differs. 502 tests pass in total.
Typecheck, lint and build are clean.
In Chrome against a local server, Spam filter › General with thresholds 4 / 12 showed the button. The dialog listed Spam threshold 4 → 5 and Reject threshold 12 → 0. Fill in defaults cleared both changed tags and showed Unsaved changes. After Save and a reload, the page showed Balanced as current and no reset button.

English only: 6 new strings.

The last item from the settings-reorg spec's *Applies to every form*: "Reset to default" on each page that has changed values. - **The button.** A Settings page (a singleton form) shows **Reset to default** beside Cancel and Save whenever one of its fields differs from its default. It uses the same rule as the *changed* tag on a field and the Overview's count, so the three always agree. - **The dialog** lists each field it would put back, with its value now and its default in words (e.g. *Spam threshold 4 → 5*). Server-set fields are left out. - **Nothing is written straight away.** *Fill in defaults* puts the defaults into the form. It then shows *Unsaved changes*, and only Save writes them; Cancel, or leaving, keeps the server as it was. - **`changedFields()`** is the new helper in `features/settings/changedFromDefault.ts`. `countChanged()` for the Overview now uses it too. As a result, a field listed twice on one page no longer counts twice, and server-set fields no longer count at all. **Checked:** - New unit tests: what's listed, server-set fields left out, and an empty list when nothing differs. 502 tests pass in total. - Typecheck, lint and build are clean. - In Chrome against a local server, Spam filter › General with thresholds 4 / 12 showed the button. The dialog listed *Spam threshold 4 → 5* and *Reject threshold 12 → 0*. *Fill in defaults* cleared both *changed* tags and showed *Unsaved changes*. After Save and a reload, the page showed Balanced as current and no reset button. English only: 6 new strings.

jcoffey-dev added 1 commit 2026-09-28 23:45:48 +00:00

Reset to default on each Settings page with changed values

ci / build (pull_request) Successful in 1m8s

Details

ci / publish (pull_request) Skipped

Details

7279528e68

jcoffey-dev merged commit 3f05b142f4 into main

2026-09-28 23:47:20 +00:00

jcoffey-dev deleted branch feature/reset-to-default

2026-09-28 23:47:21 +00:00

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#52