Rewrite global search, the command palette, the record page and the error boundary #133

Merged

jcoffey-dev merged 1 commits from phase5/search into main 2026-10-19 05:21:51 +00:00

Conversation 0 Commits 1 Files Changed 12

+544 -266

jcoffey-dev commented 2026-10-19 05:19:26 +00:00

Owner

Copy link

Copy source

Phase 5, part 2: global search, the command palette, the read-only record page and the error boundary. Stacked on #132, so merge that first.

Searching and grouping move to globalSearch.ts, the palette's rows to paletteRows.ts, and reading and naming a record to recordView.ts, all with tests. The palette, the record page and the error boundary are rewritten with the same markup; the error boundary test also passed on the old one. Dropped: an unused value the search hook returned.

	Not upstream's	Upstream lines left	Dual headers	Tests
phase 4 end	87.0%	9,896 in 33 files	20	865
after this PR	88.8%	8,534 in 24 files	10	949

That ends phase 5. The plan expected 88.4%.

Visual check: a scripted run on part 1 and then on this branch, in light and dark: five palette searches, keyboard and mouse picks, the top bar's search box, and the read-only pages for a domain, a user and a missing record. Same results, same screens. The full sweep is in #132.

Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

Phase 5, part 2: global search, the command palette, the read-only record page and the error boundary. Stacked on #132, so merge that first. Searching and grouping move to `globalSearch.ts`, the palette's rows to `paletteRows.ts`, and reading and naming a record to `recordView.ts`, all with tests. The palette, the record page and the error boundary are rewritten with the same markup; the error boundary test also passed on the old one. Dropped: an unused value the search hook returned. | | Not upstream's | Upstream lines left | Dual headers | Tests | |---|---|---|---|---| | phase 4 end | 87.0% | 9,896 in 33 files | 20 | 865 | | after this PR | 88.8% | 8,534 in 24 files | 10 | 949 | That ends phase 5. The plan expected 88.4%. **Visual check:** a scripted run on part 1 and then on this branch, in light and dark: five palette searches, keyboard and mouse picks, the top bar's search box, and the read-only pages for a domain, a user and a missing record. Same results, same screens. The full sweep is in #132. Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

jcoffey-dev added 2 commits 2026-10-19 05:19:26 +00:00

Rewrite the panel, sidebar, top bar, page routing and layout rules ec3f6daa46

Rewrite global search, the command palette, the record page and the error boundary 5c5ec05003

jcoffey-dev merged commit ebc970e46d into main 2026-10-19 05:21:51 +00:00

jcoffey-dev deleted branch phase5/search 2026-10-19 05:21:51 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

Dependency updates

documentation

Docs, README or site copy

duplicate

Already tracked elsewhere

enhancement

New feature or improvement

good first issue

Good for newcomers

help wanted

Contributions welcome

invalid

Not a valid issue

needs info

Waiting on the reporter for details

question

Needs an answer, not a code change

security

Security issue or hardening

translation

New language or translation fixes

wontfix

Will not be worked on

priority

p1

High priority

priority

p2

Medium priority

priority

p3

Low priority

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jcoffey-dev (John Coffey)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#133