Rewrite the expression editor, two-factor setup and object picker #131

Merged

jcoffey-dev merged 1 commits from phase4/editors into main 2026-10-19 04:17:41 +00:00

Conversation 0 Commits 1 Files Changed 7

+446 -291

jcoffey-dev commented 2026-10-19 04:15:18 +00:00

Owner

Copy link

Copy source

Phase 4, part 6: the expression editor, the two-factor setup field and the object picker. Stacked on #130, so merge that first.

Editing an expression's conditions moves to conditions.ts, and making the secret, checking the first code and reading the stored state move to otp.ts, both with tests. The three components are rewritten with the same markup. No change in behavior.

	Not upstream's	Upstream lines left	Dual headers	Tests
phase 3 end	81.5%	13,775 in 51 files	39	724
after this PR	87.0%	9,896 in 33 files	20	865

That ends phase 4. The plan expected 86.5%.

Visual check: see #126. It covered all six phase 4 PRs and found no change in the UI.

Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

Phase 4, part 6: the expression editor, the two-factor setup field and the object picker. Stacked on #130, so merge that first. Editing an expression's conditions moves to `conditions.ts`, and making the secret, checking the first code and reading the stored state move to `otp.ts`, both with tests. The three components are rewritten with the same markup. No change in behavior. | | Not upstream's | Upstream lines left | Dual headers | Tests | |---|---|---|---|---| | phase 3 end | 81.5% | 13,775 in 51 files | 39 | 724 | | after this PR | 87.0% | 9,896 in 33 files | 20 | 865 | That ends phase 4. The plan expected 86.5%. **Visual check:** see #126. It covered all six phase 4 PRs and found no change in the UI. Typecheck, lint, i18n:check, tests, build and notice check pass locally. No new strings.

jcoffey-dev added 6 commits 2026-10-19 04:15:18 +00:00

Rewrite the delivery trace page ... b1d833bbe4

The trace's logic is now plain, tested code: trace.ts pairs each step's
start with its outcome, groups steps by delivery attempt, names and
describes them, and holds the trace's states as a reducer; stream.ts runs
the token and the event stream. The page only draws them, unchanged.

Two fixes on the way: "Started Ns ago" counts from the trace's own start
(it carried on from the previous trace before), and cancelling while the
token is still on its way no longer opens the stream afterwards.

Rewrite the setup wizard ... 737eac2279

Its rules are now plain, tested code in wizard.ts: which fields each step
shows, which are required, where the server's refusal lands, and what the
finish screen lists. The wizard itself is rewritten on top of them, with
the same steps, look and update.

Rewrite the actions page ... 39d9062ccf

Its rules are now plain, tested code in actions.ts: grouping actions by
label, what creating one sends (no server results, no untouched secrets),
reading the answer, and which options are required. The page is
rewritten on top of them, with the same look and flow. An action without
options now shows its label while it runs, not its internal name.

Rewrite live tracing, the trace timeline and the trace detail view ... 6a4a25937a

The formatting rules (ids in the server's base 32, durations, offsets,
event icons, the trace summary) are in format.ts, and the live stream's
token, reconnects and event buffer in live.ts, all with tests; the
normalizer and types are rewritten with a test too. The three components
are rewritten on top, with the same look.

One fix: stopping live tracing while a reconnect was pending could reopen
the stream two seconds later. Stopping now stops it for good.

Rewrite the dashboard helpers, metric stores and types 12cd0ff5c8

Rewrite the expression editor, two-factor setup and object picker 7375d6ccc2

jcoffey-dev merged commit ce2b440bf9 into main 2026-10-19 04:17:41 +00:00

jcoffey-dev deleted branch phase4/editors 2026-10-19 04:17:42 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

Dependency updates

documentation

Docs, README or site copy

duplicate

Already tracked elsewhere

enhancement

New feature or improvement

good first issue

Good for newcomers

help wanted

Contributions welcome

invalid

Not a valid issue

needs info

Waiting on the reporter for details

question

Needs an answer, not a code change

security

Security issue or hardening

translation

New language or translation fixes

wontfix

Will not be worked on

priority

p1

High priority

priority

p2

Medium priority

priority

p3

Low priority

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jcoffey-dev (John Coffey)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#131