Measure what's left of upstream; drop two unused components #117

Merged

jcoffey-dev merged 2 commits from phase1/measure into main 2026-10-18 23:50:49 +00:00

Conversation 0 Commits 2 Files Changed 5

+106 -141

jcoffey-dev commented 2026-10-18 23:03:18 +00:00

Owner

Copy link

Copy source

First PR of phase 1 of the plan to reach our own code (inbuxa-drafts
specs/console-rewrite-plan.md).

• tools/divergence.mjs (npm run divergence) reports, against the
  v1.0.11 fork point:

  • the share of lines upstream didn't write;
  • upstream lines left, and in how many files;
  • files still carrying upstream's dual header.

  Each PR of the rewrite states how far it moved these numbers.
  --files lists what's left, file by file.

• Rewritten files count as ours once upstream's header is gone, since the header only changes when none of upstream's code is left. A rewrite still shares blank lines, imports, brackets and shadcn/ui class lists with upstream's copy, so a plain line diff never reaches zero. The summary prints how many lines those files still share, so the claim can be checked.

• Removed: chart.tsx and scroll-area.tsx, which nothing used,
  with @radix-ui/react-scroll-area.

	Not upstream's	Upstream lines left	Dual headers
main (5e8693f)	74.2%	19,265 in 125 files	110
this PR	74.4%	19,165 in 123 files	108

Typecheck, lint, i18n:check, all 689 tests, build and notice check pass
locally. No new strings.

First PR of phase 1 of the plan to reach our own code (inbuxa-drafts `specs/console-rewrite-plan.md`). - **`tools/divergence.mjs`** (`npm run divergence`) reports, against the v1.0.11 fork point: - the share of lines upstream didn't write; - upstream lines left, and in how many files; - files still carrying upstream's dual header. Each PR of the rewrite states how far it moved these numbers. `--files` lists what's left, file by file. - **Rewritten files count as ours** once upstream's header is gone, since the header only changes when none of upstream's code is left. A rewrite still shares blank lines, imports, brackets and shadcn/ui class lists with upstream's copy, so a plain line diff never reaches zero. The summary prints how many lines those files still share, so the claim can be checked. - **Removed:** `chart.tsx` and `scroll-area.tsx`, which nothing used, with `@radix-ui/react-scroll-area`. | | Not upstream's | Upstream lines left | Dual headers | |---|---|---|---| | main (`5e8693f`) | 74.2% | 19,265 in 125 files | 110 | | this PR | 74.4% | 19,165 in 123 files | 108 | Typecheck, lint, i18n:check, all 689 tests, build and notice check pass locally. No new strings.

jcoffey-dev added 1 commit 2026-10-18 23:03:19 +00:00

Measure what's left of upstream; drop two unused components ... 2b68e78592

tools/divergence.mjs (npm run divergence) reports how much of the console
is still upstream's, against the v1.0.11 fork point: the share of lines
upstream didn't write, upstream lines left and in how many files, and the
files still carrying upstream's dual header. Each PR of the rewrite to
our own code states how far it moved these numbers; --files lists what's
left, file by file.

The chart and scroll-area components weren't used anywhere, so they go,
with @radix-ui/react-scroll-area.

jcoffey-dev added 1 commit 2026-10-18 23:30:46 +00:00

Count a file as rewritten once upstream's header is gone ... 6d62474929

The header only changes when no upstream code is left in a file, but a
rewrite still shares blank lines, imports, brackets and shadcn/ui class lists
with upstream's copy, so a plain line diff never reaches zero. A file that
named Stalwart Labs at the base and no longer does now counts as ours, and
the summary prints how many lines those files still share, so the claim can
be checked.

jcoffey-dev merged commit 8303d6307e into main 2026-10-18 23:50:49 +00:00

jcoffey-dev deleted branch phase1/measure 2026-10-18 23:50:50 +00:00

jcoffey-dev referenced this pull request 2026-10-18 23:51:26 +00:00

Rebuild the simple base components on shadcn/ui #118

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

Dependency updates

documentation

Docs, README or site copy

duplicate

Already tracked elsewhere

enhancement

New feature or improvement

good first issue

Good for newcomers

help wanted

Contributions welcome

invalid

Not a valid issue

needs info

Waiting on the reporter for details

question

Needs an answer, not a code change

security

Security issue or hardening

translation

New language or translation fixes

wontfix

Will not be worked on

priority

p1

High priority

priority

p2

Medium priority

priority

p3

Low priority

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jcoffey-dev (John Coffey)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#117