DNS setup: a domain's own valid DMARC or SPF counts as done (#239) #240

Merged
jcoffey-dev merged 1 commits from fix/239-dns-own-record into main 2026-11-18 18:36:16 +00:00
Owner

Fixes #239. Follows #236/#237 (community t/321).

The DNS setup pages (Connect DNS's Go live step and the copy-by-hand step) marked any record that wasn't exactly the suggested value as different, in amber, with "often an old record that hasn't expired from caches yet", and never reached "All set". A DMARC with the domain's own report addresses, or an SPF with an extra include, is the admin's choice and valid.

  • DMARC and SPF are judged with coreState from #237: a single well-formed record of the domain's own is valid.
  • valid gets a green badge ("Your own record, valid"), counts toward the progress ring and "All set", and a note says it can stay; the suggested value is still shown for anyone who wants it.
  • The amber mark and caching note stay for records that really differ: two SPF records, a DMARC with no policy, MX or DKIM elsewhere.

Tests: src/features/dns/recordState.test.ts. Ran typecheck, lint, i18n:check, test (1119 passed), the three shell tests, build and notice-check locally.

Fixes #239. Follows #236/#237 (community t/321). The DNS setup pages (Connect DNS's Go live step and the copy-by-hand step) marked any record that wasn't exactly the suggested value as different, in amber, with "often an old record that hasn't expired from caches yet", and never reached "All set". A DMARC with the domain's own report addresses, or an SPF with an extra include, is the admin's choice and valid. - DMARC and SPF are judged with `coreState` from #237: a single well-formed record of the domain's own is `valid`. - `valid` gets a green badge ("Your own record, valid"), counts toward the progress ring and "All set", and a note says it can stay; the suggested value is still shown for anyone who wants it. - The amber mark and caching note stay for records that really differ: two SPF records, a DMARC with no policy, MX or DKIM elsewhere. Tests: `src/features/dns/recordState.test.ts`. Ran typecheck, lint, i18n:check, test (1119 passed), the three shell tests, build and notice-check locally.
jcoffey-dev added 1 commit 2026-11-18 18:33:37 +00:00
DNS setup: a domain's own valid DMARC or SPF counts as done (#239)
ci / build (pull_request) Skipped
ci / notices (pull_request) Successful in 17s
ci / publish (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 2m26s
0e04c5bd9d
The DNS setup pages marked every published record that wasn't exactly
the suggested one as different, in amber, with a note about old records
in caches, and never reached "All set". A DMARC with the domain's own
report addresses, or an SPF with an extra include, is neither: the
admin chose it and it's valid.

The pages now judge DMARC and SPF with coreState from #237. A single
well-formed record of the domain's own gets a green badge ("Your own
record, valid"), counts toward the progress and "All set", and a note
says it can stay. The amber mark and its caching note stay for records
that really differ: two SPF records, a DMARC with no policy, an MX or
DKIM key elsewhere.
jcoffey-dev merged commit e86ce19b61 into main 2026-11-18 18:36:16 +00:00
jcoffey-dev deleted branch fix/239-dns-own-record 2026-11-18 18:36:16 +00:00
Sign in to join this conversation.