Security: a valid DMARC or SPF of the domain's own isn't missing (#236) #237

Merged
jcoffey-dev merged 1 commits from fix/236-dns-different-not-missing into main 2026-11-18 16:04:38 +00:00
Owner

Fixes #236.

The Mail records check (SS-13) called any core record that wasn't exactly the suggested value missing, so a valid DMARC with its own rua/ruf, or a hand-tuned SPF, read as "missing in public DNS" (forum t/321).

  • checkRecordValues keeps the values found beside each state; checkRecords is unchanged for the DNS page.
  • coreState gives each kind live, valid, different, missing or error. A single well-formed DMARC (with p=) or SPF passes as valid; other TXT at the name don't count; two SPF records are different.
  • SS-13 keeps "is missing" for missing records and says "doesn't match this server" for an MX or DKIM that differs, or a broken SPF/DMARC, with a reason for each. Its value for missing-only items is the same as before, so existing acceptances hold.
  • A domain whose lookups all failed is not checked, instead of missing. A kind whose lookup alone failed is left out.
  • The hover card counts a valid record as live.

Checked locally: typecheck, lint, i18n:check, tests (1114, new ones in facts.test.ts and checks.test.ts), shell tests, notice check, build.

Fixes #236. The Mail records check (SS-13) called any core record that wasn't exactly the suggested value missing, so a valid DMARC with its own `rua`/`ruf`, or a hand-tuned SPF, read as "missing in public DNS" (forum t/321). - `checkRecordValues` keeps the values found beside each state; `checkRecords` is unchanged for the DNS page. - `coreState` gives each kind `live`, `valid`, `different`, `missing` or `error`. A single well-formed DMARC (with `p=`) or SPF passes as `valid`; other TXT at the name don't count; two SPF records are `different`. - SS-13 keeps "is missing" for missing records and says "doesn't match this server" for an MX or DKIM that differs, or a broken SPF/DMARC, with a reason for each. Its value for missing-only items is the same as before, so existing acceptances hold. - A domain whose lookups all failed is not checked, instead of missing. A kind whose lookup alone failed is left out. - The hover card counts a valid record as live. Checked locally: typecheck, lint, i18n:check, tests (1114, new ones in `facts.test.ts` and `checks.test.ts`), shell tests, notice check, build.
jcoffey-dev added 1 commit 2026-11-18 15:54:47 +00:00
Security: a valid DMARC or SPF of the domain's own isn't missing (#236)
ci / build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / notices (pull_request) Successful in 17s
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 2m5s
5abedf913a
The Mail records check (SS-13) called every core record that wasn't
exactly the suggested value missing. Now each kind has a state:
missing records stay missing; a single well-formed DMARC (with p=) or
SPF of the domain's own passes, as SS-18 and the Deliverability tab
cover what it says; an MX or DKIM that differs, or a broken SPF or
DMARC, is named as not matching this server; and a domain whose
lookups all failed is not checked rather than missing. The DNS page's
comparison is unchanged.
jcoffey-dev self-assigned this 2026-11-18 15:56:34 +00:00
jcoffey-dev merged commit 72dd71e271 into main 2026-11-18 16:04:38 +00:00
jcoffey-dev deleted branch fix/236-dns-different-not-missing 2026-11-18 16:04:38 +00:00
Sign in to join this conversation.