inbuxa/inbuxa-admin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 22 Wiki Activity Sponsor

Certificates guide: keep a domain's own hostnames #164

Merged
jcoffey-dev merged 1 commits from fix/certificates-guide-keeps-names-160 into main 2026-11-06 07:34:40 +00:00
Conversation 0 Commits 1 Files Changed 3
+30 -6
jcoffey-dev commented 2026-11-06 07:31:54 +00:00
Owner
Copy link
Copy source

Fixes #160.

The guide wrote an empty subjectAlternativeNames for every domain it switched. A domain already on ACME isn't ticked by default, but ticking one wiped its custom list with no warning.

It now keeps the domain's list. The names check and the review step use the names that list orders, by the server's rule: a name without a dot gets the domain added, one with a dot is used as written. A domain with no list gets the defaults, as before.

Tested with a new orderNames case, plus typecheck, lint, i18n check, full npm test, the release-version and IPv6 scripts, build and notice check. I didn't click through the guide against a live server.

Fixes #160. The guide wrote an empty `subjectAlternativeNames` for every domain it switched. A domain already on ACME isn't ticked by default, but ticking one wiped its custom list with no warning. It now keeps the domain's list. The names check and the review step use the names that list orders, by the server's rule: a name without a dot gets the domain added, one with a dot is used as written. A domain with no list gets the defaults, as before. Tested with a new `orderNames` case, plus typecheck, lint, i18n check, full `npm test`, the release-version and IPv6 scripts, build and notice check. I didn't click through the guide against a live server.
jcoffey-dev added 1 commit 2026-11-06 07:31:54 +00:00
Certificates guide: keep a domain's own hostnames
ci / build (pull_request) Skipped
Details
ci / publish (pull_request) Skipped
Details
ci / notices (pull_request) Successful in 1m3s
Details
github/ci (branch) GitHub Actions
Details
ci / github (pull_request) Successful in 2m37s
Details
78813c486f 
The guide wrote an empty subjectAlternativeNames for every domain it
switched, so ticking a domain already on ACME wiped its custom list with
no warning. It now keeps the list, and checks and shows the names that
list orders: a name without a dot gets the domain added, one with a dot
is used as written, the same as the server.

Fixes #160
jcoffey-dev merged commit 4f1682fc76 into main 2026-11-06 07:34:40 +00:00
jcoffey-dev deleted branch fix/certificates-guide-keeps-names-160 2026-11-06 07:34:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Dependency updates
 documentation
Docs, README or site copy
 duplicate
Already tracked elsewhere
 enhancement
New feature or improvement
 good first issue
Good for newcomers
 help wanted
Contributions welcome
 invalid
Not a valid issue
 needs info
Waiting on the reporter for details
 question
Needs an answer, not a code change
 security
Security issue or hardening
 translation
New language or translation fixes
 wontfix
Will not be worked on
priority
p1
High priority
priority
p2
Medium priority
priority
p3
Low priority
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-admin#164