jcoffey-dev
bd6a605d61
Takes the flat module count from 66 to 42, continuing what admin/ and
calendar/ started.
lib/mailbox/ archiveDate, emptyFolder, folderMove, labelTree,
mailboxName, mailboxRoute
lib/sieve/ sieve, sieveApply, sieveFolders
lib/input/ keyboard, swipe, touch, listSelection, dropUpload
lib/notify/ notify, webpush, webpushEnable
lib/sw/ swCache, swFacts, staleBuild
lib/text/ html, markdown, text, emlName
FOUR THINGS THE FILENAMES GET WRONG, each checked by reading the file
rather than trusting what it is called:
- appFolder is not a mailbox. It is the `ihasmail` folder in JMAP
*Files*, where the client keeps signature images and synced settings.
It stays flat.
- format holds no formatting of text. It re-exports the date and clock
formatters, so it belongs with dates/datetime, not with text/.
- preview is the file viewer deciding what it can show without
downloading, and source is where to point someone asking for this
instance's AGPL source. Neither is about text.
- notify is not Web Push. It is the tab title, the favicon badge and
the new-mail sound -- in-app notification, which is why it sits with
webpush rather than under sw/ with the service worker's own concerns.
threadScroll stays flat too: it decides where a conversation opens, which
is view state rather than a gesture, and input/ is honest only if
everything in it interprets something the reader did.
No behavior change. Almost every reference was on the @/ alias; eight
relative imports in files that did not move, or that moved away from a
sibling, needed rewriting by hand.
127 lines
4.7 KiB
TypeScript
127 lines
4.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import { reloadIfServerRebuilt, makeConnectionWatcher, startBuildWatch } from "@/lib/sw/staleBuild";
|
|
import { APP_VERSION } from "@/lib/version";
|
|
|
|
function healthReplies(body: unknown, ok = true) {
|
|
return vi.fn().mockResolvedValue({ ok, json: async () => body } as unknown as Response);
|
|
}
|
|
|
|
let reload: ReturnType<typeof vi.fn>;
|
|
|
|
beforeEach(() => {
|
|
sessionStorage.clear();
|
|
reload = vi.fn();
|
|
Object.defineProperty(window, "location", {
|
|
configurable: true,
|
|
value: { ...window.location, reload },
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
describe("reloadIfServerRebuilt", () => {
|
|
it("reloads when the server reports a different build", async () => {
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: `${APP_VERSION}-newer` }));
|
|
expect(await reloadIfServerRebuilt()).toBe(true);
|
|
expect(reload).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("leaves the page alone when the versions match", async () => {
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: APP_VERSION }));
|
|
expect(await reloadIfServerRebuilt()).toBe(false);
|
|
expect(reload).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("reloads once per version, not once per 401", async () => {
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: "9.9.9" }));
|
|
expect(await reloadIfServerRebuilt()).toBe(true);
|
|
expect(await reloadIfServerRebuilt()).toBe(false);
|
|
expect(reload).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("clears the guard once the versions agree again", async () => {
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: "9.9.9" }));
|
|
await reloadIfServerRebuilt();
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: APP_VERSION }));
|
|
await reloadIfServerRebuilt();
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: "9.9.9" }));
|
|
expect(await reloadIfServerRebuilt()).toBe(true);
|
|
expect(reload).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("does not reload when the server cannot be reached", async () => {
|
|
vi.stubGlobal("fetch", vi.fn().mockRejectedValue(new Error("offline")));
|
|
expect(await reloadIfServerRebuilt()).toBe(false);
|
|
expect(reload).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not reload on a bad response or a missing version", async () => {
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true, version: "9.9.9" }, false));
|
|
expect(await reloadIfServerRebuilt()).toBe(false);
|
|
vi.stubGlobal("fetch", healthReplies({ ok: true }));
|
|
expect(await reloadIfServerRebuilt()).toBe(false);
|
|
expect(reload).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe("noticing without being asked", () => {
|
|
it("checks when the push stream drops, but not before it has connected", async () => {
|
|
const fetchMock = healthReplies({ ok: true, version: APP_VERSION });
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
const onState = makeConnectionWatcher();
|
|
|
|
// never connected: a disconnect is not news
|
|
onState("connecting");
|
|
await new Promise((r) => setTimeout(r, 0));
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
|
|
onState("connected");
|
|
onState("connecting");
|
|
await new Promise((r) => setTimeout(r, 0));
|
|
expect(fetchMock).toHaveBeenCalled();
|
|
});
|
|
|
|
it("asks the server once when several things notice at the same moment", async () => {
|
|
const fetchMock = healthReplies({ ok: true, version: APP_VERSION });
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
await Promise.all([reloadIfServerRebuilt(), reloadIfServerRebuilt(), reloadIfServerRebuilt()]);
|
|
expect(fetchMock).toHaveBeenCalledOnce();
|
|
});
|
|
});
|
|
|
|
describe("the poll is what the guarantee rests on", () => {
|
|
it("checks on its own while the tab is visible, with nobody touching it", async () => {
|
|
vi.useFakeTimers();
|
|
const fetchMock = healthReplies({ ok: true, version: "9.9.9" });
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
Object.defineProperty(document, "visibilityState", { configurable: true, get: () => "visible" });
|
|
|
|
startBuildWatch();
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
|
|
await vi.advanceTimersByTimeAsync(60_000);
|
|
expect(fetchMock).toHaveBeenCalled();
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
it("leaves a hidden tab alone until it is looked at", async () => {
|
|
vi.useFakeTimers();
|
|
const fetchMock = healthReplies({ ok: true, version: APP_VERSION });
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
let visibility = "hidden";
|
|
Object.defineProperty(document, "visibilityState", { configurable: true, get: () => visibility });
|
|
|
|
startBuildWatch();
|
|
await vi.advanceTimersByTimeAsync(180_000);
|
|
expect(fetchMock).not.toHaveBeenCalled();
|
|
|
|
visibility = "visible";
|
|
document.dispatchEvent(new Event("visibilitychange"));
|
|
await vi.advanceTimersByTimeAsync(0);
|
|
expect(fetchMock).toHaveBeenCalled();
|
|
vi.useRealTimers();
|
|
});
|
|
});
|