jcoffey-dev
34baca4365
ci / node (pull_request) Skipped
ci / version (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 2m26s
ci / docker-build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / announce (pull_request) Skipped
Someone who looks after several mailboxes of their own can now keep them all signed in in one browser and move between them from the account menu, without signing out (multi-account spec, MA-B; forum topic 75). How it holds them. The session cookie is unchanged: it is the account in front, and every request is answered with it, so nothing else in the server changes. The others ride in a second cookie, <name>_more, as a list of their own session cookies. Each session stays its own -- sealed credential, expiry and "this is my device" -- and nothing about one is read through another. At most 5 in all, all on this mail server. - Add account (account menu): with sign-in on the mail server's page it goes there with prompt=login, so the server asks again rather than reuse the first sign-in; with the password form, a small dialog asks. Refused, and the front stays, when either account's organization has addAccounts off (inbuxa:SharingPolicy), the account is on another server, or 5 are open. The same account again just comes to the front. - Switching (POST /api/auth/accounts/<id>/front) swaps it into front; the web app clears what it cached for the previous account and reloads. A message being written blocks the switch. - Sign out ends only the account in front, and the next one comes forward; Sign out of all accounts ends every one. - GET /api/auth/accounts lists them, the front first, and says whether one more may be added. Not in this change: unread counts and notifications for the accounts not in front (MA-8), which the spec puts last. The mock can sign in a second user (MOCK_SECOND_USER/PASS) and answer addAccounts false (MOCK_NO_ADD_ACCOUNTS), for the new server tests: two accounts joining, switching, the same account twice, a switch to a session it doesn't hold, signing out of one and of all, and an organization that forbids it; and the OAuth start asking prompt=login. The client tests cover listing, switching (cache cleared, reload) and both sign-outs. Checked in Chrome against the mock: add, switch, sign out of one. New strings (9, English only in the other ten catalogs): "Add account", "Sign out of all accounts", "Add an account", "Both accounts stay signed in here; switch between them from this menu.", "Working…", "That account couldn't be added.", "You can't add more accounts here.", and the other-server and organization refusals. typecheck, tests (web 1538, server 276) and build pass.
78 lines
3.1 KiB
TypeScript
78 lines
3.1 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { useSession } from "@/store/session";
|
|
|
|
/**
|
|
* inbuxa MA-B: the accounts signed in in this browser. The server lists them
|
|
* and swaps the one in front; the web app clears what it cached for the
|
|
* previous account and reloads, and signing out of one reloads into the next.
|
|
*/
|
|
|
|
let reload: ReturnType<typeof vi.fn>;
|
|
let calls: { url: string; method: string }[];
|
|
let answers: Record<string, unknown>;
|
|
|
|
beforeEach(() => {
|
|
reload = vi.fn();
|
|
Object.defineProperty(window, "location", { configurable: true, value: { ...window.location, reload } });
|
|
calls = [];
|
|
answers = {};
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
vi.fn(async (url: string, init?: RequestInit) => {
|
|
const path = String(url);
|
|
calls.push({ url: path, method: init?.method ?? "GET" });
|
|
const key = Object.keys(answers).find((k) => path.endsWith(k));
|
|
const body = key ? answers[key] : { ok: true };
|
|
return { ok: true, status: 200, json: async () => body, text: async () => JSON.stringify(body) } as Response;
|
|
}),
|
|
);
|
|
localStorage.setItem("ihasmail:cached-thing", "from the account in front");
|
|
useSession.setState({ status: "authenticated", signedIn: [], canAddAccount: false });
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
localStorage.clear();
|
|
});
|
|
|
|
describe("account switcher", () => {
|
|
it("lists the accounts and whether one more may be added", async () => {
|
|
answers["/api/auth/accounts"] = {
|
|
accounts: [
|
|
{ id: "a", username: "[email protected]", front: true },
|
|
{ id: "b", username: "[email protected]", front: false },
|
|
],
|
|
canAdd: true,
|
|
};
|
|
await useSession.getState().loadSignedIn();
|
|
expect(useSession.getState().signedIn.map((a) => a.username)).toEqual(["[email protected]", "[email protected]"]);
|
|
expect(useSession.getState().canAddAccount).toBe(true);
|
|
});
|
|
|
|
it("switching asks the server, forgets the cache and reloads", async () => {
|
|
await useSession.getState().switchTo("b");
|
|
expect(calls.some((c) => c.url.endsWith("/api/auth/accounts/b/front") && c.method === "POST")).toBe(true);
|
|
expect(localStorage.getItem("ihasmail:cached-thing")).toBeNull();
|
|
expect(reload).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("signing out of one reloads into the next when there is one", async () => {
|
|
answers["/api/auth/logout"] = { ok: true, next: true };
|
|
await useSession.getState().logout();
|
|
expect(reload).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("signing out of the last one, or of all, ends at the sign-in page", async () => {
|
|
answers["/api/auth/logout-all"] = { ok: true };
|
|
await useSession.getState().logoutAll();
|
|
expect(calls.some((c) => c.url.endsWith("/api/auth/logout-all"))).toBe(true);
|
|
expect(reload).not.toHaveBeenCalled();
|
|
expect(useSession.getState().status).toBe("anonymous");
|
|
// The next ordinary sign-out goes back to signing out of one
|
|
useSession.setState({ status: "authenticated" });
|
|
answers["/api/auth/logout"] = { ok: true };
|
|
await useSession.getState().logout();
|
|
expect(calls.filter((c) => c.url.endsWith("/api/auth/logout")).length).toBe(1);
|
|
});
|
|
});
|