Passkeys: say why the section can't list them, instead of vanishing #120

Merged
jcoffey-dev merged 1 commits from fix/119-passkeys-section-reason into main 2026-11-19 17:15:56 +00:00
Owner

Fixes #119 (forum t/339; the server-side cause is inbuxa-server#478, fixed in inbuxa-server#483).

listPasskeys() returned null on any error, and the Passkeys section then hid itself. So an account the server wouldn't allow passkeys saw "Loading…" and then nothing. It now returns a PasskeyListing and the section shows each case:

Listing Section
none: unknownMethod / unknownCapability (server without passkeys) hidden, as before
forbidden "Passkeys aren't available for this account. Ask your mail administrator if you need them." No add form.
failed: anything else "Couldn't load your passkeys." with the reason, and Retry
list unchanged

When the session says adding isn't allowed (passkeysAllowed: false), the add form is already replaced by a note (PK-19, already on main), so the "Add shown, blank window flashes" point in the issue is covered.

Translation: the two new strings are in all ten catalogs, written by AI like the rest of each catalog and not reviewed by native speakers. Each uses the term its catalog already uses for "passkey".

Checked locally: npm ci, typecheck, npm test (191 files, 1614 tests, including the new passkeys-section.test.tsx and three new listing cases), scripts/release-version.test.sh, npm run build. It wasn't clicked through against a live server: the component test covers each state.

Fixes #119 (forum t/339; the server-side cause is inbuxa-server#478, fixed in inbuxa-server#483). `listPasskeys()` returned `null` on any error, and the Passkeys section then hid itself. So an account the server wouldn't allow passkeys saw "Loading…" and then nothing. It now returns a `PasskeyListing` and the section shows each case: | Listing | Section | |---|---| | `none`: `unknownMethod` / `unknownCapability` (server without passkeys) | hidden, as before | | `forbidden` | "Passkeys aren't available for this account. Ask your mail administrator if you need them." No add form. | | `failed`: anything else | "Couldn't load your passkeys." with the reason, and **Retry** | | `list` | unchanged | When the session says adding isn't allowed (`passkeysAllowed: false`), the add form is already replaced by a note (PK-19, already on main), so the "Add shown, blank window flashes" point in the issue is covered. **Translation:** the two new strings are in all ten catalogs, written by AI like the rest of each catalog and not reviewed by native speakers. Each uses the term its catalog already uses for "passkey". **Checked locally:** `npm ci`, typecheck, `npm test` (191 files, 1614 tests, including the new `passkeys-section.test.tsx` and three new listing cases), `scripts/release-version.test.sh`, `npm run build`. It wasn't clicked through against a live server: the component test covers each state.
jcoffey-dev added this to the 27.1 milestone 2026-11-19 17:12:53 +00:00
jcoffey-dev added the bug
priority
p2
labels 2026-11-19 17:12:53 +00:00
jcoffey-dev self-assigned this 2026-11-19 17:12:53 +00:00
jcoffey-dev added 1 commit 2026-11-19 17:12:53 +00:00
Passkeys: say why the section can't list them, instead of vanishing
ci / node (pull_request) Skipped
ci / version (pull_request) Skipped
ci / publish (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 1m44s
ci / docker-build (pull_request) Skipped
ci / announce (pull_request) Skipped
019d2d370c
listPasskeys returned null on any error, and the section then hid itself,
so an account the server wouldn't allow passkeys (forum t/339, server
#478) saw "Loading…" and then nothing. It now tells the cases apart:

- no passkeys on the server (unknownMethod / unknownCapability): hidden,
  as before;
- forbidden: a note that passkeys aren't available for this account and
  to ask the mail administrator, with no add form;
- anything else: "Couldn't load your passkeys." with the reason and a
  Retry button.

The two new strings are added to all ten catalogs (AI-written, like the
rest of each catalog). Tests: the listing's three outcomes, and a
component test for each state of the section.

Fixes #119
jcoffey-dev merged commit b860596b20 into main 2026-11-19 17:15:56 +00:00
jcoffey-dev deleted branch fix/119-passkeys-section-reason 2026-11-19 17:15:57 +00:00
Sign in to join this conversation.