Notifications with the app closed, for every signed-in account
ci / node (pull_request) Skipped
ci / version (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 3m3s
ci / docker-build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / announce (pull_request) Skipped
ci / node (pull_request) Skipped
ci / version (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 3m3s
ci / docker-build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / announce (pull_request) Skipped
Second of three for background push across accounts (multi-account spec, MA-8 part 2). Turning on "Notify me even when inbuxa is closed" now registers this browser in every signed-in account, each through its own session (the route from the previous change), and renewal keeps them all current. GET /api/auth/accounts says which mail account each session is, so the subscription can name it. The remembered endpoint is kept per account, and survives the clean-up that follows switching accounts. The service worker is told who the other accounts are. A push for one of them is titled with that account's address, shown even while a tab is focused (the tab only shows the front account's mail), and its Mark read and Archive act through that account's session. Clicking it brings that account to the front and opens the message. While push is on, the tab's own polling of other accounts stops notifying, so nothing arrives twice. Signing out of one account removes this device's subscription there only; signing out of all, or turning push off, removes every one. Also fixes where every background notification opened: the worker linked to /mail/inbox/<thread>, and the route takes a mailbox id there, so a click landed on the inbox list with "That folder no longer exists". The worker now gets each account's inbox id and links to the message. Checked end to end in Chrome against a local server with two accounts: both registered and verified, a message to the account not in front showed a notification under its address, and clicking it switched accounts and opened the message. No new strings. typecheck, tests (web 1547, server 279) and build pass.
This commit is contained in:
1 parent
6b979c5ac7
commit
9fcf4812f3
13 files changed
+394
-39
No files matched your search
@@ -190,3 +190,11 @@ test("inbuxa MA-8: only push, mailboxes and marking mail reach an account not in
|
||||
const front = (await b.accounts()).find((a) => a.front)!;
|
||||
assert.equal((await b.call(`/api/auth/accounts/${front.id}/jmap`, { method: "POST", body: { methodCalls: [] } })).status, 404);
|
||||
});
|
||||
|
||||
test("inbuxa MA-8: each listed account says which mail account it is", async () => {
|
||||
const b = new Browser();
|
||||
await b.signIn("[email protected]", "first-password");
|
||||
await b.signIn("[email protected]", "second-password", true);
|
||||
const res = await b.call("/api/auth/accounts");
|
||||
for (const a of res.body.accounts) assert.equal(typeof a.mailAccountId, "string", JSON.stringify(a));
|
||||
});
|
||||
+15
-5
@@ -802,11 +802,21 @@ export function createApp(basePath = config.basePath): Hono<Env> {
|
||||
setOthersCookie(c, others.map((o) => o.cookie));
|
||||
}
|
||||
const canAdd = (await addRefusal(c, front)) === null;
|
||||
return c.json({
|
||||
accounts: [front, ...others.map((o) => o.session)].map((s, i) => ({ id: s.id, username: s.username, front: i === 0 })),
|
||||
canAdd,
|
||||
max: MAX_ACCOUNTS,
|
||||
});
|
||||
// inbuxa MA-8: each one's mail account, which its push subscription and
|
||||
// a notification's buttons need
|
||||
const accounts = await Promise.all(
|
||||
[front, ...others.map((o) => o.session)].map(async (s, i) => {
|
||||
let mailAccountId: string | null = null;
|
||||
try {
|
||||
const upstream = await getUpstreamSession(s.id, s.authorization, upstreamFor(s.username));
|
||||
mailAccountId = upstream.primaryAccounts?.["urn:ietf:params:jmap:mail"] ?? null;
|
||||
} catch {
|
||||
/* unknown for now: push for it waits for the next start */
|
||||
}
|
||||
return { id: s.id, username: s.username, front: i === 0, mailAccountId };
|
||||
}),
|
||||
);
|
||||
return c.json({ accounts, canAdd, max: MAX_ACCOUNTS });
|
||||
});
|
||||
|
||||
/*
|
||||
|
||||
Reference in new issue
Block a user