Files
inbuxa-server/crates/common/src/manager/application.rs
T
jcoffey-dev cc6f1eb298
ci / fork-checks (pull_request) Successful in 16s
ci / build (pull_request) Successful in 7m53s
Rename the identifiers that carried the upstream name
Everything clients, users and operators meet now carries the fork's name,
with no aliases (SPEC.md §2.4, changed here from "protocol identifiers
stay"):

- JMAP: upstream's registry capability is urn:inbuxa:jmap:registry, beside
  the fork's own urn:inbuxa:jmap.
- WebDAV lock and sync tokens are urn:inbuxa:dav*; clients resync once.
- Sieve: vnd.inbuxa.while and vnd.inbuxa.expressions. sieve-rs spells these
  into its compiler, so it's vendored (vendor/sieve-rs, 0.7.3) and patched in;
  a unit test fails if Cargo.lock ever moves past the vendored copy. The
  trusted runtime now names itself too, rather than answering sieve-rs's
  default.
- The web interface's OAuth client is inbuxa-webui. On every start the old
  stalwart-webui client is removed and any application naming it is moved
  over.
- The spam filter's blobs are INBUXA_SPAM_*; every start moves any left
  under the old keys, so a trained model survives.
- SQL stores and log files default to inbuxa, in the code and in the
  schema served to the admin (checksum regenerated).
- Settings are INBUXA_* only. A STALWART_* variable that's set where its
  INBUXA_* one isn't stops the server at startup, naming it.
- The version-upgrade messages link docs.inbuxa.org's migration page, and
  the OpenAPI description, smtp crate metadata and web-push test fixtures
  lose the name.

Kept on purpose, allowlisted with reasons: the OAuth key-derivation
contexts (renaming them would end every session and invalidate every
sealed client id) and the hashed application prefix.

Also fixes a latent start-up failure: ensure_client updated an existing
first-party client with a revision of 0, which the registry's assertion
never matches, so adding a redirect URI or changing the webmail secret
failed start-up. And the principal session test now expects
legacyProtocols (C-1, added 2026-09-21), which it had missed.

Tested: the server builds without warnings; common's 106 unit tests,
including the vendoring check; a new integration test for the two
start-up migrations; and the webdav, jmap, imap and SMTP Sieve suites.
2026-09-22 19:33:02 -07:00

744 lines
24 KiB
Rust

/*
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
*
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
*
* Modified by Coffey Labs in 2026 for INBUXA.
*/
use crate::{Server, manager::fetch_resource};
use ahash::AHashMap;
use arc_swap::ArcSwap;
use registry::schema::{enums::CompressionAlgo, structs::Application};
use std::{
borrow::Cow,
io::{self, Cursor, Read},
path::{Path, PathBuf},
sync::{
Arc,
atomic::{AtomicU64, Ordering},
},
time::Duration,
};
use store::{
registry::{RegistryObject, bootstrap::Bootstrap},
write::{BatchBuilder, BlobLink, BlobOp, now},
};
use trc::{AddContext, Key};
use types::{blob_hash::BlobHash, id::Id};
const APP_BLOB_PREFIX: &str = "STALWART_APP_";
const MAX_APP_SIZE: usize = 100 * 1024 * 1024;
const BASE_HREF: &str = "<base href=\"/\"";
const OAUTH_CLIENT_ID: &str = "<meta name=\"oauth-client-id\" content=\"\"";
enum IndexEdit<'x> {
BaseHref(&'x str),
OAuthClientId(&'x str),
}
#[allow(clippy::type_complexity)]
pub struct WebApplications {
applications: ArcSwap<Vec<WebApplicationManager>>,
routes: ArcSwap<AHashMap<String, Arc<AppRoutes>>>,
generation: AtomicU64,
}
pub struct AppRoutes {
resources: AHashMap<String, Resource<PathBuf>>,
oauth_client_id_meta: Option<String>,
_bundle_dir: TempDir,
}
#[derive(Clone)]
pub struct WebApplicationManager {
base_path: PathBuf,
prefixes: Vec<String>,
description: String,
url: String,
expiry: u64,
blob_key: BlobHash,
oauth_client_id: Option<String>,
}
#[derive(Default, Clone)]
pub struct Resource<T> {
pub content_type: Cow<'static, str>,
pub contents: T,
}
impl<T> Resource<T> {
pub fn new(content_type: impl Into<Cow<'static, str>>, contents: T) -> Self {
Self {
content_type: content_type.into(),
contents,
}
}
}
pub struct AppResource {
pub resource: Resource<Vec<u8>>,
pub no_cache: bool,
}
impl WebApplications {
pub fn new() -> Self {
Self {
applications: ArcSwap::new(Arc::new(Vec::new())),
routes: ArcSwap::new(Arc::new(AHashMap::new())),
generation: AtomicU64::new(0),
}
}
pub async fn serve(&self, prefix: &str, path: &str) -> trc::Result<Option<AppResource>> {
if let Some(routes) = self.routes.load().get(prefix)
&& let Some((is_index, resource)) = routes
.resources
.get(path)
.map(|res| (path == "index.html", res))
.or_else(|| routes.resources.get("index.html").map(|res| (true, res)))
{
tokio::fs::read(&resource.contents)
.await
.map(|mut contents| {
if is_index && let Ok(html) = std::str::from_utf8(&contents) {
contents =
rewrite_index(html, prefix, routes.oauth_client_id_meta.as_deref());
}
Some(AppResource {
resource: Resource {
content_type: resource.content_type.clone(),
contents,
},
no_cache: is_index,
})
})
.map_err(|err| {
trc::ResourceEvent::Error
.reason(err)
.ctx(trc::Key::Path, path.to_string())
.caused_by(trc::location!())
})
} else {
Ok(None)
}
}
pub async fn reload(&self, bp: &mut Bootstrap) {
let mut apps = Vec::new();
for app in bp.list_infallible::<Application>().await {
if app.object.enabled {
apps.push(WebApplicationManager::new(app));
}
}
self.applications.store(Arc::new(apps));
}
pub async fn unpack_all(&self, server: &Server, update: bool) {
let previous = self.routes.load_full();
let sweep_orphans = previous.is_empty();
let mut routes = AHashMap::with_capacity(previous.len());
for app in self.applications.load().as_ref() {
match app
.unpack(server, self.next_generation(), update, sweep_orphans)
.await
{
Ok(app_routes) => {
let app_routes = Arc::new(app_routes);
for prefix in &app.prefixes {
routes.insert(prefix.clone(), app_routes.clone());
}
}
Err(err) => {
let mut is_retained = false;
for prefix in &app.prefixes {
if let Some(app_routes) = previous.get(prefix) {
routes.insert(prefix.clone(), app_routes.clone());
is_retained = true;
}
}
trc::event!(
Resource(trc::ResourceEvent::Error),
Reason = err,
Url = app.url.clone(),
Details = format!(
"Failed to unpack application for prefixes: {}, {}",
app.prefixes.join(", "),
if is_retained {
"the previously unpacked bundle remains in service"
} else {
"no bundle is available to serve"
}
)
);
}
}
}
self.routes.store(Arc::new(routes));
}
fn next_generation(&self) -> u64 {
self.generation.fetch_add(1, Ordering::Relaxed)
}
}
impl WebApplicationManager {
pub fn new(app: RegistryObject<Application>) -> Self {
let base_path = app
.object
.unpack_directory
.map(PathBuf::from)
.unwrap_or_else(std::env::temp_dir)
.join(app.id.id().to_string());
Self {
base_path,
blob_key: BlobHash::generate(format!("{}{}", APP_BLOB_PREFIX, app.id.id()).as_bytes()),
url: app.object.resource_url,
description: app.object.description,
expiry: app.object.auto_update_frequency.as_secs(),
oauth_client_id: app.object.oauth_client_id,
prefixes: app
.object
.url_prefix
.iter()
.map(|prefix| {
prefix
.trim_end_matches('/')
.trim_start_matches('/')
.to_string()
})
.collect(),
}
}
async fn unpack(
&self,
server: &Server,
generation: u64,
force_refresh: bool,
sweep_orphans: bool,
) -> trc::Result<AppRoutes> {
let cached = if force_refresh {
None
} else {
server
.blob_store()
.get_blob(self.blob_key.as_slice(), 0..usize::MAX)
.await?
};
let is_cached = cached.is_some();
let bundle = match cached {
Some(bundle) => bundle,
None => self.fetch().await?,
};
let staging = TempDir::new(self.base_path.join(format!("{:x}-{generation:x}", now())));
staging.create().await.map_err(unpack_error)?;
let url = self.url.clone();
let bundle_path = staging.path.clone();
let (resources, bundle) = tokio::task::spawn_blocking(move || -> trc::Result<_> {
let mut archive = zip::ZipArchive::new(Cursor::new(bundle)).map_err(|err| {
trc::ResourceEvent::Error
.caused_by(trc::location!())
.reason(err)
.ctx(Key::Url, url.clone())
.details("Failed to decompress application bundle")
})?;
let mut resources = AHashMap::with_capacity(archive.len());
for i in 0..archive.len() {
let mut file = archive.by_index(i).map_err(|err| {
trc::ResourceEvent::Error
.caused_by(trc::location!())
.reason(err)
.details("Failed to read file from application bundle")
})?;
if file.is_dir() {
continue;
}
let mut contents = Vec::new();
file.read_to_end(&mut contents).map_err(unpack_error)?;
let file_name = file.name().to_string();
drop(file);
let path = bundle_path.join(format!("{i:02}"));
std::fs::write(&path, contents).map_err(unpack_error)?;
let resource = Resource {
content_type: match file_name
.rsplit_once('.')
.map(|(_, ext)| ext)
.unwrap_or_default()
{
"html" => "text/html",
"css" => "text/css",
"wasm" => "application/wasm",
"js" => "application/javascript",
"json" => "application/json",
"png" => "image/png",
"svg" => "image/svg+xml",
"ico" => "image/x-icon",
_ => "application/octet-stream",
}
.into(),
contents: path,
};
resources.insert(file_name, resource);
}
Ok((resources, archive.into_inner().into_inner()))
})
.await
.map_err(|err| {
trc::ResourceEvent::Error
.caused_by(trc::location!())
.reason(err)
.details("Bundle unpack task panicked")
})??;
if !is_cached && let Err(err) = self.cache(server, &bundle).await {
trc::event!(
Resource(trc::ResourceEvent::Error),
Reason = err,
Url = self.url.clone(),
Details = "Failed to cache application bundle, it will be downloaded again"
);
}
if sweep_orphans {
remove_siblings(&self.base_path, &staging.path).await;
}
trc::event!(
Resource(trc::ResourceEvent::ApplicationUnpacked),
Url = self.url.clone(),
Path = staging.path.to_string_lossy().into_owned(),
);
Ok(AppRoutes {
resources,
oauth_client_id_meta: self.oauth_client_id.as_deref().map(oauth_client_id_meta),
_bundle_dir: staging,
})
}
async fn fetch(&self) -> trc::Result<Vec<u8>> {
fetch_resource(&self.url, None, Duration::from_secs(60), MAX_APP_SIZE)
.await
.map_err(|err| {
trc::ResourceEvent::Error
.caused_by(trc::location!())
.ctx(Key::Url, self.url.clone())
.reason(err)
.details("Failed to fetch application bundle")
})
}
async fn cache(&self, server: &Server, bundle: &[u8]) -> trc::Result<()> {
server
.blob_store()
.put_blob(self.blob_key.as_slice(), bundle, CompressionAlgo::None)
.await
.caused_by(trc::location!())?;
let mut batch = BatchBuilder::new();
batch
.set(
BlobOp::Link {
hash: self.blob_key.clone(),
to: BlobLink::Temporary {
until: now() + self.expiry,
},
},
vec![],
)
.set(
BlobOp::Commit {
hash: self.blob_key.clone(),
},
Vec::new(),
);
server
.store()
.write(batch.build_all())
.await
.caused_by(trc::location!())?;
trc::event!(
Resource(trc::ResourceEvent::ApplicationUpdated),
Url = self.url.clone(),
Details = self.description.clone(),
);
Ok(())
}
pub async fn delete_bundle(server: &Server, app_id: Id) -> trc::Result<()> {
let blob_key = BlobHash::generate(format!("{APP_BLOB_PREFIX}{app_id}").as_bytes());
server
.blob_store()
.delete_blob(blob_key.as_slice())
.await
.map(|_| ())
}
}
impl Resource<Vec<u8>> {
pub fn is_empty(&self) -> bool {
self.content_type.is_empty() && self.contents.is_empty()
}
}
pub struct TempDir {
pub path: PathBuf,
}
impl TempDir {
pub fn new(path: PathBuf) -> TempDir {
TempDir { path }
}
pub async fn create(&self) -> io::Result<()> {
if tokio::fs::metadata(&self.path).await.is_ok() {
let _ = tokio::fs::remove_dir_all(&self.path).await;
}
tokio::fs::create_dir_all(&self.path).await
}
}
impl Drop for TempDir {
fn drop(&mut self) {
let _ = std::fs::remove_dir_all(&self.path);
}
}
async fn remove_siblings(base_path: &Path, keep: &Path) {
let Ok(mut entries) = tokio::fs::read_dir(base_path).await else {
return;
};
while let Ok(Some(entry)) = entries.next_entry().await {
let path = entry.path();
if path == keep {
continue;
}
if matches!(entry.file_type().await, Ok(file_type) if file_type.is_dir()) {
let _ = tokio::fs::remove_dir_all(&path).await;
} else {
let _ = tokio::fs::remove_file(&path).await;
}
}
}
fn unpack_error(err: std::io::Error) -> trc::Error {
trc::ResourceEvent::Error
.reason(err)
.details("Failed to unpack application bundle")
}
impl Default for WebApplications {
fn default() -> Self {
Self::new()
}
}
fn rewrite_index(html: &str, prefix: &str, oauth_client_id_meta: Option<&str>) -> Vec<u8> {
let mut edits = [
html.find(BASE_HREF)
.map(|at| (at, BASE_HREF.len(), IndexEdit::BaseHref(prefix))),
oauth_client_id_meta.and_then(|meta| {
html.find(OAUTH_CLIENT_ID)
.map(|at| (at, OAUTH_CLIENT_ID.len(), IndexEdit::OAuthClientId(meta)))
}),
];
if edits.iter().all(Option::is_none) {
return html.as_bytes().to_vec();
}
edits.sort_unstable_by_key(|edit| edit.as_ref().map_or(usize::MAX, |(at, _, _)| *at));
let mut out =
String::with_capacity(html.len() + prefix.len() + oauth_client_id_meta.map_or(0, str::len));
let mut pos = 0;
for (at, len, edit) in edits.into_iter().flatten() {
out.push_str(&html[pos..at]);
match edit {
IndexEdit::BaseHref(prefix) => {
out.push_str("<base href=\"/");
out.push_str(prefix);
out.push_str("/\"");
}
IndexEdit::OAuthClientId(meta) => out.push_str(meta),
}
pos = at + len;
}
out.push_str(&html[pos..]);
out.into_bytes()
}
fn oauth_client_id_meta(client_id: &str) -> String {
let mut meta = String::with_capacity(OAUTH_CLIENT_ID.len() + client_id.len());
meta.push_str("<meta name=\"oauth-client-id\" content=\"");
for ch in client_id.chars() {
match ch {
'&' => meta.push_str("&amp;"),
'"' => meta.push_str("&quot;"),
'<' => meta.push_str("&lt;"),
'>' => meta.push_str("&gt;"),
_ => meta.push(ch),
}
}
meta.push('"');
meta
}
#[cfg(test)]
mod tests {
use super::*;
const INDEX: &str = concat!(
"<!doctype html>\n<html lang=\"en\">\n\n<head>\n <meta charset=\"UTF-8\" />\n",
" <base href=\"/\" />\n <meta name=\"oauth-client-id\" content=\"\" />\n",
" <title>Portal</title>\n</head>\n\n<body></body>\n\n</html>\n"
);
#[test]
fn index_is_rewritten_with_the_prefix_and_client_id() {
let meta = oauth_client_id_meta("inbuxa-webui");
let html = String::from_utf8(rewrite_index(INDEX, "admin", Some(&meta))).unwrap();
assert!(html.contains("<base href=\"/admin/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"inbuxa-webui\" />"),
"{html}"
);
assert!(html.contains("<title>Portal</title>"), "{html}");
assert!(html.starts_with("<!doctype html>"), "{html}");
assert!(html.ends_with("</html>\n"), "{html}");
}
#[test]
fn index_keeps_the_empty_placeholder_when_no_client_id_is_configured() {
let html = String::from_utf8(rewrite_index(INDEX, "account", None)).unwrap();
assert!(html.contains("<base href=\"/account/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"\" />"),
"{html}"
);
}
#[test]
fn index_without_a_placeholder_is_left_alone() {
let bundle = "<head>\n <base href=\"/\" />\n</head>";
let meta = oauth_client_id_meta("inbuxa-webui");
let html = String::from_utf8(rewrite_index(bundle, "admin", Some(&meta))).unwrap();
assert_eq!(html, "<head>\n <base href=\"/admin/\" />\n</head>");
}
#[test]
fn edits_are_applied_in_document_order() {
let bundle = concat!(
"<head><meta name=\"oauth-client-id\" content=\"\" />",
"<base href=\"/\" /></head>"
);
let meta = oauth_client_id_meta("app");
let html = String::from_utf8(rewrite_index(bundle, "admin", Some(&meta))).unwrap();
assert_eq!(
html,
concat!(
"<head><meta name=\"oauth-client-id\" content=\"app\" />",
"<base href=\"/admin/\" /></head>"
)
);
}
#[test]
fn client_ids_are_escaped_for_the_attribute() {
let meta = oauth_client_id_meta("a\"b&c<d>");
assert_eq!(
meta,
"<meta name=\"oauth-client-id\" content=\"a&quot;b&amp;c&lt;d&gt;\""
);
}
async fn fixture(name: &str, client_id: Option<&str>) -> WebApplications {
let dir = TempDir::new(std::env::temp_dir().join(format!("inbuxa-app-{name}")));
dir.create().await.unwrap();
tokio::fs::write(dir.path.join("index.html"), INDEX)
.await
.unwrap();
tokio::fs::write(dir.path.join("app.js"), "export const x = 1;\n")
.await
.unwrap();
let mut resources = AHashMap::new();
resources.insert(
"index.html".to_string(),
Resource::new("text/html", dir.path.join("index.html")),
);
resources.insert(
"app.js".to_string(),
Resource::new("text/javascript", dir.path.join("app.js")),
);
let routes = Arc::new(AppRoutes {
resources,
oauth_client_id_meta: client_id.map(oauth_client_id_meta),
_bundle_dir: dir,
});
let mut map = AHashMap::new();
map.insert("admin".to_string(), routes.clone());
map.insert("account".to_string(), routes);
let apps = WebApplications::new();
apps.routes.store(Arc::new(map));
apps
}
async fn serve_html(apps: &WebApplications, prefix: &str, path: &str) -> String {
let served = apps.serve(prefix, path).await.unwrap().unwrap();
assert!(served.no_cache, "index responses must not be cached");
assert_eq!(served.resource.content_type.as_ref(), "text/html");
String::from_utf8(served.resource.contents).unwrap()
}
#[tokio::test]
async fn serving_index_injects_the_prefix_and_client_id() {
let apps = fixture("serve-configured", Some("pocket-id-client")).await;
let html = serve_html(&apps, "admin", "index.html").await;
assert!(html.contains("<base href=\"/admin/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"pocket-id-client\" />"),
"{html}"
);
let html = serve_html(&apps, "account", "index.html").await;
assert!(html.contains("<base href=\"/account/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"pocket-id-client\" />"),
"{html}"
);
}
#[tokio::test]
async fn unknown_paths_fall_back_to_a_rewritten_index() {
let apps = fixture("serve-fallback", Some("pocket-id-client")).await;
let html = serve_html(&apps, "admin", "settings/directory").await;
assert!(html.contains("<base href=\"/admin/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"pocket-id-client\" />"),
"{html}"
);
}
#[tokio::test]
async fn assets_and_unknown_prefixes_are_untouched() {
let apps = fixture("serve-assets", Some("pocket-id-client")).await;
let served = apps.serve("admin", "app.js").await.unwrap().unwrap();
assert_eq!(served.resource.contents, b"export const x = 1;\n");
assert_eq!(served.resource.content_type.as_ref(), "text/javascript");
assert!(!served.no_cache);
assert!(apps.serve("unknown", "index.html").await.unwrap().is_none());
}
#[tokio::test]
async fn serving_index_without_a_client_id_keeps_the_placeholder() {
let apps = fixture("serve-unconfigured", None).await;
let html = serve_html(&apps, "admin", "index.html").await;
assert!(html.contains("<base href=\"/admin/\" />"), "{html}");
assert!(
html.contains("<meta name=\"oauth-client-id\" content=\"\" />"),
"{html}"
);
}
#[test]
fn an_unmodified_document_is_returned_verbatim() {
let bundle = "<head><title>x</title></head>";
assert_eq!(rewrite_index(bundle, "admin", None), bundle.as_bytes());
}
#[tokio::test]
async fn missing_parent_directories_are_created() {
let base = std::env::temp_dir().join("inbuxa-app-nested");
let _ = tokio::fs::remove_dir_all(&base).await;
let dir = TempDir::new(base.join("webui").join("0"));
dir.create().await.unwrap();
assert!(tokio::fs::metadata(&dir.path).await.is_ok());
drop(dir);
let _ = tokio::fs::remove_dir_all(&base).await;
}
#[tokio::test]
async fn dropping_the_routes_removes_the_bundle_directory() {
let apps = fixture("drop-guard", None).await;
let path = apps
.routes
.load()
.get("admin")
.unwrap()
._bundle_dir
.path
.clone();
assert!(tokio::fs::metadata(&path).await.is_ok());
apps.routes.store(Arc::new(AHashMap::new()));
assert!(tokio::fs::metadata(&path).await.is_err());
}
#[tokio::test]
async fn sweeping_orphans_spares_the_current_generation() {
let base = std::env::temp_dir().join("inbuxa-app-sweep");
let _ = tokio::fs::remove_dir_all(&base).await;
let current = TempDir::new(base.join("1"));
current.create().await.unwrap();
let orphan = base.join("0");
tokio::fs::create_dir_all(&orphan).await.unwrap();
let stray = base.join("webui.zip");
tokio::fs::write(&stray, b"not a bundle").await.unwrap();
remove_siblings(&base, &current.path).await;
assert!(tokio::fs::metadata(&current.path).await.is_ok());
assert!(tokio::fs::metadata(&orphan).await.is_err());
assert!(tokio::fs::metadata(&stray).await.is_err());
drop(current);
let _ = tokio::fs::remove_dir_all(&base).await;
}
#[test]
fn generations_never_repeat() {
let apps = WebApplications::new();
assert_ne!(apps.next_generation(), apps.next_generation());
}
}