Upstream commit: 474dd0229cb20cf513036619781ed97bd8073c3f Enterprise-only files removed or emptied: 63 Enterprise-only snippets removed: 117 in 50 files Dangling module declarations removed: 5 Cargo edits turning enterprise off: 14 Verification: clean Enterprise feature gates left for rebuilt features: 19 in 18 files Produced by tools/fork/strip.py. The full report is in docs/fork/strip-reports/ on main.
403 lines
14 KiB
Rust
403 lines
14 KiB
Rust
/*
|
|
* SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
|
|
*
|
|
* SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
|
|
*/
|
|
|
|
use crate::task_manager::{TaskFailureType, TaskResult};
|
|
use common::{
|
|
Server,
|
|
ipc::{BroadcastEvent, RegistryChange},
|
|
manager::{SPAM_CLASSIFIER_KEY, SPAM_TRAINER_KEY, fetch_resource},
|
|
};
|
|
use registry::{
|
|
schema::{
|
|
enums::TaskSpamFilterMaintenanceType,
|
|
prelude::ObjectType,
|
|
structs::{
|
|
HttpLookup, MemoryLookupKey, SpamDnsblServer, SpamFileExtension, SpamRule, SpamTag,
|
|
TaskSpamFilterMaintenance,
|
|
},
|
|
},
|
|
types::EnumImpl,
|
|
};
|
|
use spam_filter::modules::classifier::SpamClassifier;
|
|
use std::time::{Duration, Instant};
|
|
use store::{
|
|
ahash::AHashMap,
|
|
registry::write::{RegistryWrite, RegistryWriteResult},
|
|
};
|
|
use trc::{SpamEvent, Value};
|
|
|
|
pub(crate) trait SpamFilterMaintenanceTask: Sync + Send {
|
|
fn spam_filter_maintenance(
|
|
&self,
|
|
task: &TaskSpamFilterMaintenance,
|
|
) -> impl Future<Output = TaskResult> + Send;
|
|
}
|
|
|
|
impl SpamFilterMaintenanceTask for Server {
|
|
async fn spam_filter_maintenance(&self, task: &TaskSpamFilterMaintenance) -> TaskResult {
|
|
match spam_filter_maintenance(self, task).await {
|
|
Ok(result) => result,
|
|
Err(err) => {
|
|
let result = TaskResult::temporary(err.to_string());
|
|
trc::error!(err.details("Failed to perform spam filter maintenance task"));
|
|
result
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
async fn spam_filter_maintenance(
|
|
server: &Server,
|
|
task: &TaskSpamFilterMaintenance,
|
|
) -> trc::Result<TaskResult> {
|
|
match task.maintenance_type {
|
|
TaskSpamFilterMaintenanceType::Train => {
|
|
if !server.inner.ipc.train_task_controller.is_running() {
|
|
Box::pin(server.spam_train(false)).await?;
|
|
}
|
|
}
|
|
TaskSpamFilterMaintenanceType::Retrain => {
|
|
if !server.inner.ipc.train_task_controller.is_running() {
|
|
Box::pin(server.spam_train(true)).await?;
|
|
}
|
|
}
|
|
TaskSpamFilterMaintenanceType::Reset => {
|
|
for key in [SPAM_CLASSIFIER_KEY, SPAM_TRAINER_KEY] {
|
|
server.blob_store().delete_blob(key).await?;
|
|
}
|
|
}
|
|
TaskSpamFilterMaintenanceType::Abort => {
|
|
if server.inner.ipc.train_task_controller.is_running() {
|
|
server.inner.ipc.train_task_controller.stop();
|
|
}
|
|
}
|
|
TaskSpamFilterMaintenanceType::UpdateRules => {
|
|
return update_spam_rules(server).await;
|
|
}
|
|
}
|
|
|
|
Ok(TaskResult::Success(vec![]))
|
|
}
|
|
|
|
struct RuleUpdateError {
|
|
typ: TaskFailureType,
|
|
reason: String,
|
|
}
|
|
|
|
#[derive(Default)]
|
|
struct Rules {
|
|
rules: Vec<SpamRule>,
|
|
dnsbls: Vec<SpamDnsblServer>,
|
|
tags: Vec<SpamTag>,
|
|
http_lookups: Vec<HttpLookup>,
|
|
key_lookups: Vec<MemoryLookupKey>,
|
|
file_exts: Vec<SpamFileExtension>,
|
|
}
|
|
|
|
#[derive(Default)]
|
|
struct RuleUpdateResult {
|
|
success: usize,
|
|
already_exists: usize,
|
|
failed: usize,
|
|
}
|
|
|
|
async fn update_spam_rules(server: &Server) -> trc::Result<TaskResult> {
|
|
let started = Instant::now();
|
|
let rules = match fetch_spam_rules(server).await {
|
|
Ok(rules) => rules,
|
|
Err(err) => {
|
|
return Ok(TaskResult::Failure {
|
|
typ: err.typ,
|
|
message: err.reason,
|
|
max_attempts: None,
|
|
});
|
|
}
|
|
};
|
|
|
|
let registry = server.registry();
|
|
let mut stats: AHashMap<ObjectType, RuleUpdateResult> = AHashMap::new();
|
|
|
|
let mut reload_settings = false;
|
|
let mut reload_lookups = false;
|
|
|
|
for rule in rules.rules {
|
|
match registry.write(RegistryWrite::insert(&rule.into())).await? {
|
|
RegistryWriteResult::Success(_) => {
|
|
stats.entry(ObjectType::SpamRule).or_default().success += 1;
|
|
reload_settings = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats
|
|
.entry(ObjectType::SpamRule)
|
|
.or_default()
|
|
.already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats.entry(ObjectType::SpamRule).or_default().failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for dnsbl in rules.dnsbls {
|
|
match registry.write(RegistryWrite::insert(&dnsbl.into())).await? {
|
|
RegistryWriteResult::Success(_) => {
|
|
stats
|
|
.entry(ObjectType::SpamDnsblServer)
|
|
.or_default()
|
|
.success += 1;
|
|
reload_settings = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats
|
|
.entry(ObjectType::SpamDnsblServer)
|
|
.or_default()
|
|
.already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats.entry(ObjectType::SpamDnsblServer).or_default().failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for tag in rules.tags {
|
|
match registry.write(RegistryWrite::insert(&tag.into())).await? {
|
|
RegistryWriteResult::Success(_) => {
|
|
stats.entry(ObjectType::SpamTag).or_default().success += 1;
|
|
reload_settings = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats.entry(ObjectType::SpamTag).or_default().already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats.entry(ObjectType::SpamTag).or_default().failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for lookup in rules.http_lookups {
|
|
match registry
|
|
.write(RegistryWrite::insert(&lookup.into()))
|
|
.await?
|
|
{
|
|
RegistryWriteResult::Success(_) => {
|
|
stats.entry(ObjectType::HttpLookup).or_default().success += 1;
|
|
reload_lookups = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats
|
|
.entry(ObjectType::HttpLookup)
|
|
.or_default()
|
|
.already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats.entry(ObjectType::HttpLookup).or_default().failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for key_lookup in rules.key_lookups {
|
|
match registry
|
|
.write(RegistryWrite::insert(&key_lookup.into()))
|
|
.await?
|
|
{
|
|
RegistryWriteResult::Success(_) => {
|
|
stats
|
|
.entry(ObjectType::MemoryLookupKey)
|
|
.or_default()
|
|
.success += 1;
|
|
reload_lookups = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats
|
|
.entry(ObjectType::MemoryLookupKey)
|
|
.or_default()
|
|
.already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats.entry(ObjectType::MemoryLookupKey).or_default().failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
for ext in rules.file_exts {
|
|
match registry.write(RegistryWrite::insert(&ext.into())).await? {
|
|
RegistryWriteResult::Success(_) => {
|
|
stats
|
|
.entry(ObjectType::SpamFileExtension)
|
|
.or_default()
|
|
.success += 1;
|
|
reload_settings = true;
|
|
}
|
|
RegistryWriteResult::PrimaryKeyConflict { .. } => {
|
|
stats
|
|
.entry(ObjectType::SpamFileExtension)
|
|
.or_default()
|
|
.already_exists += 1;
|
|
}
|
|
_ => {
|
|
stats
|
|
.entry(ObjectType::SpamFileExtension)
|
|
.or_default()
|
|
.failed += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
if reload_settings {
|
|
if let Err(err) =
|
|
Box::pin(server.reload_registry(RegistryChange::Reload(ObjectType::SpamRule))).await
|
|
{
|
|
trc::error!(err.details("Failed to reload registry after updating spam rules"));
|
|
}
|
|
server
|
|
.cluster_broadcast(BroadcastEvent::RegistryChange(RegistryChange::Reload(
|
|
ObjectType::SpamRule,
|
|
)))
|
|
.await;
|
|
}
|
|
|
|
if reload_lookups {
|
|
if let Err(err) =
|
|
Box::pin(server.reload_registry(RegistryChange::Reload(ObjectType::MemoryLookupKey)))
|
|
.await
|
|
{
|
|
trc::error!(err.details("Failed to reload registry after updating spam rules"));
|
|
}
|
|
server
|
|
.cluster_broadcast(BroadcastEvent::RegistryChange(RegistryChange::Reload(
|
|
ObjectType::MemoryLookupKey,
|
|
)))
|
|
.await;
|
|
}
|
|
|
|
trc::event!(
|
|
Spam(SpamEvent::RulesUpdated),
|
|
Details = stats
|
|
.into_iter()
|
|
.map(|(object_type, result)| {
|
|
Value::Array(vec![
|
|
Value::String(object_type.as_str().into()),
|
|
Value::from(result.success),
|
|
Value::from(result.already_exists),
|
|
Value::from(result.failed),
|
|
])
|
|
})
|
|
.collect::<Vec<_>>(),
|
|
Elapsed = started.elapsed(),
|
|
);
|
|
|
|
Ok(TaskResult::Success(vec![]))
|
|
}
|
|
|
|
async fn fetch_spam_rules(server: &Server) -> Result<Rules, RuleUpdateError> {
|
|
let Some(rules_url) = server.core.spam.spam_rules_url.as_ref() else {
|
|
return Err(RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: "Spam rules resource URL not configured".to_string(),
|
|
});
|
|
};
|
|
let rules_json: AHashMap<String, Vec<serde_json::Value>> =
|
|
fetch_resource(rules_url, None, Duration::from_secs(60), 1024 * 500)
|
|
.await
|
|
.map_err(|reason| RuleUpdateError {
|
|
typ: TaskFailureType::Temporary,
|
|
reason,
|
|
})
|
|
.and_then(|bytes| {
|
|
serde_json::from_slice(&bytes).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse spam rules JSON: {err}"),
|
|
})
|
|
})?;
|
|
|
|
let mut rules = Rules::default();
|
|
for (object_type, values) in rules_json {
|
|
let Some(object_type) = ObjectType::parse(&object_type) else {
|
|
return Err(RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Invalid object type in spam rules JSON: {object_type}"),
|
|
});
|
|
};
|
|
|
|
match object_type {
|
|
ObjectType::SpamRule => {
|
|
rules.rules = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse spam rule: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<SpamRule>, RuleUpdateError>>()?;
|
|
}
|
|
ObjectType::SpamDnsblServer => {
|
|
rules.dnsbls = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse DNSBL server: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<SpamDnsblServer>, RuleUpdateError>>()?;
|
|
}
|
|
ObjectType::SpamTag => {
|
|
rules.tags = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse spam tag: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<SpamTag>, RuleUpdateError>>()?;
|
|
}
|
|
ObjectType::HttpLookup => {
|
|
rules.http_lookups = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse HTTP lookup: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<HttpLookup>, RuleUpdateError>>()?;
|
|
}
|
|
ObjectType::MemoryLookupKey => {
|
|
rules.key_lookups = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse memory lookup key: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<MemoryLookupKey>, RuleUpdateError>>()?;
|
|
}
|
|
ObjectType::SpamFileExtension => {
|
|
rules.file_exts = values
|
|
.into_iter()
|
|
.map(|value| {
|
|
serde_json::from_value(value).map_err(|err| RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Failed to parse spam file extension: {err}"),
|
|
})
|
|
})
|
|
.collect::<Result<Vec<SpamFileExtension>, RuleUpdateError>>()?;
|
|
}
|
|
_ => {
|
|
return Err(RuleUpdateError {
|
|
typ: TaskFailureType::Permanent,
|
|
reason: format!("Unsupported object type in spam rules: {object_type:?}"),
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
Ok(rules)
|
|
}
|