Security fixes for 2026.11.20.1: the WebDAV, ACME, DNS and OIDC fixes from #511, cherry-picked (-x). The passkey fix doesn't apply: 2026.x has no passkeys. Advisories are drafts and stay private for now.
WebDAV: file answers are sandboxed and sent with nosniff; only raster images, audio, video and plain text are shown inline. (advisory, high)
ACME and DNS: a tenant's providers reach only public (HTTPS) addresses; ACME errors carry only the problem type and detail. (advisory, medium)
OIDC directories: a tenant's reaches only public HTTPS addresses. (hardening)
Tests: fmt, build, unit tests, and the webdav, directory and system suites pass locally.
Security fixes for 2026.11.20.1: the WebDAV, ACME, DNS and OIDC fixes from #511, cherry-picked (`-x`). The passkey fix doesn't apply: 2026.x has no passkeys. Advisories are drafts and stay private for now.
- WebDAV: file answers are sandboxed and sent with `nosniff`; only raster images, audio, video and plain text are shown inline. (advisory, high)
- ACME and DNS: a tenant's providers reach only public (HTTPS) addresses; ACME errors carry only the problem type and detail. (advisory, medium)
- OIDC directories: a tenant's reaches only public HTTPS addresses. (hardening)
Tests: fmt, build, unit tests, and the webdav, directory and system suites pass locally.
A file stored over WebDAV was served with whatever content type its
uploader gave it, and with no Content-Disposition or sandbox policy. An
HTML or SVG file opened in a browser ran as a page of the mail server's
own origin, the one that serves the sign-in page and JMAP. Any account
that can store a file could leave one for someone else to open.
Every file answer (GET, HEAD, ranges, 416) now carries
"Content-Security-Policy: default-src 'none'; frame-ancestors 'none';
sandbox" and nosniff, so a document has an opaque origin and no
scripts. Only raster images, audio, video and plain text are offered for
display; HTML, XHTML, SVG, XML, PDF and anything unknown download as
attachments. WebDAV clients ignore both headers.
Test: in the WebDAV suite, user_content stores HTML, XHTML, SVG, PDF,
untyped, text and PNG files and checks both headers on GET, HEAD and a
range request. On main the HTML file came back as text/html with
neither header.
Reported privately in a security review.
(cherry picked from commit 05da91201917e17da4bb74c680a6c469d8fd52d3)
Tenant administrators can create ACME providers (sysAcmeProvider* is in
the default tenant role), and creating one fetches its directory URL
from the server, then follows the URLs the directory names. Nothing
limited where those requests went, plain HTTP was allowed, and a
non-2xx answer's body was returned in the JMAP error. A tenant
administrator could make the server request an internal address and
read part of the reply.
For a provider with a memberTenantId, every ACME request must be HTTPS
to a public address: IP literals are checked before sending, host names
when they resolve (the resolver Web Push uses), and redirects aren't
followed. The server's own providers are unchanged, so an internal ACME
server still works there. For every provider, an error now carries only
an RFC 7807 problem document's type and detail (bounded), never the raw
body, and a parse error quotes at most 120 characters.
Test: unit tests in acme::http refuse plain HTTP, private, link-local,
loopback and mapped addresses, and a name resolving to loopback, before
anything is sent; the tenant suite checks the same through
x:AcmeProvider/set (with the DNS changes).
Reported privately in a security review.
(cherry picked from commit efec85345a0c18bf84cc88c694868d465490cd2d)
Tenant administrators can create DNS providers (sysDnsServer* is in the
default tenant role). Several take an endpoint (cPanel, Plesk, PowerDNS,
BlueCat, Infoblox, EdgeDNS, UltraDNS, Volcengine) and RFC 2136 takes a
server address, so DNS updates could be aimed at loopback or a private
service. Others build their URL from a region, zone id or domain, where
a value such as "[email protected]/" moves the host.
For a provider with a memberTenantId, checked each time it's saved and
each time an updater is built from it: endpoints must be HTTPS to names
that resolve only to public addresses, an RFC 2136 server must have a
public address, and names that go into URLs may only hold letters,
digits, '-', '_' and '.'. The server's own providers keep any
destination; private DNS servers are a normal setup there.
Test: unit tests in dns::tenant_endpoints; the tenant suite refuses
tenant ACME and DNS providers aimed at private addresses or with a
host-moving region, and still creates the server's own RFC 2136 provider
on a private address.
Reported privately in a security review.
(cherry picked from commit 0db0c686f50c03f030be61599537925bc018103d)
An OpenID Connect directory fetches discovery, JWKS, user info and
introspection from the server. A directory a tenant manages (only when a
server administrator delegates sysDirectory*, which tenants don't have
by default) could point those at internal addresses.
For a directory with a memberTenantId, the issuer, introspection,
jwks_uri and userinfo URLs must be HTTPS and not a private IP literal,
host names are checked when they resolve, and redirects aren't followed.
Server-owned directories are unchanged. Test builds let a tenant's
directory use loopback, as push and reports do, because the harness
runs Keycloak on localhost.
is_global_ip and the public-only resolver move from common to utils,
unchanged, so the directory crate (below common) can use them; common
re-exports both.
Test: oidc::config::tenant_url_tests.
Reported privately in a security review.
(cherry picked from commit d139b1198fd0f65a2496871c08d76cea86d0e989)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Security fixes for 2026.11.20.1: the WebDAV, ACME, DNS and OIDC fixes from #511, cherry-picked (
-x). The passkey fix doesn't apply: 2026.x has no passkeys. Advisories are drafts and stay private for now.nosniff; only raster images, audio, video and plain text are shown inline. (advisory, high)Tests: fmt, build, unit tests, and the webdav, directory and system suites pass locally.
6dc362c2ecto1188447511