The path-change part of system::tracer_reload sent a fixed 2000 events and moved the tracer 5 ms in. The stream finishes in a few tens of ms, so on a fast machine every event reached the old file before the reload ran, and the test failed on main.
The stream now runs until the new file has some of it, behind a stop flag, capped at 500,000 events so a reload that never lands fails instead of filling the disk.
The move starts only once the old file has some of the stream, so the switch always lands mid-stream.
Each event sent is checked to be in exactly one file, and both files must have part of the stream. The count comes from the stream, not a constant.
The JSON-format and removal parts are unchanged.
Locally (STORE=RocksDb): 6 of 6 runs in a row passed, each with about 3,800 events, ~3,750 in the old file and 50–100 in the new one. cargo fmt --all --check and the fork checks are clean. Test-only change.
Fixes #464.
The path-change part of `system::tracer_reload` sent a fixed 2000 events and moved the tracer 5 ms in. The stream finishes in a few tens of ms, so on a fast machine every event reached the old file before the reload ran, and the test failed on main.
- The stream now runs until the new file has some of it, behind a stop flag, capped at 500,000 events so a reload that never lands fails instead of filling the disk.
- The move starts only once the old file has some of the stream, so the switch always lands mid-stream.
- Each event sent is checked to be in exactly one file, and both files must have part of the stream. The count comes from the stream, not a constant.
- The JSON-format and removal parts are unchanged.
Locally (`STORE=RocksDb`): 6 of 6 runs in a row passed, each with about 3,800 events, ~3,750 in the old file and 50–100 in the new one. `cargo fmt --all --check` and the fork checks are clean. Test-only change.
The path-change part sent a fixed 2000 events and moved the tracer 5 ms
in. The stream finishes in a few tens of ms, so on a fast machine every
event reached the old file before the reload ran and the test failed.
The stream now runs until the new file has some of it (capped at
500,000), starts the move only once the old file has some, and checks
every event it sent is in exactly one of the two files.
Fixes#464
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #464.
The path-change part of
system::tracer_reloadsent a fixed 2000 events and moved the tracer 5 ms in. The stream finishes in a few tens of ms, so on a fast machine every event reached the old file before the reload ran, and the test failed on main.Locally (
STORE=RocksDb): 6 of 6 runs in a row passed, each with about 3,800 events, ~3,750 in the old file and 50–100 in the new one.cargo fmt --all --checkand the fork checks are clean. Test-only change.