Build with every store backend again: box --upgrade-store's future #449

Merged
jcoffey-dev merged 1 commits from fix/main-future-depth into main 2026-11-18 19:22:32 +00:00
Owner

Main doesn't compile with the release image's features since #448 (mine):

cargo build --release -p inbuxa --no-default-features --features "sqlite postgres mysql rocks s3 redis azure nats"
error: queries overflow the depth limit!
  = note: query depth increased by 130 when computing layout of `{async block@crates/main/src/main.rs:50:1: 50:15}`

--upgrade-store awaited the whole migration chain inline in main. Boxing that future keeps it out of main's layout. One line, plus a comment saying why.

Why CI was green: ci.yml builds -p inbuxa with the default features (rocks only), debug and release. Only the publish build (the Dockerfile) uses every backend, so the next release image would have failed. Found while building a lab image from main for the chart.

Tested

  • The release-features build above: finishes (17 m 36 s).
  • That binary: --upgrade-store on a new RocksDB store → The store layout is at version 3: nothing to upgrade., exit 0.
  • fmt ok.

Worth considering (not in this PR): a CI step that builds with the release features, so a break like this shows on the PR. A cargo check would be cheaper and catches feature-gated code, but I haven't confirmed it catches a layout error like this one. Either costs CI time on the shared runner, so it's your call.

Main doesn't compile with the release image's features since #448 (mine): ``` cargo build --release -p inbuxa --no-default-features --features "sqlite postgres mysql rocks s3 redis azure nats" error: queries overflow the depth limit! = note: query depth increased by 130 when computing layout of `{async block@crates/main/src/main.rs:50:1: 50:15}` ``` `--upgrade-store` awaited the whole migration chain inline in `main`. Boxing that future keeps it out of `main`'s layout. One line, plus a comment saying why. **Why CI was green:** `ci.yml` builds `-p inbuxa` with the default features (`rocks` only), debug and release. Only the publish build (the Dockerfile) uses every backend, so the next release image would have failed. Found while building a lab image from main for the chart. **Tested** - The release-features build above: finishes (17 m 36 s). - That binary: `--upgrade-store` on a new RocksDB store → `The store layout is at version 3: nothing to upgrade.`, exit 0. - fmt ok. **Worth considering (not in this PR):** a CI step that builds with the release features, so a break like this shows on the PR. A `cargo check` would be cheaper and catches feature-gated code, but I haven't confirmed it catches a layout error like this one. Either costs CI time on the shared runner, so it's your call.
jcoffey-dev added this to the 27.1 milestone 2026-11-18 18:00:11 +00:00
jcoffey-dev added 1 commit 2026-11-18 18:00:11 +00:00
Build with every store backend again: box --upgrade-store's future
ci / fork-checks (pull_request) Skipped
ci / build (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 13m7s
b618bf863d
With the release image's features (sqlite postgres mysql rocks s3 redis
azure nats), main stopped compiling after #448: "queries overflow the
depth limit" computing the layout of main's async block. The
--upgrade-store call awaited the whole migration chain inline in main.
Boxed, it no longer adds to main's layout.

CI builds the default features (rocks), so it passed; the next release
image build would have failed.
jcoffey-dev merged commit 7d594621b2 into main 2026-11-18 19:22:32 +00:00
jcoffey-dev deleted branch fix/main-future-depth 2026-11-18 19:22:32 +00:00
Sign in to join this conversation.