Sign SHA256SUMS on GitHub builds too #396

Merged
jcoffey-dev merged 1 commits from ci/github-minisign into main 2026-11-13 22:44:04 +00:00
Owner

27.1-rc.22 shipped without SHA256SUMS.minisig. #386 added signing to Gitea's publish.yml, but this repo builds releases on GitHub (BUILD_ON=github), and GitHub's ci.yml makes the binaries and SHA256SUMS, with no signing step.

  • .github/workflows/ci.yml, binaries job: signs out/SHA256SUMS with MINISIGN_SECRET_KEY (trusted comment inbuxa <tag>, as on Gitea and in inbuxa-migrate) and attaches SHA256SUMS.minisig. With no key it warns and the release stays unsigned. The release copy to GitHub already takes every asset, so it carries the signature over.
  • CHANGELOG: the 27.1-rc.22 entry no longer claims signed downloads.

Needs John: add MINISIGN_SECRET_KEY to the GitHub repo inbuxa/inbuxa-server (the same key as inbuxa-migrate's). The Gitea secret exists, but the GitHub one doesn't.

Checked locally: YAML parses, version.py --changelog, the four fork checks and the release tool tests.

27.1-rc.22 shipped without `SHA256SUMS.minisig`. #386 added signing to Gitea's `publish.yml`, but this repo builds releases on GitHub (`BUILD_ON=github`), and GitHub's `ci.yml` makes the binaries and `SHA256SUMS`, with no signing step. - `.github/workflows/ci.yml`, binaries job: signs `out/SHA256SUMS` with `MINISIGN_SECRET_KEY` (trusted comment `inbuxa <tag>`, as on Gitea and in inbuxa-migrate) and attaches `SHA256SUMS.minisig`. With no key it warns and the release stays unsigned. The release copy to GitHub already takes every asset, so it carries the signature over. - CHANGELOG: the 27.1-rc.22 entry no longer claims signed downloads. **Needs John:** add `MINISIGN_SECRET_KEY` to the GitHub repo `inbuxa/inbuxa-server` (the same key as inbuxa-migrate's). The Gitea secret exists, but the GitHub one doesn't. Checked locally: YAML parses, `version.py --changelog`, the four fork checks and the release tool tests.
jcoffey-dev added 1 commit 2026-11-13 22:35:35 +00:00
Sign SHA256SUMS on GitHub builds too
ci / fork-checks (pull_request) Skipped
ci / build (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 8m6s
35cc4d6ed9
#386 signed SHA256SUMS in Gitea's publish.yml, but with BUILD_ON=github
the release binaries and SHA256SUMS come from GitHub's ci.yml, so
27.1-rc.22 went out unsigned. The binaries job now signs SHA256SUMS
with the same MINISIGN_SECRET_KEY and attaches SHA256SUMS.minisig. With
no key it warns and the release stays unsigned, as on Gitea.

The 27.1-rc.22 CHANGELOG entry said its downloads came with the
signature; that line is gone.
jcoffey-dev merged commit e904a0832a into main 2026-11-13 22:44:04 +00:00
jcoffey-dev deleted branch ci/github-minisign 2026-11-13 22:44:04 +00:00
Sign in to join this conversation.