Automatic DNS: publish record types newly added to publishRecords #389

Merged
jcoffey-dev merged 1 commits from fix/dns-publish-records-trigger into main 2026-11-13 16:52:59 +00:00
Owner

Contributed by @StefanSa in #372 (attached patch, ported to main).

With DNS management already Automatic, adding a record type to publishRecords was saved but queued no DNS task, so the new records were never published. The workaround was switching the domain to Manual and back. An Automatic to Automatic save now queues one DNS task for the newly enabled record types. Removing a type deletes nothing, the same set in another order queues nothing, and new domains, Manual to Automatic and the DKIM paths behave as before.

Port note: Stefan's patch was made against release/2026. Main has since gained the #304 guard, so the port keeps it: a domain with nothing to publish and no certificate to order still queues no DNS task. There's a unit test for that next to his 9.

Checked locally:

  • cargo test -p jmap --lib registry::mapping::domain: 14 passed (Stefan's 9, the #304 one, main's 4)
  • automation::automation_tests (ACME, relay certificate, DKIM, DNS Management, RFC2136 against Pebble): passed
  • cargo fmt --all --check, the four fork checks and version.py --changelog: clean

Fixes #372

Contributed by @StefanSa in #372 (attached patch, ported to main). With DNS management already Automatic, adding a record type to `publishRecords` was saved but queued no DNS task, so the new records were never published. The workaround was switching the domain to Manual and back. An Automatic to Automatic save now queues one DNS task for the newly enabled record types. Removing a type deletes nothing, the same set in another order queues nothing, and new domains, Manual to Automatic and the DKIM paths behave as before. Port note: Stefan's patch was made against release/2026. Main has since gained the #304 guard, so the port keeps it: a domain with nothing to publish and no certificate to order still queues no DNS task. There's a unit test for that next to his 9. Checked locally: - `cargo test -p jmap --lib registry::mapping::domain`: 14 passed (Stefan's 9, the #304 one, main's 4) - `automation::automation_tests` (ACME, relay certificate, DKIM, DNS Management, RFC2136 against Pebble): passed - `cargo fmt --all --check`, the four fork checks and `version.py --changelog`: clean Fixes #372
jcoffey-dev added 1 commit 2026-11-13 16:43:11 +00:00
Automatic DNS: publish record types newly added to publishRecords
ci / fork-checks (pull_request) Skipped
ci / build (pull_request) Skipped
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 9m47s
226631ae62
With DNS management already Automatic, adding a record type to
publishRecords was saved but queued no DNS task, so the new records
were never published (the workaround was Manual and back to Automatic).
An Automatic to Automatic save now queues one DNS task for the record
types that are newly enabled. Removing a type deletes nothing, and the
same set in another order queues nothing. New domains, Manual to
Automatic, and the DKIM paths behave as before.

Task planning moves into schedule_dns_tasks, with unit tests for each
transition.

Ported to main: keeps the #304 guard, so a domain with nothing to
publish and no certificate to order still queues no DNS task, with a
test for it.

Fixes #372
jcoffey-dev merged commit 6df9672c80 into main 2026-11-13 16:52:59 +00:00
jcoffey-dev deleted branch fix/dns-publish-records-trigger 2026-11-13 16:52:59 +00:00
Sign in to join this conversation.