Snapshots: listed and destroyed also while a new one is refused (2026.x) #352

Merged
jcoffey-dev merged 1 commits from backport/snapshots-listed-2026 into release/2026 2026-11-10 04:36:22 +00:00
Owner

Backport of #351 to 2026.x. One commit, cherry-picked clean from main's 95117823.

While a blob store change isn't settled, a new snapshot is refused (BM-8). The snapshots already on disk went with it: inbuxa:StoreSnapshot/get listed none, destroy answered notFound, and the start-up cleanup left partial directories alone. The directory now comes from the RocksDB data store alone (Store::snapshot_data_path). Spec SN-7 says so.

The bug is in 2026.11.9.1 and later.

Test: system::store_snapshot puts the blob store through an unsettled change and checks the refusal, the snapshot still listed, and its destroy. On this branch it passes with blobs in the data store and with BLOB_STORE=FileSystem, and fails without the services change. Also fork checks, build, and the store and services snapshot unit tests.

Backport of #351 to 2026.x. One commit, cherry-picked clean from main's 95117823. While a blob store change isn't settled, a new snapshot is refused (BM-8). The snapshots already on disk went with it: `inbuxa:StoreSnapshot/get` listed none, destroy answered `notFound`, and the start-up cleanup left partial directories alone. The directory now comes from the RocksDB data store alone (`Store::snapshot_data_path`). Spec SN-7 says so. The bug is in 2026.11.9.1 and later. Test: `system::store_snapshot` puts the blob store through an unsettled change and checks the refusal, the snapshot still listed, and its destroy. On this branch it passes with blobs in the data store and with `BLOB_STORE=FileSystem`, and fails without the services change. Also fork checks, build, and the store and services snapshot unit tests.
jcoffey-dev added 1 commit 2026-11-10 04:23:54 +00:00
Snapshots: listed and destroyed also while a new one is refused
github/ci (branch) GitHub Actions
ci / fork-checks (pull_request) Skipped
ci / build (pull_request) Skipped
ci / github (pull_request) Successful in 5s
e50b2d4fc2
While a blob store change isn't settled, a new snapshot is refused
(BM-8). The snapshots already on disk went with it: get listed none,
destroy said notFound, and the start-up cleanup skipped partial
directories, because all three found the snapshots' directory through
the same check that refuses a new one. Found with inbuxa Admin's new
Snapshots page.

The directory now comes from the RocksDB data store alone. The system
test takes the blob store through an unsettled change and checks the
refusal, the snapshot still listed, and its destroy.
jcoffey-dev merged commit 7f870160b9 into release/2026 2026-11-10 04:36:22 +00:00
jcoffey-dev deleted branch backport/snapshots-listed-2026 2026-11-10 04:36:22 +00:00
Sign in to join this conversation.