Certificate Hostnames: say the list replaces the default names #299

Merged

jcoffey-dev merged 1 commits from fix/certificate-hostnames-label-291 into main

2026-11-06 07:47:02 +00:00

jcoffey-dev commented

2026-11-06 07:33:41 +00:00

Owner

Fixes #291.

The field was labeled "Additional Hostnames" and described as names to include, but a list replaces the default names: the domain itself drops out, along with the wildcard on DNS challenges and the standard names on the others (build_domains in crates/common/src/network/acme/order.rs).

This renames the label to "Certificate Hostnames" and rewrites the description: the list replaces the defaults, what the defaults are, and how a name is read (no dot gets the domain added, a dot means as written). The property name and stored configs don't change, so nothing orders differently. Making the list additive would change what existing configs order, so it's left as is.

The schema was rewritten the way expr-schema.py writes it (checked byte for byte on the unchanged file first). The explain and explanation unit tests, which read the schema, pass; cargo build -p inbuxa and the fork checks are clean. The reference docs regenerate from this at release; the DNS guide's wording is in inbuxa/inbuxa.org (docs/certificate-hostnames-291).

Fixes #291. The field was labeled "Additional Hostnames" and described as names to include, but a list replaces the default names: the domain itself drops out, along with the wildcard on DNS challenges and the standard names on the others (`build_domains` in `crates/common/src/network/acme/order.rs`). This renames the label to "Certificate Hostnames" and rewrites the description: the list replaces the defaults, what the defaults are, and how a name is read (no dot gets the domain added, a dot means as written). The property name and stored configs don't change, so nothing orders differently. Making the list additive would change what existing configs order, so it's left as is. The schema was rewritten the way `expr-schema.py` writes it (checked byte for byte on the unchanged file first). The explain and explanation unit tests, which read the schema, pass; `cargo build -p inbuxa` and the fork checks are clean. The reference docs regenerate from this at release; the DNS guide's wording is in inbuxa/inbuxa.org (docs/certificate-hostnames-291).

jcoffey-dev added 1 commit 2026-11-06 07:33:41 +00:00

Certificate Hostnames: say the list replaces the default names

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 13m6s

Details

d7c32062c5

The field was labeled "Additional Hostnames" and described as names to
include, but a list replaces the default names: the domain itself drops
out, with the wildcard on DNS challenges and the standard names on the
others. Rename the label and say what the defaults are and how a name is
read. The property and stored configs are unchanged.

Fixes #291

jcoffey-dev merged commit 4951ad038b into main

2026-11-06 07:47:02 +00:00

jcoffey-dev deleted branch fix/certificate-hostnames-label-291

2026-11-06 07:47:02 +00:00

jcoffey-dev referenced this pull request

2026-11-06 19:19:33 +00:00

Version 27.1-rc.10 #302

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inbuxa/inbuxa-server#299