Leave the startup domain check out of test builds

jcoffey-dev commented

2026-10-18 21:22:19 +00:00

Owner

#201 schedules its first check of automatic domains' DKIM and ACME
tasks 5 minutes after start. The JMAP suite (RocksDB) runs about 7–8
minutes, so the check fired mid-suite, queued DkimManagement for the
test domain, and the store cleanup at the end failed ("Store is not
empty": two DkimSignature objects and their indexes). Seen while
checking the v0.16.27 import; it fails the same way on main since #201.

The scheduler no longer queues that first check in test_mode builds.
The DKIM tests call check_tasks_for_domains directly, so their
coverage is unchanged; production builds behave as before.

Checked: the JMAP suite passes with this change (464 s, past the
5-minute mark); fork checks clean.

#201 schedules its first check of automatic domains' DKIM and ACME tasks 5 minutes after start. The JMAP suite (RocksDB) runs about 7–8 minutes, so the check fired mid-suite, queued DkimManagement for the test domain, and the store cleanup at the end failed ("Store is not empty": two DkimSignature objects and their indexes). Seen while checking the v0.16.27 import; it fails the same way on main since #201. The scheduler no longer queues that first check in test_mode builds. The DKIM tests call `check_tasks_for_domains` directly, so their coverage is unchanged; production builds behave as before. Checked: the JMAP suite passes with this change (464 s, past the 5-minute mark); fork checks clean.

jcoffey-dev added 1 commit 2026-10-18 21:22:19 +00:00

Leave the startup domain check out of test builds

ci / fork-checks (pull_request) Skipped

Details

ci / build (pull_request) Skipped

Details

github/ci (branch) GitHub Actions

Details

ci / github (pull_request) Successful in 5m45s

Details

8e981db4d4

#201 queues its first check of automatic domains' DKIM and ACME tasks
5 minutes after start. The JMAP suite runs longer than that, so the
check gave its test domain DKIM keys mid-run and the store cleanup
failed with leftover DkimSignature objects. Tests call
check_tasks_for_domains themselves.

jcoffey-dev referenced this pull request

2026-10-18 21:22:31 +00:00

Merge upstream v0.16.27 #204

jcoffey-dev merged commit 034dfd71f1 into main

2026-10-18 21:28:11 +00:00

jcoffey-dev deleted branch fix/domain-check-in-tests

2026-10-18 21:28:11 +00:00

Leave the startup domain check out of test builds #203