Merge pull request 'Hotfix 2026.9.24.4: report reschedules keep the task queue readable' (#49) from hotfix/2026.9.24.4 into release/2026.9.24.4

Setting deliverAt on an internal DMARC or TLS report wrote the new task
queue row with the report's object type (0x21, 0x6e) instead of the task
type (7, 8), and left the task row at its old due. The task manager's scan
failed on that row with store.data-corruption ("Failed to iterate over task
queue"), and because the error ended the whole scan, every task due after
the row stopped running on every node.

- reschedule_ops writes the new queue row through schedule_task_with_id, so
  it carries the task type and the task row gets the new due. It removes
  the row the task is actually queued under (the task's due, which differs
  from deliverAt once the task has been retried) and any row an earlier
  reschedule left at deliverAt.
- x:DmarcInternalReport/set and x:TlsInternalReport/set lock the report's
  task while they move it, as x:Task/set does, refuse while the report is
  being sent, release the locks however the request ends, and wake the task
  manager.
- The task manager logs a queue row it can't read (id, due, key, value) and
  skips it instead of ending the scan. It then repairs the row from its task:
  the row is rewritten with the task's type, and a row with no task behind
  it is removed. A row holding a report's object type for a report task is
  what the old reschedule wrote: the task is moved to that row's time, as
  the reschedule intended, and its old queue row is removed. Stores that
  already hold such a row recover on their own once it comes due.
- x:Task/query with a type filter skips an unreadable row instead of
  failing.

Test: smtp::reporting::reschedule (RocksDB and PostgreSQL). It fails on
main: x:Task/get shows the old due, and with that check removed, neither
report nor a later task ever runs.

(cherry picked from commit 1a7859a8cc)

.gitea/workflows/publish.yml

@@ -3,36 +3,22 @@
 # whether a person pushed it or weekly-release.yml created it through the
 # releases API.
 #
-# The image is multi-arch (linux/amd64, linux/arm64), built by two jobs on
+# The image is multi-arch (linux/amd64, linux/arm64) as before, but built in
-# the image-build runner rather than one buildx run for both. The Dockerfile's
+# one buildx run on host1 instead of one native runner per architecture: the
-# builder stage runs on the build platform and cross-compiles with an aarch64
+# Dockerfile's builder stage runs on the build platform and cross-compiles
-# linker, so only the small final stage (apt, setcap) goes through QEMU for
+# with an aarch64 linker, so only the small final stage (apt, setcap) goes
-# arm64 -- but two release builds (LTO, one codegen unit) side by side on one
+# through QEMU for arm64. No digest-joining job is needed.
-# machine each take twice as long. Production runs amd64, so amd64 goes first
-# and on its own:
-#   * publish-amd64 pushes :<version>-amd64 and :<version>, a plain amd64
-#     image, as soon as its build is done. A deploy can start from it.
-#   * publish-arm64 then builds arm64, pushes :<version>-arm64, and replaces
-#     :<version> with the two-platform index. :latest moves only here, so it
-#     never names an image without arm64.
-#
-# Both jobs use one BuildKit builder, `gitea-builder`, whose container
-# (buildx_buildkit_gitea-builder0) and state volume stay on the runner's host
-# between jobs: a job container's `buildx create` finds the existing container
-# and reuses it and its cache. The dependency build (`cargo chef cook`) is
-# keyed on the recipe, which only a dependency change alters, so a release
-# normally compiles just the workspace. Removing that container or its volume
-# costs the next release a cold build, nothing more. The planner and dependency
-# layers for the build platform are shared, so arm64 also reuses what amd64
-# just did where it can.
 #
 # Two guards before anything is pushed:
 #   * the tag must be v<brand_version!>. The version is a string in
 #     crates/types/src/branding.rs, not Cargo.toml, and the image is tagged
 #     with it, so a tag beside an unbumped macro would publish an image that
 #     reports a different version from its tag.
-#   * the tag must be on main, so an image never describes code that was never
+#   * the tag must be on main or on a release/* branch, so an image never
-#     reviewed onto the default branch.
+#     describes code that was never reviewed onto one of them. A release/*
+#     branch carries a hotfix: it starts at an earlier release tag, takes
+#     fixes through pull requests into it, and is tagged there, so production
+#     can get a fix without everything that has landed on main since.
 #
 # :latest moves with every published tag: tags are cut by the weekly release
 # (or by hand for a real release); there are no prerelease tags here.
@@ -74,12 +60,17 @@ jobs:
             echo "Refusing to publish an image that would report the wrong version." >&2
             exit 1
           fi
-          git merge-base --is-ancestor "$(git rev-parse "${TAG}^{commit}")" origin/main \
+          commit="$(git rev-parse "${TAG}^{commit}")"
-            || { echo "$TAG is not on main" >&2; exit 1; }
+          on=""
+          for ref in origin/main $(git for-each-ref --format='%(refname:short)' 'refs/remotes/origin/release/*'); do
+            if git merge-base --is-ancestor "$commit" "$ref"; then on="$ref"; break; fi
+          done
+          [ -n "$on" ] || { echo "$TAG is not on main or a release/* branch" >&2; exit 1; }
+          echo "$TAG is on $on"
           echo "version=$V" >> "$GITHUB_OUTPUT"
           echo "version $V"
 
-  publish-amd64:
+  publish:
     needs: [version]
     runs-on: docker
     container:
@@ -98,15 +89,16 @@ jobs:
           test -n "$REGISTRY" && test -n "$VERSION"
           test -n "$PACKAGE_TOKEN" || { echo "PACKAGE_TOKEN secret is not set on this repository" >&2; exit 1; }
           echo "$PACKAGE_TOKEN" | docker login -u jcoffey-dev --password-stdin "$REGISTRY"
+          docker run --privileged --rm tonistiigi/binfmt --install arm64
           docker buildx create --use --name gitea-builder --driver docker-container || docker buildx use gitea-builder
-      # Attestations off, as before: they add manifests of their own, and the
+      # Attestations off, as before: they add manifests of their own to the
-      # index should hold the two images and nothing else.
+      # index, and the index should hold the two images and nothing else.
       - run: |
           docker buildx build \
-            --platform linux/amd64 \
+            --platform linux/amd64,linux/arm64 \
             --provenance=false --sbom=false \
-            --tag "$IMAGE:$VERSION-amd64" \
             --tag "$IMAGE:$VERSION" \
+            --tag "$IMAGE:latest" \
             --push .
           docker buildx imagetools inspect "$IMAGE:$VERSION"
       # Gitea keeps a container package on its owner; linking it shows it on
@@ -119,47 +111,11 @@ jobs:
       - if: always()
         run: docker logout "$REGISTRY" || true
 
-  publish-arm64:
-    needs: [version, publish-amd64]
-    runs-on: docker
-    container:
-      image: docker:28-cli@sha256:625d9431a9f54c5a2bc90f24f0e1c3d55b1349fd857dd85035f98c2c9acbdd4d # 28-cli
-      volumes:
-        - /var/run/docker.sock:/var/run/docker.sock
-    env:
-      DOCKER_BUILDKIT: "1"
-      REGISTRY: ${{ vars.REGISTRY }}
-      IMAGE: ${{ vars.REGISTRY }}/${{ github.repository }}
-      VERSION: ${{ needs.version.outputs.version }}
-      PACKAGE_TOKEN: ${{ secrets.PACKAGE_TOKEN }}
-    steps:
-      - uses: coffey-labs/actions/checkout@fab0c4d45e0162963965f1555df27b7bed5e20ec
-      - run: |
-          echo "$PACKAGE_TOKEN" | docker login -u jcoffey-dev --password-stdin "$REGISTRY"
-          docker run --privileged --rm tonistiigi/binfmt --install arm64
-          docker buildx create --use --name gitea-builder --driver docker-container || docker buildx use gitea-builder
-      # The index is built from the two per-architecture tags rather than from
-      # :<version>, which by now is the amd64 image and would be read as such.
-      - run: |
-          docker buildx build \
-            --platform linux/arm64 \
-            --provenance=false --sbom=false \
-            --tag "$IMAGE:$VERSION-arm64" \
-            --push .
-          docker buildx imagetools create \
-            --tag "$IMAGE:$VERSION" \
-            --tag "$IMAGE:latest" \
-            "$IMAGE:$VERSION-amd64" "$IMAGE:$VERSION-arm64"
-          docker buildx imagetools inspect "$IMAGE:$VERSION"
-      - if: always()
-        run: docker logout "$REGISTRY" || true
-
   # The weekly release creates its Release (and so the tag) first; a tag
   # pushed by hand has none. Either way the tag ends up with exactly one
-  # Release, created once the amd64 image exists so its pull instructions
+  # Release, created after the image exists so its pull instructions work.
-  # work; arm64 and the binaries follow.
   release:
-    needs: [version, publish-amd64]
+    needs: [version, publish]
     runs-on: light
     container:
       image: python:3.13-slim@sha256:8d9d0b8bcf6506481eae4907c18f5e3e7902e629f5f6d684f9e7c32e85e3ddf0 # 3.13-slim
@@ -183,9 +139,7 @@ jobs:
           except urllib.error.HTTPError as e:
               if e.code != 404: raise
           image = f"{os.environ['REGISTRY']}/{os.environ['REPO']}:{version}"
-          body = (f"Container image: `{image}` (linux/amd64, linux/arm64); also `:latest`. "
+          body = (f"Container image: `{image}` (linux/amd64, linux/arm64); also `:latest`.\n\n"
-                  "amd64 is published first; arm64 is added to the same tag when its build "
-                  "finishes, and `:latest` moves then.\n\n"
                   "Binaries for a host install are attached: `inbuxa-linux-amd64.tar.gz` and "
                   "`inbuxa-linux-arm64.tar.gz`, with `SHA256SUMS`. Each is the binary out of this "
                   "release's image for that architecture, so it is the same build. The image "
@@ -208,7 +162,7 @@ jobs:
   # `docker create` does not start anything, so pulling an arm64 image on an
   # amd64 runner and copying a file out of it needs no emulation.
   binaries:
-    needs: [version, publish-arm64, release]
+    needs: [version, publish, release]
     runs-on: docker
     container:
       image: docker:28-cli@sha256:625d9431a9f54c5a2bc90f24f0e1c3d55b1349fd857dd85035f98c2c9acbdd4d # 28-cli

crates/common/src/cache/reload.rs

@@ -13,27 +13,20 @@ use crate::{
         storage::Storage,
         telemetry::Telemetry,
     },
-    ipc::{BroadcastEvent, QueueEvent, RegistryChange},
+    ipc::{QueueEvent, RegistryChange},
     network::security::{BlockedIps, IpWithTtl},
 };
 use ahash::AHashMap;
 use directory::Directories;
 use registry::{
     schema::{prelude::ObjectType, structs::BlockedIp},
-    types::{
+    types::error::{Error, Warning},
-        error::{Error, Warning},
-        id::ObjectId,
-    },
 };
 use std::sync::Arc;
 use store::{LookupStores, registry::bootstrap::Bootstrap, write::now};
 
 pub struct ReloadResult {
-    /// Errors that kept the reload from being applied.
     pub errors: Vec<Error>,
-    /// inbuxa: errors in objects that already failed when the running
-    /// settings were built; logged, but they don't refuse a reload.
-    pub known_errors: Vec<Error>,
     pub warnings: Vec<Warning>,
     pub replaced_core: bool,
 }
@@ -121,66 +114,42 @@ impl Server {
                     directories: directory.directories,
                 };
 
-                // inbuxa: upstream swapped the core only when the whole build
+                // Parse tracers
-                // was free of errors, while boot runs with whatever built. So one
-                // object that failed (a DNS lookup that timed out, say) refused
-                // every later reload, cluster-wide when the reload came from
-                // ReloadSettings, and the running settings went stale. Now a
-                // reload is refused only for errors in objects that built when
-                // the running settings were built: those would be lost by
-                // applying it. Objects that already failed then are missing
-                // from the running settings anyway, as at boot, so their
-                // errors are reported but don't hold the reload back.
                 let tracers = Telemetry::parse(&mut bootstrap, &storage).await;
-                let core = Box::pin(Core::parse(&mut bootstrap, storage)).await;
-                let mut servers = Listeners::parse(&mut bootstrap).await;
 
-                if !self.has_new_build_errors(&bootstrap.errors) {
+                if bootstrap.errors.is_empty() {
-                    servers
+                    let core = Box::pin(Core::parse(&mut bootstrap, storage)).await;
-                        .parse_tcp_acceptors(&mut bootstrap, self.inner.clone())
-                        .await;
 
-                    if !self.has_new_build_errors(&bootstrap.errors) {
+                    if bootstrap.errors.is_empty() {
-                        // Update core
+                        let mut servers = Listeners::parse(&mut bootstrap).await;
-                        self.inner.shared_core.store(core.into());
+                        servers
+                            .parse_tcp_acceptors(&mut bootstrap, self.inner.clone())
+                            .await;
 
-                        // Update tracers
+                        if bootstrap.errors.is_empty() {
-                        tracers.update();
+                            // Update core
+                            self.inner.shared_core.store(core.into());
 
-                        // Reload queue settings
+                            // Update tracers
-                        self.inner
-                            .ipc
-                            .queue_tx
-                            .send(QueueEvent::ReloadSettings)
-                            .await
-                            .ok();
 
-                        // inbuxa: the task manager reads the node's role on
+                            tracers.update();
-                        // every scan; scan now, so a role that gained task
-                        // types starts claiming them without waiting out the
-                        // refresh interval
-                        self.inner.ipc.task_tx.notify_one();
 
-                        self.record_build_errors(&bootstrap.errors);
+                            // Reload queue settings
+                            self.inner
+                                .ipc
+                                .queue_tx
+                                .send(QueueEvent::ReloadSettings)
+                                .await
+                                .ok();
 
-                        return Ok(ReloadResult {
+                            return Ok(ReloadResult {
-                            errors: Vec::new(),
+                                errors: bootstrap.errors,
-                            known_errors: bootstrap.errors,
+                                warnings: bootstrap.warnings,
-                            warnings: bootstrap.warnings,
+                                replaced_core: true,
-                            replaced_core: true,
+                            });
-                        });
+                        }
                     }
                 }
-
-                let (known_errors, errors) = std::mem::take(&mut bootstrap.errors)
-                    .into_iter()
-                    .partition(|error| self.is_known_build_error(error));
-                return Ok(ReloadResult {
-                    errors,
-                    known_errors,
-                    warnings: bootstrap.warnings,
-                    replaced_core: false,
-                });
             }
         }
 
@@ -194,7 +163,7 @@ impl ReloadResult {
     }
 
     pub fn log(&self) {
-        for error in self.errors.iter().chain(&self.known_errors) {
+        for error in &self.errors {
             error.log();
         }
         for warning in &self.warnings {
@@ -207,237 +176,8 @@ impl From<Bootstrap> for ReloadResult {
     fn from(bootstrap: Bootstrap) -> Self {
         Self {
             errors: bootstrap.errors,
-            known_errors: Vec::new(),
             warnings: bootstrap.warnings,
             replaced_core: false,
         }
     }
 }
-
-// inbuxa: which objects failed to build for the running settings
-impl Server {
-    /// Records the objects that failed to build for the settings now running.
-    pub fn record_build_errors(&self, errors: &[Error]) {
-        *self.inner.data.build_errors.lock() = errors.iter().filter_map(error_object).collect();
-    }
-
-    fn is_known_build_error(&self, error: &Error) -> bool {
-        error_object(error).is_some_and(|id| self.inner.data.build_errors.lock().contains(&id))
-    }
-
-    fn has_new_build_errors(&self, errors: &[Error]) -> bool {
-        errors.iter().any(|error| !self.is_known_build_error(error))
-    }
-}
-
-fn error_object(error: &Error) -> Option<ObjectId> {
-    match error {
-        Error::Validation { object_id, .. }
-        | Error::Build { object_id, .. }
-        | Error::NotFound { object_id } => Some(*object_id),
-        Error::Internal { object_id, .. } => *object_id,
-    }
-}
-
-// inbuxa: upstream applied a registry write to the running settings only on
-// an explicit x:Action ReloadSettings (Directory and Authentication aside), so
-// a new MtaDeliverySchedule, say, stayed unknown ("Queue strategy not found")
-// until someone reloaded. Writes to objects the settings are built from now
-// reload them, here and across the cluster, as ReloadSettings does.
-
-/// Coalesces the full reloads that registry writes trigger: a write waits for
-/// a reload that started after it was stored, and joins one if it can, so a
-/// burst of writes costs a reload or two rather than one each.
-#[derive(Default)]
-pub struct SettingsReloadGate {
-    requested: std::sync::atomic::AtomicU64,
-    state: tokio::sync::Mutex<SettingsReloadState>,
-}
-
-#[derive(Default)]
-struct SettingsReloadState {
-    completed: u64,
-    refused: Option<String>,
-}
-
-/// The reload a write to `object` calls for: the object to reload, or None
-/// when the running settings don't hold that object (accounts, domains and
-/// other data read as needed, stores, which take a restart, and objects with
-/// reload actions of their own, such as applications). Blocked IPs have a
-/// reload of their own; allowed IPs take the full one.
-pub fn write_reload_target(object: ObjectType) -> Option<ObjectType> {
-    match object {
-        ObjectType::Certificate => Some(ObjectType::Certificate),
-        ObjectType::MemoryLookupKey
-        | ObjectType::MemoryLookupKeyValue
-        | ObjectType::HttpLookup
-        | ObjectType::StoreLookup => Some(ObjectType::StoreLookup),
-        ObjectType::BlockedIp => Some(ObjectType::BlockedIp),
-        // Allowed IPs are part of the core's security settings
-        // (Security::parse), which only a full reload rebuilds; the blocked-IP
-        // reload doesn't touch them
-        ObjectType::AllowedIp
-        | ObjectType::AcmeProvider
-        | ObjectType::AddressBook
-        | ObjectType::AiModel
-        | ObjectType::Asn
-        | ObjectType::Authentication
-        | ObjectType::Cache
-        | ObjectType::Calendar
-        | ObjectType::CalendarAlarm
-        | ObjectType::CalendarScheduling
-        | ObjectType::ClusterRole
-        | ObjectType::DataRetention
-        | ObjectType::Directory
-        | ObjectType::DkimReportSettings
-        | ObjectType::DmarcReportSettings
-        | ObjectType::DnsResolver
-        | ObjectType::DsnReportSettings
-        | ObjectType::Email
-        | ObjectType::EventTracingLevel
-        | ObjectType::FileStorage
-        | ObjectType::Http
-        | ObjectType::HttpForm
-        | ObjectType::Imap
-        | ObjectType::Jmap
-        | ObjectType::Metrics
-        | ObjectType::MtaConnectionStrategy
-        | ObjectType::MtaDeliverySchedule
-        | ObjectType::MtaExtensions
-        | ObjectType::MtaHook
-        | ObjectType::MtaInboundSession
-        | ObjectType::MtaInboundThrottle
-        | ObjectType::MtaMilter
-        | ObjectType::MtaOutboundStrategy
-        | ObjectType::MtaOutboundThrottle
-        | ObjectType::MtaQueueQuota
-        | ObjectType::MtaRoute
-        | ObjectType::MtaStageAuth
-        | ObjectType::MtaStageConnect
-        | ObjectType::MtaStageData
-        | ObjectType::MtaStageEhlo
-        | ObjectType::MtaStageMail
-        | ObjectType::MtaStageRcpt
-        | ObjectType::MtaSts
-        | ObjectType::MtaTlsStrategy
-        | ObjectType::MtaVirtualQueue
-        | ObjectType::NetworkListener
-        | ObjectType::OidcProvider
-        | ObjectType::ReportSettings
-        | ObjectType::Search
-        | ObjectType::Security
-        | ObjectType::SenderAuth
-        | ObjectType::Sharing
-        | ObjectType::SieveSystemInterpreter
-        | ObjectType::SieveSystemScript
-        | ObjectType::SieveUserInterpreter
-        | ObjectType::SieveUserScript
-        | ObjectType::SpamClassifier
-        | ObjectType::SpamDnsblServer
-        | ObjectType::SpamDnsblSettings
-        | ObjectType::SpamFileExtension
-        | ObjectType::SpamPyzor
-        | ObjectType::SpamRule
-        | ObjectType::SpamSettings
-        | ObjectType::SpamTag
-        | ObjectType::SpfReportSettings
-        | ObjectType::SystemSettings
-        | ObjectType::TaskManager
-        | ObjectType::TlsReportSettings
-        | ObjectType::Tracer
-        | ObjectType::WebDav
-        | ObjectType::WebHook => Some(object),
-        _ => None,
-    }
-}
-
-impl Server {
-    /// Applies a stored registry write to `object` to the running settings,
-    /// and on success tells the other nodes to do the same. Returns None when
-    /// the write needs no reload, Some(Ok(())) when it was applied, and
-    /// Some(Err(reason)) when the reload was refused (the write stays stored;
-    /// ReloadSettings reports the same errors).
-    pub async fn reload_after_write(&self, object: ObjectType) -> Option<Result<(), String>> {
-        let target = write_reload_target(object)?;
-        let change = RegistryChange::Reload(target);
-
-        if matches!(
-            target,
-            ObjectType::Certificate | ObjectType::StoreLookup | ObjectType::BlockedIp
-        ) {
-            // Cheap, and limited to their own objects
-            let result = self.reload_and_broadcast(change).await;
-            return Some(result);
-        }
-
-        let gate = &self.inner.data.settings_reload;
-        let ticket = gate
-            .requested
-            .fetch_add(1, std::sync::atomic::Ordering::SeqCst)
-            + 1;
-        let mut state = gate.state.lock().await;
-        if state.completed >= ticket {
-            // A reload that started after this write was stored has run
-            return Some(state.refused.clone().map_or(Ok(()), Err));
-        }
-        let covers = gate.requested.load(std::sync::atomic::Ordering::SeqCst);
-        let result = self.reload_and_broadcast(change).await;
-        state.completed = covers;
-        state.refused = result.clone().err();
-        Some(result)
-    }
-
-    async fn reload_and_broadcast(&self, change: RegistryChange) -> Result<(), String> {
-        match Box::pin(self.reload_registry(change)).await {
-            Ok(reload) if !reload.has_errors() => {
-                reload.log();
-                self.cluster_broadcast(BroadcastEvent::RegistryChange(change))
-                    .await;
-                Ok(())
-            }
-            Ok(reload) => {
-                reload.log();
-                let reason = describe_reload_errors(&reload.errors);
-                trc::event!(
-                    Registry(trc::RegistryEvent::BuildWarning),
-                    Details = "Settings didn't reload after a registry write",
-                    Reason = reason.clone(),
-                );
-                Err(reason)
-            }
-            Err(err) => {
-                let reason = err.to_string();
-                trc::error!(err.details("Failed to reload settings after a registry write"));
-                Err(reason)
-            }
-        }
-    }
-}
-
-/// inbuxa: a refused reload's errors in a sentence: the first one, naming its
-/// object, and how many more there are.
-pub fn describe_reload_errors(errors: &[Error]) -> String {
-    let mut description = match errors.first() {
-        Some(Error::Build { object_id, message }) => format!("{object_id}: {message}"),
-        Some(Error::Validation { object_id, errors }) => format!(
-            "{object_id}: {}",
-            errors
-                .iter()
-                .map(|err| err.to_string())
-                .collect::<Vec<_>>()
-                .join("; ")
-        ),
-        Some(Error::Internal {
-            object_id: Some(object_id),
-            error,
-        }) => format!("{object_id}: {error}"),
-        Some(Error::Internal { error, .. }) => error.to_string(),
-        Some(Error::NotFound { object_id }) => format!("{object_id} was not found"),
-        None => String::new(),
-    };
-    let more = errors.len().saturating_sub(1);
-    if more > 0 {
-        description.push_str(&format!(" ({more} more in the server log.)"));
-    }
-    description
-}

crates/common/src/config/inner.rs

@@ -93,11 +93,9 @@ impl Data {
             registry_id_gen: id_generator.clone(),
             span_id_gen: id_generator,
             queue_status: true.into(),
-            settings_reload: Default::default(),
             applications,
             logos: Default::default(),
             smtp_connectors: TlsConnectors::try_new().failed("Failed to build TLS connectors"),
-            build_errors: Default::default(),
             asn_geo_data: Default::default(),
         }
     }
@@ -236,11 +234,9 @@ impl Default for Data {
             span_id_gen: Default::default(),
             registry_id_gen: Default::default(),
             queue_status: true.into(),
-            settings_reload: Default::default(),
             applications: WebApplications::new(),
             logos: Default::default(),
             smtp_connectors: TlsConnectors::try_new().unwrap(),
-            build_errors: Default::default(),
             asn_geo_data: Default::default(),
             lookup_stores: Default::default(),
         }

crates/common/src/config/mailstore/spamfilter.rs

@@ -16,6 +16,7 @@ use mail_auth::common::resolver::ToReverseName;
 use nlp::classifier::model::{CcfhClassifier, FhClassifier};
 use registry::schema::{
     enums::{ExpressionVariable, ModelSize},
+    prelude::ObjectType,
     structs::{
         self, SpamDnsblServer, SpamDnsblSettings, SpamFileExtension, SpamPyzor, SpamRule,
         SpamSettings, SpamTag,
@@ -24,10 +25,10 @@ use registry::schema::{
 use sieve::SpamStatus;
 use std::{
     net::{IpAddr, SocketAddr},
-    sync::Arc,
+    time::Duration,
-    time::{Duration, Instant},
 };
 use store::registry::{RegistryObject, bootstrap::Bootstrap};
+use tokio::net::lookup_host;
 use utils::{cache::CacheItemWeight, glob::GlobMap};
 
 #[derive(rkyv::Archive, rkyv::Deserialize, rkyv::Serialize, Debug, Default)]
@@ -156,11 +157,7 @@ pub struct FtrlParameters {
 
 #[derive(Debug, Clone)]
 pub struct PyzorConfig {
-    // inbuxa: the server is resolved when a message is checked, not while the
+    pub address: SocketAddr,
-    // settings are built (see PyzorConfig::address)
-    pub host: String,
-    pub port: u16,
-    pub resolved: Arc<parking_lot::Mutex<Option<(SocketAddr, Instant)>>>,
     pub timeout: Duration,
     pub min_count: u64,
     pub min_wl_count: u64,
@@ -477,15 +474,31 @@ impl PyzorConfig {
             return None;
         }
 
-        // inbuxa: upstream resolved the host here and reported a failed lookup
+        let port = pyzor.port;
-        // as a build error, so a DNS hiccup on one node refused every settings
+        let host = pyzor.host;
-        // reload on it (and, from the node that ran ReloadSettings, across the
+        let address = match lookup_host(format!("{host}:{port}"))
-        // cluster). The lookup now happens when a message is checked; a
+            .await
-        // failure there is logged as a Pyzor error for that message.
+            .map(|mut a| a.next())
+        {
+            Ok(Some(address)) => address,
+            Ok(None) => {
+                bp.build_error(
+                    ObjectType::SpamPyzor.singleton(),
+                    "Invalid address: No addresses found.",
+                );
+                return None;
+            }
+            Err(err) => {
+                bp.build_error(
+                    ObjectType::SpamPyzor.singleton(),
+                    format!("Invalid address: {}", err),
+                );
+                return None;
+            }
+        };
+
         PyzorConfig {
-            host: pyzor.host,
+            address,
-            port: pyzor.port as u16,
-            resolved: Default::default(),
             timeout: pyzor.timeout.into_inner(),
             min_count: pyzor.block_count,
             min_wl_count: pyzor.allow_count,
@@ -495,35 +508,6 @@ impl PyzorConfig {
     }
 }
 
-// inbuxa: how long a resolved Pyzor address is reused
-const PYZOR_RESOLVE_TTL: Duration = Duration::from_secs(300);
-
-impl PyzorConfig {
-    /// The server's address: the host itself when it is an IP address,
-    /// otherwise the first address it resolves to, reused for five minutes.
-    pub async fn address(&self) -> std::io::Result<SocketAddr> {
-        if let Ok(ip) = self.host.parse::<IpAddr>() {
-            return Ok(SocketAddr::new(ip, self.port));
-        }
-        if let Some((address, resolved_at)) = *self.resolved.lock()
-            && resolved_at.elapsed() < PYZOR_RESOLVE_TTL
-        {
-            return Ok(address);
-        }
-        let address = tokio::net::lookup_host((self.host.as_str(), self.port))
-            .await?
-            .next()
-            .ok_or_else(|| {
-                std::io::Error::new(
-                    std::io::ErrorKind::NotFound,
-                    format!("{} has no addresses", self.host),
-                )
-            })?;
-        *self.resolved.lock() = Some((address, Instant::now()));
-        Ok(address)
-    }
-}
-
 impl ClassifierConfig {
     pub async fn parse(bp: &mut Bootstrap) -> Option<Self> {
         let classifier = bp.setting_infallible::<structs::SpamClassifier>().await;

crates/common/src/config/smtp/session.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use self::resolver::Policy;
@@ -24,7 +22,7 @@ use registry::schema::{
 };
 use smtp_proto::*;
 use std::{
-    net::{IpAddr, SocketAddr},
+    net::{SocketAddr, ToSocketAddrs},
     str::FromStr,
     time::Duration,
 };
@@ -386,16 +384,19 @@ impl SessionConfig {
                     Some(Milter {
                         enable: bp.compile_expr(id, &milter.ctx_enable()),
                         id,
-                        // inbuxa: upstream resolved the hostname here (a
+                        addrs: format!("{}:{}", milter.hostname, milter.port)
-                        // blocking lookup) and made a failure a build error,
+                            .to_socket_addrs()
-                        // which refused the whole settings reload. An IP
+                            .map_err(|err| {
-                        // address is kept as is; a name is resolved on each
+                                bp.build_error(
-                        // connection (MilterClient::connect).
+                                    id,
-                        addrs: milter
+                                    format!(
-                            .hostname
+                                        "Unable to resolve milter hostname {}: {}",
-                            .parse::<IpAddr>()
+                                        milter.hostname, err
-                            .map(|ip| vec![SocketAddr::new(ip, milter.port as u16)])
+                                    ),
-                            .unwrap_or_default(),
+                                )
+                            })
+                            .ok()?
+                            .collect(),
                         hostname: milter.hostname,
                         port: milter.port as u16,
                         timeout_connect: milter.timeout_connect.into_inner(),

crates/common/src/ipc.rs

@@ -335,72 +335,3 @@ impl EmailPush {
         }
     }
 }
-
-/// inbuxa: the task locks this node holds, so a graceful stop can hand them
-/// back instead of leaving the tasks blocked until the locks expire.
-pub struct TaskLocks {
-    held: parking_lot::Mutex<ahash::AHashSet<u64>>,
-    stopping: AtomicBool,
-    expiry: std::sync::atomic::AtomicU64,
-}
-
-impl TaskLocks {
-    /// How long a task lock lasts, in seconds, unless it is released first
-    /// or renewed. inbuxa: upstream held a lock for an hour, so a killed
-    /// node's tasks waited that long; the lock is now a five-minute lease
-    /// that the task manager renews every third of it while the task runs
-    /// (renew_task_locks), so a dead node's tasks run elsewhere within
-    /// minutes.
-    pub const DEFAULT_EXPIRY: u64 = 5 * 60;
-
-    pub fn is_stopping(&self) -> bool {
-        self.stopping.load(Ordering::Acquire)
-    }
-
-    /// Stops new claims and returns the ids of every lock still held.
-    pub fn stop(&self) -> Vec<u64> {
-        self.stopping.store(true, Ordering::Release);
-        self.held.lock().drain().collect()
-    }
-
-    pub fn insert(&self, id: u64) {
-        self.held.lock().insert(id);
-    }
-
-    pub fn remove(&self, id: u64) {
-        self.held.lock().remove(&id);
-    }
-
-    pub fn held(&self) -> usize {
-        self.held.lock().len()
-    }
-
-    /// inbuxa: the tasks this node holds, to renew their locks.
-    pub fn held_ids(&self) -> Vec<u64> {
-        self.held.lock().iter().copied().collect()
-    }
-
-    /// inbuxa: whether this node holds (and is running) the task.
-    pub fn is_held(&self, id: u64) -> bool {
-        self.held.lock().contains(&id)
-    }
-
-    pub fn expiry(&self) -> u64 {
-        self.expiry.load(Ordering::Relaxed)
-    }
-
-    /// Changes the lock lifetime; the tests shorten it.
-    pub fn set_expiry(&self, seconds: u64) {
-        self.expiry.store(seconds.max(1), Ordering::Relaxed);
-    }
-}
-
-impl Default for TaskLocks {
-    fn default() -> Self {
-        Self {
-            held: Default::default(),
-            stopping: AtomicBool::new(false),
-            expiry: std::sync::atomic::AtomicU64::new(Self::DEFAULT_EXPIRY),
-        }
-    }
-}

crates/common/src/lib.rs

@@ -161,17 +161,11 @@ pub struct Data {
     pub span_id_gen: SnowflakeIdGenerator,
     pub registry_id_gen: SnowflakeIdGenerator,
     pub queue_status: AtomicBool,
-    // inbuxa: coalesces the settings reloads registry writes trigger
-    pub settings_reload: cache::reload::SettingsReloadGate,
 
     pub applications: WebApplications,
     pub logos: Mutex<AHashMap<Box<str>, LogoCache>>,
 
     pub smtp_connectors: TlsConnectors,
-
-    // inbuxa: the objects that failed to build when the running settings
-    // were built, at boot or by the last applied reload (see reload_registry)
-    pub build_errors: Mutex<AHashSet<registry::types::id::ObjectId>>,
 }
 
 #[derive(Clone)]
@@ -285,8 +279,6 @@ pub struct HttpAuthCache {
 pub struct Ipc {
     pub push_tx: mpsc::Sender<PushEvent>,
     pub task_tx: Arc<Notify>,
-    // inbuxa: task locks held by this node, released on a graceful stop
-    pub task_locks: Arc<crate::ipc::TaskLocks>,
     pub queue_tx: mpsc::Sender<QueueEvent>,
     pub report_tx: mpsc::Sender<ReportingEvent>,
     pub broadcast_tx: Option<mpsc::Sender<BroadcastEvent>>,

crates/common/src/manager/backup.rs

@@ -23,13 +23,6 @@ use utils::{UnwrapFailure, codec::leb128::Leb128_};
 
 pub(super) const MAGIC_MARKER: u8 = 123;
 
-// inbuxa: blobs kept under a fixed name instead of a content hash. Nothing
-// links to them, so the export names them outright.
-const NAMED_BLOBS: &[&[u8]] = &[
-    crate::manager::SPAM_CLASSIFIER_KEY,
-    crate::manager::SPAM_TRAINER_KEY,
-];
-
 #[derive(Debug, Clone, Copy, Hash, PartialEq, Eq)]
 pub(super) enum Family {
     Data = 0,
@@ -150,21 +143,15 @@ impl Core {
                     .await
                     .failed("Failed to iterate over data store");
 
-                // inbuxa: the trained spam classifier and its trainer state are
+                for hash in blobs {
-                // blobs stored under fixed names with no blob link, so the walk
-                // over links above never reaches them.
-                let named = NAMED_BLOBS.iter().map(|key| key.to_vec());
-                for key in blobs
-                    .into_iter()
-                    .map(|hash| hash.as_slice().to_vec())
-                    .chain(named)
-                {
                     if let Some(blob) = blob_store
-                        .get_blob(&key, 0..usize::MAX)
+                        .get_blob(hash.as_slice(), 0..usize::MAX)
                         .await
                         .failed("Failed to get blob")
                     {
-                        writer.send((key, blob)).failed("Failed to send key");
+                        writer
+                            .send((hash.as_slice().to_vec(), blob))
+                            .failed("Failed to send key");
                     }
                 }
             }),
@@ -336,13 +323,7 @@ impl Family {
                 SUBSPACE_REGISTRY_IDX,
                 SUBSPACE_REGISTRY_PK,
                 SUBSPACE_DIRECTORY,
-                // inbuxa: registry objects the upstream list left out, so an
+                store::SUBSPACE_INBUXA, // inbuxa: masked email
-                // export dropped them: archived items (undelete) and spam
-                // training samples. Their indexes and id counters already
-                // travel in this family and in `data`, so they ride along.
-                SUBSPACE_DELETED_ITEMS,
-                SUBSPACE_SPAM_SAMPLES,
-                store::SUBSPACE_INBUXA, // inbuxa: the fork's own data (masked email, undelete, policies)
             ],
             Family::Changelog => &[SUBSPACE_LOGS],
             Family::Queue => &[SUBSPACE_QUEUE_MESSAGE, SUBSPACE_QUEUE_EVENT],

crates/common/src/manager/boot.rs

@@ -54,13 +54,6 @@ Options:
   -o, --console                    Open the store console
   -h, --help                       Print help
   -V, --version                    Print version
-
-An export holds everything in the data and blob stores except short-lived
-in-memory state (rate limits, locks, greylisting) and the full-text search
-index, which belongs to one search backend. An import into an empty store
-queues the index to be rebuilt when the server next starts. EXPORT_TYPES
-limits an export to some of: data, registry, blob, changelog, queue, report,
-telemetry, tasks.
 "#
 );
 
@@ -240,9 +233,6 @@ impl BootManager {
                     .parse_tcp_acceptors(&mut bootstrap, inner.clone())
                     .await;
 
-                // inbuxa: a reload isn't refused over objects that failed here
-                inner.build_server().record_build_errors(&bootstrap.errors);
-
                 BootManager {
                     inner,
                     bootstrap,
@@ -266,10 +256,10 @@ impl BootManager {
                 telemetry.enable();
 
                 // Parse settings and restore
-                let core = Box::pin(Core::parse(&mut bootstrap, storage)).await;
+                Box::pin(Core::parse(&mut bootstrap, storage))
-                let imported = core.restore(path).await;
+                    .await
-                // inbuxa: the search index isn't exported; rebuild it
+                    .restore(path)
-                core.queue_reindex(&imported).await;
+                    .await;
                 std::process::exit(0);
             }
             StoreOp::Console => {
@@ -300,7 +290,6 @@ pub fn build_ipc(has_pubsub: bool) -> (Ipc, IpcReceivers) {
             report_tx,
             broadcast_tx: has_pubsub.then_some(broadcast_tx),
             task_tx: Arc::new(Notify::new()),
-            task_locks: Arc::new(crate::ipc::TaskLocks::default()),
             train_task_controller: Arc::new(TrainTaskController::default()),
         },
         IpcReceivers {

crates/common/src/manager/restore.rs

@@ -9,22 +9,15 @@
 use super::backup::MAGIC_MARKER;
 use crate::{Core, DATABASE_SCHEMA_VERSION};
 use lz4_flex::frame::FrameDecoder;
-use registry::{
+use registry::schema::enums::CompressionAlgo;
-    schema::{
-        enums::{CompressionAlgo, TaskStoreMaintenanceType},
-        structs::{Task, TaskStatus, TaskStoreMaintenance},
-    },
-    types::EnumImpl,
-};
 use std::{
     fs::File,
     io::{BufReader, ErrorKind, Read},
     path::{Path, PathBuf},
 };
 use store::{
-    BlobStore, IterateParams, SUBSPACE_BLOBS, SUBSPACE_COUNTER, SUBSPACE_INDEXES,
+    BlobStore, IterateParams, SUBSPACE_BLOBS, SUBSPACE_COUNTER, SUBSPACE_INDEXES, SUBSPACE_QUOTA,
-    SUBSPACE_PROPERTY, SUBSPACE_QUOTA, SUBSPACE_REGISTRY_PK, SUBSPACE_TELEMETRY_SPAN, Store,
+    SUBSPACE_REGISTRY_PK, Store, U32_LEN,
-    U32_LEN,
     write::{
         AnyClass, AnyKey, BatchBuilder, ValueClass,
         key::{DeserializeBigEndian, is_node_id_key},
@@ -34,9 +27,7 @@ use types::{collection::Collection, field::Field};
 use utils::{UnwrapFailure, failed};
 
 impl Core {
-    /// Imports an export into an empty store and returns the subspaces it
+    pub async fn restore(&self, src: PathBuf) {
-    /// wrote. inbuxa: the caller hands them to [`Core::queue_reindex`].
-    pub async fn restore(&self, src: PathBuf) -> Vec<u8> {
         // Backup the core
         let paths = if src.is_dir() {
             let mut paths = Vec::new();
@@ -73,13 +64,6 @@ impl Core {
             std::process::exit(1);
         }
 
-        let mut imported = paths
-            .iter()
-            .map(|path| KeyValueReader::new(path).subspace)
-            .collect::<Vec<_>>();
-        imported.sort_unstable();
-        imported.dedup();
-
         let mut tasks = Vec::new();
         for path in paths {
             let storage = self.storage.clone();
@@ -92,54 +76,6 @@ impl Core {
         for task in tasks {
             task.await.failed("Failed to wait for task");
         }
-
-        imported
-    }
-
-    /// inbuxa: an export never carries the full-text index. It is built by
-    /// and for one search backend (the SQL stores index into their own
-    /// tables, the key-value stores into a subspace, external engines keep it
-    /// themselves), so it would be wrong or unreadable after a move to
-    /// another one. Instead, an import queues the same reindex tasks an
-    /// administrator can queue by hand (`reindexAccounts` and
-    /// `reindexTelemetry` store maintenance), and the server rebuilds the
-    /// index for whatever search store it is configured with once it starts.
-    pub async fn queue_reindex(&self, imported: &[u8]) -> Vec<TaskStoreMaintenanceType> {
-        let mut queued = Vec::new();
-        if imported.contains(&SUBSPACE_PROPERTY) {
-            queued.push(TaskStoreMaintenanceType::ReindexAccounts);
-        }
-        if imported.contains(&SUBSPACE_TELEMETRY_SPAN) {
-            queued.push(TaskStoreMaintenanceType::ReindexTelemetry);
-        }
-        if queued.is_empty() {
-            return queued;
-        }
-
-        let mut batch = BatchBuilder::new();
-        for maintenance_type in &queued {
-            batch.schedule_task(Task::StoreMaintenance(TaskStoreMaintenance {
-                maintenance_type: *maintenance_type,
-                status: TaskStatus::now(),
-                shard_index: None,
-            }));
-        }
-        self.storage
-            .data
-            .write(batch.build_all())
-            .await
-            .failed("Failed to queue the reindex tasks");
-
-        println!(
-            "Queued {} to rebuild the search index; it runs when the server starts.",
-            queued
-                .iter()
-                .map(|t| t.as_str())
-                .collect::<Vec<_>>()
-                .join(" and ")
-        );
-
-        queued
     }
 }
 
@@ -189,22 +125,17 @@ async fn restore_file(store: Store, blob_store: BlobStore, path: &Path) {
         }
         SUBSPACE_COUNTER | SUBSPACE_QUOTA => {
             while let Some((key, value)) = reader.next() {
-                let class = ValueClass::Any(AnyClass {
+                batch.add(
-                    subspace: reader.subspace,
+                    ValueClass::Any(AnyClass {
-                    key,
+                        subspace: reader.subspace,
-                });
+                        key,
-                let value = u64::from_le_bytes(
+                    }),
-                    value
+                    u64::from_le_bytes(
-                        .try_into()
+                        value
-                        .expect("Failed to deserialize counter/quota"),
+                            .try_into()
-                ) as i64;
+                            .expect("Failed to deserialize counter/quota"),
-                // inbuxa: the SQL stores add a negative amount with an UPDATE,
+                    ) as i64,
-                // which does nothing to a row that isn't there yet, so a
+                );
-                // negative counter vanished on import. Create the row first.
-                if value < 0 {
-                    batch.add(class.clone(), 0);
-                }
-                batch.add(class, value);
                 if batch.is_large_batch() {
                     store
                         .write(batch.build_all())

crates/coordinator/Cargo.toml

@@ -8,7 +8,7 @@ store = { path =  "../store" }
 registry = { path =  "../registry" }
 trc = { path = "../trc" }
 futures = { version = "0.3", optional = true }
-tokio = { version = "1.53", features = ["sync", "fs", "io-util", "rt", "time"] }
+tokio = { version = "1.53", features = ["sync", "fs", "io-util"] }
 async-nats = { version = "0.50", default-features = false, features = ["server_2_10", "server_2_11", "aws-lc-rs"], optional = true }
 zenoh = { version = "1.10.0", default-features = false, features = ["auth_pubkey", "transport_multilink", "transport_compression", "transport_quic", "transport_tcp", "transport_tls", "transport_udp"], optional = true }
 rdkafka = { version = "0.39", features = ["cmake-build"], optional = true }

crates/coordinator/src/backend/nats/mod.rs

@@ -2,22 +2,13 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
-use std::{
+use std::sync::Arc;
-    sync::{
-        Arc,
-        atomic::{AtomicBool, Ordering},
-    },
-    time::Duration,
-};
 
 use crate::Coordinator;
 use async_nats::Client;
 use registry::schema::structs::NatsCoordinator;
-use trc::ClusterEvent;
 
 pub mod pubsub;
 
@@ -56,116 +47,9 @@ impl NatsPubSub {
             opts = opts.token(credentials);
         }
 
-        // inbuxa: connect in the background and keep trying, so a node that
-        // starts while NATS is down still joins the cluster once NATS is
-        // back, instead of running without a coordinator until restarted;
-        // and report the connection going and coming back
-        let reporter = Arc::new(Reporter::default());
-        opts = opts.retry_on_initial_connect().event_callback({
-            let reporter = reporter.clone();
-            move |event| {
-                let reporter = reporter.clone();
-                async move { reporter.report(event) }
-            }
-        });
-        let connection_timeout = config.timeout_connection.into_inner();
-
         async_nats::connect_with_options(config.addresses.into_inner(), opts)
             .await
-            .map(|client| {
+            .map(|client| Coordinator::Nats(Arc::new(NatsPubSub { client })))
-                reporter.watch_first_connection(client.clone(), connection_timeout);
-                Coordinator::Nats(Arc::new(NatsPubSub { client }))
-            })
             .map_err(|err| format!("Failed to connect to Nats: {}", err))
     }
-
-    /// inbuxa: whether the client is connected to a NATS server right now.
-    pub fn is_connected(&self) -> bool {
-        matches!(
-            self.client.connection_state(),
-            async_nats::connection::State::Connected
-        )
-    }
-}
-
-/// inbuxa: reports the client's connection events as the server's own.
-#[derive(Default)]
-struct Reporter {
-    connected_once: AtomicBool,
-    // A failed attempt raises an error each time the client retries, every
-    // few seconds while NATS is down: report the first after each change
-    error_reported: AtomicBool,
-}
-
-impl Reporter {
-    fn report(&self, event: async_nats::Event) {
-        match event {
-            async_nats::Event::Connected => {
-                self.connected_once.store(true, Ordering::Relaxed);
-                self.error_reported.store(false, Ordering::Relaxed);
-                trc::event!(Cluster(ClusterEvent::CoordinatorConnected), Type = "nats");
-            }
-            async_nats::Event::Disconnected => {
-                self.error_reported.store(false, Ordering::Relaxed);
-                trc::event!(
-                    Cluster(ClusterEvent::CoordinatorDisconnected),
-                    Type = "nats",
-                    Details = "Connection lost; reconnecting in the background",
-                );
-            }
-            async_nats::Event::Closed => {
-                trc::event!(
-                    Cluster(ClusterEvent::CoordinatorDisconnected),
-                    Type = "nats",
-                    Details = "Connection closed; no further attempts will be made",
-                );
-            }
-            async_nats::Event::ClientError(async_nats::ClientError::MaxReconnects) => {
-                trc::event!(
-                    Cluster(ClusterEvent::CoordinatorDisconnected),
-                    Type = "nats",
-                    Details = "Gave up reconnecting (maxReconnects reached)",
-                );
-            }
-            async_nats::Event::ClientError(err) => {
-                if !self.error_reported.swap(true, Ordering::Relaxed) {
-                    trc::event!(
-                        Cluster(ClusterEvent::CoordinatorError),
-                        Type = "nats",
-                        Details = "Connection attempt failed; retrying",
-                        Reason = err.to_string(),
-                    );
-                }
-            }
-            event => {
-                trc::event!(
-                    Cluster(ClusterEvent::CoordinatorError),
-                    Type = "nats",
-                    Details = event.to_string(),
-                );
-            }
-        }
-    }
-
-    /// The first connection is made in the background, so say so when it
-    /// hasn't been made within the connection timeout. The client keeps
-    /// trying, and reports the connection when it comes.
-    fn watch_first_connection(self: &Arc<Self>, client: Client, timeout: Duration) {
-        let reporter = self.clone();
-        tokio::spawn(async move {
-            tokio::time::sleep(timeout).await;
-            if !reporter.connected_once.load(Ordering::Relaxed)
-                && !matches!(
-                    client.connection_state(),
-                    async_nats::connection::State::Connected
-                )
-            {
-                trc::event!(
-                    Cluster(ClusterEvent::CoordinatorDisconnected),
-                    Type = "nats",
-                    Details = "Not connected at startup; retrying in the background",
-                );
-            }
-        });
-    }
 }

crates/coordinator/src/dispatch.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{Coordinator, Msg, PubSubStream};
@@ -45,17 +43,6 @@ impl Coordinator {
     pub fn is_none(&self) -> bool {
         matches!(self, Coordinator::None)
     }
-
-    /// inbuxa: whether the coordinator is connected right now, for the
-    /// backends that track it (NATS); `None` for the others and when no
-    /// coordinator is configured.
-    pub fn is_connected(&self) -> Option<bool> {
-        match self {
-            #[cfg(feature = "nats")]
-            Coordinator::Nats(store) => Some(store.is_connected()),
-            _ => None,
-        }
-    }
 }
 
 impl PubSubStream {

crates/http/src/request.rs

@@ -562,27 +562,6 @@ impl ParseHttp for Server {
                         })
                         .into_http_response());
                     }
-                    // inbuxa: the cluster coordinator's connection, for
-                    // monitoring. It stays out of live and ready on purpose:
-                    // a node without its coordinator still serves mail, and
-                    // failing those would have an orchestrator restart, or
-                    // take out of service, every node at once when the
-                    // coordinator goes down
-                    "cluster" => {
-                        let coordinator = &self.core.storage.coordinator;
-                        let (status, state) = match coordinator.is_connected() {
-                            Some(true) => (StatusCode::OK, "connected"),
-                            Some(false) => (StatusCode::SERVICE_UNAVAILABLE, "disconnected"),
-                            None if coordinator.is_none() => (StatusCode::OK, "none"),
-                            None => (StatusCode::OK, "unknown"),
-                        };
-                        return Ok(http_proto::JsonResponse::with_status(
-                            status,
-                            serde_json::json!({ "coordinator": state }),
-                        )
-                        .no_cache()
-                        .into_http_response());
-                    }
                     _ => (),
                 }
             }

crates/jmap-proto/src/method/set.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::ahash_is_empty;
@@ -73,23 +71,6 @@ pub struct SetResponse<T: JmapObject> {
     #[serde(rename = "notDestroyed")]
     #[serde(skip_serializing_if = "VecMap::is_empty")]
     pub not_destroyed: VecMap<MaybeInvalid<Id>, SetError<T::Property>>,
-
-    // inbuxa: on a registry write that changes the running settings, whether
-    // the server applied it
-    #[serde(rename = "x:settingsReload")]
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub settings_reload: Option<SettingsReload>,
-}
-
-/// inbuxa: the settings reload that followed a registry write.
-#[derive(Debug, Clone, serde::Serialize)]
-pub struct SettingsReload {
-    /// The running settings (here and, through the cluster, on every node)
-    /// include the write.
-    pub applied: bool,
-    /// Why they don't, when they don't.
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub description: Option<String>,
 }
 
 impl<'de, T: JmapObject> DeserializeArguments<'de> for SetRequest<'de, T> {
@@ -218,7 +199,6 @@ impl<T: JmapObject> SetResponse<T> {
                 not_created: VecMap::new(),
                 not_updated: VecMap::new(),
                 not_destroyed: VecMap::new(),
-                settings_reload: None,
             })
         } else {
             Err(trc::JmapEvent::RequestTooLarge.into_err())

crates/jmap/src/inbuxa/telemetry.rs

@@ -427,24 +427,9 @@ pub(crate) async fn trace_query(
             }
             None => false,
         },
-        // The queue id column is an integer on every search backend, and
+        Property::QueueId => match value.as_str() {
-        // holds a trace's first queue id; the keywords carry all of them
-        Property::QueueId => match value
-            .as_str()
-            .and_then(|v| v.trim().parse::<u64>().ok())
-            .or_else(|| value.as_u64())
-        {
             Some(queue_id) => {
-                search.extend([
+                search.push(SearchFilter::eq(TracingSearchField::QueueId, queue_id.to_string()));
-                    SearchFilter::Or,
-                    SearchFilter::eq(TracingSearchField::QueueId, queue_id),
-                    SearchFilter::has_text(
-                        TracingSearchField::Keywords,
-                        queue_id.to_string(),
-                        nlp::language::Language::None,
-                    ),
-                    SearchFilter::End,
-                ]);
                 true
             }
             None => false,

crates/jmap/src/registry/mapping/action.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::registry::mapping::{RegistrySetResponse, map_bootstrap_error};
@@ -101,7 +99,7 @@ pub(crate) async fn action_set(
                 } else {
                     set.response
                         .not_created
-                        .append(id, reload_refused(result.errors));
+                        .append(id, map_bootstrap_error(result.errors));
                 }
             }
             Action::InvalidateCaches => {
@@ -575,14 +573,3 @@ async fn dmarc_troubleshoot(
 
     Some(request)
 }
-
-/// inbuxa: a refused reload names the object that stopped it and says the
-/// settings weren't applied; upstream passed on the first error's bare message
-/// ("Invalid address: ..."), which read like a problem with the request.
-fn reload_refused(errors: Vec<registry::types::error::Error>) -> SetError<Property> {
-    let description = format!(
-        "Settings were not reloaded. {}",
-        common::cache::reload::describe_reload_errors(&errors)
-    );
-    map_bootstrap_error(errors).with_description(description)
-}

crates/jmap/src/registry/mapping/report.rs

@@ -2,6 +2,8 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
+ *
+ * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{
@@ -15,22 +17,42 @@ use jmap_proto::{error::set::SetError, types::state::State};
 use jmap_tools::{Key, Value};
 use registry::{
     jmap::IntoValue,
-    schema::prelude::{Object, ObjectInner, ObjectType, Property},
+    schema::{
+        prelude::{Object, ObjectInner, ObjectType, Property},
+        structs::Task,
+    },
     types::{EnumImpl, datetime::UTCDateTime},
 };
+use services::task_manager::lock::TaskLockManager;
 use smtp::reporting::index::{ExternalReportIndex, InternalReportIndex};
 use std::str::FromStr;
 use store::{
     U64_LEN, ValueKey,
     registry::{RegistryFilter, RegistryFilterValue, RegistryQuery},
-    write::{BatchBuilder, RegistryClass, ValueClass, key::KeySerializer},
+    write::{BatchBuilder, RegistryClass, TaskQueueClass, ValueClass, key::KeySerializer},
 };
 use trc::AddContext;
 use types::id::Id;
 
 pub(crate) async fn report_set(
-    mut set: RegistrySetResponse<'_>,
+    set: RegistrySetResponse<'_>,
 ) -> trc::Result<RegistrySetResponse<'_>> {
+    // inbuxa: task locks taken to reschedule reports are released however
+    // the request ends; a held lock is renewed, so a leaked one would keep
+    // the report's task from ever running
+    let server = set.server;
+    let mut locked_tasks = Vec::new();
+    let result = report_set_locked(set, &mut locked_tasks).await;
+    for task_id in locked_tasks {
+        server.remove_index_lock(task_id).await;
+    }
+    result
+}
+
+async fn report_set_locked<'x>(
+    mut set: RegistrySetResponse<'x>,
+    locked_tasks: &mut Vec<u64>,
+) -> trc::Result<RegistrySetResponse<'x>> {
     let object_id = set.object_type.to_id();
 
     // Reports cannot be created
@@ -89,12 +111,45 @@ pub(crate) async fn report_set(
                 .get_value::<Object>(ValueKey::from(key.clone()))
                 .await?
             {
+                // inbuxa: the report's task shares its id. Hold the task
+                // while its queue rows move, as x:Task/set does, and move the
+                // row the task is actually queued under
+                if !set.server.try_lock_task(item_id).await {
+                    set.response.not_updated.append(
+                        id,
+                        SetError::forbidden().with_description(
+                            "The report is being sent and cannot be rescheduled".to_string(),
+                        ),
+                    );
+                    continue;
+                }
+                locked_tasks.push(item_id);
+                let queued = set
+                    .server
+                    .store()
+                    .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
+                        TaskQueueClass::Task { id: item_id },
+                    )))
+                    .await?;
+
                 match &mut report_obj.inner {
                     ObjectInner::DmarcInternalReport(report) => {
-                        report.reschedule_ops(&mut batch, item_id, report_obj.revision, deliver_at);
+                        report.reschedule_ops(
+                            &mut batch,
+                            item_id,
+                            report_obj.revision,
+                            deliver_at,
+                            queued.as_ref(),
+                        );
                     }
                     ObjectInner::TlsInternalReport(report) => {
-                        report.reschedule_ops(&mut batch, item_id, report_obj.revision, deliver_at);
+                        report.reschedule_ops(
+                            &mut batch,
+                            item_id,
+                            report_obj.revision,
+                            deliver_at,
+                            queued.as_ref(),
+                        );
                     }
                     _ => {}
                 }
@@ -156,6 +211,9 @@ pub(crate) async fn report_set(
             .write(batch.build_all())
             .await
             .caused_by(trc::location!())?;
+        // inbuxa: a rescheduled report may now be due sooner than the task
+        // manager's next scan
+        set.server.notify_task_queue();
     }
 
     Ok(set)

crates/jmap/src/registry/mapping/task.rs

@@ -463,15 +463,10 @@ pub(crate) async fn task_query(
                 .set_values(typ.is_some()),
             |key, value| {
                 if let Some(typ) = typ {
-                    let task_type =
+                    // inbuxa: a row whose type can't be read matches no type
-                        TaskType::from_id(value.deserialize_be_u16(0)?).ok_or_else(|| {
+                    // filter; the task manager logs and repairs it
-                            trc::StoreEvent::DataCorruption
+                    let task_type = value.deserialize_be_u16(0).ok().and_then(TaskType::from_id);
-                                .into_err()
+                    if task_type != Some(typ) {
-                                .ctx(trc::Key::Key, key.to_vec())
-                                .ctx(trc::Key::Value, value.to_vec())
-                                .caused_by(trc::location!())
-                        })?;
-                    if task_type != typ {
                         return Ok(true);
                     }
                 }

crates/jmap/src/registry/set.rs

@@ -38,7 +38,7 @@ use directory::core::secret::{hash_secret, is_password_hash};
 use http_proto::HttpSessionData;
 use jmap_proto::{
     error::set::{SetError, SetErrorType},
-    method::set::{SetRequest, SetResponse, SettingsReload},
+    method::set::{SetRequest, SetResponse},
     object::registry::Registry,
     references::resolve::ResolveCreatedReference,
     request::{IntoValid, MaybeInvalid},
@@ -931,28 +931,30 @@ impl RegistrySet for Server {
             }
         };
 
-        // inbuxa: a write to an object the running settings are built from
+        // inbuxa: DIR-17: a directory or the server default applies on the
-        // applies at once, here and on every node (DIR-17 did this for
+        // next request, here and on every node
-        // directories and the server default; now it covers every such object)
+        if matches!(
-        let mut result = result;
+            object_type,
-        if let Ok(response) = &mut result
+            ObjectType::Directory | ObjectType::Authentication
+        ) && let Ok(response) = &result
             && (!response.created.is_empty()
                 || !response.updated.is_empty()
                 || !response.destroyed.is_empty())
-            && let Some(reload) = self.reload_after_write(object_type).await
         {
-            response.settings_reload = Some(match reload {
+            let change = common::ipc::RegistryChange::Reload(ObjectType::Directory);
-                Ok(()) => SettingsReload {
+            match Box::pin(self.reload_registry(change)).await {
-                    applied: true,
+                Ok(reload) if !reload.has_errors() => {
-                    description: None,
+                    self.cluster_broadcast(common::ipc::BroadcastEvent::RegistryChange(change))
-                },
+                        .await;
-                Err(reason) => SettingsReload {
+                }
-                    applied: false,
+                Ok(_) => trc::event!(
-                    description: Some(format!(
+                    Registry(trc::RegistryEvent::BuildWarning),
-                        "Saved, but the running settings were not reloaded. {reason}"
+                    Details = "Settings didn't reload after a directory change",
-                    )),
+                ),
-                },
+                Err(err) => {
-            });
+                    trc::error!(err.details("Failed to reload directories"));
+                }
+            }
         }
         result
     }

crates/main/src/main.rs

@@ -109,10 +109,6 @@ async fn main() -> std::io::Result<()> {
     // Wait for shutdown signal
     wait_for_shutdown().await;
 
-    // inbuxa: hand back the task locks this node holds, so other nodes can
-    // run those tasks now rather than when the locks expire
-    services::task_manager::lock::release_task_locks(&inner.build_server()).await;
-
     // Shutdown collector
     Collector::shutdown();
 

crates/services/src/broadcast/subscriber.rs

@@ -26,7 +26,7 @@ pub fn spawn_broadcast_subscriber(inner: Arc<Inner>, mut shutdown_rx: watch::Rec
     };
 
     tokio::spawn(async move {
-        let mut retry_count: u32 = 0;
+        let mut retry_count = 0;
 
         trc::event!(Cluster(ClusterEvent::SubscriberStart));
 
@@ -53,7 +53,7 @@ pub fn spawn_broadcast_subscriber(inner: Arc<Inner>, mut shutdown_rx: watch::Rec
                     );
 
                     match tokio::time::timeout(
-                        subscribe_retry_delay(retry_count),
+                        Duration::from_secs(1 << retry_count.max(6)),
                         shutdown_rx.changed(),
                     )
                     .await
@@ -62,7 +62,7 @@ pub fn spawn_broadcast_subscriber(inner: Arc<Inner>, mut shutdown_rx: watch::Rec
                             break;
                         }
                         Err(_) => {
-                            retry_count = retry_count.saturating_add(1);
+                            retry_count += 1;
                             continue;
                         }
                     }
@@ -234,11 +234,6 @@ pub fn spawn_broadcast_subscriber(inner: Arc<Inner>, mut shutdown_rx: watch::Rec
     });
 }
 
-/// Delay before the next subscribe attempt: 1 s, 2 s, 4 s ... capped at 64 s.
-fn subscribe_retry_delay(retry_count: u32) -> Duration {
-    Duration::from_secs(1u64 << retry_count.min(6))
-}
-
 fn log_event(event: &BroadcastEvent) -> trc::Value {
     match event {
         BroadcastEvent::PushNotification(notification) => match notification {
@@ -301,19 +296,3 @@ fn log_event(event: &BroadcastEvent) -> trc::Value {
         BroadcastEvent::QueueRefresh => "QueueRefresh".into(),
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::subscribe_retry_delay;
-    use std::time::Duration;
-
-    #[test]
-    fn subscribe_retry_backoff_grows_then_caps() {
-        let schedule: Vec<u64> = (0..10)
-            .map(|n| subscribe_retry_delay(n).as_secs())
-            .collect();
-        assert_eq!(schedule, vec![1, 2, 4, 8, 16, 32, 64, 64, 64, 64]);
-        // No shift overflow at the top of the range.
-        assert_eq!(subscribe_retry_delay(u32::MAX), Duration::from_secs(64));
-    }
-}

crates/services/src/task_manager/index.rs

@@ -91,15 +91,7 @@ impl SearchIndexTask for Server {
                             build_contact_document(self, account_id, document_id).await
                         }
                         IndexDocumentType::File => {
-                            // File indexing not implemented yet. inbuxa: still
+                            // File indexing not implemented yet
-                            // one result per task: update_tasks pairs them by
-                            // position, and a missing one shifts every result
-                            // after it onto the wrong task
-                            results.push(IndexTaskResult {
-                                task_type: TaskType::Insert,
-                                index: task.document_type,
-                                result: TaskResult::Ignored,
-                            });
                             continue;
                         }
                     };
@@ -575,14 +567,20 @@ async fn build_contact_document(
 }
 
 
-// inbuxa: MON-16: a trace's search document, when trace search is on
+// inbuxa: MON-16: a trace's search document, when trace search is on:
+// its event types, queue ids, and addresses, their domains, hosts, IPs,
+// message ids and account names as keywords
 async fn build_tracing_span_document(
     server: &Server,
     span_id: u64,
 ) -> trc::Result<Option<IndexDocument>> {
     use common::telemetry::tracers::store::MaybeTrace;
-    use registry::schema::structs::Search;
+    use registry::schema::{enums::SearchTracingField, structs::Search};
-    use store::write::{TelemetryClass, ValueClass};
+    use store::{
+        search::TracingSearchField,
+        write::{TelemetryClass, ValueClass},
+    };
+    use trc::Key;
 
     let settings = server
         .registry()
@@ -592,6 +590,7 @@ async fn build_tracing_span_document(
     if !settings.index_telemetry {
         return Ok(None);
     }
+    let wants = |field: SearchTracingField| settings.index_tracing_fields.iter().any(|f| *f == field);
     let Some(MaybeTrace(Some(trace))) = server
         .tracing_store()
         .get_value::<MaybeTrace>(ValueKey::from(ValueClass::Telemetry(TelemetryClass::Span(
@@ -602,67 +601,23 @@ async fn build_tracing_span_document(
         return Ok(None);
     };
 
-    Ok(Some(trace_search_document(
-        span_id,
-        &trace,
-        &settings
-            .index_tracing_fields
-            .iter()
-            .copied()
-            .collect::<Vec<_>>(),
-    )))
-}
-
-/// inbuxa: MON-16: the search document for a stored trace.
-///
-/// The event type and queue id columns are integers on every search backend
-/// (BIGINT on PostgreSQL and MySQL, long on Elasticsearch), and each holds a
-/// single value per trace: the event type is the trace's opening event, the
-/// one `x:Trace/query` filters on, and the queue id is the first queue id the
-/// trace mentions. Every queue id also goes into the keywords, so a session
-/// that queued several messages is found by any of them.
-pub fn trace_search_document(
-    span_id: u64,
-    trace: &registry::schema::structs::Trace,
-    fields: &[registry::schema::enums::SearchTracingField],
-) -> IndexDocument {
-    use registry::schema::{enums::SearchTracingField, structs::TraceValue};
-    use store::search::TracingSearchField;
-    use trc::Key;
-
-    let wants = |field: SearchTracingField| fields.contains(&field);
     let mut document = IndexDocument::new(SearchIndex::Tracing).with_id(span_id);
-    if wants(SearchTracingField::EventType)
-        && let Some(first) = trace.events.iter().next()
-    {
-        document.index_unsigned(TracingSearchField::EventType, first.event.to_id() as u64);
-    }
-
     let mut seen = store::ahash::AHashSet::new();
-    let mut queue_id_indexed = false;
     for event in trace.events.iter() {
+        if wants(SearchTracingField::EventType) && seen.insert(event.event.as_str().to_string()) {
+            document.index_keyword(TracingSearchField::EventType, event.event.as_str());
+        }
         for kv in event.key_values.iter() {
             let text = match &kv.value {
-                TraceValue::String(v) => v.value.clone(),
+                registry::schema::structs::TraceValue::String(v) => v.value.clone(),
-                TraceValue::UnsignedInt(v) => v.value.to_string(),
+                registry::schema::structs::TraceValue::UnsignedInt(v) => v.value.to_string(),
-                TraceValue::IpAddr(v) => v.value.to_string(),
+                registry::schema::structs::TraceValue::IpAddr(v) => v.value.to_string(),
                 _ => continue,
             };
             match kv.key {
-                Key::QueueId => {
+                Key::QueueId if wants(SearchTracingField::QueueId) => {
-                    let Ok(queue_id) = text.parse::<u64>() else {
+                    if seen.insert(format!("q:{text}")) {
-                        continue;
+                        document.index_keyword(TracingSearchField::QueueId, &text);
-                    };
-                    if wants(SearchTracingField::QueueId) && !queue_id_indexed {
-                        document.index_unsigned(TracingSearchField::QueueId, queue_id);
-                        queue_id_indexed = true;
-                    }
-                    if wants(SearchTracingField::Keywords) && seen.insert(format!("k:{text}")) {
-                        document.index_text(
-                            TracingSearchField::Keywords,
-                            &text,
-                            nlp::language::Language::None,
-                        );
                     }
                 }
                 Key::From
@@ -693,7 +648,7 @@ pub fn trace_search_document(
             }
         }
     }
-    document
+    Ok(Some(document))
 }
 
 // inbuxa: UD-1, UD-4: archives a deleted file, event or contact noted at

crates/services/src/task_manager/lock.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::task_manager::*;
@@ -15,21 +13,13 @@ pub trait TaskLockManager: Sync + Send {
 
 impl TaskLockManager for Server {
     async fn try_lock_task(&self, id: u64) -> bool {
-        // inbuxa: a node that is stopping claims nothing new
-        let locks = &self.inner.ipc.task_locks;
-        if locks.is_stopping() {
-            return false;
-        }
-
         match self
             .in_memory_store()
-            .try_lock(KV_LOCK_TASK, &id.to_be_bytes(), locks.expiry())
+            .try_lock(KV_LOCK_TASK, &id.to_be_bytes(), DEFAULT_LOCK_EXPIRY)
             .await
         {
             Ok(result) => {
-                if result {
+                if !result {
-                    locks.insert(id);
-                } else {
                     trc::event!(
                         TaskManager(TaskManagerEvent::TaskLocked),
                         Id = id,
@@ -58,66 +48,5 @@ impl TaskLockManager for Server {
                     .caused_by(trc::location!())
             );
         }
-        self.inner.ipc.task_locks.remove(id);
     }
 }
-
-/// inbuxa: on a graceful stop, stops claiming tasks and releases every task
-/// lock this node holds, so the rest of the cluster can pick the tasks up at
-/// once instead of after the lock expires. Returns how many were released.
-pub async fn release_task_locks(server: &Server) -> usize {
-    let ids = server.inner.ipc.task_locks.stop();
-    for id in &ids {
-        if let Err(err) = server
-            .in_memory_store()
-            .remove_lock(KV_LOCK_TASK, &id.to_be_bytes())
-            .await
-        {
-            trc::error!(
-                err.details("Failed to release task lock on shutdown")
-                    .ctx(trc::Key::Id, *id)
-                    .caused_by(trc::location!())
-            );
-        }
-    }
-    ids.len()
-}
-
-/// inbuxa: renews the lease on every task this node is running, so it stays
-/// claimed for as long as it runs while a node that dies loses its claims
-/// within one lock lifetime. Returns how many leases were renewed and how
-/// many were found lost (expired, perhaps taken by another node).
-pub async fn renew_task_locks(server: &Server) -> (usize, usize) {
-    let locks = &server.inner.ipc.task_locks;
-    let expiry = locks.expiry();
-    let (mut renewed, mut lost) = (0, 0);
-    for id in locks.held_ids() {
-        match server
-            .in_memory_store()
-            .renew_lock(KV_LOCK_TASK, &id.to_be_bytes(), expiry)
-            .await
-        {
-            Ok(true) => renewed += 1,
-            Ok(false) => {
-                // Still held here as far as this node knows; the task
-                // finishes and its lock is removed as usual
-                if locks.is_held(id) {
-                    lost += 1;
-                    trc::event!(
-                        TaskManager(TaskManagerEvent::TaskLocked),
-                        Id = id,
-                        Details = "Task lock expired while the task was running",
-                    );
-                }
-            }
-            Err(err) => {
-                trc::error!(
-                    err.details("Failed to renew task lock")
-                        .ctx(trc::Key::Id, id)
-                        .caused_by(trc::location!())
-                );
-            }
-        }
-    }
-    (renewed, lost)
-}

crates/services/src/task_manager/manager.rs

@@ -13,23 +13,23 @@ use crate::task_manager::dkim::DkimManagementTask;
 use crate::task_manager::dns::DnsManagementTask;
 use crate::task_manager::imip::SendImipTask;
 use crate::task_manager::index::SearchIndexTask;
-use crate::task_manager::lock::{TaskLockManager, renew_task_locks};
+use crate::task_manager::lock::TaskLockManager;
 use crate::task_manager::maintenance::MaintenanceTask;
 use crate::task_manager::merge_threads::MergeThreadsTask;
 use crate::task_manager::report::{self, SubmitReportTask};
 use crate::task_manager::restore_item::RestoreItemTask;
 use crate::task_manager::spam_classifier::SpamFilterMaintenanceTask;
 use crate::task_manager::{
-    CLAIM_RECHECK_INTERVAL, Locked, QUEUE_REFRESH_INTERVAL, TaskDetails, TaskFailureType, TaskInfo,
+    DEFAULT_LOCK_EXPIRY, Locked, QUEUE_REFRESH_INTERVAL, TaskDetails, TaskFailureType, TaskInfo,
     TaskJob, TaskManagerIpc, TaskResult,
 };
 use common::BuildServer;
-use common::config::network::ClusterRoles;
 use common::config::server::{DEFAULT_TLS_TIMEOUT, ServerProtocol};
 use common::network::limiter::ConcurrencyLimiter;
 use common::network::{ServerInstance, TcpAcceptor};
 use common::{Inner, Server};
 use registry::schema::enums::TaskType;
+use registry::schema::prelude::ObjectType;
 use registry::schema::structs::{
     Task, TaskManager, TaskRetryStrategy, TaskStatus, TaskStatusFailed, TaskStatusRetry,
 };
@@ -55,37 +55,24 @@ const PERPETUAL_RETRY_MIN_DELAY: u64 = 3600;
 const PERPETUAL_RETRY_MAX_DELAY: u64 = 21600;
 
 pub fn spawn_task_manager(inner: Arc<Inner>) {
-    // inbuxa: upstream didn't start the task manager on a node whose role
+    let is_clustered = {
-    // had no task types at boot, so adding one later did nothing until a
+        let server = inner.build_server();
-    // restart. It now always runs and reads the role on every scan and
+        let roles = &server.core.network.roles;
-    // before every job (task_enabled), so a role change applies at the next
+
-    // settings reload.
+        if !roles.account_maintenance
-    let is_clustered = inner.build_server().core.storage.coordinator.is_enabled();
+            && !roles.store_maintenance
+            && !roles.search_indexing
+            && !roles.spam_training
+            && !roles.task_manager
+        {
+            return;
+        }
+
+        server.core.storage.coordinator.is_enabled()
+    };
 
     trc::event!(TaskManager(TaskManagerEvent::ManagerStarted));
 
-    // inbuxa: keep the leases of running tasks alive, every third of a lock
-    // lifetime, until the node stops
-    {
-        let inner = inner.clone();
-        tokio::spawn(async move {
-            let mut renewed_at = Instant::now();
-            loop {
-                tokio::time::sleep(Duration::from_secs(1)).await;
-                let locks = &inner.ipc.task_locks;
-                if locks.is_stopping() {
-                    break;
-                }
-                if renewed_at.elapsed() >= Duration::from_secs((locks.expiry() / 3).max(1)) {
-                    renewed_at = Instant::now();
-                    if locks.held() > 0 {
-                        renew_task_locks(&inner.build_server()).await;
-                    }
-                }
-            }
-        });
-    }
-
     // Create dummy server instance for alarms
     let server_instance = Arc::new(ServerInstance {
         id: "_local".to_string(),
@@ -140,50 +127,72 @@ pub fn spawn_task_manager(inner: Arc<Inner>) {
                     let server = inner.build_server();
                     let batch_size = server.core.email.index_batch_size;
                     let mut batch = Vec::with_capacity(batch_size);
-                    if let Some(task) = fetch_enabled_task(&server, job).await {
+                    match server
-                        batch.push(task);
+                        .store()
+                        .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
+                            TaskQueueClass::Task { id: job.id },
+                        )))
+                        .await
+                    {
+                        Ok(Some(task)) => {
+                            batch.push(TaskDetails { task, info: job });
+                        }
+                        Ok(None) => {
+                            trc::event!(
+                                TaskManager(TaskManagerEvent::TaskIgnored),
+                                Id = job.id,
+                                Reason = "Task not found in store, likely already processed.",
+                            );
+                        }
+                        Err(err) => {
+                            trc::error!(
+                                err.id(job.id)
+                                    .details("Failed to retrieve task details.")
+                                    .caused_by(trc::location!())
+                            );
+                        }
                     }
 
                     while batch.len() < batch_size {
                         match rx.try_recv() {
                             Ok(job) => {
-                                if let Some(task) = fetch_enabled_task(&server, job).await {
+                                match server
-                                    batch.push(task);
+                                    .store()
+                                    .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
+                                        TaskQueueClass::Task { id: job.id },
+                                    )))
+                                    .await
+                                {
+                                    Ok(Some(task)) => {
+                                        batch.push(TaskDetails { task, info: job });
+                                    }
+                                    Ok(None) => {
+                                        trc::event!(
+                                            TaskManager(TaskManagerEvent::TaskIgnored),
+                                            Id = job.id,
+                                            Reason = "Task not found in store, likely already processed.",
+                                        );
+                                    }
+                                    Err(err) => {
+                                        trc::error!(
+                                            err.id(job.id)
+                                                .details("Failed to retrieve task details.")
+                                                .caused_by(trc::location!())
+                                        );
+                                    }
                                 }
                             }
                             Err(_) => break,
                         }
                     }
-                    if batch.is_empty() {
-                        continue;
-                    }
 
-                    // Dispatch. inbuxa: on a task of its own, so a panic
+                    // Dispatch
-                    // releases the batch's locks and leaves this worker
-                    // running; a dead worker would keep claiming tasks it
-                    // can never run
                     let mut refresh_queue = false;
-                    let ids = batch.iter().map(|task| task.info.id).collect::<Vec<_>>();
+                    let results = server.index(&batch).await.into_iter().map(|r| {
-                    let run = {
+                        refresh_queue |= r.result.is_retry();
-                        let server = server.clone();
+                        r.result
-                        tokio::spawn(async move {
+                    });
-                            let results = server.index(&batch).await;
+                    update_tasks(&server, &mut batch, results).await;
-                            (batch, results)
-                        })
-                    };
-                    match run.await {
-                        Ok((mut batch, results)) => {
-                            let results = results.into_iter().map(|r| {
-                                refresh_queue |= r.result.is_retry();
-                                r.result
-                            });
-                            update_tasks(&server, &mut batch, results).await;
-                        }
-                        Err(err) => {
-                            worker_failed(&server, &ids, err).await;
-                            refresh_queue = true;
-                        }
-                    }
 
                     if refresh_queue || rx.is_empty() {
                         server.notify_task_queue();
@@ -197,32 +206,83 @@ pub fn spawn_task_manager(inner: Arc<Inner>) {
                     let server = inner.build_server();
                     let mut refresh_queue = false;
 
-                    if let Some(TaskDetails { task, info }) = fetch_enabled_task(&server, job).await
+                    match server
+                        .store()
+                        .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
+                            TaskQueueClass::Task { id: job.id },
+                        )))
+                        .await
                     {
-                        // inbuxa: on a task of its own, as above
+                        Ok(Some(task)) => {
-                        let run = {
+                            let result = match &task {
-                            let server = server.clone();
+                                Task::CalendarAlarmEmail(task) => {
-                            let server_instance = server_instance.clone();
+                                    server.send_email_alarm(task, server_instance.clone()).await
-                            tokio::spawn(async move {
+                                }
-                                let result = run_task(&server, &task, server_instance).await;
+                                Task::CalendarAlarmNotification(task) => {
-                                (task, result)
+                                    server.send_display_alarm(task).await
-                            })
+                                }
-                        };
+                                Task::CalendarItipMessage(task) => {
-                        match run.await {
+                                    server.send_imip(task, server_instance.clone()).await
-                            Ok((task, result)) => {
+                                }
-                                refresh_queue = result.is_retry();
+                                Task::MergeThreads(task) => server.merge_threads(task).await,
+                                Task::DmarcReport(task) => {
+                                    server
+                                        .submit_report(report::ReportId::Dmarc(task.report_id.id()))
+                                        .await
+                                }
+                                Task::TlsReport(task) => {
+                                    server
+                                        .submit_report(report::ReportId::Tls(task.report_id.id()))
+                                        .await
+                                }
+                                Task::RestoreArchivedItem(task) => server.restore_item(task).await,
+                                Task::DestroyAccount(task) => server.destroy_account(task).await,
+                                Task::AccountMaintenance(task) => {
+                                    server.account_maintenance(task).await
+                                }
+                                Task::TenantMaintenance(task) => {
+                                    server.tenant_maintenance(task).await
+                                }
+                                Task::StoreMaintenance(task) => {
+                                    server.store_maintenance(task).await
+                                }
+                                Task::SpamFilterMaintenance(task) => {
+                                    Box::pin(server.spam_filter_maintenance(task)).await
+                                }
+                                Task::AcmeRenewal(task) => server.acme_management(task).await,
+                                Task::DkimManagement(task_dkim_rotation) => {
+                                    server.dkim_management(task_dkim_rotation).await
+                                }
+                                Task::DnsManagement(task_dns_management) => {
+                                    server.dns_management(task_dns_management).await
+                                }
+                                Task::IndexDocument(_)
+                                | Task::UnindexDocument(_)
+                                | Task::IndexTrace(_) => unreachable!(),
+                            };
 
-                                update_tasks(
+                            refresh_queue = result.is_retry();
-                                    &server,
+
-                                    &mut [TaskDetails { task, info }],
+                            update_tasks(
-                                    vec![result],
+                                &server,
-                                )
+                                &mut [TaskDetails { task, info: job }],
-                                .await;
+                                vec![result],
-                            }
+                            )
-                            Err(err) => {
+                            .await;
-                                worker_failed(&server, &[info.id], err).await;
+                        }
-                                refresh_queue = true;
+                        Ok(None) => {
-                            }
+                            trc::event!(
+                                TaskManager(TaskManagerEvent::TaskIgnored),
+                                Id = job.id,
+                                Reason = "Task not found in store, likely already processed.",
+                            );
+                        }
+                        Err(err) => {
+                            trc::error!(
+                                err.id(job.id)
+                                    .details("Failed to retrieve task details.")
+                                    .caused_by(trc::location!())
+                            );
                         }
                     }
 
@@ -261,24 +321,6 @@ pub(crate) trait TaskQueueManager: Sync + Send {
 
 impl TaskQueueManager for Server {
     async fn process_tasks(&self, ipc: &mut TaskManagerIpc) -> Duration {
-        // inbuxa: a node that is stopping has released its locks and claims
-        // nothing new
-        let task_locks = &self.inner.ipc.task_locks;
-        if task_locks.is_stopping() {
-            return Duration::from_secs(QUEUE_REFRESH_INTERVAL);
-        }
-        // inbuxa: with no task type enabled by this node's role there is
-        // nothing to claim; a settings reload wakes the manager when that
-        // changes
-        let roles = &self.core.network.roles;
-        if !(0..TaskType::COUNT as u16)
-            .filter_map(TaskType::from_id)
-            .any(|task_type| task_enabled(roles, task_type))
-        {
-            ipc.locked.clear();
-            return Duration::from_secs(QUEUE_REFRESH_INTERVAL);
-        }
-        let lock_expiry = task_locks.expiry();
         let now_timestamp = now();
         let from_key = ValueKey::<ValueClass> {
             account_id: 0,
@@ -298,8 +340,10 @@ impl TaskQueueManager for Server {
 
         // Retrieve tasks pending to be processed
         let mut tasks = Vec::new();
+        let mut unreadable = Vec::new();
         let now = Instant::now();
         let mut next_event = None;
+        let roles = &self.core.network.roles;
         ipc.revision += 1;
         let _ = self
             .store()
@@ -311,19 +355,41 @@ impl TaskQueueManager for Server {
                         let task_id = key.deserialize_be_u64(U64_LEN)?;
 
                         if task_due <= now_timestamp {
-                            let task_type_idx = value.deserialize_be_u16(0)?;
+                            // inbuxa: a row whose task type can't be read is
-                            let task_type = TaskType::from_id(task_type_idx).ok_or_else(|| {
+                            // set aside, not allowed to end the scan: every
-                                trc::StoreEvent::DataCorruption
+                            // task due after it would wait behind it
-                                    .caused_by(trc::location!())
+                            let Some((task_type_idx, task_type)) = value
-                                    .ctx(trc::Key::Value, value)
+                                .deserialize_be_u16(0)
-                            })?;
+                                .ok()
-                            // inbuxa: running here under a lease this node
+                                .and_then(|idx| TaskType::from_id(idx).map(|typ| (idx, typ)))
-                            // renews; don't hand it to a worker again
+                            else {
-                            if task_locks.is_held(task_id) {
+                                unreadable.push(UnreadableDueRow {
+                                    due: task_due,
+                                    id: task_id,
+                                    value: value.to_vec(),
+                                });
                                 return Ok(true);
-                            }
+                            };
-
+                            let enabled = match task_type {
-                            let enabled = task_enabled(roles, task_type);
+                                TaskType::IndexDocument
+                                | TaskType::UnindexDocument
+                                | TaskType::IndexTrace => roles.search_indexing,
+                                TaskType::AccountMaintenance
+                                | TaskType::TenantMaintenance
+                                | TaskType::DestroyAccount => roles.account_maintenance,
+                                TaskType::StoreMaintenance => roles.store_maintenance,
+                                TaskType::SpamFilterMaintenance => roles.spam_training,
+                                TaskType::CalendarAlarmEmail
+                                | TaskType::CalendarAlarmNotification
+                                | TaskType::CalendarItipMessage
+                                | TaskType::MergeThreads
+                                | TaskType::DmarcReport
+                                | TaskType::TlsReport
+                                | TaskType::RestoreArchivedItem
+                                | TaskType::AcmeRenewal
+                                | TaskType::DkimManagement
+                                | TaskType::DnsManagement => true,
+                            };
 
                             if !enabled {
                                 trc::event!(
@@ -340,7 +406,9 @@ impl TaskQueueManager for Server {
                                     let locked = entry.get_mut();
                                     if locked.expires <= now || locked.due < task_due {
                                         locked.expires = Instant::now()
-                                            + std::time::Duration::from_secs(lock_expiry + 1);
+                                            + std::time::Duration::from_secs(
+                                                DEFAULT_LOCK_EXPIRY + 1,
+                                            );
                                         locked.due = task_due;
                                         tasks.push((
                                             TaskJob {
@@ -356,7 +424,9 @@ impl TaskQueueManager for Server {
                                 Entry::Vacant(entry) => {
                                     entry.insert(Locked {
                                         expires: Instant::now()
-                                            + std::time::Duration::from_secs(lock_expiry + 1),
+                                            + std::time::Duration::from_secs(
+                                                DEFAULT_LOCK_EXPIRY + 1,
+                                            ),
                                         due: task_due,
                                         revision: ipc.revision,
                                     });
@@ -389,6 +459,11 @@ impl TaskQueueManager for Server {
                 );
             });
 
+        if !unreadable.is_empty() && repair_due_rows(self, unreadable).await {
+            // Look again at once for the rows that were rewritten
+            self.notify_task_queue();
+        }
+
         if !tasks.is_empty() {
             trc::event!(
                 TaskManager(TaskManagerEvent::TaskAcquired),
@@ -407,26 +482,12 @@ impl TaskQueueManager for Server {
             let tx = &ipc.txs[task_type_idx as usize];
 
             if tx.capacity() > 0 {
-                let id = task_job.id;
+                if self.try_lock_task(task_job.id).await && tx.send(task_job).await.is_err() {
-                if !self.try_lock_task(id).await {
-                    // inbuxa: another node holds the task. Look again after a
-                    // short while rather than a full lock lifetime from now:
-                    // the holder may have claimed it after this scan began,
-                    // or run on a clock ahead of this one, and waiting the
-                    // whole lifetime again would leave the task stuck for
-                    // another hour past its lock if that holder died
-                    if let Some(locked) = ipc.locked.get_mut(&id) {
-                        locked.expires =
-                            Instant::now() + Duration::from_secs(claim_recheck_interval(lock_expiry));
-                    }
-                } else if tx.send(task_job).await.is_err() {
                     trc::event!(
                         Server(trc::ServerEvent::ThreadError),
                         Details = "Error sending task.",
                         CausedBy = trc::location!()
                     );
-                    // inbuxa: nothing will run it here, so don't hold it
-                    self.remove_index_lock(id).await;
                 }
             } else {
                 // If the channel is full, release the lock so it can be picked up in the next iteration
@@ -438,178 +499,9 @@ impl TaskQueueManager for Server {
         let now = Instant::now();
         ipc.locked
             .retain(|_, locked| locked.expires > now && locked.revision == ipc.revision);
-        let sleep_for = Duration::from_secs(next_event.map_or(QUEUE_REFRESH_INTERVAL, |timestamp| {
+        Duration::from_secs(next_event.map_or(QUEUE_REFRESH_INTERVAL, |timestamp| {
             timestamp.saturating_sub(store::write::now())
-        }));
+        }))
-
-        // inbuxa: wake up when a claim held elsewhere is due to be tried
-        // again, rather than only on the next task or refresh
-        ipc.locked
-            .values()
-            .map(|locked| locked.expires.saturating_duration_since(now))
-            .min()
-            .map_or(sleep_for, |recheck| sleep_for.min(recheck.max(Duration::from_secs(1))))
-    }
-}
-
-/// inbuxa: whether this node's cluster role lets it run a task type. Upstream
-/// checked the dedicated roles (search indexing, account and store
-/// maintenance, spam training) and let every node with a task manager run
-/// the rest, whatever its taskQueueProcessing setting. Every task type now
-/// answers to one ClusterTaskType:
-///
-/// - IndexDocument, UnindexDocument, IndexTrace: searchIndexing
-/// - AccountMaintenance, TenantMaintenance, DestroyAccount: accountMaintenance
-/// - StoreMaintenance: storeMaintenance
-/// - SpamFilterMaintenance: spamClassifierTraining
-/// - DmarcReport, TlsReport: outboundMta. They build and send reports to
-///   other domains (TLS reports can go straight to an HTTPS endpoint), which
-///   is the outbound MTA's business.
-/// - CalendarAlarmEmail, CalendarAlarmNotification, CalendarItipMessage,
-///   MergeThreads, RestoreArchivedItem, AcmeRenewal, DkimManagement,
-///   DnsManagement: taskQueueProcessing, the role for queue tasks with no
-///   role of their own.
-///
-/// A node that may not run a task leaves it unclaimed, so a node that may
-/// picks it up.
-pub fn task_enabled(roles: &ClusterRoles, task_type: TaskType) -> bool {
-    match task_type {
-        TaskType::IndexDocument | TaskType::UnindexDocument | TaskType::IndexTrace => {
-            roles.search_indexing
-        }
-        TaskType::AccountMaintenance | TaskType::TenantMaintenance | TaskType::DestroyAccount => {
-            roles.account_maintenance
-        }
-        TaskType::StoreMaintenance => roles.store_maintenance,
-        TaskType::SpamFilterMaintenance => roles.spam_training,
-        TaskType::DmarcReport | TaskType::TlsReport => roles.outbound_mta,
-        TaskType::CalendarAlarmEmail
-        | TaskType::CalendarAlarmNotification
-        | TaskType::CalendarItipMessage
-        | TaskType::MergeThreads
-        | TaskType::RestoreArchivedItem
-        | TaskType::AcmeRenewal
-        | TaskType::DkimManagement
-        | TaskType::DnsManagement => roles.task_manager,
-    }
-}
-
-async fn run_task(
-    server: &Server,
-    task: &Task,
-    server_instance: Arc<ServerInstance>,
-) -> TaskResult {
-    match task {
-        Task::CalendarAlarmEmail(task) => {
-            server.send_email_alarm(task, server_instance.clone()).await
-        }
-        Task::CalendarAlarmNotification(task) => {
-            server.send_display_alarm(task).await
-        }
-        Task::CalendarItipMessage(task) => {
-            server.send_imip(task, server_instance.clone()).await
-        }
-        Task::MergeThreads(task) => server.merge_threads(task).await,
-        Task::DmarcReport(task) => {
-            server
-                .submit_report(report::ReportId::Dmarc(task.report_id.id()))
-                .await
-        }
-        Task::TlsReport(task) => {
-            server
-                .submit_report(report::ReportId::Tls(task.report_id.id()))
-                .await
-        }
-        Task::RestoreArchivedItem(task) => server.restore_item(task).await,
-        Task::DestroyAccount(task) => server.destroy_account(task).await,
-        Task::AccountMaintenance(task) => {
-            server.account_maintenance(task).await
-        }
-        Task::TenantMaintenance(task) => {
-            server.tenant_maintenance(task).await
-        }
-        Task::StoreMaintenance(task) => {
-            server.store_maintenance(task).await
-        }
-        Task::SpamFilterMaintenance(task) => {
-            Box::pin(server.spam_filter_maintenance(task)).await
-        }
-        Task::AcmeRenewal(task) => server.acme_management(task).await,
-        Task::DkimManagement(task_dkim_rotation) => {
-            server.dkim_management(task_dkim_rotation).await
-        }
-        Task::DnsManagement(task_dns_management) => {
-            server.dns_management(task_dns_management).await
-        }
-        Task::IndexDocument(_)
-        | Task::UnindexDocument(_)
-        | Task::IndexTrace(_) => unreachable!(),
-    }
-}
-
-/// inbuxa: reads a claimed task when this node's role still allows its type.
-/// The role may have changed since the task was claimed (a settings reload in
-/// between); the claim is then handed back at once for a node that may run
-/// it, rather than held until the lease runs out.
-async fn fetch_enabled_task(server: &Server, job: TaskJob) -> Option<TaskDetails> {
-    if task_enabled(&server.core.network.roles, job.typ) {
-        fetch_task(server, job).await
-    } else {
-        trc::event!(
-            TaskManager(TaskManagerEvent::TaskIgnored),
-            Id = job.id,
-            Details = job.typ.as_str(),
-            Reason = "Task type was disabled by cluster roles after it was claimed.",
-        );
-        server.remove_index_lock(job.id).await;
-        None
-    }
-}
-
-/// Reads a claimed task. When it is gone or can't be read, the claim is
-/// released: inbuxa: holding it would block the task, everywhere, until
-/// the lock expired.
-async fn fetch_task(server: &Server, job: TaskJob) -> Option<TaskDetails> {
-    match server
-        .store()
-        .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(TaskQueueClass::Task {
-            id: job.id,
-        })))
-        .await
-    {
-        Ok(Some(task)) => Some(TaskDetails { task, info: job }),
-        Ok(None) => {
-            trc::event!(
-                TaskManager(TaskManagerEvent::TaskIgnored),
-                Id = job.id,
-                Reason = "Task not found in store, likely already processed.",
-            );
-            server.remove_index_lock(job.id).await;
-            None
-        }
-        Err(err) => {
-            trc::error!(
-                err.id(job.id)
-                    .details("Failed to retrieve task details.")
-                    .caused_by(trc::location!())
-            );
-            server.remove_index_lock(job.id).await;
-            None
-        }
-    }
-}
-
-/// inbuxa: a task panicked: its locks are released so it runs again, here or
-/// on another node, and the worker carries on.
-async fn worker_failed(server: &Server, ids: &[u64], err: tokio::task::JoinError) {
-    trc::event!(
-        Server(trc::ServerEvent::ThreadError),
-        Details = "Task worker failed",
-        Reason = err.to_string(),
-        CausedBy = trc::location!()
-    );
-    for id in ids {
-        server.remove_index_lock(*id).await;
     }
 }
 
@@ -740,13 +632,6 @@ async fn update_tasks(
     }
 }
 
-/// inbuxa: how long to wait before trying again to claim a task another node
-/// holds: a twelfth of the lock lifetime, so five minutes for the one-hour
-/// lock, never more than that and never under a second.
-pub(crate) fn claim_recheck_interval(lock_expiry: u64) -> u64 {
-    (lock_expiry / 12).clamp(1, CLAIM_RECHECK_INTERVAL)
-}
-
 pub fn perpetual_retry_time(typ: TaskType, attempt: u64) -> Option<u64> {
     matches!(
         typ,
@@ -819,3 +704,114 @@ impl TaskResult {
         )
     }
 }
+
+/// inbuxa: a task queue row whose task type could not be read.
+struct UnreadableDueRow {
+    due: u64,
+    id: u64,
+    value: Vec<u8>,
+}
+
+/// inbuxa: logs each unreadable queue row and repairs it from the task it
+/// schedules. The task row says what the task is, so the queue row is
+/// rewritten with that task's type; a row with no task behind it is removed.
+///
+/// Rescheduling an internal DMARC or TLS report wrote the report's object
+/// type into the queue row instead of the task type. Such a row is the time
+/// an administrator chose, so the task is moved to it as the reschedule
+/// meant to do: the task row takes that due, and a queue row left at the
+/// task's previous due is removed. Returns whether any row was repaired.
+async fn repair_due_rows(server: &Server, rows: Vec<UnreadableDueRow>) -> bool {
+    let mut repaired = false;
+    for row in rows {
+        let UnreadableDueRow { due, id, value } = row;
+        trc::error!(
+            trc::StoreEvent::DataCorruption
+                .into_err()
+                .id(id)
+                .ctx(trc::Key::Due, trc::Value::Timestamp(due))
+                .ctx(
+                    trc::Key::Key,
+                    [due.to_be_bytes(), id.to_be_bytes()].concat()
+                )
+                .ctx(trc::Key::Value, value.clone())
+                .details("Unreadable task queue row skipped")
+                .caused_by(trc::location!())
+        );
+
+        let task_key = ValueClass::TaskQueue(TaskQueueClass::Task { id });
+        let due_key = ValueClass::TaskQueue(TaskQueueClass::Due { id, due });
+        let task = match server
+            .store()
+            .get_value::<Task>(ValueKey::from(task_key.clone()))
+            .await
+        {
+            Ok(task) => task,
+            Err(err) => {
+                trc::error!(
+                    err.id(id)
+                        .details("Failed to read the task of an unreadable queue row.")
+                        .caused_by(trc::location!())
+                );
+                continue;
+            }
+        };
+
+        let mut batch = BatchBuilder::new();
+        let action = if let Some(mut task) = task {
+            let task_type = task.object_type();
+            batch.assert_value(task_key.clone(), AssertValue::Some);
+            if rescheduled_report_type(&value) == Some(task_type) {
+                let old_due = task.due_timestamp();
+                if old_due != due {
+                    batch.clear(ValueClass::TaskQueue(TaskQueueClass::Due {
+                        id,
+                        due: old_due,
+                    }));
+                }
+                task.set_status(TaskStatus::at(due as i64));
+            }
+            batch
+                .set(due_key, task_type.to_id().serialize())
+                .set(task_key, task.to_pickled_vec());
+            "Rewrote the queue row from its task."
+        } else {
+            batch.clear(due_key);
+            "Removed a queue row with no task."
+        };
+
+        match server.store().write(batch.build_all()).await {
+            Ok(_) => {
+                repaired = true;
+                trc::event!(
+                    TaskManager(TaskManagerEvent::TaskIgnored),
+                    Id = id,
+                    Due = trc::Value::Timestamp(due),
+                    Reason = action,
+                );
+            }
+            Err(err) if err.matches(trc::EventType::Store(trc::StoreEvent::AssertValueFailed)) => {
+                // The task went away meanwhile; the next scan looks again
+            }
+            Err(err) => {
+                trc::error!(
+                    err.id(id)
+                        .details("Failed to repair an unreadable queue row.")
+                        .caused_by(trc::location!())
+                );
+            }
+        }
+    }
+    repaired
+}
+
+/// inbuxa: the task type a report reschedule meant, when a queue row holds
+/// an internal report's object type (the value that reschedule wrote).
+fn rescheduled_report_type(value: &[u8]) -> Option<TaskType> {
+    let id = u16::from_be_bytes(value.get(..2)?.try_into().ok()?);
+    match ObjectType::from_id(id)? {
+        ObjectType::DmarcInternalReport => Some(TaskType::DmarcReport),
+        ObjectType::TlsInternalReport => Some(TaskType::TlsReport),
+        _ => None,
+    }
+}

crates/services/src/task_manager/mod.rs

@@ -35,9 +35,7 @@ pub mod scheduler;
 pub mod spam_classifier;
 
 const QUEUE_REFRESH_INTERVAL: u64 = 60 * 5; // 5 minutes
-// inbuxa: the lock lifetime (one hour) lives in common::ipc::TaskLocks, per
+const DEFAULT_LOCK_EXPIRY: u64 = 60 * 60; // 1 hour
-// server, so a graceful stop can release the locks and the tests can shorten it
-const CLAIM_RECHECK_INTERVAL: u64 = 60 * 5; // 5 minutes
 
 pub(crate) struct TaskManagerIpc {
     txs: [mpsc::Sender<TaskJob>; TaskType::COUNT],

crates/smtp/src/inbound/milter/client.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use common::config::smtp::session::Milter;
@@ -27,19 +25,7 @@ impl MilterClient<TcpStream> {
     pub async fn connect(config: &Milter, session_id: u64) -> Result<Self> {
         tokio::time::timeout(config.timeout_command, async {
             let mut last_err = Error::Disconnected;
-            // inbuxa: a hostname is resolved here, per connection, rather
+            for addr in &config.addrs {
-            // than while the settings are built
-            let resolved;
-            let addrs = if config.addrs.is_empty() {
-                resolved = tokio::net::lookup_host((config.hostname.as_str(), config.port))
-                    .await
-                    .map_err(Error::Io)?
-                    .collect::<Vec<_>>();
-                &resolved
-            } else {
-                &config.addrs
-            };
-            for addr in addrs {
                 match TcpStream::connect(addr).await {
                     Ok(stream) => {
                         return Ok(MilterClient {

crates/smtp/src/lib.rs

@@ -44,14 +44,7 @@ impl StartQueueManager for BootManager {
 impl SpawnQueueManager for IpcReceivers {
     fn spawn_queue_manager(&mut self, inner: Arc<Inner>) {
         let core = inner.shared_core.load();
-        // inbuxa: upstream started these only when the node's role included
+        if !core.storage.registry.is_recovery_mode() && core.network.roles.outbound_mta {
-        // outboundMta at boot, so turning the role on later did nothing and
-        // turning it off left them delivering until a restart. They now run
-        // on every node and follow the role live (see Queue::start and the
-        // report scheduler). This also drains the queue channel on nodes
-        // without the role, where every queued message's refresh used to sit
-        // in a channel nobody read until it filled and queueing blocked.
-        if !core.storage.registry.is_recovery_mode() {
             // Spawn queue manager
             self.queue_rx.take().unwrap().spawn(inner.clone());
 

crates/smtp/src/queue/manager.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::{Message, QueueId, Status, spool::SmtpSpool};
@@ -41,9 +39,6 @@ pub struct Queue {
     pub urgent_refresh: bool,
     pub last_scan: Instant,
     pub last_full_scan: Instant,
-    /// inbuxa: whether this node's role included outboundMta when last
-    /// checked (None before the first check)
-    pub role_enabled: Option<bool>,
 }
 
 #[derive(Debug)]
@@ -72,9 +67,6 @@ impl SpawnQueue for mpsc::Receiver<QueueEvent> {
 const BACK_PRESSURE_WARN_INTERVAL: Duration = Duration::from_secs(60);
 const MIN_SCAN_INTERVAL: Duration = Duration::from_millis(100);
 const FULL_SCAN_INTERVAL: Duration = Duration::from_secs(QUEUE_REFRESH / 2);
-/// inbuxa: how often a node without the outbound MTA role looks at its role
-/// again when nothing else wakes it (a settings reload does)
-const ROLE_RECHECK_INTERVAL: Duration = Duration::from_secs(30);
 
 impl Queue {
     pub fn new(core: Arc<Inner>, rx: mpsc::Receiver<QueueEvent>) -> Self {
@@ -95,7 +87,6 @@ impl Queue {
             urgent_refresh: false,
             last_scan: now.checked_sub(MIN_SCAN_INTERVAL).unwrap_or(now),
             last_full_scan: now,
-            role_enabled: None,
         }
     }
 
@@ -132,27 +123,6 @@ impl Queue {
                 continue;
             }
 
-            // inbuxa: follow the node's role live. Without outboundMta the
-            // queue claims nothing new; deliveries already running finish
-            // and report back as usual, releasing their locks. When the role
-            // comes back, the whole queue is scanned at once.
-            let role_enabled = self.core.shared_core.load().network.roles.outbound_mta;
-            if self.role_enabled.replace(role_enabled) == Some(false) && role_enabled {
-                trc::event!(
-                    Queue(trc::QueueEvent::Started),
-                    Details = "This node's cluster role now includes outboundMta",
-                );
-                self.scan_from = 0;
-                self.pending_refresh = true;
-                self.urgent_refresh = true;
-            }
-            if !role_enabled {
-                self.pending_refresh = false;
-                self.urgent_refresh = false;
-                self.next_refresh = Instant::now() + ROLE_RECHECK_INTERVAL;
-                continue;
-            }
-
             self.pending_refresh |= refresh_queue;
             if !self.pending_refresh && self.next_refresh > Instant::now() {
                 continue;

crates/smtp/src/reporting/index.rs

@@ -2,6 +2,8 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
+ *
+ * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use registry::{
@@ -40,35 +42,49 @@ pub trait InternalReportIndex: ObjectImpl {
 
     fn primary_key(&self) -> ValueClass;
 
+    /// Moves the report's delivery, and its queued task, to `at`.
+    ///
+    /// inbuxa: the new queue row carries the task's type, as
+    /// `schedule_task_with_id` writes it, and the task row gets the new due
+    /// too. `queued` is the task as stored: its due, not the report's
+    /// `deliverAt`, is the queue row that exists (they differ once the task
+    /// has been retried).
     fn reschedule_ops(
         &mut self,
         batch: &mut BatchBuilder,
         item_id: u64,
         revision: u64,
         at: UTCDateTime,
+        queued: Option<&Task>,
     ) {
         let current_deliver_at = self.deliver_at();
+        let current_due = current_deliver_at.timestamp() as u64;
+        let queued_due = queued.map_or(current_due, |task| task.due_timestamp());
+        let new_due = at.timestamp() as u64;
 
-        if current_deliver_at != at {
+        if current_deliver_at != at || queued_due != new_due {
             let object = Self::OBJECT;
             let object_id = object.to_id();
             let key = ValueClass::Registry(RegistryClass::Item { object_id, item_id });
 
             self.set_deliver_at(at);
 
-            batch
+            batch.assert_value(key.clone(), AssertValue::Hash(revision));
-                .assert_value(key.clone(), AssertValue::Hash(revision))
+            if queued_due != new_due {
-                .clear(ValueClass::TaskQueue(TaskQueueClass::Due {
+                batch.clear(ValueClass::TaskQueue(TaskQueueClass::Due {
                     id: item_id,
-                    due: current_deliver_at.timestamp() as u64,
+                    due: queued_due,
-                }))
+                }));
-                .set(
+            }
-                    ValueClass::TaskQueue(TaskQueueClass::Due {
+            // A row an earlier reschedule left at the report's deliverAt
-                        id: item_id,
+            if current_due != new_due && current_due != queued_due {
-                        due: at.timestamp() as u64,
+                batch.clear(ValueClass::TaskQueue(TaskQueueClass::Due {
-                    }),
+                    id: item_id,
-                    object_id.serialize(),
+                    due: current_due,
-                )
+                }));
+            }
+            batch
+                .schedule_task_with_id(item_id, self.task(item_id))
                 .set(key, self.to_pickled_vec());
         }
     }

crates/smtp/src/reporting/scheduler.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::{dmarc::DmarcReporting, tls::TlsReporting};
@@ -20,14 +18,6 @@ impl SpawnReport for mpsc::Receiver<ReportingEvent> {
         tokio::spawn(async move {
             while let Some(event) = self.recv().await {
                 let server = inner.build_server();
-                // inbuxa: reports are the outbound MTA's business, as at
-                // boot, but the role is read per event so a change applies
-                // without a restart. Events that arrive while the role is
-                // off are dropped, as they were on a node started without it
-                if !matches!(event, ReportingEvent::Stop) && !server.core.network.roles.outbound_mta
-                {
-                    continue;
-                }
                 match event {
                     ReportingEvent::Dmarc(event) => server.schedule_dmarc(event).await,
                     ReportingEvent::Tls(event) => server.schedule_tls(event).await,

crates/spam-filter/src/modules/pyzor.rs

@@ -48,24 +48,19 @@ pub(crate) async fn pyzor_check(
     // Send message to address. inbuxa: in tests, a fixed table answers
     // instead of a public server (test_response).
     #[cfg(not(feature = "test_mode"))]
-    let response = match tokio::time::timeout(config.timeout, config.address()).await {
+    let response = pyzor_send_message(config.address, config.timeout, &request).await;
-        Ok(Ok(address)) => pyzor_send_message(address, config.timeout, &request).await,
-        Ok(Err(err)) => Err(err),
-        Err(_) => Err(std::io::Error::new(
-            std::io::ErrorKind::TimedOut,
-            "Timed out resolving the Pyzor server",
-        )),
-    };
     #[cfg(feature = "test_mode")]
     let response = std::io::Result::Ok(test_response(&request));
 
-    response.map(Into::into).map_err(|err| {
+    response
-        trc::SpamEvent::PyzorError
+        .map(Into::into)
-            .into_err()
+        .map_err(|err| {
-            .ctx(trc::Key::Url, format!("{}:{}", config.host, config.port))
+            trc::SpamEvent::PyzorError
-            .reason(err)
+                .into_err()
-            .details("Pyzor failed")
+                .ctx(trc::Key::Url, config.address.to_string())
-    })
+                .reason(err)
+                .details("Pyzor failed")
+        })
 }
 
 /// inbuxa: the answers tests get, by digest, instead of a public server's,

crates/store/src/backend/mysql/blob.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use std::ops::Range;
@@ -18,7 +16,7 @@ impl MysqlStore {
         key: &[u8],
         range: Range<usize>,
     ) -> trc::Result<Option<Vec<u8>>> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep("SELECT v FROM t WHERE k = ?")
             .await
@@ -41,7 +39,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn put_blob(&self, key: &[u8], data: &[u8]) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep("INSERT INTO t (k, v) VALUES (?, ?) ON DUPLICATE KEY UPDATE v = VALUES(v)")
             .await
@@ -53,7 +51,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn delete_blob(&self, key: &[u8]) -> trc::Result<bool> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep("DELETE FROM t WHERE k = ?")
             .await

crates/store/src/backend/mysql/lookup.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use mysql_async::{Params, Row, prelude::Queryable};
@@ -18,7 +16,7 @@ impl MysqlStore {
         query: &str,
         params: &[Value<'_>],
     ) -> trc::Result<T> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn.prep(query).await.map_err(into_error)?;
         let params = Params::Positional(params.iter().map(Into::into).collect());
 

crates/store/src/backend/mysql/main.rs

@@ -32,9 +32,6 @@ impl MysqlStore {
             .max_allowed_packet(config.max_allowed_packet.map(|v| v as usize))
             .wait_timeout(config.timeout.map(|t| t.as_secs() as usize))
             .client_found_rows(true)
-            // inbuxa: notice a server that went away without closing the
-            // connection in minutes, not the system default of two hours
-            .tcp_keepalive(Some(super::POOL_KEEPALIVE_IDLE))
             .tcp_port(config.port as u16);
 
         if config.use_tls {
@@ -98,7 +95,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn create_storage_tables(&self) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
 
         for table in [
             SUBSPACE_ACL,
@@ -172,7 +169,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn create_search_tables(&self) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
 
         create_search_tables::<EmailSearchField>(&mut conn).await?;
         create_search_tables::<CalendarSearchField>(&mut conn).await?;

crates/store/src/backend/mysql/mod.rs

@@ -27,33 +27,6 @@ pub struct MysqlStore {
     pub(crate) conn_pool: Pool,
 }
 
-/// inbuxa: how long a request waits for a pooled connection (including
-/// opening one). mysql_async's pool has no wait timeout, so upstream waited
-/// forever when the server stopped answering.
-pub(crate) const POOL_WAIT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30);
-/// inbuxa: idle time before TCP keepalive probes start.
-pub(crate) const POOL_KEEPALIVE_IDLE: std::time::Duration = std::time::Duration::from_secs(60);
-
-impl MysqlStore {
-    /// inbuxa: a pooled connection, or an error once POOL_WAIT_TIMEOUT has
-    /// passed without one.
-    pub(crate) async fn conn(&self) -> trc::Result<mysql_async::Conn> {
-        pool_conn(&self.conn_pool, POOL_WAIT_TIMEOUT).await
-    }
-}
-
-pub(crate) async fn pool_conn(
-    pool: &Pool,
-    wait: std::time::Duration,
-) -> trc::Result<mysql_async::Conn> {
-    match tokio::time::timeout(wait, pool.get_conn()).await {
-        Ok(result) => result.map_err(into_error),
-        Err(_) => Err(trc::StoreEvent::MysqlError
-            .reason("Timed out waiting for a database connection")
-            .details(format!("No connection within {} s", wait.as_secs()))),
-    }
-}
-
 #[inline(always)]
 pub(crate) fn into_error(err: impl Display) -> trc::Error {
     trc::StoreEvent::MysqlError.reason(err)

crates/store/src/backend/mysql/read.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::{MysqlStore, into_error, is_timeout_error};
@@ -16,7 +14,7 @@ impl MysqlStore {
     where
         U: Deserialize + 'static,
     {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep(format!(
                 "SELECT v FROM {} WHERE k = ?",
@@ -38,7 +36,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn key_exists(&self, key: impl Key) -> trc::Result<bool> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep(format!(
                 "SELECT 1 FROM {} WHERE k = ?",
@@ -58,7 +56,7 @@ impl MysqlStore {
         params: IterateParams<T>,
         mut cb: impl for<'x> FnMut(&'x [u8], &'x [u8]) -> trc::Result<bool> + Sync + Send,
     ) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let table = char::from(params.begin.subspace());
         let begin = params.begin.serialize(0);
         let end = params.end.serialize(0);
@@ -157,7 +155,7 @@ impl MysqlStore {
         let key = key.into();
         let table = char::from(key.subspace());
         let key = key.serialize(0);
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn
             .prep(format!("SELECT v FROM {table} WHERE k = ?"))
             .await

crates/store/src/backend/mysql/search.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{
@@ -21,12 +19,12 @@ use crate::{
     write::SearchIndex,
 };
 use mysql_async::{IsolationLevel, TxOpts, Value, prelude::Queryable};
-use nlp::{language::Language, tokenizers::word::WordTokenizer};
+use nlp::tokenizers::word::WordTokenizer;
 use std::fmt::Write;
 
 impl MysqlStore {
     pub async fn index(&self, documents: Vec<IndexDocument>) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let mut tx_opts = TxOpts::default();
         tx_opts
             .with_consistent_snapshot(false)
@@ -96,7 +94,7 @@ impl MysqlStore {
             build_sort(&mut query, sort);
         }
 
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn.prep(query).await.map_err(into_error)?;
 
         conn.exec::<i64, _, _>(s, params)
@@ -110,7 +108,7 @@ impl MysqlStore {
         let mut query = format!("DELETE FROM {table} ");
         let params = build_filter(&mut query, &filter.filters);
 
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let s = conn.prep(&query).await.map_err(into_error)?;
 
         match conn.exec_drop(s, params.clone()).await {
@@ -148,20 +146,6 @@ impl MysqlStore {
     }
 }
 
-// inbuxa: InnoDB's default full-text stopword list
-// (INFORMATION_SCHEMA.INNODB_FT_DEFAULT_STOPWORD) and innodb_ft_min_token_size
-// default; words outside these are not in a FULLTEXT index.
-const FT_STOPWORDS: &[&str] = &[
-    "a", "about", "an", "are", "as", "at", "be", "by", "com", "de", "en", "for", "from", "how",
-    "i", "in", "is", "it", "la", "of", "on", "or", "that", "the", "this", "to", "was", "what",
-    "when", "where", "who", "will", "with", "und", "www",
-];
-const FT_MIN_TOKEN_SIZE: usize = 3;
-
-fn is_ft_indexed(word: &str) -> bool {
-    word.chars().count() >= FT_MIN_TOKEN_SIZE && !FT_STOPWORDS.contains(&word)
-}
-
 fn build_filter(query: &mut String, filters: &[SearchFilter]) -> Vec<Value> {
     if filters.is_empty() {
         return Vec::new();
@@ -187,77 +171,30 @@ fn build_filter(query: &mut String, filters: &[SearchFilter]) -> Vec<Value> {
 
                 if field.is_text() && matches!(op, SearchOperator::Equal | SearchOperator::Contains)
                 {
-                    let (value, mode, unindexed) = match (value, op) {
+                    let (value, mode) = match (value, op) {
-                        (SearchValue::Text { value, .. }, SearchOperator::Equal) => (
+                        (SearchValue::Text { value, .. }, SearchOperator::Equal) => {
-                            Value::Bytes(format!("{value:?}").into_bytes()),
+                            (Value::Bytes(format!("{value:?}").into_bytes()), "BOOLEAN")
-                            "BOOLEAN",
+                        }
-                            Vec::new(),
+                        (SearchValue::Text { value, .. }, ..) => {
-                        ),
-                        (SearchValue::Text { value, language }, ..) => {
                             let mut text_query = String::with_capacity(value.len() + 1);
-                            let mut unindexed = Vec::new();
 
                             for item in WordTokenizer::new(value, MAX_TOKEN_LENGTH) {
-                                // inbuxa: InnoDB never indexes stopwords ("com",
+                                if !text_query.is_empty() {
-                                // "de", "www", ...) or words under
+                                    text_query.push(' ');
-                                // innodb_ft_min_token_size, and a required
-                                // (+word) term it has not indexed matches no row,
-                                // so "example.com" or "[email protected]" found
-                                // nothing. Such words are matched with a
-                                // word-boundary REGEXP instead.
-                                if is_ft_indexed(&item.word) {
-                                    if !text_query.is_empty() {
-                                        text_query.push(' ');
-                                    }
-                                    text_query.push('+');
-                                    text_query.push_str(&item.word);
-                                } else {
-                                    unindexed.push(item.word);
                                 }
+                                text_query.push('+');
+                                text_query.push_str(&item.word);
                             }
 
-                            // For language text (bodies, subjects) the unindexed
+                            (Value::Bytes(text_query.into_bytes()), "BOOLEAN")
-                            // words are noise words and only checked when nothing
-                            // else is left to match; keyword text (addresses,
-                            // contact fields) checks every word, as the other
-                            // backends do.
-                            if !text_query.is_empty() && !matches!(language, Language::None) {
-                                unindexed.clear();
-                            }
-
-                            (Value::Bytes(text_query.into_bytes()), "BOOLEAN", unindexed)
                         }
                         _ => {
                             debug_assert!(false, "Invalid search value for text field");
                             continue;
                         }
                     };
-                    if unindexed.is_empty() {
+                    let _ = write!(query, "MATCH({}) AGAINST(? IN {mode} MODE)", field.column());
-                        let _ =
+                    values.push(value);
-                            write!(query, "MATCH({}) AGAINST(? IN {mode} MODE)", field.column());
-                        values.push(value);
-                    } else {
-                        query.push('(');
-                        let is_empty = matches!(&value, Value::Bytes(v) if v.is_empty());
-                        if !is_empty {
-                            let _ = write!(
-                                query,
-                                "MATCH({}) AGAINST(? IN {mode} MODE) AND ",
-                                field.column()
-                            );
-                            values.push(value);
-                        }
-                        for (i, word) in unindexed.iter().enumerate() {
-                            if i > 0 {
-                                query.push_str(" AND ");
-                            }
-                            let _ = write!(query, "{} REGEXP ?", field.column());
-                            values.push(Value::Bytes(
-                                format!("(^|[^[:alnum:]]){word}([^[:alnum:]]|$)").into_bytes(),
-                            ));
-                        }
-                        query.push(')');
-                    }
                 } else if let SearchValue::KeyValues(kv) = value {
                     let (key, value) = kv.iter().next().unwrap();
 

crates/store/src/backend/mysql/write.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::{DELETE_CHUNK_SIZE, MIN_DELETE_CHUNK_SIZE, MysqlStore, into_error, is_timeout_error};
@@ -31,7 +29,7 @@ impl MysqlStore {
     pub(crate) async fn write(&self, mut batch: Batch<'_>) -> trc::Result<AssignedIds> {
         let start = Instant::now();
         let mut retry_count = 0;
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
 
         loop {
             let err = match self.write_trx(&mut conn, &mut batch).await {
@@ -384,7 +382,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn purge_store(&self) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         for subspace in [SUBSPACE_QUOTA, SUBSPACE_COUNTER, SUBSPACE_IN_MEMORY_COUNTER] {
             purge_table(&mut conn, char::from(subspace)).await?;
         }
@@ -393,7 +391,7 @@ impl MysqlStore {
     }
 
     pub(crate) async fn delete_range(&self, from: impl Key, to: impl Key) -> trc::Result<()> {
-        let mut conn = self.conn().await?;
+        let mut conn = self.conn_pool.get_conn().await.map_err(into_error)?;
         let table = char::from(from.subspace());
         let mut from = from.serialize(0);
         let to = to.serialize(0);

crates/store/src/backend/postgres/main.rs

@@ -22,34 +22,11 @@ use crate::{
 use ::registry::schema::{enums::PostgreSqlRecyclingMethod, structs};
 use ahash::AHashSet;
 use deadpool_postgres::{
-    Config, ManagerConfig, Object, Pool, PoolConfig, RecyclingMethod, Runtime, Timeouts,
+    Config, ManagerConfig, Object, Pool, PoolConfig, RecyclingMethod, Runtime,
 };
-use std::time::Duration;
 use tokio_postgres::NoTls;
 use utils::tls::rustls_client_config;
 
-/// inbuxa: how long a request waits for a pooled connection.
-pub(crate) const POOL_WAIT_TIMEOUT: Duration = Duration::from_secs(30);
-/// inbuxa: how long opening a connection may take when the store sets no
-/// timeout of its own.
-pub(crate) const POOL_CREATE_TIMEOUT: Duration = Duration::from_secs(15);
-/// inbuxa: how long checking a pooled connection before reuse may take.
-pub(crate) const POOL_RECYCLE_TIMEOUT: Duration = Duration::from_secs(10);
-/// inbuxa: idle time before TCP keepalive probes start.
-pub(crate) const POOL_KEEPALIVE_IDLE: Duration = Duration::from_secs(60);
-
-/// inbuxa: the pool's timeouts. Opening a connection is bounded by the
-/// store's own timeout when it has one; waiting for one covers at least that
-/// long, so a slow connect isn't cut short by the wait.
-pub(crate) fn pool_timeouts(connect_timeout: Option<Duration>) -> Timeouts {
-    let create = connect_timeout.unwrap_or(POOL_CREATE_TIMEOUT);
-    Timeouts {
-        wait: POOL_WAIT_TIMEOUT.max(create).into(),
-        create: create.into(),
-        recycle: POOL_RECYCLE_TIMEOUT.into(),
-    }
-}
-
 impl PostgresStore {
     pub async fn open(config: structs::PostgreSqlStore) -> Result<Store, String> {
         // inbuxa: ST-15: where the primary is, to tell a replica from it
@@ -69,20 +46,9 @@ impl PostgresStore {
                 PostgreSqlRecyclingMethod::Clean => RecyclingMethod::Clean,
             },
         });
-        // inbuxa: upstream set no pool timeouts, so a request waited for a
+        if let Some(max_conn) = config.pool_max_connections {
-        // free connection, or for one to be made or recycled, for as long as
+            cfg.pool = PoolConfig::new(max_conn as usize).into();
-        // it took: forever when the server stopped answering. A worker now
+        }
-        // gets an error instead and the task or request is retried.
-        let mut pool = config
-            .pool_max_connections
-            .map(|max_conn| PoolConfig::new(max_conn as usize))
-            .unwrap_or_default();
-        pool.timeouts = pool_timeouts(cfg.connect_timeout);
-        cfg.pool = pool.into();
-        // Notice a server that went away without closing the connection in
-        // minutes rather than the system default of two hours
-        cfg.keepalives = true.into();
-        cfg.keepalives_idle = POOL_KEEPALIVE_IDLE.into();
 
         let primary_pool = if config.use_tls {
             cfg.create_pool(

crates/store/src/backend/postgres/search.rs

@@ -2,17 +2,12 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <[email protected]>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{
-    backend::{
+    backend::postgres::{
-        MAX_TOKEN_LENGTH,
+        DELETE_CHUNK_SIZE, MIN_DELETE_CHUNK_SIZE, PostgresStore, PsqlSearchField, into_error,
-        postgres::{
+        into_pool_error, is_timeout_error,
-            DELETE_CHUNK_SIZE, MIN_DELETE_CHUNK_SIZE, PostgresStore, PsqlSearchField, into_error,
-            into_pool_error, is_timeout_error,
-        },
     },
     search::{
         IndexDocument, SearchComparator, SearchDocumentId, SearchFilter, SearchOperator,
@@ -20,7 +15,7 @@ use crate::{
     },
     write::SearchIndex,
 };
-use nlp::{language::Language, tokenizers::space::SpaceTokenizer};
+use nlp::language::Language;
 use std::fmt::Write;
 use tokio_postgres::{
     IsolationLevel,
@@ -48,19 +43,6 @@ impl PostgresStore {
             let primary_keys = index.primary_keys();
             let all_fields = index.all_fields();
             let fields = document.fields;
-            // inbuxa: keyword text (addresses, contact fields, ...) is split into
-            // words before it reaches the text parser, see keyword_terms().
-            let keywords = primary_keys
-                .iter()
-                .chain(all_fields)
-                .map(|field| match fields.get(field) {
-                    Some(SearchValue::Text {
-                        value,
-                        language: Language::None,
-                    }) if field.is_text() => Some(keyword_terms(value)),
-                    _ => None,
-                })
-                .collect::<Vec<_>>();
             let mut values = Vec::with_capacity(fields.len() + 2);
             let mut query = format!("INSERT INTO {} (", index.psql_table());
 
@@ -92,20 +74,7 @@ impl PostgresStore {
                         (0, PG_UNSTEMMED_LANG)
                     };
 
-                    if let Some(keywords) = &keywords[i] {
+                    if field.is_text() {
-                        let _ = write!(&mut query, "to_tsvector('{language}',{value_ref})");
-                        values.push(keywords as &(dyn ToSql + Sync));
-                        if field.sort_column().is_some() {
-                            let value_ref = format!("${}", values.len() + 1);
-                            if text_len > 255 {
-                                let _ = write!(&mut query, ",left({value_ref},255)");
-                            } else {
-                                let _ = write!(&mut query, ",{value_ref}");
-                            }
-                            values.push(value as &(dyn ToSql + Sync));
-                        }
-                        continue;
-                    } else if field.is_text() {
                         let _ = write!(&mut query, "to_tsvector('{language}',{value_ref})");
                     } else if text_len > 512 {
                         query.push_str("left(");
@@ -165,7 +134,6 @@ impl PostgresStore {
     ) -> trc::Result<Vec<R>> {
         let mut query = format!("SELECT {} FROM {}", R::field().column(), index.psql_table());
         let params = self.build_filter(&mut query, filters);
-        let params = params.iter().map(SqlParam::as_sql).collect::<Vec<_>>();
         if !sort.is_empty() {
             build_sort(&mut query, sort);
         }
@@ -187,7 +155,6 @@ impl PostgresStore {
         let table = filter.index.psql_table();
         let mut where_clause = String::new();
         let params = self.build_filter(&mut where_clause, &filter.filters);
-        let params = params.iter().map(SqlParam::as_sql).collect::<Vec<_>>();
         let conn = self.conn_pool.get().await.map_err(into_pool_error)?;
         let s = conn
             .prepare_cached(&format!("DELETE FROM {table}{where_clause}"))
@@ -229,7 +196,7 @@ impl PostgresStore {
         &self,
         query: &mut String,
         filters: &'x [SearchFilter],
-    ) -> Vec<SqlParam<'x>> {
+    ) -> Vec<&'x (dyn ToSql + Sync)> {
         if filters.is_empty() {
             return Vec::new();
         }
@@ -270,10 +237,6 @@ impl PostgresStore {
 
                         if matches!(language, Language::None) {
                             let _ = write!(query, "@@ {method}('{config}', ${value_pos})");
-                            if let SearchValue::Text { value, .. } = value {
-                                values.push(SqlParam::Owned(keyword_terms(value)));
-                                continue;
-                            }
                         } else {
                             let _ = write!(query, "@@ ({method}('{config}', ${value_pos})");
                             for fallback in [PG_FALLBACK_LANG, PG_UNSTEMMED_LANG] {
@@ -284,18 +247,18 @@ impl PostgresStore {
                             }
                             query.push(')');
                         }
-                        values.push(SqlParam::Ref(value));
+                        values.push(value as &(dyn ToSql + Sync));
                     } else if let SearchValue::KeyValues(kv) = value {
                         query.push_str(field.column());
                         query.push(' ');
 
                         let (key, value) = kv.iter().next().unwrap();
-                        values.push(SqlParam::Ref(key));
+                        values.push(key as &(dyn ToSql + Sync));
 
                         if !value.is_empty() {
                             let _ = write!(query, "->> ${value_pos} ");
                             op.write_pqsql(query, values.len() + 1);
-                            values.push(SqlParam::Ref(value));
+                            values.push(value as &(dyn ToSql + Sync));
                         } else {
                             let _ = write!(query, " ? ${value_pos}");
                         }
@@ -304,7 +267,7 @@ impl PostgresStore {
                         query.push(' ');
 
                         op.write_pqsql(query, value_pos);
-                        values.push(SqlParam::Ref(value));
+                        values.push(value as &(dyn ToSql + Sync));
                     }
                 }
                 SearchFilter::And | SearchFilter::Or => {
@@ -358,38 +321,6 @@ impl PostgresStore {
     }
 }
 
-// inbuxa: PostgreSQL's text parser keeps "[email protected]" (and host names,
-// URLs, file paths, ...) as a single token, so a search for "user" or
-// "example.com" never matched an address. Keyword text is split into words the
-// same way the built-in index splits it (SpaceTokenizer: lowercase runs of
-// alphanumerics) on both the indexing and the query side, so a full address,
-// its local part, its domain and the display-name words all match, as they do
-// on the other backends.
-pub(crate) fn keyword_terms(value: &str) -> String {
-    let mut terms = String::with_capacity(value.len());
-    for token in SpaceTokenizer::new(value, MAX_TOKEN_LENGTH) {
-        if !terms.is_empty() {
-            terms.push(' ');
-        }
-        terms.push_str(&token);
-    }
-    terms
-}
-
-pub(super) enum SqlParam<'x> {
-    Ref(&'x (dyn ToSql + Sync)),
-    Owned(String),
-}
-
-impl SqlParam<'_> {
-    fn as_sql(&self) -> &(dyn ToSql + Sync) {
-        match self {
-            SqlParam::Ref(value) => *value,
-            SqlParam::Owned(value) => value,
-        }
-    }
-}
-
 fn build_sort(query: &mut String, sort: &[SearchComparator]) {
     query.push_str(" ORDER BY ");
     for (i, comparator) in sort.iter().enumerate() {

crates/store/src/backend/redis/lookup.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use super::{RedisPool, RedisStore, into_error};
@@ -81,30 +79,6 @@ impl RedisStore {
         }
     }
 
-    // inbuxa: see InMemoryStore::renew_lock
-    pub async fn renew_lock(&self, key: &[u8], expires: u64) -> trc::Result<bool> {
-        match &self.pool {
-            RedisPool::Single(pool) => {
-                with_conn(pool, async |conn| {
-                    Self::renew_lock_(conn, key, expires).await
-                })
-                .await
-            }
-            RedisPool::Cluster(pool) => {
-                with_conn(pool, async |conn| {
-                    Self::renew_lock_(conn, key, expires).await
-                })
-                .await
-            }
-            RedisPool::Sentinel(pool) => {
-                with_conn(pool, async |conn| {
-                    Self::renew_lock_(conn, key, expires).await
-                })
-                .await
-            }
-        }
-    }
-
     pub async fn key_delete(&self, key: &[u8]) -> trc::Result<()> {
         match &self.pool {
             RedisPool::Single(pool) => {
@@ -252,22 +226,6 @@ impl RedisStore {
             .map(|reply| reply.is_some())
     }
 
-    async fn renew_lock_(
-        conn: &mut impl AsyncCommands,
-        key: &[u8],
-        expires: u64,
-    ) -> RedisResult<bool> {
-        redis::cmd("SET")
-            .arg(key)
-            .arg(now() + expires)
-            .arg("XX")
-            .arg("EX")
-            .arg(expires as i64)
-            .query_async::<Option<String>>(conn)
-            .await
-            .map(|reply| reply.is_some())
-    }
-
     async fn key_delete_(conn: &mut impl AsyncCommands, key: &[u8]) -> RedisResult<()> {
         conn.del(key).await
     }

crates/store/src/dispatch/lookup.rs

@@ -401,57 +401,6 @@ impl InMemoryStore {
         }
     }
 
-    /// inbuxa: extends a lock this node holds to `duration` seconds from now.
-    /// Returns false when the lock is gone or has expired: it may have been
-    /// taken by someone else since, so it is left alone.
-    pub async fn renew_lock(&self, prefix: u8, key: &[u8], duration: u64) -> trc::Result<bool> {
-        match self {
-            InMemoryStore::Store(store) => {
-                let key = KeyValue::<()>::build_key(prefix, key);
-                let key = ValueClass::InMemory(InMemoryClass::Key(key));
-                let Some(lock_expiry) = store
-                    .get_value::<u64>(ValueKey::from(key.clone()))
-                    .await
-                    .caused_by(trc::location!())?
-                else {
-                    return Ok(false);
-                };
-                let now = now();
-                if lock_expiry <= now {
-                    return Ok(false);
-                }
-
-                let mut batch = BatchBuilder::new();
-                batch.assert_value(key.clone(), AssertValue::U64(lock_expiry));
-                batch.set(key, (now + duration).serialize());
-                match store.write(batch.build_all()).await {
-                    Ok(_) => Ok(true),
-                    Err(err) if err.is_assertion_failure() => Ok(false),
-                    Err(err) => Err(err
-                        .details("Failed to renew lock.")
-                        .caused_by(trc::location!())),
-                }
-            }
-            InMemoryStore::Sharded(store) => {
-                Box::pin(
-                    store
-                        .member(&KeyValue::<()>::build_key(prefix, key))
-                        .renew_lock(prefix, key, duration),
-                )
-                .await
-            }
-            #[cfg(feature = "redis")]
-            InMemoryStore::Redis(store) => {
-                store
-                    .renew_lock(&KeyValue::<()>::build_key(prefix, key), duration)
-                    .await
-            }
-            InMemoryStore::Static(_) | InMemoryStore::Http(_) => {
-                Err(trc::StoreEvent::NotSupported.into_err())
-            }
-        }
-    }
-
     pub async fn remove_lock(&self, prefix: u8, key: &[u8]) -> trc::Result<()> {
         self.key_delete(KeyValue::<()>::build_key(prefix, key))
             .await

crates/trc/src/event/enums.rs

@@ -10,9 +10,8 @@
 
 // inbuxa: 637 to 641 are the fork's SCIM events (SCIM-54); 642 is
 // auth.legacy-protocol-refused (legacy-protocols LP-6); 643 is
-// security.legacy-protocols-changed (LP-8); 644 to 646 are the cluster
+// security.legacy-protocols-changed (LP-8)
-// coordinator's connection events
+pub const TOTAL_EVENT_COUNT: usize = 644;
-pub const TOTAL_EVENT_COUNT: usize = 647;
 pub const TOTAL_METRIC_COUNT: usize = 369;
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
@@ -151,10 +150,6 @@ pub enum ClusterEvent {
     MessageSkipped = 47,
     MessageInvalid = 49,
     NodeIdRenewed = 275,
-    // inbuxa: the coordinator's connection
-    CoordinatorConnected = 644,
-    CoordinatorDisconnected = 645,
-    CoordinatorError = 646,
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]

crates/trc/src/event/enums_impl.rs

@@ -81,10 +81,6 @@ impl EventType {
             b"cluster.message-skipped" => EventType::Cluster(ClusterEvent::MessageSkipped),
             b"cluster.message-invalid" => EventType::Cluster(ClusterEvent::MessageInvalid),
             b"cluster.node-id-renewed" => EventType::Cluster(ClusterEvent::NodeIdRenewed),
-            // inbuxa: coordinator connection
-            b"cluster.coordinator-connected" => EventType::Cluster(ClusterEvent::CoordinatorConnected),
-            b"cluster.coordinator-disconnected" => EventType::Cluster(ClusterEvent::CoordinatorDisconnected),
-            b"cluster.coordinator-error" => EventType::Cluster(ClusterEvent::CoordinatorError),
             b"dane.authentication-success" => EventType::Dane(DaneEvent::AuthenticationSuccess),
             b"dane.authentication-failure" => EventType::Dane(DaneEvent::AuthenticationFailure),
             b"dane.no-certificates-found" => EventType::Dane(DaneEvent::NoCertificatesFound),
@@ -746,14 +742,6 @@ impl EventType {
             EventType::Cluster(ClusterEvent::MessageSkipped) => "cluster.message-skipped",
             EventType::Cluster(ClusterEvent::MessageInvalid) => "cluster.message-invalid",
             EventType::Cluster(ClusterEvent::NodeIdRenewed) => "cluster.node-id-renewed",
-            // inbuxa: coordinator connection
-            EventType::Cluster(ClusterEvent::CoordinatorConnected) => {
-                "cluster.coordinator-connected"
-            }
-            EventType::Cluster(ClusterEvent::CoordinatorDisconnected) => {
-                "cluster.coordinator-disconnected"
-            }
-            EventType::Cluster(ClusterEvent::CoordinatorError) => "cluster.coordinator-error",
             EventType::Dane(DaneEvent::AuthenticationSuccess) => "dane.authentication-success",
             EventType::Dane(DaneEvent::AuthenticationFailure) => "dane.authentication-failure",
             EventType::Dane(DaneEvent::NoCertificatesFound) => "dane.no-certificates-found",
@@ -1536,10 +1524,6 @@ impl EventType {
             EventType::Cluster(ClusterEvent::MessageSkipped) => 47,
             EventType::Cluster(ClusterEvent::MessageInvalid) => 49,
             EventType::Cluster(ClusterEvent::NodeIdRenewed) => 275,
-            // inbuxa: coordinator connection
-            EventType::Cluster(ClusterEvent::CoordinatorConnected) => 644,
-            EventType::Cluster(ClusterEvent::CoordinatorDisconnected) => 645,
-            EventType::Cluster(ClusterEvent::CoordinatorError) => 646,
             EventType::Dane(DaneEvent::AuthenticationSuccess) => 67,
             EventType::Dane(DaneEvent::AuthenticationFailure) => 66,
             EventType::Dane(DaneEvent::NoCertificatesFound) => 69,
@@ -2192,10 +2176,6 @@ impl EventType {
             47 => Some(EventType::Cluster(ClusterEvent::MessageSkipped)),
             49 => Some(EventType::Cluster(ClusterEvent::MessageInvalid)),
             275 => Some(EventType::Cluster(ClusterEvent::NodeIdRenewed)),
-            // inbuxa: coordinator connection
-            644 => Some(EventType::Cluster(ClusterEvent::CoordinatorConnected)),
-            645 => Some(EventType::Cluster(ClusterEvent::CoordinatorDisconnected)),
-            646 => Some(EventType::Cluster(ClusterEvent::CoordinatorError)),
             67 => Some(EventType::Dane(DaneEvent::AuthenticationSuccess)),
             66 => Some(EventType::Dane(DaneEvent::AuthenticationFailure)),
             69 => Some(EventType::Dane(DaneEvent::NoCertificatesFound)),
@@ -3134,10 +3114,6 @@ impl EventType {
             EventType::Auth(AuthEvent::TooManyAttempts) => Level::Warn,
             EventType::Calendar(CalendarEvent::AlarmFailed) => Level::Warn,
             EventType::Cluster(ClusterEvent::SubscriberDisconnected) => Level::Warn,
-            // inbuxa: coordinator connection
-            EventType::Cluster(ClusterEvent::CoordinatorConnected) => Level::Info,
-            EventType::Cluster(ClusterEvent::CoordinatorDisconnected) => Level::Warn,
-            EventType::Cluster(ClusterEvent::CoordinatorError) => Level::Warn,
             EventType::Delivery(DeliveryEvent::MissingOutboundHostname) => Level::Warn,
             EventType::Delivery(DeliveryEvent::ConcurrencyLimitExceeded) => Level::Warn,
             EventType::Delivery(DeliveryEvent::RateLimitExceeded) => Level::Warn,
@@ -3268,10 +3244,6 @@ impl EventType {
             EventType::Cluster(ClusterEvent::MessageSkipped) => "PubSub message skipped",
             EventType::Cluster(ClusterEvent::MessageInvalid) => "Invalid PubSub message",
             EventType::Cluster(ClusterEvent::NodeIdRenewed) => "Node ID renewed",
-            // inbuxa: coordinator connection
-            EventType::Cluster(ClusterEvent::CoordinatorConnected) => "Coordinator connected",
-            EventType::Cluster(ClusterEvent::CoordinatorDisconnected) => "Coordinator unavailable",
-            EventType::Cluster(ClusterEvent::CoordinatorError) => "Coordinator error",
             EventType::Dane(DaneEvent::AuthenticationSuccess) => "DANE authentication successful",
             EventType::Dane(DaneEvent::AuthenticationFailure) => "DANE authentication failed",
             EventType::Dane(DaneEvent::NoCertificatesFound) => "No certificates found for DANE",
@@ -4350,10 +4322,6 @@ impl EventType {
             EventType::Cluster(ClusterEvent::MessageSkipped),
             EventType::Cluster(ClusterEvent::MessageInvalid),
             EventType::Cluster(ClusterEvent::NodeIdRenewed),
-            // inbuxa: coordinator connection
-            EventType::Cluster(ClusterEvent::CoordinatorConnected),
-            EventType::Cluster(ClusterEvent::CoordinatorDisconnected),
-            EventType::Cluster(ClusterEvent::CoordinatorError),
             EventType::Dane(DaneEvent::AuthenticationSuccess),
             EventType::Dane(DaneEvent::AuthenticationFailure),
             EventType::Dane(DaneEvent::NoCertificatesFound),

crates/types/src/branding.rs

@@ -81,7 +81,7 @@ fn legacy_setting(name: &str, is_set: impl Fn(&str) -> bool) -> Option<String> {
 #[macro_export]
 macro_rules! brand_version {
     () => {
-        "2026.9.24.3"
+        "2026.9.24.4"
     };
 }
 

docs/spec/features/monitoring.md

@@ -212,15 +212,10 @@ unchanged.
 - **MON-16.** With `indexTelemetry` on, storing a trace schedules an
   `IndexTrace` task. The task builds one document for `SearchIndex::Tracing`
   with the fields named in `indexTracingFields`:
-  - `eventType`: the trace's opening event, as its numeric id;
+  - `eventType`: every event type in the trace;
-  - `queueId`: the first `queueId` value, as an integer;
+  - `queueId`: every `queueId` value;
   - `keywords`: every address in `from` and `to`, each address's domain, every
-    `domain`, `hostname`, `remoteIp`, `messageId` and `accountName` value,
+    `domain`, `hostname`, `remoteIp`, `messageId` and `accountName` value.
-    and every `queueId` value.
-  The event type and queue id are single integer columns on every search
-  backend (BIGINT on PostgreSQL and MySQL), so the `queueId` filter matches
-  the column or any queue id in the keywords, and a session that queued
-  several messages is found by each of them.
   So searching `example.org` finds every trace to or from that domain, as the
   upstream suite expects. With `indexTelemetry` off nothing is indexed, and
   the `text` and `queueId` filters are refused (see "Interfaces").

resources/schema/schema.json.sha256

@@ -1 +1 @@
-XFI3xuKC_rH1KZyaVBF0uTIiRDXRqyYboijquiGz2eg
+VbnFuwCOTBh0s2T-NuRhb2JaJr8Jl5s3LgXv4Pv2sTg

tests/src/cluster/broadcast.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{
@@ -13,7 +11,6 @@ use crate::{
         server::TestServerBuilder,
     },
 };
-use common::BuildServer;
 use imap_proto::ResponseType;
 use registry::{
     schema::{
@@ -21,8 +18,7 @@ use registry::{
         prelude::{ObjectType, Property, SocketAddr},
         structs::{
             ClusterListenerGroup, ClusterListenerGroupProperties, ClusterRole, ClusterTaskGroup,
-            Coordinator, Imap, MtaDeliverySchedule, MtaVirtualQueue, NatsCoordinator,
+            Coordinator, Imap, NatsCoordinator, NetworkListener, RedisStore,
-            NetworkListener, RedisStore,
         },
     },
     types::map::Map,
@@ -213,45 +209,6 @@ pub async fn cluster_tests() {
         Some("John Doe")
     );
 
-    // inbuxa: a settings write applies on every node, no ReloadSettings
-    let queue_id = admin
-        .registry_create_object(MtaVirtualQueue {
-            name: "clusterq".into(),
-            threads_per_node: 1,
-            description: None,
-        })
-        .await;
-    admin
-        .registry_create_object(MtaDeliverySchedule {
-            name: "cluster-autoreload".into(),
-            queue_id,
-            ..Default::default()
-        })
-        .await;
-    for (node_id, test) in servers.iter().enumerate() {
-        let started = std::time::Instant::now();
-        while !test
-            .server
-            .inner
-            .build_server()
-            .core
-            .smtp
-            .queue
-            .queue_strategy
-            .contains_key("cluster-autoreload")
-        {
-            assert!(
-                started.elapsed() < std::time::Duration::from_secs(5),
-                "node {node_id} didn't pick up the new delivery schedule"
-            );
-            tokio::time::sleep(std::time::Duration::from_millis(50)).await;
-        }
-        println!(
-            "Node {node_id} has the new delivery schedule after {} ms",
-            started.elapsed().as_millis()
-        );
-    }
-
     // Run IMAP idle tests across nodes
     let mut node1_client = imap_client("[email protected]", "this is john's secret", 1).await;
     let mut node2_client = imap_client("[email protected]", "this is john's secret", 2).await;

tests/src/cluster/coordinator.rs

@@ -1,145 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-//! A node that starts while its NATS coordinator is down joins the cluster
-//! once NATS comes up, without a restart, and reports the coordinator's
-//! connection on `/healthz/cluster` as it goes and comes back.
-
-use crate::utils::server::TestServerBuilder;
-use coordinator::Coordinator;
-use registry::{
-    schema::{
-        enums::NetworkListenerProtocol,
-        structs::{Coordinator as CoordinatorSetting, NatsCoordinator},
-    },
-    types::map::Map,
-};
-use serde_json::{Value, json};
-use std::time::{Duration, Instant};
-use testcontainers::{
-    GenericImage, ImageExt, core::IntoContainerPort, core::WaitFor, runners::AsyncRunner,
-};
-
-const HTTP_PORT: u16 = 11_310;
-const TOPIC: &str = "inbuxa-coordinator-test";
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn coordinator_reconnect_tests() {
-    println!("Running coordinator reconnect tests...");
-
-    // A port with no NATS server behind it, yet
-    let nats_port = std::net::TcpListener::bind("127.0.0.1:0")
-        .unwrap()
-        .local_addr()
-        .unwrap()
-        .port();
-    let config = NatsCoordinator {
-        addresses: Map::new(vec![format!("127.0.0.1:{nats_port}")]),
-        use_tls: false,
-        timeout_connection: 1_000u64.into(),
-        ..Default::default()
-    };
-
-    // 1. The node starts, without a build error, while NATS is down, and
-    // says so
-    let test = TestServerBuilder::new("coordinator_reconnect_tests")
-        .await
-        .with_object(CoordinatorSetting::Nats(config.clone()))
-        .await
-        .with_listener(NetworkListenerProtocol::Http, "http", HTTP_PORT, true)
-        .await
-        .build()
-        .await;
-    let coordinator = test.server.core.storage.coordinator.clone();
-    assert!(
-        coordinator.is_enabled(),
-        "a coordinator, though not connected"
-    );
-    assert_eq!(coordinator.is_connected(), Some(false));
-    assert_eq!(
-        cluster_health().await,
-        (503, json!({"coordinator": "disconnected"}))
-    );
-
-    // A subscription made now, as the broadcast subscriber makes it at
-    // startup, has to work once NATS is up
-    let mut stream = coordinator.subscribe(TOPIC).await.unwrap();
-
-    // 2. NATS comes up: the node connects on its own
-    let nats = GenericImage::new("nats", "latest")
-        .with_wait_for(WaitFor::message_on_stderr("Server is ready"))
-        .with_mapped_port(nats_port, 4222.tcp())
-        .start()
-        .await
-        .expect("Failed to start NATS container");
-    wait_for_health(200, "connected").await;
-    let other_node = coordinator::backend::nats::NatsPubSub::open(config.clone())
-        .await
-        .unwrap();
-    wait_until_connected(&other_node).await;
-    round_trip(&other_node, &mut stream, b"after startup").await;
-
-    // 3. NATS goes away: the node reports it; and it comes back: the node
-    // reconnects and the same subscription carries on
-    nats.stop().await.unwrap();
-    wait_for_health(503, "disconnected").await;
-    nats.start().await.unwrap();
-    wait_for_health(200, "connected").await;
-    wait_until_connected(&other_node).await;
-    round_trip(&other_node, &mut stream, b"after reconnect").await;
-
-    drop(nats);
-    if test.is_reset() {
-        test.temp_dir.delete();
-    }
-}
-
-async fn cluster_health() -> (u16, Value) {
-    let response = reqwest::Client::builder()
-        .danger_accept_invalid_certs(true)
-        .timeout(Duration::from_secs(5))
-        .build()
-        .unwrap()
-        .get(format!("https://127.0.0.1:{HTTP_PORT}/healthz/cluster"))
-        .send()
-        .await
-        .unwrap();
-    let status = response.status().as_u16();
-    (status, response.json().await.unwrap())
-}
-
-async fn wait_for_health(status: u16, state: &str) {
-    let started = Instant::now();
-    loop {
-        let health = cluster_health().await;
-        if health == (status, json!({"coordinator": state})) {
-            return;
-        }
-        assert!(
-            started.elapsed() < Duration::from_secs(30),
-            "expected {status} {state}, still {health:?}"
-        );
-        tokio::time::sleep(Duration::from_millis(250)).await;
-    }
-}
-
-async fn wait_until_connected(coordinator: &Coordinator) {
-    let started = Instant::now();
-    while coordinator.is_connected() != Some(true) {
-        assert!(started.elapsed() < Duration::from_secs(30), "not connected");
-        tokio::time::sleep(Duration::from_millis(100)).await;
-    }
-}
-
-/// Another node publishes; this one's subscription receives it.
-async fn round_trip(from: &Coordinator, stream: &mut coordinator::PubSubStream, payload: &[u8]) {
-    from.publish(TOPIC, payload.to_vec()).await.unwrap();
-    let message = tokio::time::timeout(Duration::from_secs(10), stream.next())
-        .await
-        .expect("no message within 10 seconds")
-        .expect("subscription ended");
-    assert_eq!(message.payload(), payload);
-}

tests/src/cluster/live_roles.rs

@@ -1,297 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-//! A node follows edits to its cluster role without a restart: outbound
-//! delivery and report tasks start when the role gains outboundMta and stop
-//! when it loses it. Upstream decided at boot whether the queue, report and
-//! task managers ran at all. Needs a store the seed and the node can share
-//! (STORE=PostgreSql or MySql).
-
-use crate::utils::server::{TestServer, TestServerBuilder};
-use common::Server;
-use registry::{
-    schema::{
-        enums::ClusterTaskType,
-        prelude::{Object, ObjectType},
-        structs::{
-            ClusterListenerGroup, ClusterRole, ClusterTaskGroup, ClusterTaskGroupProperties, Task,
-            TaskStatus, TaskTlsReport,
-        },
-    },
-    types::{id::ObjectId, map::Map},
-};
-use smtp::{
-    queue::{Message, Status},
-    reporting::send::MtaReportSend,
-};
-use std::time::{Duration, Instant};
-use store::{
-    Deserialize, IterateParams, ValueKey,
-    registry::write::{RegistryWrite, RegistryWriteResult},
-    write::{AlignedBytes, Archive, BatchBuilder, QueueClass, TaskQueueClass, ValueClass},
-};
-use types::id::Id;
-use utils::snowflake::SnowflakeIdGenerator;
-
-const BUSY_ROLE: &str = "live_role_busy";
-const IDLE_ROLE: &str = "live_role_idle";
-const WITH: &[ClusterTaskType] = &[
-    ClusterTaskType::PushNotifications,
-    ClusterTaskType::OutboundMta,
-];
-const WITHOUT: &[ClusterTaskType] = &[ClusterTaskType::PushNotifications];
-const RCPT_DOMAIN: &str = "live-role.invalid";
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn live_role_tests() {
-    if matches!(
-        std::env::var("STORE").as_deref(),
-        Ok("RocksDb" | "Sqlite") | Err(_)
-    ) {
-        println!("Skipping live role tests: they need a store the nodes can share.");
-        return;
-    }
-    println!(
-        "Running live role tests on {}...",
-        std::env::var("STORE").unwrap_or_default()
-    );
-
-    // Two roles: one with outboundMta, one with no task type at all
-    let seed = TestServerBuilder::new("live_roles_seed").await;
-    let busy_id = seed.insert_object(role(BUSY_ROLE, WITH)).await;
-    let idle_id = seed.insert_object(role(IDLE_ROLE, WITHOUT)).await;
-    let seed = seed.disable_services().build().await;
-    let registry = seed.server.clone();
-
-    // 1. The rehearsal case: a node started with outboundMta has it taken
-    // away. Upstream kept delivering, report messages included, until a
-    // restart.
-    let node = start_node("live_roles_busy", BUSY_ROLE).await;
-    let server = node.server.clone();
-    assert!(server.core.network.roles.outbound_mta);
-    let (msg, task) = queue_work(&server, "busy-before").await;
-    assert_runs(&server, &msg, task).await;
-
-    set_role(&registry, &server, busy_id, role(BUSY_ROLE, WITHOUT)).await;
-    let (msg, task) = queue_work(&server, "busy-off").await;
-    assert_idle(&server, &msg, task).await;
-
-    // Given back, it takes up the work left waiting
-    set_role(&registry, &server, busy_id, role(BUSY_ROLE, WITH)).await;
-    assert_runs(&server, &msg, task).await;
-
-    // Off again, so it leaves the next node's work alone
-    set_role(&registry, &server, busy_id, role(BUSY_ROLE, WITHOUT)).await;
-
-    // 2. A node started with no task type at all gains outboundMta.
-    // Upstream never started its queue, report or task manager, so the
-    // role did nothing until a restart.
-    let node2 = start_node("live_roles_idle", IDLE_ROLE).await;
-    let server2 = node2.server.clone();
-    assert!(!server2.core.network.roles.outbound_mta);
-    let (msg, task) = queue_work(&server2, "idle-off").await;
-    assert_idle(&server2, &msg, task).await;
-    set_role(&registry, &server2, idle_id, role(IDLE_ROLE, WITH)).await;
-    assert_runs(&server2, &msg, task).await;
-    set_role(&registry, &server2, idle_id, role(IDLE_ROLE, WITHOUT)).await;
-
-    if seed.is_reset() {
-        seed.temp_dir.delete();
-        node.temp_dir.delete();
-        node2.temp_dir.delete();
-    }
-}
-
-async fn start_node(name: &str, role: &str) -> TestServer {
-    TestServerBuilder::new_with_role(
-        name,
-        format!("{name}.example.com").replace('_', "-"),
-        Some(role.into()),
-        false,
-    )
-    .await
-    .build_with_opts(false)
-    .await
-}
-
-/// Neither the message nor the report task is touched.
-async fn assert_idle(server: &Server, msg: &str, task: u64) {
-    tokio::time::sleep(Duration::from_secs(4)).await;
-    server.notify_task_queue();
-    tokio::time::sleep(Duration::from_secs(1)).await;
-    assert!(
-        !attempted(server, msg).await,
-        "delivery attempted without outboundMta"
-    );
-    assert!(
-        is_pending(server, task).await,
-        "report task claimed without outboundMta"
-    );
-}
-
-/// Delivery of the message is attempted and the report task runs.
-async fn assert_runs(server: &Server, msg: &str, task: u64) {
-    wait_for(Duration::from_secs(20), "message delivery attempt", || {
-        attempted(server, msg)
-    })
-    .await;
-    wait_for(Duration::from_secs(20), "report task to run", || async {
-        !is_pending(server, task).await
-    })
-    .await;
-}
-
-fn role(name: &str, tasks: &[ClusterTaskType]) -> ClusterRole {
-    ClusterRole {
-        name: name.into(),
-        description: None,
-        listeners: ClusterListenerGroup::EnableAll,
-        tasks: ClusterTaskGroup::EnableSome(ClusterTaskGroupProperties {
-            task_types: Map::new(tasks.to_vec()),
-        }),
-    }
-}
-
-/// Stores a new version of a role and reloads the node's settings, as a
-/// JMAP write to the role does.
-async fn set_role(registry: &Server, node: &Server, id: Id, new: ClusterRole) {
-    let enabled = matches!(&new.tasks, ClusterTaskGroup::EnableSome(group)
-        if group.task_types.iter().any(|t| *t == ClusterTaskType::OutboundMta));
-    let old = registry
-        .registry()
-        .get(ObjectId::new(ObjectType::ClusterRole, id))
-        .await
-        .unwrap()
-        .expect("role not found");
-    let new = Object::from(new);
-    let result = registry
-        .registry()
-        .write(RegistryWrite::update(id, &new, &old))
-        .await
-        .unwrap();
-    assert!(
-        matches!(result, RegistryWriteResult::Success(_)),
-        "role update refused"
-    );
-    assert_eq!(
-        node.reload_after_write(ObjectType::ClusterRole).await,
-        Some(Ok(()))
-    );
-    assert_eq!(
-        node.inner.shared_core.load().network.roles.outbound_mta,
-        enabled
-    );
-}
-
-/// Queues a message to an unreachable domain and schedules a TLS report
-/// task, both due now. Returns the recipient's local part and the task id.
-async fn queue_work(server: &Server, name: &str) -> (String, u64) {
-    let local = format!("{name}-{}", SnowflakeIdGenerator::global_id().unwrap());
-    let rcpt = format!("{local}@{RCPT_DOMAIN}");
-    server
-        .send_autogenerated(
-            "[email protected]",
-            [rcpt.as_str()].into_iter(),
-            format!(
-                "From: [email protected]\r\nTo: {rcpt}\r\n\
-                 Subject: live role test\r\n\r\nTest\r\n"
-            )
-            .into_bytes(),
-            None,
-            0,
-        )
-        .await;
-    assert!(
-        queued_recipient(server, &rcpt).await.is_some(),
-        "message to {rcpt} was not queued"
-    );
-
-    let task = SnowflakeIdGenerator::global_id().unwrap();
-    let mut batch = BatchBuilder::new();
-    batch.schedule_task_with_id(
-        task,
-        Task::TlsReport(TaskTlsReport {
-            report_id: u64::MAX.into(),
-            status: TaskStatus::now(),
-        }),
-    );
-    server.store().write(batch.build_all()).await.unwrap();
-    server.notify_task_queue();
-
-    (rcpt, task)
-}
-
-/// Whether delivery to `rcpt` was tried: the message is gone, or its
-/// recipient is no longer scheduled or has a retry count.
-async fn attempted(server: &Server, rcpt: &str) -> bool {
-    match queued_recipient(server, rcpt).await {
-        None => true,
-        Some((status_scheduled, retries)) => !status_scheduled || retries > 0,
-    }
-}
-
-/// The queued recipient `rcpt`: whether it is still scheduled, and how many
-/// times delivery was retried.
-async fn queued_recipient(server: &Server, rcpt: &str) -> Option<(bool, u32)> {
-    let mut found = None;
-    server
-        .store()
-        .iterate(
-            IterateParams::new(
-                ValueKey::from(ValueClass::Queue(QueueClass::Message(0))),
-                ValueKey::from(ValueClass::Queue(QueueClass::Message(u64::MAX))),
-            ),
-            |_, value| {
-                let message = <Archive<AlignedBytes> as Deserialize>::deserialize(value)?
-                    .deserialize::<Message>()?;
-                if let Some(recipient) = message
-                    .recipients
-                    .iter()
-                    .find(|recipient| recipient.address.as_ref() == rcpt)
-                {
-                    found = Some((
-                        matches!(recipient.status, Status::Scheduled),
-                        recipient.retry.inner,
-                    ));
-                    return Ok(false);
-                }
-                Ok(true)
-            },
-        )
-        .await
-        .unwrap();
-    found
-}
-
-async fn is_pending(server: &Server, id: u64) -> bool {
-    matches!(
-        server
-            .store()
-            .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
-                TaskQueueClass::Task { id },
-            )))
-            .await
-            .unwrap()
-            .map(|task| task.status().clone()),
-        Some(TaskStatus::Pending(_))
-    )
-}
-
-async fn wait_for<F, Fut>(within: Duration, what: &str, mut check: F)
-where
-    F: FnMut() -> Fut,
-    Fut: Future<Output = bool>,
-{
-    let started = Instant::now();
-    while !check().await {
-        assert!(
-            started.elapsed() < within,
-            "still waiting for the {what} after {:?}",
-            started.elapsed()
-        );
-        tokio::time::sleep(Duration::from_millis(250)).await;
-    }
-}

tests/src/cluster/mod.rs

@@ -2,13 +2,7 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 pub mod broadcast;
-pub mod live_roles; // inbuxa: role edits apply without a restart
-#[cfg(feature = "nats")]
-pub mod coordinator; // inbuxa: coordinator reconnects
 pub mod stress;
-pub mod task_roles; // inbuxa: task types follow cluster roles

tests/src/cluster/task_roles.rs

@@ -1,218 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-//! Two task managers with different cluster roles over one shared store:
-//! each runs only the task types its role allows, and a task one node may
-//! not run is left for the node that may. Needs a store both nodes can open
-//! (STORE=PostgreSql or MySql).
-
-use crate::utils::server::TestServerBuilder;
-use common::Server;
-use registry::{
-    schema::{
-        enums::{ClusterTaskType, IndexDocumentType},
-        structs::{
-            ClusterListenerGroup, ClusterRole, ClusterTaskGroup, ClusterTaskGroupProperties, Task,
-            TaskDnsManagement, TaskIndexDocument, TaskStatus, TaskTlsReport,
-        },
-    },
-    types::map::Map,
-};
-use std::time::{Duration, Instant};
-use store::{
-    ValueKey,
-    write::{BatchBuilder, TaskQueueClass, ValueClass},
-};
-use utils::snowflake::SnowflakeIdGenerator;
-
-const QUEUE_ROLE: &str = "tasks_queue";
-const INDEX_MTA_ROLE: &str = "tasks_index_mta";
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn task_role_tests() {
-    if matches!(
-        std::env::var("STORE").as_deref(),
-        Ok("RocksDb" | "Sqlite") | Err(_)
-    ) {
-        println!("Skipping task role tests: they need a store both nodes can open.");
-        return;
-    }
-    println!(
-        "Running task role tests on {}...",
-        std::env::var("STORE").unwrap_or_default()
-    );
-
-    // The roles, stored by a node that runs no services of its own (a node
-    // looks its role up when it starts)
-    let seed = TestServerBuilder::new("task_roles_seed")
-        .await
-        .with_object(role(QUEUE_ROLE, &[ClusterTaskType::TaskQueueProcessing]))
-        .await
-        .with_object(role(
-            INDEX_MTA_ROLE,
-            &[
-                ClusterTaskType::SearchIndexing,
-                ClusterTaskType::OutboundMta,
-            ],
-        ))
-        .await
-        .disable_services()
-        .build()
-        .await;
-
-    // Node A runs queue tasks (taskQueueProcessing) only
-    let node_a = TestServerBuilder::new_with_role(
-        "task_roles_a",
-        "node-a.example.com".into(),
-        Some(QUEUE_ROLE.into()),
-        false,
-    )
-    .await
-    .build_with_opts(false)
-    .await;
-    let server_a = node_a.server.clone();
-    let roles = &server_a.core.network.roles;
-    assert!(roles.task_manager && !roles.search_indexing && !roles.outbound_mta);
-
-    // A DNS task (taskQueueProcessing), an unindex task (searchIndexing) and
-    // a TLS report (outboundMta), all due now
-    let [dns, unindex, report] = new_task_ids();
-    let mut batch = BatchBuilder::new();
-    batch
-        .schedule_task_with_id(
-            dns,
-            Task::DnsManagement(TaskDnsManagement {
-                status: TaskStatus::now(),
-                ..Default::default()
-            }),
-        )
-        .schedule_task_with_id(
-            unindex,
-            Task::UnindexDocument(TaskIndexDocument {
-                account_id: 0u32.into(),
-                document_id: u32::MAX.into(),
-                document_type: IndexDocumentType::File,
-                status: TaskStatus::now(),
-            }),
-        )
-        .schedule_task_with_id(
-            report,
-            Task::TlsReport(TaskTlsReport {
-                report_id: u64::MAX.into(),
-                status: TaskStatus::now(),
-            }),
-        );
-    server_a.store().write(batch.build_all()).await.unwrap();
-    server_a.notify_task_queue();
-
-    // Node A runs the DNS task and leaves the other two alone. Upstream ran
-    // the TLS report here too: report tasks ran on any node with a task
-    // manager.
-    wait_until_run(&server_a, &[dns], Duration::from_secs(20)).await;
-    tokio::time::sleep(Duration::from_secs(3)).await;
-    server_a.notify_task_queue();
-    tokio::time::sleep(Duration::from_secs(2)).await;
-    assert!(
-        is_pending(&server_a, unindex).await,
-        "unindex ran on node A"
-    );
-    assert!(
-        is_pending(&server_a, report).await,
-        "TLS report ran on node A"
-    );
-
-    // Node B (search indexing and outbound MTA) comes up and picks up what
-    // node A left
-    let node_b = TestServerBuilder::new_with_role(
-        "task_roles_b",
-        "node-b.example.com".into(),
-        Some(INDEX_MTA_ROLE.into()),
-        false,
-    )
-    .await
-    .build_with_opts(false)
-    .await;
-    let server_b = node_b.server.clone();
-    let roles = &server_b.core.network.roles;
-    assert!(!roles.task_manager && roles.search_indexing && roles.outbound_mta);
-    server_b.notify_task_queue();
-    wait_until_run(&server_b, &[unindex, report], Duration::from_secs(20)).await;
-
-    // A queue task scheduled now still runs, on node A: node B may not
-    // claim it
-    let [dns] = new_task_ids();
-    let mut batch = BatchBuilder::new();
-    batch.schedule_task_with_id(
-        dns,
-        Task::DnsManagement(TaskDnsManagement {
-            status: TaskStatus::now(),
-            ..Default::default()
-        }),
-    );
-    server_b.store().write(batch.build_all()).await.unwrap();
-    server_b.notify_task_queue();
-    tokio::time::sleep(Duration::from_secs(3)).await;
-    assert!(is_pending(&server_b, dns).await, "DNS task ran on node B");
-    server_a.notify_task_queue();
-    wait_until_run(&server_a, &[dns], Duration::from_secs(20)).await;
-
-    if seed.is_reset() {
-        seed.temp_dir.delete();
-        node_a.temp_dir.delete();
-        node_b.temp_dir.delete();
-    }
-}
-
-fn role(name: &str, tasks: &[ClusterTaskType]) -> ClusterRole {
-    ClusterRole {
-        name: name.into(),
-        description: None,
-        listeners: ClusterListenerGroup::EnableAll,
-        tasks: ClusterTaskGroup::EnableSome(ClusterTaskGroupProperties {
-            task_types: Map::new(tasks.to_vec()),
-        }),
-    }
-}
-
-fn new_task_ids<const N: usize>() -> [u64; N] {
-    std::array::from_fn(|_| SnowflakeIdGenerator::global_id().unwrap())
-}
-
-/// Still due and never run: present, and pending.
-async fn is_pending(server: &Server, id: u64) -> bool {
-    matches!(
-        server
-            .store()
-            .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
-                TaskQueueClass::Task { id },
-            )))
-            .await
-            .unwrap()
-            .map(|task| task.status().clone()),
-        Some(TaskStatus::Pending(_))
-    )
-}
-
-async fn wait_until_run(server: &Server, ids: &[u64], within: Duration) {
-    let started = Instant::now();
-    loop {
-        let mut left = 0;
-        for id in ids {
-            if is_pending(server, *id).await {
-                left += 1;
-            }
-        }
-        if left == 0 {
-            return;
-        }
-        assert!(
-            started.elapsed() < within,
-            "{left} task(s) still pending after {:?}",
-            started.elapsed()
-        );
-        tokio::time::sleep(Duration::from_millis(250)).await;
-    }
-}

tests/src/smtp/inbound/milter.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{
@@ -77,7 +75,7 @@ async fn milter_session() {
                 else_: "true".into(),
                 ..Default::default()
             },
-            hostname: "localhost".into(), // inbuxa: resolved when the session connects
+            hostname: "127.0.0.1".into(),
             port: 9332,
             use_tls: false,
             stages: Map::new(vec![MtaStage::Data]),

tests/src/smtp/inbound/mod.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::utils::server::TestServer;
@@ -42,23 +40,15 @@ pub mod vrfy;
 const EVENT_TIMEOUT: Duration = Duration::from_secs(5);
 
 impl TestServer {
-    // inbuxa: registry writes reload the settings, and each reload sends the
-    // queue a ReloadSettings; read_event, try_read_event and assert_no_events
-    // pass over those (expect_reload_settings still waits for one)
     pub async fn read_event(&mut self) -> QueueEvent {
-        while let Some(event) = self.queue_events.pop_front() {
+        if let Some(event) = self.queue_events.pop_front() {
-            if !event.is_reload_settings() {
+            return event;
-                return event;
-            }
         }
 
-        loop {
+        match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
-            match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
+            Ok(Some(event)) => event,
-                Ok(Some(event)) if event.is_reload_settings() => (),
+            Ok(None) => panic!("Channel closed."),
-                Ok(Some(event)) => return event,
+            Err(_) => panic!("No queue event received."),
-                Ok(None) => panic!("Channel closed."),
-                Err(_) => panic!("No queue event received."),
-            }
         }
     }
 
@@ -88,39 +78,26 @@ impl TestServer {
     }
 
     pub async fn try_read_event(&mut self) -> Option<QueueEvent> {
-        while let Some(event) = self.queue_events.pop_front() {
+        if let Some(event) = self.queue_events.pop_front() {
-            if !event.is_reload_settings() {
+            return Some(event);
-                return Some(event);
-            }
         }
 
-        loop {
+        match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
-            match tokio::time::timeout(EVENT_TIMEOUT, self.queue_rx.recv()).await {
+            Ok(Some(event)) => Some(event),
-                Ok(Some(event)) if event.is_reload_settings() => (),
+            Ok(None) => panic!("Channel closed."),
-                Ok(Some(event)) => return Some(event),
+            Err(_) => None,
-                Ok(None) => panic!("Channel closed."),
-                Err(_) => return None,
-            }
         }
     }
 
     pub fn assert_no_events(&mut self) {
-        if let Some(event) = self
+        if let Some(event) = self.queue_events.pop_front() {
-            .queue_events
-            .iter()
-            .find(|event| !event.is_reload_settings())
-        {
             panic!("Expected empty queue but got {event:?}");
         }
-        self.queue_events.clear();
 
-        loop {
+        match self.queue_rx.try_recv() {
-            match self.queue_rx.try_recv() {
+            Err(TryRecvError::Empty) => (),
-                Ok(event) if event.is_reload_settings() => (),
+            Ok(event) => panic!("Expected empty queue but got {event:?}"),
-                Err(TryRecvError::Empty) => break,
+            Err(err) => panic!("Queue error: {err:?}"),
-                Ok(event) => panic!("Expected empty queue but got {event:?}"),
-                Err(err) => panic!("Queue error: {err:?}"),
-            }
         }
     }
 

tests/src/smtp/reporting/mod.rs

@@ -2,9 +2,12 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
+ *
+ * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 pub mod analyze;
 pub mod dmarc;
+pub mod reschedule; // inbuxa: report reschedules and unreadable queue rows
 pub mod scheduler;
 pub mod tls;

tests/src/smtp/reporting/reschedule.rs

@@ -0,0 +1,370 @@
+/*
+ * SPDX-FileCopyrightText: 2026 Coffey Labs
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only
+ */
+
+//! Rescheduling an internal DMARC or TLS report over JMAP moves its task: the
+//! task runs at the new time, x:Task/get shows the new due, and tasks due
+//! after it still run. A task queue row whose type can't be read is logged
+//! and repaired rather than stopping every task due after it, including the
+//! rows an earlier reschedule wrote with the report's object type.
+
+use crate::utils::server::{TestServer, TestServerBuilder};
+use common::{
+    Server,
+    config::smtp::report::AggregateFrequency,
+    ipc::{DmarcEvent, PolicyType, TlsEvent},
+};
+use mail_auth::{
+    common::parse::TxtRecordParser,
+    dmarc::Dmarc,
+    mta_sts::TlsRpt,
+    report::{ActionDisposition, DmarcResult, Record},
+};
+use registry::{
+    schema::{
+        enums::{TaskStoreMaintenanceType, TaskType},
+        prelude::{ObjectType, Property},
+        structs::{
+            DmarcInternalReport, DmarcReportSettings, Expression, Task, TaskStatus,
+            TaskStoreMaintenance, TlsInternalReport, TlsReportSettings,
+        },
+    },
+    types::{EnumImpl, ObjectImpl, datetime::UTCDateTime},
+};
+use serde_json::json;
+use smtp::reporting::{index::InternalReportIndex, send::MtaReportSend};
+use std::{
+    sync::Arc,
+    time::{Duration, Instant},
+};
+use store::{
+    SerializeInfallible, ValueKey,
+    write::{BatchBuilder, RegistryClass, TaskQueueClass, ValueClass, now},
+};
+use types::id::Id;
+use utils::snowflake::SnowflakeIdGenerator;
+
+#[tokio::test(flavor = "multi_thread")]
+#[serial_test::serial]
+async fn report_reschedule() {
+    let mut test = TestServerBuilder::new("smtp_report_reschedule")
+        .await
+        .with_http_listener(19057)
+        .await
+        .capture_queue()
+        .build()
+        .await;
+
+    let admin = test.account("admin");
+    admin
+        .registry_create_object(TlsReportSettings {
+            max_report_size: Expression {
+                else_: "1024".into(),
+                ..Default::default()
+            },
+            ..Default::default()
+        })
+        .await;
+    admin
+        .registry_create_object(DmarcReportSettings {
+            aggregate_max_report_size: Expression {
+                else_: "1024".into(),
+                ..Default::default()
+            },
+            ..Default::default()
+        })
+        .await;
+    admin.reload_settings().await;
+    test.reload_core();
+    test.expect_reload_settings().await;
+    let admin = test.account("admin");
+
+    // A daily DMARC and TLS report, due a day from now
+    schedule_dmarc(&test, "foobar.org").await;
+    schedule_tls(&test, "foobar.org").await;
+    let dmarc_id = wait_for_report::<DmarcInternalReport>(&test, "foobar.org").await;
+    let tls_id = wait_for_report::<TlsInternalReport>(&test, "foobar.org").await;
+
+    // Reschedule both to a few seconds from now, with a task due after them
+    let at = now() + 3;
+    let later = marker_task(&test.server, at + 3).await;
+    for (object, id, task_type) in [
+        (
+            ObjectType::DmarcInternalReport,
+            dmarc_id,
+            TaskType::DmarcReport,
+        ),
+        (ObjectType::TlsInternalReport, tls_id, TaskType::TlsReport),
+    ] {
+        admin
+            .registry_update_object(
+                object,
+                id,
+                json!({
+                    Property::DeliverAt: UTCDateTime::from_timestamp(at as i64),
+                }),
+            )
+            .await;
+
+        // x:Task/get shows the new due, and the queue row carries the task's
+        // type. Upstream wrote the report's object type there and left the
+        // task at its old due
+        let task = admin.registry_get::<Task>(id).await;
+        assert_eq!(task.object_type(), task_type);
+        assert_eq!(
+            task.due_timestamp(),
+            at,
+            "{object:?} task due not moved: {task:?}"
+        );
+        assert_eq!(
+            queue_row(&test.server, id.id(), at).await,
+            Some(task_type.to_id().serialize()),
+            "{object:?} queue row"
+        );
+    }
+
+    // Both reports go out at the new time, and the later task still runs
+    wait_until_run(&test.server, &[dmarc_id.id(), tls_id.id(), later]).await;
+    assert!(now() >= at, "the reports went out before their new time");
+    assert!(
+        admin
+            .registry_get_all::<DmarcInternalReport>()
+            .await
+            .is_empty()
+    );
+    assert!(
+        admin
+            .registry_get_all::<TlsInternalReport>()
+            .await
+            .is_empty()
+    );
+
+    // Rows an earlier reschedule may have left in a store: one with the
+    // report's object type and the task left at its old due, and one that
+    // is unreadable and has no task behind it. Neither may hold back a task
+    // due after them.
+    schedule_dmarc(&test, "foobar.net").await;
+    let dmarc_id = wait_for_report::<DmarcInternalReport>(&test, "foobar.net").await;
+    let at = now() + 2;
+    let old_due = old_style_reschedule(&test.server, dmarc_id.id(), at).await;
+    let orphan = SnowflakeIdGenerator::global_id().unwrap();
+    let mut batch = BatchBuilder::new();
+    batch.set(
+        ValueClass::TaskQueue(TaskQueueClass::Due {
+            id: orphan,
+            due: at,
+        }),
+        vec![0xff, 0xff],
+    );
+    test.server.store().write(batch.build_all()).await.unwrap();
+    let later = marker_task(&test.server, at + 2).await;
+
+    wait_until_run(&test.server, &[dmarc_id.id(), later]).await;
+    assert!(
+        admin
+            .registry_get_all::<DmarcInternalReport>()
+            .await
+            .is_empty()
+    );
+    assert_eq!(queue_row(&test.server, orphan, at).await, None);
+    assert_eq!(queue_row(&test.server, dmarc_id.id(), at).await, None);
+    assert_eq!(queue_row(&test.server, dmarc_id.id(), old_due).await, None);
+
+    // x:Task/query by type skips an unreadable row rather than failing
+    let mut batch = BatchBuilder::new();
+    let due = now() + 3600;
+    batch.set(
+        ValueClass::TaskQueue(TaskQueueClass::Due { id: orphan, due }),
+        vec![0xff, 0xff],
+    );
+    test.server.store().write(batch.build_all()).await.unwrap();
+    admin
+        .registry_query_ids(
+            ObjectType::Task,
+            vec![(Property::Type, TaskType::DmarcReport.as_str())],
+            Vec::<&str>::new(),
+        )
+        .await;
+    let mut batch = BatchBuilder::new();
+    batch.clear(ValueClass::TaskQueue(TaskQueueClass::Due {
+        id: orphan,
+        due,
+    }));
+    test.server.store().write(batch.build_all()).await.unwrap();
+
+    if test.is_reset() {
+        test.temp_dir.delete();
+    }
+}
+
+async fn schedule_dmarc(test: &TestServer, domain: &str) {
+    test.server
+        .schedule_report(DmarcEvent {
+            domain: domain.to_string(),
+            report_record: Record::new()
+                .with_source_ip("192.168.1.2".parse().unwrap())
+                .with_action_disposition(ActionDisposition::Pass)
+                .with_dmarc_dkim_result(DmarcResult::Pass)
+                .with_dmarc_spf_result(DmarcResult::Fail)
+                .with_envelope_from("[email protected]")
+                .with_envelope_to("[email protected]")
+                .with_header_from("[email protected]"),
+            dmarc_record: Arc::new(
+                Dmarc::parse(format!("v=DMARC1; p=reject; rua=mailto:reports@{domain}").as_bytes())
+                    .unwrap(),
+            ),
+            interval: AggregateFrequency::Daily,
+            span_id: 0,
+        })
+        .await;
+}
+
+async fn schedule_tls(test: &TestServer, domain: &str) {
+    test.server
+        .schedule_report(TlsEvent {
+            domain: domain.to_string(),
+            policy: PolicyType::None,
+            failure: None,
+            tls_record: Arc::new(
+                TlsRpt::parse(format!("v=TLSRPTv1;rua=mailto:reports@{domain}").as_bytes())
+                    .unwrap(),
+            ),
+            interval: AggregateFrequency::Daily,
+            span_id: 0,
+        })
+        .await;
+}
+
+trait ReportDomain: ObjectImpl {
+    fn report_domain(&self) -> &str;
+}
+
+impl ReportDomain for DmarcInternalReport {
+    fn report_domain(&self) -> &str {
+        &self.domain
+    }
+}
+
+impl ReportDomain for TlsInternalReport {
+    fn report_domain(&self) -> &str {
+        &self.domain
+    }
+}
+
+async fn wait_for_report<T: ReportDomain>(test: &TestServer, domain: &str) -> Id {
+    let admin = test.account("admin");
+    for _ in 0..100 {
+        if let Some((id, _)) = admin
+            .registry_get_all::<T>()
+            .await
+            .into_iter()
+            .find(|(_, report)| report.report_domain() == domain)
+        {
+            return id;
+        }
+        tokio::time::sleep(Duration::from_millis(100)).await;
+    }
+    panic!("No {} for {domain}", T::OBJECT.as_str());
+}
+
+/// A task that succeeds when it runs, due at `due`.
+async fn marker_task(server: &Server, due: u64) -> u64 {
+    let id = SnowflakeIdGenerator::global_id().unwrap();
+    let mut batch = BatchBuilder::new();
+    batch.schedule_task_with_id(
+        id,
+        Task::StoreMaintenance(TaskStoreMaintenance {
+            maintenance_type: TaskStoreMaintenanceType::RemoveLockDav,
+            shard_index: Some(0),
+            status: TaskStatus::at(due as i64),
+        }),
+    );
+    server.store().write(batch.build_all()).await.unwrap();
+    server.notify_task_queue();
+    id
+}
+
+/// What the reschedule before this fix wrote: the report's object type in
+/// the new queue row, and the task row left at its old due. Returns that
+/// old due.
+async fn old_style_reschedule(server: &Server, item_id: u64, at: u64) -> u64 {
+    let object_id = ObjectType::DmarcInternalReport.to_id();
+    let key = ValueClass::Registry(RegistryClass::Item { object_id, item_id });
+    let mut report = server
+        .store()
+        .get_value::<DmarcInternalReport>(ValueKey::from(key.clone()))
+        .await
+        .unwrap()
+        .unwrap();
+    let old_due = report.deliver_at().timestamp() as u64;
+    report.set_deliver_at(UTCDateTime::from_timestamp(at as i64));
+    let mut batch = BatchBuilder::new();
+    batch
+        .clear(ValueClass::TaskQueue(TaskQueueClass::Due {
+            id: item_id,
+            due: old_due,
+        }))
+        .set(
+            ValueClass::TaskQueue(TaskQueueClass::Due {
+                id: item_id,
+                due: at,
+            }),
+            object_id.serialize(),
+        )
+        .set(key, report.to_pickled_vec());
+    server.store().write(batch.build_all()).await.unwrap();
+    server.notify_task_queue();
+    old_due
+}
+
+struct RawValue(Vec<u8>);
+
+impl store::Deserialize for RawValue {
+    fn deserialize(bytes: &[u8]) -> trc::Result<Self> {
+        Ok(RawValue(bytes.to_vec()))
+    }
+}
+
+async fn queue_row(server: &Server, id: u64, due: u64) -> Option<Vec<u8>> {
+    server
+        .store()
+        .get_value::<RawValue>(ValueKey::from(ValueClass::TaskQueue(TaskQueueClass::Due {
+            id,
+            due,
+        })))
+        .await
+        .unwrap()
+        .map(|raw| raw.0)
+}
+
+async fn task_exists(server: &Server, id: u64) -> bool {
+    server
+        .store()
+        .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
+            TaskQueueClass::Task { id },
+        )))
+        .await
+        .unwrap()
+        .is_some()
+}
+
+async fn wait_until_run(server: &Server, ids: &[u64]) {
+    let started = Instant::now();
+    loop {
+        let mut pending = Vec::new();
+        for id in ids {
+            if task_exists(server, *id).await {
+                pending.push(*id);
+            }
+        }
+        if pending.is_empty() {
+            return;
+        }
+        if started.elapsed() > Duration::from_secs(30) {
+            panic!("tasks {pending:?} never ran");
+        }
+        tokio::time::sleep(Duration::from_millis(200)).await;
+    }
+}

tests/src/store/import_export.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::utils::{
@@ -11,22 +9,14 @@ use crate::utils::{
     server::TestServer,
     temp_dir::TempDir,
 };
-use ::registry::schema::{
+use ::registry::schema::enums::CompressionAlgo;
-    enums::{CompressionAlgo, TaskStoreMaintenanceType},
-    prelude::ObjectType,
-    structs::Task,
-};
 use ahash::AHashSet;
-use common::{
+use common::{DATABASE_SCHEMA_VERSION, manager::backup::BackupParams};
-    DATABASE_SCHEMA_VERSION,
-    manager::{SPAM_CLASSIFIER_KEY, SPAM_TRAINER_KEY, backup::BackupParams},
-};
 use store::{
     rand,
     write::{
         AnyClass, AnyKey, BatchBuilder, BlobLink, BlobOp, Operation, QueueClass, QueueEvent,
-        RegistryClass, TaskQueueClass, ValueClass,
+        RegistryClass, ValueClass, key::KeySerializer,
-        key::{DeserializeBigEndian, KeySerializer},
     },
     *,
 };
@@ -177,50 +167,6 @@ pub async fn test(test: &TestServer) {
     }
     db.write(batch.build_all()).await.unwrap();
 
-    // inbuxa: registry objects kept outside the registry subspace (archived
-    // items for undelete, spam training samples, directory entries) and the
-    // fork's own subspace. Exports used to leave the first two behind.
-    println!("Creating archived items, spam samples and fork data...");
-    let mut batch = BatchBuilder::new();
-    for item_id in [1u64, 2, 3] {
-        for object in [
-            ObjectType::ArchivedItem,
-            ObjectType::SpamTrainingSample,
-            ObjectType::Account,
-        ] {
-            batch.set(
-                ValueClass::Registry(RegistryClass::Item {
-                    object_id: object as u16,
-                    item_id,
-                }),
-                random_bytes(item_id as usize * 64),
-            );
-        }
-        batch.set(
-            ValueClass::Any(AnyClass {
-                subspace: SUBSPACE_INBUXA,
-                key: [b'U', b'x']
-                    .into_iter()
-                    .chain(item_id.to_be_bytes())
-                    .collect(),
-            }),
-            random_bytes(32),
-        );
-    }
-    db.write(batch.build_all()).await.unwrap();
-
-    // inbuxa: the trained spam classifier lives in blobs with fixed names
-    let mut named_blobs = Vec::new();
-    for key in [SPAM_CLASSIFIER_KEY, SPAM_TRAINER_KEY] {
-        let data = random_bytes(4096);
-        test.server
-            .blob_store()
-            .put_blob(key, &data, CompressionAlgo::Lz4)
-            .await
-            .unwrap();
-        named_blobs.push((key, data));
-    }
-
     // Create directory data
     println!("Creating directory data...");
     let mut batch = BatchBuilder::new();
@@ -239,17 +185,6 @@ pub async fn test(test: &TestServer) {
     println!("Calculating store hash...");
     let snapshot = Snapshot::new(&db).await;
     assert!(!snapshot.keys.is_empty(), "Store hash counts are empty",);
-    for subspace in [
-        SUBSPACE_DELETED_ITEMS,
-        SUBSPACE_SPAM_SAMPLES,
-        SUBSPACE_INBUXA,
-    ] {
-        assert!(
-            snapshot.keys.iter().any(|k| k.subspace == subspace),
-            "No test data in subspace {}",
-            char::from(subspace)
-        );
-    }
 
     // Export store
     println!("Exporting store...");
@@ -275,188 +210,22 @@ pub async fn test(test: &TestServer) {
             .finalize(),
     );
     db.write(batch.build_all()).await.unwrap();
-    for (key, _) in &named_blobs {
+    test.server.core.restore(temp_dir.path.clone()).await;
-        test.server.blob_store().delete_blob(key).await.unwrap();
-    }
-    let imported = test.server.core.restore(temp_dir.path.clone()).await;
     let mut batch = BatchBuilder::new();
     batch.clear(ValueClass::NodeId(0));
     db.write(batch.build_all()).await.unwrap();
-    for subspace in [
-        SUBSPACE_DELETED_ITEMS,
-        SUBSPACE_SPAM_SAMPLES,
-        SUBSPACE_INBUXA,
-    ] {
-        assert!(
-            imported.contains(&subspace),
-            "Subspace {} was not exported",
-            char::from(subspace)
-        );
-    }
 
     // Verify hash
     print!("Verifying store hash...");
     snapshot.assert_is_eq(&Snapshot::new(&db).await);
-    assert_named_blobs(test.server.blob_store(), &named_blobs).await;
     println!(" GREAT SUCCESS!");
 
-    // inbuxa: import the same export into a fresh store of another backend,
-    // the way a move from one database to another does it
-    #[cfg(all(feature = "rocks", feature = "sqlite"))]
-    cross_backend(test, &db, &temp_dir, &named_blobs).await;
-
     // Destroy store
-    for (key, _) in &named_blobs {
-        test.server.blob_store().delete_blob(key).await.unwrap();
-    }
     store_destroy(&db).await;
     store_assert_is_empty(&db, db.clone().into(), true).await;
     temp_dir.delete();
 }
 
-#[cfg(all(feature = "rocks", feature = "sqlite"))]
-async fn cross_backend(
-    test: &TestServer,
-    source: &Store,
-    export: &TempDir,
-    named_blobs: &[(&[u8], Vec<u8>)],
-) {
-    let source_type = std::env::var("STORE").unwrap();
-    let target_type = if source_type.eq_ignore_ascii_case("sqlite") {
-        "RocksDb"
-    } else {
-        "Sqlite"
-    };
-    println!("Importing the export into a fresh {target_type} store...");
-
-    let target_dir = TempDir::new("art_vandelay_cross_backend", true);
-    let target = Store::build(
-        crate::utils::storage::build_data_store(target_type, &target_dir.path.to_string_lossy())
-            .await,
-    )
-    .await
-    .unwrap();
-    target.create_tables().await.unwrap();
-    store_destroy(&target).await;
-
-    let mut core = test.server.core.as_ref().clone();
-    core.storage.data = target.clone();
-    core.storage.blob = target.clone().into();
-    let imported = core.restore(export.path.clone()).await;
-
-    // Counters are stored differently by the SQL and key-value backends, so
-    // compare their keys here and their values through the counter API.
-    print!("Verifying {target_type} store hash...");
-    Snapshot::new_portable(source)
-        .await
-        .assert_is_eq(&Snapshot::new_portable(&target).await);
-    for subspace in [SUBSPACE_COUNTER, SUBSPACE_QUOTA] {
-        let mut keys = Vec::new();
-        source
-            .iterate(
-                IterateParams::new(
-                    AnyKey {
-                        subspace,
-                        key: vec![0u8],
-                    },
-                    AnyKey {
-                        subspace,
-                        key: vec![u8::MAX; 10],
-                    },
-                )
-                .no_values(),
-                |key, _| {
-                    keys.push(key.to_vec());
-                    Ok(true)
-                },
-            )
-            .await
-            .unwrap();
-        for key in keys {
-            let class = || {
-                ValueClass::Any(AnyClass {
-                    subspace,
-                    key: key.clone(),
-                })
-            };
-            assert_eq!(
-                source.get_counter(class()).await.unwrap(),
-                target.get_counter(class()).await.unwrap(),
-                "Counter mismatch in {} for {key:?}",
-                char::from(subspace)
-            );
-        }
-    }
-    assert_named_blobs(&core.storage.blob, named_blobs).await;
-    println!(" GREAT SUCCESS!");
-
-    // The search index isn't exported; the import queues its rebuild
-    let queued = core.queue_reindex(&imported).await;
-    let expected = [
-        TaskStoreMaintenanceType::ReindexAccounts,
-        TaskStoreMaintenanceType::ReindexTelemetry,
-    ];
-    assert_eq!(queued, expected);
-    let mut task_ids = Vec::new();
-    target
-        .iterate(
-            IterateParams::new(
-                AnyKey {
-                    subspace: SUBSPACE_TASK_QUEUE,
-                    key: vec![0u8],
-                },
-                AnyKey {
-                    subspace: SUBSPACE_TASK_QUEUE,
-                    key: vec![u8::MAX; 20],
-                },
-            )
-            .no_values(),
-            |key, _| {
-                if key.deserialize_be_u64(0)? == 0 {
-                    task_ids.push(key.deserialize_be_u64(U64_LEN)?);
-                }
-                Ok(true)
-            },
-        )
-        .await
-        .unwrap();
-    let mut found = Vec::new();
-    for id in task_ids {
-        match target
-            .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
-                TaskQueueClass::Task { id },
-            )))
-            .await
-            .unwrap()
-        {
-            Some(Task::StoreMaintenance(task)) => found.push(task.maintenance_type),
-            other => panic!("Unexpected task {other:?}"),
-        }
-    }
-    found.sort_by_key(|t| *t as u16);
-    assert_eq!(found, expected, "Queued tasks don't match");
-
-    store_destroy(&target).await;
-    drop(core);
-    drop(target);
-    target_dir.delete();
-}
-
-async fn assert_named_blobs(blob_store: &BlobStore, named_blobs: &[(&[u8], Vec<u8>)]) {
-    for (key, data) in named_blobs {
-        assert_eq!(
-            blob_store
-                .get_blob(key, 0..usize::MAX)
-                .await
-                .unwrap()
-                .as_ref(),
-            Some(data),
-            "Blob {} was not restored",
-            String::from_utf8_lossy(key)
-        );
-    }
-}
-
 #[derive(Debug, PartialEq, Eq)]
 struct Snapshot {
     keys: AHashSet<KeyValue>,
@@ -471,19 +240,7 @@ struct KeyValue {
 
 impl Snapshot {
     async fn new(db: &Store) -> Self {
-        Self::build(db, !db.is_sql(), true).await
+        let is_sql = db.is_sql();
-    }
-
-    /// Comparable across backends: no counter values, which the SQL and
-    /// key-value stores encode differently, and no blobs, which only live in
-    /// the data store when it doubles as the blob store.
-    #[cfg(all(feature = "rocks", feature = "sqlite"))]
-    async fn new_portable(db: &Store) -> Self {
-        Self::build(db, false, false).await
-    }
-
-    async fn build(db: &Store, counter_values: bool, with_blobs: bool) -> Self {
-        let is_sql = !counter_values;
 
         let mut keys = AHashSet::new();
 
@@ -508,12 +265,7 @@ impl Snapshot {
             (SUBSPACE_QUOTA, !is_sql),
             (SUBSPACE_REPORT_OUT, true),
             (SUBSPACE_REPORT_IN, true),
-            (SUBSPACE_DIRECTORY, true),
-            (SUBSPACE_INBUXA, true),
         ] {
-            if subspace == SUBSPACE_BLOBS && !with_blobs {
-                continue;
-            }
             let from_key = AnyKey {
                 subspace,
                 key: vec![0u8],

tests/src/store/mod.rs

@@ -10,8 +10,6 @@ pub mod blob;
 pub mod import_export;
 pub mod lookup;
 pub mod ops;
-#[cfg(any(feature = "postgres", feature = "mysql"))]
-pub mod pool_timeout; // inbuxa: SQL pools give up instead of hanging
 pub mod query;
 pub mod registry;
 #[cfg(feature = "postgres")]
@@ -23,7 +21,6 @@ pub mod replica_cluster; // inbuxa: read replicas across nodes
 pub mod scaleout; // inbuxa: scale-out storage
 #[cfg(any(feature = "postgres", feature = "mysql"))]
 pub mod sql_timeout;
-pub mod task_locks; // inbuxa: task locks across nodes
 
 use crate::utils::server::TestServerBuilder;
 use std::io::Read;

tests/src/store/pool_timeout.rs

@@ -1,96 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-//! A database that accepts connections and then says nothing (a hung or
-//! half-dead server, a black-holed failover) gives a worker an error within
-//! the pool's timeouts. Upstream's pools had none, so the worker waited for
-//! good. No database is needed: a local listener that never answers plays
-//! the server.
-
-use registry::schema::structs::DataStore;
-use std::time::{Duration, Instant};
-use store::{Store, ValueKey, write::ValueClass};
-use tokio::net::TcpListener;
-
-/// Accepts connections on a local port and never sends a byte.
-async fn silent_server() -> u16 {
-    let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
-    let port = listener.local_addr().unwrap().port();
-    tokio::spawn(async move {
-        let mut held = Vec::new();
-        while let Ok((socket, _)) = listener.accept().await {
-            held.push(socket);
-        }
-    });
-    port
-}
-
-/// Builds the store and reads a key; both must end, with an error for the
-/// read, well within `limit`.
-async fn assert_times_out(data_store: DataStore, limit: Duration) {
-    let started = Instant::now();
-    let result = tokio::time::timeout(limit, async {
-        match Store::build(data_store).await {
-            Ok(store) => store
-                .get_value::<u64>(ValueKey::from(ValueClass::Property(0)))
-                .await
-                .map(|_| ())
-                .map_err(|err| err.to_string()),
-            Err(err) => Err(err.to_string()),
-        }
-    })
-    .await;
-    let elapsed = started.elapsed();
-    match result {
-        Ok(Err(err)) => println!("Got {err} after {elapsed:?}"),
-        Ok(Ok(())) => panic!("a silent server answered?"),
-        Err(_) => panic!("still waiting for a connection after {elapsed:?}"),
-    }
-}
-
-#[cfg(feature = "postgres")]
-#[tokio::test(flavor = "multi_thread")]
-pub async fn postgres_pool_timeout() {
-    use registry::schema::structs::PostgreSqlStore;
-
-    let port = silent_server().await;
-    println!("Running PostgreSQL pool timeout test...");
-    // The store's own timeout bounds opening a connection, handshake
-    // included (tokio-postgres's connect_timeout covers only the TCP connect)
-    assert_times_out(
-        DataStore::PostgreSql(PostgreSqlStore {
-            host: "127.0.0.1".into(),
-            port: port as u64,
-            database: "none".into(),
-            timeout: Some(Duration::from_secs(2).into()),
-            use_tls: false,
-            ..Default::default()
-        }),
-        Duration::from_secs(20),
-    )
-    .await;
-}
-
-#[cfg(feature = "mysql")]
-#[tokio::test(flavor = "multi_thread")]
-pub async fn mysql_pool_timeout() {
-    use registry::schema::structs::MySqlStore;
-
-    let port = silent_server().await;
-    println!("Running MySQL pool timeout test...");
-    // mysql_async has no pool timeout; the store waits 30 s for a connection
-    assert_times_out(
-        DataStore::MySql(MySqlStore {
-            host: "127.0.0.1".into(),
-            port: port as u64,
-            database: "none".into(),
-            use_tls: false,
-            ..Default::default()
-        }),
-        Duration::from_secs(60),
-    )
-    .await;
-}

tests/src/store/query.rs

@@ -2,8 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Stalwart Labs LLC <hello@stalw.art>
  *
  * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-SEL
- *
- * Modified by Coffey Labs in 2026 for INBUXA.
  */
 
 use crate::{store::deflate_test_resource, utils::server::TestServer};
@@ -124,15 +122,6 @@ pub async fn test(test: &TestServer) {
     println!("Running global id filtering tests...");
     test_global(store.clone()).await;
 
-    // inbuxa: trace documents as the index task builds them
-    println!("Running trace document tests...");
-    test_trace_documents(store.clone()).await;
-
-    // inbuxa: address fields match by full address, local part, domain and
-    // display name on every backend
-    println!("Running address search tests...");
-    test_address_search(store.clone()).await;
-
     // Large document insert test
     println!("Running large document insert tests...");
     let mut large_text = String::with_capacity(20 * 1024 * 1024);
@@ -820,312 +809,3 @@ async fn test_global(store: SearchStore) {
         AHashSet::from_iter([3, 4, 5])
     );
 }
-
-// inbuxa: MON-16: documents built by the index task from stored traces go
-// into every search backend (the SQL backends type etyp and qid as BIGINT)
-// and are found again by queue id and keyword.
-async fn test_trace_documents(store: SearchStore) {
-    use registry::schema::{
-        enums::SearchTracingField,
-        structs::{
-            Trace, TraceEvent, TraceKeyValue, TraceValue, TraceValueString,
-            TraceValueUnsignedInt,
-        },
-    };
-    use services::task_manager::index::trace_search_document;
-    use trc::{DeliveryEvent, EventType, Key, SmtpEvent};
-
-    let kv_u = |key: Key, value: u64| TraceKeyValue {
-        key,
-        value: TraceValue::UnsignedInt(TraceValueUnsignedInt { value }),
-    };
-    let kv_s = |key: Key, value: &str| TraceKeyValue {
-        key,
-        value: TraceValue::String(TraceValueString {
-            value: value.to_string(),
-        }),
-    };
-    let event = |event: EventType, key_values: Vec<TraceKeyValue>| TraceEvent {
-        event,
-        key_values: key_values.into(),
-        ..Default::default()
-    };
-    let fields = [
-        SearchTracingField::EventType,
-        SearchTracingField::QueueId,
-        SearchTracingField::Keywords,
-    ];
-
-    // An SMTP session that queued two messages, and a delivery attempt
-    let session = Trace {
-        events: vec![
-            event(
-                EventType::Smtp(SmtpEvent::ConnectionStart),
-                vec![kv_s(Key::RemoteIp, "192.0.2.7")],
-            ),
-            event(
-                EventType::Smtp(SmtpEvent::MailFrom),
-                vec![kv_s(Key::From, "[email protected]")],
-            ),
-            event(
-                EventType::Smtp(SmtpEvent::RcptTo),
-                vec![kv_u(Key::QueueId, 9_000_000_001), kv_s(Key::To, "[email protected]")],
-            ),
-            event(
-                EventType::Smtp(SmtpEvent::RcptTo),
-                vec![kv_u(Key::QueueId, 9_000_000_002)],
-            ),
-        ]
-        .into(),
-    };
-    let delivery = Trace {
-        events: vec![event(
-            EventType::Delivery(DeliveryEvent::AttemptStart),
-            vec![kv_u(Key::QueueId, 9_000_000_003), kv_s(Key::Hostname, "relay.example.net")],
-        )]
-        .into(),
-    };
-    let documents = vec![
-        trace_search_document(100, &session, &fields),
-        trace_search_document(101, &delivery, &fields),
-    ];
-    assert!(
-        documents
-            .iter()
-            .all(|d| d.has_field(&SearchField::Tracing(TracingSearchField::QueueId))
-                && d.has_field(&SearchField::Tracing(TracingSearchField::EventType))),
-        "trace documents carry a queue id and an event type"
-    );
-    store.index(documents).await.unwrap();
-    if let SearchStore::ElasticSearch(store) = &store {
-        store.refresh_index(SearchIndex::Tracing).await.unwrap();
-    }
-
-    let query = |filters: Vec<SearchFilter>| {
-        let store = store.clone();
-        async move {
-            store
-                .query_global(
-                    SearchQuery::new(SearchIndex::Tracing)
-                        .with_filter(SearchFilter::ge(SearchField::Id, 100u64))
-                        .with_filters(filters),
-                )
-                .await
-                .unwrap()
-                .into_iter()
-                .collect::<AHashSet<_>>()
-        }
-    };
-    // By queue id, the way x:Trace/query asks: the queue id column, or any
-    // queue id in the keywords
-    let by_queue_id = |queue_id: u64| {
-        vec![
-            SearchFilter::Or,
-            SearchFilter::eq(TracingSearchField::QueueId, queue_id),
-            SearchFilter::has_text(
-                TracingSearchField::Keywords,
-                queue_id.to_string(),
-                Language::None,
-            ),
-            SearchFilter::End,
-        ]
-    };
-    assert_eq!(query(by_queue_id(9_000_000_001)).await, AHashSet::from_iter([100]));
-    assert_eq!(query(by_queue_id(9_000_000_002)).await, AHashSet::from_iter([100]));
-    assert_eq!(query(by_queue_id(9_000_000_003)).await, AHashSet::from_iter([101]));
-    assert_eq!(query(by_queue_id(9_000_000_004)).await, AHashSet::new());
-    assert_eq!(
-        query(vec![SearchFilter::eq(TracingSearchField::QueueId, 9_000_000_003u64)]).await,
-        AHashSet::from_iter([101])
-    );
-    // By opening event type
-    assert_eq!(
-        query(vec![SearchFilter::eq(
-            TracingSearchField::EventType,
-            EventType::Delivery(DeliveryEvent::AttemptStart).to_id() as u64,
-        )])
-        .await,
-        AHashSet::from_iter([101])
-    );
-    // By keyword: an address, lowercased, and its domain
-    assert_eq!(
-        query(vec![SearchFilter::has_text(
-            TracingSearchField::Keywords,
-            "example.org",
-            Language::None,
-        )])
-        .await,
-        AHashSet::from_iter([100])
-    );
-    assert_eq!(
-        query(vec![SearchFilter::has_text(
-            TracingSearchField::Keywords,
-            "relay.example.net",
-            Language::None,
-        )])
-        .await,
-        AHashSet::from_iter([101])
-    );
-
-    for id in [100u64, 101] {
-        store
-            .unindex(
-                SearchQuery::new(SearchIndex::Tracing)
-                    .with_filter(SearchFilter::eq(SearchField::Id, id)),
-            )
-            .await
-            .unwrap();
-    }
-}
-
-// inbuxa: the message indexer passes each display name and each address of
-// From/To/Cc/Bcc as keyword text (Language::None). The built-in index splits
-// that text into words, so an address is found by its full form, its local
-// part, its domain or a display-name word; PostgreSQL kept the whole address
-// as one token and MySQL dropped stopwords such as "com" and words under three
-// characters. The expected results below are the built-in (RocksDB/SQLite)
-// results and must be the same on every backend.
-async fn test_address_search(store: SearchStore) {
-    const ACCOUNT_ID: u32 = 7;
-    let messages: [[&[(&str, &str)]; 4]; 5] = [
-        // From, To, Cc, Bcc
-        [
-            &[("Amazon.com", "[email protected]")],
-            &[("Jane Doe", "[email protected]")],
-            &[],
-            &[],
-        ],
-        [
-            &[("", "[email protected]")],
-            &[("", "[email protected]")],
-            &[("Jane Doe", "[email protected]")],
-            &[],
-        ],
-        [
-            &[("GitHub", "[email protected]")],
-            &[("Jo Li", "[email protected]")],
-            &[],
-            &[("Audit", "[email protected]")],
-        ],
-        [
-            &[("Jane Doe", "[email protected]")],
-            &[("Amazon Web Services", "[email protected]")],
-            &[("Bob", "[email protected]")],
-            &[("", "[email protected]")],
-        ],
-        [
-            &[("Newsletter", "[email protected]")],
-            &[("", "[email protected]")],
-            &[],
-            &[],
-        ],
-    ];
-    let fields = [
-        EmailSearchField::From,
-        EmailSearchField::To,
-        EmailSearchField::Cc,
-        EmailSearchField::Bcc,
-    ];
-
-    let mut documents = Vec::new();
-    let mut mask = RoaringBitmap::new();
-    for (document_id, message) in messages.iter().enumerate() {
-        let mut document = IndexDocument::new(SearchIndex::Email)
-            .with_account_id(ACCOUNT_ID)
-            .with_document_id(document_id as u32);
-        for (field, addresses) in fields.iter().zip(message.iter()) {
-            for (name, address) in addresses.iter() {
-                if !name.is_empty() {
-                    document.index_text(field.clone(), name, Language::None);
-                }
-                document.index_text(field.clone(), address, Language::None);
-            }
-        }
-        document.index_unsigned(EmailSearchField::ReceivedAt, document_id as u64);
-        documents.push(document);
-        mask.insert(document_id as u32);
-    }
-    store.index(documents).await.unwrap();
-    if let SearchStore::ElasticSearch(store) = &store {
-        store.refresh_index(SearchIndex::Email).await.unwrap();
-    }
-
-    for (field, text, expected) in [
-        // full address
-        (EmailSearchField::From, "[email protected]", vec![0u32]),
-        (EmailSearchField::To, "[email protected]", vec![0]),
-        (EmailSearchField::Cc, "[email protected]", vec![1]),
-        (EmailSearchField::Bcc, "[email protected]", vec![3]),
-        (EmailSearchField::To, "[email protected]", vec![1, 2]),
-        // local part
-        (EmailSearchField::From, "noreply", vec![0, 2]),
-        (EmailSearchField::To, "jo", vec![1, 2]),
-        (EmailSearchField::Cc, "bob", vec![3]),
-        (EmailSearchField::Bcc, "audit", vec![2]),
-        // domain
-        (EmailSearchField::From, "amazon.com", vec![0, 1]),
-        (EmailSearchField::From, "amazon", vec![0, 1]),
-        (EmailSearchField::To, "example.org", vec![0, 4]),
-        (EmailSearchField::To, "io.de", vec![1, 2]),
-        (EmailSearchField::Cc, "example.net", vec![3]),
-        (EmailSearchField::Bcc, "example.org", vec![2]),
-        (EmailSearchField::From, "www.example.com", vec![4]),
-        (EmailSearchField::From, "com", vec![0, 1, 2, 4]),
-        // display name
-        (EmailSearchField::From, "Jane", vec![3]),
-        (EmailSearchField::From, "jane doe", vec![3]),
-        (EmailSearchField::To, "Web Services", vec![3]),
-        (EmailSearchField::To, "Li", vec![2]),
-        (EmailSearchField::Cc, "Doe", vec![1]),
-        (EmailSearchField::Bcc, "Audit", vec![2]),
-        // hyphenated local part
-        (EmailSearchField::From, "shipment-tracking", vec![1]),
-        (EmailSearchField::From, "tracking", vec![1]),
-        // no match
-        (EmailSearchField::From, "amazon.org", vec![]),
-        (EmailSearchField::To, "noreply", vec![]),
-        (EmailSearchField::Bcc, "jane", vec![]),
-    ] {
-        let ids = store
-            .query_account(
-                SearchQuery::new(SearchIndex::Email)
-                    .with_filters(vec![
-                        SearchFilter::eq(SearchField::AccountId, ACCOUNT_ID),
-                        SearchFilter::has_keyword(field.clone(), text),
-                    ])
-                    .with_comparator(SearchComparator::ascending(EmailSearchField::ReceivedAt))
-                    .with_mask(mask.clone()),
-            )
-            .await
-            .unwrap();
-        assert_eq!(ids, expected, "{field:?} {text:?}");
-    }
-
-    // TEXT-style search across all address fields
-    let ids = store
-        .query_account(
-            SearchQuery::new(SearchIndex::Email)
-                .with_filters(vec![
-                    SearchFilter::eq(SearchField::AccountId, ACCOUNT_ID),
-                    SearchFilter::Or,
-                    SearchFilter::has_keyword(EmailSearchField::From, "example.org"),
-                    SearchFilter::has_keyword(EmailSearchField::To, "example.org"),
-                    SearchFilter::has_keyword(EmailSearchField::Cc, "example.org"),
-                    SearchFilter::has_keyword(EmailSearchField::Bcc, "example.org"),
-                    SearchFilter::End,
-                ])
-                .with_comparator(SearchComparator::ascending(EmailSearchField::ReceivedAt))
-                .with_mask(mask.clone()),
-        )
-        .await
-        .unwrap();
-    assert_eq!(ids, vec![0, 1, 2, 3, 4]);
-
-    store
-        .unindex(
-            SearchQuery::new(SearchIndex::Email)
-                .with_filter(SearchFilter::eq(SearchField::AccountId, ACCOUNT_ID)),
-        )
-        .await
-        .unwrap();
-}

tests/src/store/task_locks.rs

@@ -1,210 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-//! Task locks across nodes: tasks claimed by a node that then disappears
-//! run elsewhere once its locks expire, and a node that stops gracefully
-//! hands its locks back at once. The other node is played by writing its
-//! locks straight into the shared in-memory store, as a node that claimed
-//! the tasks and died leaves them.
-
-use crate::utils::server::TestServerBuilder;
-use common::{KV_LOCK_TASK, Server};
-use registry::schema::{
-    enums::IndexDocumentType,
-    structs::{Task, TaskIndexDocument, TaskStatus},
-};
-use services::task_manager::lock::{TaskLockManager, release_task_locks};
-use std::time::{Duration, Instant};
-use store::{
-    ValueKey,
-    write::{BatchBuilder, TaskQueueClass, ValueClass},
-};
-use utils::snowflake::SnowflakeIdGenerator;
-
-// Short enough for a test, long enough that the recheck interval (a twelfth
-// of it) is well below it
-const LOCK_EXPIRY: u64 = 12;
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn task_lock_tests() {
-    let test = TestServerBuilder::new("task_lock_tests")
-        .await
-        .build()
-        .await;
-    let server = test.server.clone();
-    println!(
-        "Running task lock tests on {}...",
-        std::env::var("STORE").unwrap_or_default()
-    );
-    server.inner.ipc.task_locks.set_expiry(LOCK_EXPIRY);
-
-    // 1. Another node claimed the tasks and died. Its locks block them until
-    // they expire; then this node runs them, without waiting for anything
-    // else to wake it
-    let ids = new_task_ids(4);
-    for id in &ids {
-        assert!(foreign_lock(&server, *id, LOCK_EXPIRY).await);
-    }
-    schedule(&server, &ids).await;
-    let started = Instant::now();
-    server.notify_task_queue();
-    tokio::time::sleep(Duration::from_secs(3)).await;
-    assert_eq!(pending(&server, &ids).await, ids.len(), "held by the other node");
-    wait_until_done(&server, &ids, Duration::from_secs(LOCK_EXPIRY + 10)).await;
-    let elapsed = started.elapsed();
-    assert!(
-        elapsed >= Duration::from_secs(LOCK_EXPIRY - 2),
-        "ran before the other node's locks expired: {elapsed:?}"
-    );
-
-    // 2. The other node's locks outlive what this node expects: claimed just
-    // after this node looked, or by a node whose clock runs ahead. This node
-    // keeps checking at the recheck interval, so the tasks run soon after
-    // those locks expire, not a whole lock lifetime later
-    let held_for = LOCK_EXPIRY + LOCK_EXPIRY / 2;
-    let ids = new_task_ids(4);
-    for id in &ids {
-        assert!(foreign_lock(&server, *id, held_for).await);
-    }
-    schedule(&server, &ids).await;
-    let started = Instant::now();
-    server.notify_task_queue();
-    wait_until_done(&server, &ids, Duration::from_secs(held_for + 8)).await;
-    let elapsed = started.elapsed();
-    assert!(
-        elapsed >= Duration::from_secs(held_for - 2),
-        "ran before the other node's locks expired: {elapsed:?}"
-    );
-
-    // 3. A task that runs longer than a lock lifetime keeps its claim: the
-    // task manager renews the lease while this node holds it, and the claim
-    // ends when the task does. (Before, a lock simply lasted an hour.)
-    let [id] = new_task_ids(1)[..] else {
-        unreachable!()
-    };
-    assert!(server.try_lock_task(id).await, "claim {id}");
-    tokio::time::sleep(Duration::from_secs(LOCK_EXPIRY + LOCK_EXPIRY / 2)).await;
-    assert!(
-        !foreign_lock(&server, id, LOCK_EXPIRY).await,
-        "lease lapsed while the task ran"
-    );
-    server.remove_index_lock(id).await;
-    assert!(
-        foreign_lock(&server, id, LOCK_EXPIRY).await,
-        "released when the task ended"
-    );
-    let _ = server
-        .in_memory_store()
-        .remove_lock(KV_LOCK_TASK, &id.to_be_bytes())
-        .await;
-    assert!(
-        common::ipc::TaskLocks::DEFAULT_EXPIRY <= 5 * 60,
-        "a dead node's tasks wait no more than a few minutes"
-    );
-
-    // 4. A graceful stop releases the locks this node holds: another node
-    // can claim those tasks at once, and this one claims nothing more
-    let ids = new_task_ids(3);
-    for id in &ids {
-        assert!(server.try_lock_task(*id).await, "claim {id}");
-    }
-    assert_eq!(server.inner.ipc.task_locks.held(), ids.len());
-    for id in &ids {
-        assert!(
-            !foreign_lock(&server, *id, LOCK_EXPIRY).await,
-            "held while this node runs"
-        );
-    }
-    assert_eq!(release_task_locks(&server).await, ids.len());
-    assert_eq!(server.inner.ipc.task_locks.held(), 0);
-    for id in &ids {
-        assert!(
-            foreign_lock(&server, *id, LOCK_EXPIRY).await,
-            "released on stop: {id}"
-        );
-    }
-    let [id] = new_task_ids(1)[..] else {
-        unreachable!()
-    };
-    assert!(!server.try_lock_task(id).await, "a stopping node claims nothing");
-
-    for id in ids {
-        let _ = server
-            .in_memory_store()
-            .remove_lock(KV_LOCK_TASK, &id.to_be_bytes())
-            .await;
-    }
-    if test.is_reset() {
-        test.temp_dir.delete();
-    }
-}
-
-fn new_task_ids(count: usize) -> Vec<u64> {
-    (0..count)
-        .map(|_| SnowflakeIdGenerator::global_id().unwrap())
-        .collect()
-}
-
-/// The other node's claim on a task, as its task manager takes it.
-async fn foreign_lock(server: &Server, id: u64, seconds: u64) -> bool {
-    server
-        .in_memory_store()
-        .try_lock(KV_LOCK_TASK, &id.to_be_bytes(), seconds)
-        .await
-        .unwrap()
-}
-
-/// Unindex tasks for files that don't exist: files aren't search-indexed and
-/// there is no undelete note, so running one only drops it from the queue.
-async fn schedule(server: &Server, ids: &[u64]) {
-    let mut batch = BatchBuilder::new();
-    for (n, id) in ids.iter().enumerate() {
-        batch.schedule_task_with_id(
-            *id,
-            Task::UnindexDocument(TaskIndexDocument {
-                account_id: 0u32.into(),
-                document_id: (u32::MAX - n as u32).into(),
-                document_type: IndexDocumentType::File,
-                status: TaskStatus::now(),
-            }),
-        );
-    }
-    server.store().write(batch.build_all()).await.unwrap();
-}
-
-async fn pending(server: &Server, ids: &[u64]) -> usize {
-    let mut count = 0;
-    for id in ids {
-        if server
-            .store()
-            .get_value::<Task>(ValueKey::from(ValueClass::TaskQueue(
-                TaskQueueClass::Task { id: *id },
-            )))
-            .await
-            .unwrap()
-            .is_some()
-        {
-            count += 1;
-        }
-    }
-    count
-}
-
-async fn wait_until_done(server: &Server, ids: &[u64], within: Duration) {
-    let started = Instant::now();
-    loop {
-        let left = pending(server, ids).await;
-        if left == 0 {
-            return;
-        }
-        assert!(
-            started.elapsed() < within,
-            "{left} task(s) still pending after {:?}",
-            started.elapsed()
-        );
-        tokio::time::sleep(Duration::from_millis(250)).await;
-    }
-}

tests/src/system/auto_reload.rs

@@ -1,220 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-// inbuxa: a registry write to an object the running settings are built from
-// applies without an x:Action ReloadSettings, and the set response says so.
-
-use crate::utils::{
-    jmap::JmapResponse,
-    server::{TestServer, TestServerBuilder},
-};
-use common::BuildServer;
-use registry::{
-    schema::{
-        enums::TracingLevel,
-        prelude::ObjectType,
-        structs::{
-            AllowedIp, CertificateManagement, DkimManagement, DnsManagement, Domain, Expression,
-            MtaDeliverySchedule, MtaStageAuth, MtaVirtualQueue, Tracer, TracerStdout,
-        },
-    },
-    types::ipmask::IpAddrOrMask,
-};
-use serde_json::Value;
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn settings_reload_tests() {
-    let mut test = TestServerBuilder::new("settings_reload_tests")
-        .await
-        .with_default_listeners()
-        .await
-        .with_object(MtaStageAuth {
-            require: Expression {
-                else_: "false".to_string(),
-                ..Default::default()
-            },
-            ..Default::default()
-        })
-        .await
-        .build()
-        .await;
-
-    let admin = test
-        .create_user_account(
-            "admin",
-            "[email protected]",
-            "these_pretzels_are_making_me_thirsty",
-            &[],
-            "Admin",
-        )
-        .await;
-    test.account("admin")
-        .assign_roles_to_account(admin.id(), &["user", "system"])
-        .await;
-    test.insert_account(admin);
-
-    test_write_applies(&test).await;
-
-    if test.is_reset() {
-        test.temp_dir.delete();
-    }
-}
-
-async fn test_write_applies(test: &TestServer) {
-    println!("Running settings reload after registry writes...");
-    let admin = test.account("[email protected]");
-
-    // A delivery schedule is in use as soon as it is saved
-    let response = admin
-        .registry_create([MtaVirtualQueue {
-            name: "autorld".into(),
-            threads_per_node: 2,
-            description: None,
-        }])
-        .await;
-    assert_applied(&response);
-    let queue_id = response.created_id(0);
-    assert!(!has_schedule(test, "autoreload-schedule"));
-    let response = admin
-        .registry_create([MtaDeliverySchedule {
-            name: "autoreload-schedule".into(),
-            queue_id,
-            ..Default::default()
-        }])
-        .await;
-    assert_applied(&response);
-    assert!(has_schedule(test, "autoreload-schedule"));
-
-    // Destroyed, it's gone at once too
-    let schedule_id = response.created_id(0);
-    let response = admin
-        .registry_destroy(ObjectType::MtaDeliverySchedule, [schedule_id])
-        .await;
-    assert_applied(&response);
-    assert!(!has_schedule(test, "autoreload-schedule"));
-
-    // Concurrent writes all end up in the running settings
-    let names = (0..8)
-        .map(|i| format!("autoreload-{i}"))
-        .collect::<Vec<_>>();
-    let mut writes = Vec::new();
-    for name in &names {
-        writes.push(admin.registry_create([MtaDeliverySchedule {
-            name: name.clone(),
-            queue_id,
-            ..Default::default()
-        }]));
-    }
-    let mut schedule_ids = Vec::new();
-    for response in futures::future::join_all(writes).await {
-        assert_applied(&response);
-        schedule_ids.push(response.created_id(0));
-    }
-    for name in &names {
-        assert!(has_schedule(test, name), "{name} missing");
-    }
-    // Several objects in one request: one reload
-    let response = admin
-        .registry_destroy(ObjectType::MtaDeliverySchedule, schedule_ids.iter())
-        .await;
-    assert_applied(&response);
-    for name in &names {
-        assert!(!has_schedule(test, name), "{name} still present");
-    }
-
-    // A write whose reload fails is stored, and the response says the
-    // settings weren't reloaded: only one console tracer is allowed.
-    let response = admin
-        .registry_create([
-            Tracer::Stdout(TracerStdout {
-                enable: true,
-                level: TracingLevel::Error,
-                ..Default::default()
-            }),
-            Tracer::Stdout(TracerStdout {
-                enable: true,
-                level: TracingLevel::Error,
-                ..Default::default()
-            }),
-        ])
-        .await;
-    let reload = settings_reload(&response).expect("x:settingsReload missing");
-    assert_eq!(reload["applied"], Value::Bool(false), "{response:?}");
-    let description = reload["description"].as_str().unwrap_or_default();
-    assert!(
-        description.starts_with("Saved, but the running settings were not reloaded. ")
-            && description.contains("Only one console tracer is allowed"),
-        "{description}"
-    );
-    let tracer_ids = [response.created_id(0), response.created_id(1)];
-    let response = admin
-        .registry_destroy(ObjectType::Tracer, tracer_ids.iter())
-        .await;
-    assert_applied(&response);
-
-    // An allowed IP is live as soon as it is saved, and gone once
-    // destroyed. It lives in the core's security settings, which the
-    // blocked-IP reload it used to get doesn't rebuild.
-    let ip: std::net::IpAddr = "198.51.100.7".parse().unwrap();
-    assert!(!is_allowed(test, ip));
-    let response = admin
-        .registry_create([AllowedIp {
-            address: IpAddrOrMask::from_ip(ip),
-            reason: Some("autoreload".into()),
-            ..Default::default()
-        }])
-        .await;
-    assert_applied(&response);
-    assert!(
-        is_allowed(test, ip),
-        "allowed IP not in the running settings"
-    );
-    let allowed_id = response.created_id(0);
-    let response = admin
-        .registry_destroy(ObjectType::AllowedIp, [allowed_id])
-        .await;
-    assert_applied(&response);
-    assert!(!is_allowed(test, ip), "destroyed allowed IP still live");
-
-    // Data that isn't part of the running settings doesn't reload them
-    let response = admin
-        .registry_create([Domain {
-            name: "autoreload.example.org".into(),
-            certificate_management: CertificateManagement::Manual,
-            dns_management: DnsManagement::Manual,
-            dkim_management: DkimManagement::Manual,
-            ..Default::default()
-        }])
-        .await;
-    assert!(settings_reload(&response).is_none(), "{response:?}");
-}
-
-fn settings_reload(response: &JmapResponse) -> Option<&Value> {
-    response.pointer("/methodResponses/0/1/x:settingsReload")
-}
-
-fn assert_applied(response: &JmapResponse) {
-    assert_eq!(
-        settings_reload(response),
-        Some(&serde_json::json!({"applied": true})),
-        "{response:?}"
-    );
-}
-
-fn has_schedule(test: &TestServer, name: &str) -> bool {
-    test.server
-        .inner
-        .build_server()
-        .core
-        .smtp
-        .queue
-        .queue_strategy
-        .contains_key(name)
-}
-
-fn is_allowed(test: &TestServer, ip: std::net::IpAddr) -> bool {
-    test.server.inner.build_server().is_ip_allowed(ip)
-}

tests/src/system/mod.rs

@@ -11,7 +11,6 @@ pub mod authentication;
 pub mod ai;
 pub mod ai_calibration;
 pub mod authorization;
-pub mod auto_reload; // inbuxa: registry writes apply at once
 pub mod branding;
 pub mod crypto;
 pub mod delivery;
@@ -21,7 +20,6 @@ pub mod monitoring;
 pub mod oidc;
 pub mod purge;
 pub mod quota;
-pub mod reload; // inbuxa: reloads and build errors
 pub mod security;
 pub mod task;
 pub mod tenant;

tests/src/system/monitoring.rs

@@ -148,73 +148,6 @@ pub async fn test(test: &mut TestServer) {
         "test 9: to"
     );
 
-    // MON-16: the queueId filter finds the traces that name a queue id (the
-    // session that queued the message and its delivery attempt) through the
-    // search index, given as a string or a number (the index column is an
-    // integer)
-    fn queue_ids(value: &Value, out: &mut Vec<u64>) {
-        match value {
-            Value::Object(map) => {
-                if map.get("key").and_then(|k| k.as_str()) == Some("queueId")
-                    && let Some(id) = map
-                        .get("value")
-                        .and_then(|v| v.get("value").unwrap_or(v).as_u64())
-                {
-                    out.push(id);
-                }
-                map.values().for_each(|v| queue_ids(v, out));
-            }
-            Value::Array(list) => list.iter().for_each(|v| queue_ids(v, out)),
-            _ => {}
-        }
-    }
-    let with_ids = traces
-        .iter()
-        .map(|t| {
-            let mut ids = Vec::new();
-            queue_ids(t, &mut ids);
-            (t["id"].as_str().unwrap().to_string(), ids)
-        })
-        .collect::<Vec<_>>();
-    let queue_id = with_ids
-        .iter()
-        .find_map(|(_, ids)| ids.first().copied())
-        .expect("MON-16: a trace with a queue id");
-    let mut expected = with_ids
-        .iter()
-        .filter(|(_, ids)| ids.contains(&queue_id))
-        .map(|(id, _)| id.clone())
-        .collect::<Vec<_>>();
-    expected.sort();
-    for filter in [json!(queue_id.to_string()), json!(queue_id)] {
-        let response = admin
-            .jmap_method_call("x:Trace/query", json!({"filter": {"queueId": filter}}))
-            .await;
-        let mut found = response
-            .0
-            .pointer("/methodResponses/0/1/ids")
-            .and_then(|ids| ids.as_array())
-            .map(|ids| {
-                ids.iter()
-                    .filter_map(|id| id.as_str().map(str::to_string))
-                    .collect::<Vec<_>>()
-            })
-            .unwrap_or_default();
-        found.sort();
-        assert_eq!(found, expected, "MON-16: queueId {filter}: {response:?}");
-    }
-    let response = admin
-        .jmap_method_call(
-            "x:Trace/query",
-            json!({"filter": {"queueId": (queue_id ^ 0x5a5a_5a5a).to_string()}}),
-        )
-        .await;
-    assert_eq!(
-        response.0.pointer("/methodResponses/0/1/ids"),
-        Some(&json!([])),
-        "MON-16: an unknown queue id"
-    );
-
     // Acceptance test 24: destroy removes a trace; create is refused
     let trace_id = traces[0]["id"].as_str().unwrap().to_string();
     let response = admin

tests/src/system/reload.rs

@@ -1,213 +0,0 @@
-/*
- * SPDX-FileCopyrightText: 2026 Coffey Labs
- *
- * SPDX-License-Identifier: AGPL-3.0-only
- */
-
-// inbuxa: a settings reload isn't held back by a DNS lookup, or by objects
-// that already failed when the running settings were built; an error in an
-// object that built then still refuses it, and says which object.
-
-use crate::utils::server::{TestServer, TestServerBuilder};
-use common::{BuildServer, config::mailstore::spamfilter::PyzorConfig, ipc::RegistryChange};
-use registry::schema::{
-    enums::TracingLevel,
-    prelude::{ObjectType, Property},
-    structs::{Action, Expression, MtaStageAuth, SpamPyzor, Tracer, TracerStdout},
-};
-
-#[tokio::test(flavor = "multi_thread")]
-pub async fn reload_tests() {
-    let mut test = TestServerBuilder::new("reload_tests")
-        .await
-        .with_default_listeners()
-        .await
-        .with_object(MtaStageAuth {
-            require: Expression {
-                else_: "false".to_string(),
-                ..Default::default()
-            },
-            ..Default::default()
-        })
-        .await
-        .build()
-        .await;
-
-    let admin = test
-        .create_user_account(
-            "admin",
-            "[email protected]",
-            "these_pretzels_are_making_me_thirsty",
-            &[],
-            "Admin",
-        )
-        .await;
-    test.account("admin")
-        .assign_roles_to_account(admin.id(), &["user", "system"])
-        .await;
-    test.insert_account(admin);
-
-    test_unresolvable_pyzor(&test).await;
-    test_build_errors(&test).await;
-
-    if test.is_reset() {
-        test.temp_dir.delete();
-    }
-}
-
-async fn test_unresolvable_pyzor(test: &TestServer) {
-    println!("Running reload with an unresolvable Pyzor host...");
-    let admin = test.account("[email protected]");
-
-    // Upstream resolved the host while building the settings and refused the
-    // reload when that failed.
-    admin
-        .registry_update_setting(
-            SpamPyzor {
-                enable: true,
-                host: "pyzor.invalid".into(),
-                port: 24441,
-                ..Default::default()
-            },
-            &[Property::Enable, Property::Host, Property::Port],
-        )
-        .await;
-    admin.reload_settings().await;
-
-    let pyzor = running_pyzor(test);
-    assert_eq!(pyzor.host, "pyzor.invalid");
-    assert_eq!(pyzor.port, 24441);
-    assert!(pyzor.address().await.is_err());
-
-    // An IP address needs no lookup
-    admin
-        .registry_update_setting(
-            SpamPyzor {
-                host: "192.0.2.1".into(),
-                ..Default::default()
-            },
-            &[Property::Host],
-        )
-        .await;
-    admin.reload_settings().await;
-    assert_eq!(
-        running_pyzor(test).address().await.unwrap().to_string(),
-        "192.0.2.1:24441"
-    );
-}
-
-async fn test_build_errors(test: &TestServer) {
-    println!("Running reload with build errors...");
-    let admin = test.account("[email protected]");
-    let pyzor_ratio = running_pyzor(test).ratio;
-    assert_ne!(pyzor_ratio, 0.25);
-
-    // Two console tracers: only one is allowed, so the build of one of them
-    // fails. Neither existed when the running settings were built.
-    let mut tracer_ids = Vec::new();
-    for _ in 0..2 {
-        tracer_ids.push(
-            admin
-                .registry_create_object(Tracer::Stdout(TracerStdout {
-                    enable: true,
-                    level: TracingLevel::Error,
-                    ..Default::default()
-                }))
-                .await,
-        );
-    }
-    admin
-        .registry_update_setting(
-            SpamPyzor {
-                ratio: 0.25.into(),
-                ..Default::default()
-            },
-            &[Property::Ratio],
-        )
-        .await;
-
-    // A new error refuses the reload and names the object
-    let err = admin
-        .registry_create_object_expect_err(Action::ReloadSettings)
-        .await;
-    let description = err.description.clone().unwrap_or_default();
-    assert!(
-        description.starts_with("Settings were not reloaded. ")
-            && description.contains("Tracer")
-            && description.contains("Only one console tracer is allowed"),
-        "{err:?}"
-    );
-    assert_eq!(running_pyzor(test).ratio, pyzor_ratio);
-
-    // Had the running settings been built with that tracer failing, as a
-    // restart now would, the same error doesn't hold the reload back.
-    let result = Box::pin(
-        test.server
-            .reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
-    )
-    .await
-    .unwrap();
-    assert!(!result.replaced_core);
-    assert_eq!(result.errors.len(), 1, "{:?}", result.errors);
-    test.server.record_build_errors(&result.errors);
-
-    admin.reload_settings().await;
-    assert_eq!(running_pyzor(test).ratio, 0.25);
-    let result = Box::pin(
-        test.server
-            .reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
-    )
-    .await
-    .unwrap();
-    assert!(result.replaced_core);
-    assert!(result.errors.is_empty());
-    assert_eq!(result.known_errors.len(), 1);
-
-    // Once fixed, the object is no longer known to fail, so a new error
-    // there refuses the reload again.
-    admin
-        .registry_destroy(ObjectType::Tracer, tracer_ids.iter())
-        .await
-        .assert_destroyed(&tracer_ids);
-    admin.reload_settings().await;
-    let result = Box::pin(
-        test.server
-            .reload_registry(RegistryChange::Reload(ObjectType::DataStore)),
-    )
-    .await
-    .unwrap();
-    assert!(result.replaced_core);
-    assert!(result.errors.is_empty() && result.known_errors.is_empty());
-
-    for _ in 0..2 {
-        tracer_ids.push(
-            admin
-                .registry_create_object(Tracer::Stdout(TracerStdout {
-                    enable: true,
-                    level: TracingLevel::Error,
-                    ..Default::default()
-                }))
-                .await,
-        );
-    }
-    admin
-        .registry_create_object_expect_err(Action::ReloadSettings)
-        .await;
-    let tracer_ids = tracer_ids.split_off(2);
-    admin
-        .registry_destroy(ObjectType::Tracer, tracer_ids.iter())
-        .await
-        .assert_destroyed(&tracer_ids);
-    admin.reload_settings().await;
-}
-
-fn running_pyzor(test: &TestServer) -> PyzorConfig {
-    test.server
-        .inner
-        .build_server()
-        .core
-        .spam
-        .pyzor
-        .clone()
-        .expect("Pyzor enabled")
-}