From 7309bb5ce4d342c7a3aa60b5be2c3030ead6dbf4 Mon Sep 17 00:00:00 2001 From: John Coffey Date: Sat, 21 Nov 2026 20:24:32 -0700 Subject: [PATCH] Certificates: an automatic order's names follow its account, not the DNS setting (#261) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Ordered automatically panel and the order guide worked out what a domain orders today from whether its DNS is automatic. The server goes by the domain's ACME account: DNS-01 or DNS-PERSIST-01 orders the domain and a wildcard, anything else the technical names. A domain with automatic DNS and a TLS-ALPN account was shown as "*.domain, domain · not issued yet" though its certificate was there and renewing. orderingMethod() reads the account's challenge type and falls back to the DNS setting only when the account can't be found. The setup guides keep using the DNS setting to choose how a new order is checked. Fixes #261 --- .../certificates/CertificateOrdersPanel.tsx | 4 +-- .../certificates/OrderCertificatePage.tsx | 12 +++++-- src/features/certificates/shared.test.ts | 33 ++++++++++++++++++- src/features/certificates/shared.ts | 18 ++++++++++ 4 files changed, 62 insertions(+), 5 deletions(-) diff --git a/src/features/certificates/CertificateOrdersPanel.tsx b/src/features/certificates/CertificateOrdersPanel.tsx index ff79ad2..91100c1 100644 --- a/src/features/certificates/CertificateOrdersPanel.tsx +++ b/src/features/certificates/CertificateOrdersPanel.tsx @@ -20,7 +20,7 @@ import { useSchemaStore } from '@/stores/schemaStore'; import { cn } from '@/lib/utils'; import { orderNames } from './names'; import { canOrderAgain, orderAgainSet, renewalState, type RenewalState } from './orders'; -import { coveringCert, fmtDate, type CertRow, type Loaded, load, pollOrders, refusal } from './shared'; +import { coveringCert, fmtDate, type CertRow, type Loaded, load, orderingMethod, pollOrders, refusal } from './shared'; import { ORDER_WIZARD_VIEW } from './CertificateSetupCard'; interface State { @@ -142,7 +142,7 @@ export function CertificateOrdersPanel({ className }: { className?: string }) { {automatic.length > 0 && (