Certificates: an automatic order's names follow its account, not the DNS setting (#261) #262

Merged
jcoffey-dev merged 1 commits from fix/cert-orders-method into main 2026-11-22 03:27:05 +00:00
Owner

Fixes #261.

The Ordered automatically panel and the order guide worked out what a domain orders today from whether its DNS is automatic. The server goes by the domain's ACME account (build_domains in common/src/network/acme/order.rs): DNS-01 or DNS-PERSIST-01 orders the domain and a wildcard, anything else the technical names. So a domain with automatic DNS and a TLS-ALPN account showed *.domain, domain · not issued yet while its certificate was there and renewing.

  • orderingMethod() in shared.ts reads the domain's account's challenge type, and falls back to the DNS setting only when the account can't be found.
  • The panel uses it for every automatic domain.
  • The order guide uses it for "what this domain orders today", so it no longer says an order replaces wildcard names the domain never had. How the new order is checked still follows the DNS setting, as before.
  • The setup guide is unchanged: there the DNS setting chooses how a new domain is checked.

Checked locally: typecheck, lint, i18n:check, npm test (129 files, 1174 tests, two new in shared.test.ts), release-version and changelog-check tests.

Fixes #261. The **Ordered automatically** panel and the order guide worked out what a domain orders today from whether its DNS is automatic. The server goes by the domain's ACME account (`build_domains` in `common/src/network/acme/order.rs`): DNS-01 or DNS-PERSIST-01 orders the domain and a wildcard, anything else the technical names. So a domain with automatic DNS and a TLS-ALPN account showed `*.domain, domain · not issued yet` while its certificate was there and renewing. - `orderingMethod()` in `shared.ts` reads the domain's account's challenge type, and falls back to the DNS setting only when the account can't be found. - The panel uses it for every automatic domain. - The order guide uses it for "what this domain orders today", so it no longer says an order replaces wildcard names the domain never had. How the *new* order is checked still follows the DNS setting, as before. - The setup guide is unchanged: there the DNS setting chooses how a new domain is checked. Checked locally: typecheck, lint, i18n:check, `npm test` (129 files, 1174 tests, two new in `shared.test.ts`), release-version and changelog-check tests.
jcoffey-dev added this to the 27.1 milestone 2026-11-22 03:24:43 +00:00
jcoffey-dev added 1 commit 2026-11-22 03:24:43 +00:00
Certificates: an automatic order's names follow its account, not the DNS setting (#261)
ci / build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / notices (pull_request) Successful in 1m2s
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 1m57s
7309bb5ce4
The Ordered automatically panel and the order guide worked out what a
domain orders today from whether its DNS is automatic. The server goes by
the domain's ACME account: DNS-01 or DNS-PERSIST-01 orders the domain and
a wildcard, anything else the technical names. A domain with automatic
DNS and a TLS-ALPN account was shown as "*.domain, domain · not issued
yet" though its certificate was there and renewing.

orderingMethod() reads the account's challenge type and falls back to the
DNS setting only when the account can't be found. The setup guides keep
using the DNS setting to choose how a new order is checked.

Fixes #261
jcoffey-dev merged commit a4de0c68a5 into main 2026-11-22 03:27:05 +00:00
jcoffey-dev deleted branch fix/cert-orders-method 2026-11-22 03:27:05 +00:00
Sign in to join this conversation.