The console's logo now follows its theme: the dark theme probes /logo?theme=dark, the light one /logo, each once per page load on first use. A logo that broke in one theme no longer hides the other's. Against a server without the parameter, it answers with the ordinary logo, so nothing changes there.
The dark logo fields themselves come from the server's schema (Settings › System › Branding, domain and tenant forms), so no form change is needed here.
Checks run locally: typecheck, lint, i18n:check, npm test (1134 passed, 2 new), release-version, changelog-check, listen-ipv6 tests, build, notice-check.
Part of inbuxa/inbuxa-server#410 (dark-mode logo, community t/304).
The console's logo now follows its theme: the dark theme probes `/logo?theme=dark`, the light one `/logo`, each once per page load on first use. A logo that broke in one theme no longer hides the other's. Against a server without the parameter, it answers with the ordinary logo, so nothing changes there.
The dark logo fields themselves come from the server's schema (Settings › System › Branding, domain and tenant forms), so no form change is needed here.
Checks run locally: typecheck, lint, i18n:check, `npm test` (1134 passed, 2 new), release-version, changelog-check, listen-ipv6 tests, build, notice-check.
The console showed the server's logo from /logo in both themes, so a logo
drawn for a light background was the only choice on a dark one. The server
now takes `?theme=dark` and answers with the logo an admin set for dark mode
(logoUrlDark, or a domain's or tenant's logoDark), falling back to the
ordinary one (inbuxa-server#410, branding BT-27).
The logo cache probes each theme's /logo once per page load, on first use:
the light theme as before, the dark theme with ?theme=dark. The header logo
follows the theme switch, and a logo that broke in one theme no longer
hides the other theme's. A server that predates the parameter ignores it
and answers with its ordinary logo, so nothing changes against it.
The dark logo fields themselves come from the served schema (Settings ›
System › Branding, and each domain's and tenant's form), so the forms need
no change here.
Test: the cache asks /logo?theme=dark in the dark theme and /logo in the
light one, each once, and follows the page's dark class when no theme is
given.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Part of inbuxa/inbuxa-server#410 (dark-mode logo, community t/304).
The console's logo now follows its theme: the dark theme probes
/logo?theme=dark, the light one/logo, each once per page load on first use. A logo that broke in one theme no longer hides the other's. Against a server without the parameter, it answers with the ordinary logo, so nothing changes there.The dark logo fields themselves come from the server's schema (Settings › System › Branding, domain and tenant forms), so no form change is needed here.
Checks run locally: typecheck, lint, i18n:check,
npm test(1134 passed, 2 new), release-version, changelog-check, listen-ipv6 tests, build, notice-check.