Show a logo set as an https URL in the console #226

Merged
jcoffey-dev merged 1 commits from fix/225-logo-url into main 2026-11-16 22:26:01 +00:00
Owner

Fixes #225, reported in community t/304.

The console fetched /logo; for a URL logo the server redirects /logo to that URL, and a cross-origin fetch needs CORS from the image host, so it fell back to the inbuxa logo. It now loads /logo as an image, which needs no CORS, as the server sign-in page does. The <img> also falls back to the inbuxa logo on error.

Checked in headless Chromium against the built console, with a stand-in server whose /logo redirects to an image on another origin that sends no CORS headers:

  • main: inbuxa logo (the bug)
  • this branch: the custom image (312x328)
  • this branch, /logo 404 (no logo set): inbuxa logo

typecheck, lint, i18n:check, notice-check and build pass; 1096 tests.

Fixes #225, reported in community t/304. The console fetched `/logo`; for a URL logo the server redirects `/logo` to that URL, and a cross-origin fetch needs CORS from the image host, so it fell back to the inbuxa logo. It now loads `/logo` as an image, which needs no CORS, as the server sign-in page does. The `<img>` also falls back to the inbuxa logo on error. Checked in headless Chromium against the built console, with a stand-in server whose `/logo` redirects to an image on another origin that sends no CORS headers: - main: inbuxa logo (the bug) - this branch: the custom image (312x328) - this branch, `/logo` 404 (no logo set): inbuxa logo typecheck, lint, i18n:check, notice-check and build pass; 1096 tests.
jcoffey-dev added 1 commit 2026-11-16 22:01:53 +00:00
Show a logo set as an https URL in the console
ci / build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / notices (pull_request) Successful in 59s
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 2m22s
7059d5849b
The console fetched /logo and showed the response as a blob. For a logo
set as an https URL the server answers /logo with a redirect to that
URL, and a fetch only follows a redirect to another site when the site
sends CORS headers, which most image hosts don't. The fetch failed and
the console fell back to the inbuxa logo, while the server's sign-in
page, which uses a plain image, showed the custom one.

Load /logo as an image instead: an image follows the redirect without
CORS. The <img> also falls back to the inbuxa logo if the custom one
stops loading later.

Fixes #225
jcoffey-dev merged commit 56e920b016 into main 2026-11-16 22:26:01 +00:00
jcoffey-dev deleted branch fix/225-logo-url 2026-11-16 22:26:02 +00:00
Sign in to join this conversation.