The console fetched /logo; for a URL logo the server redirects /logo to that URL, and a cross-origin fetch needs CORS from the image host, so it fell back to the inbuxa logo. It now loads /logo as an image, which needs no CORS, as the server sign-in page does. The <img> also falls back to the inbuxa logo on error.
Checked in headless Chromium against the built console, with a stand-in server whose /logo redirects to an image on another origin that sends no CORS headers:
main: inbuxa logo (the bug)
this branch: the custom image (312x328)
this branch, /logo 404 (no logo set): inbuxa logo
typecheck, lint, i18n:check, notice-check and build pass; 1096 tests.
Fixes #225, reported in community t/304.
The console fetched `/logo`; for a URL logo the server redirects `/logo` to that URL, and a cross-origin fetch needs CORS from the image host, so it fell back to the inbuxa logo. It now loads `/logo` as an image, which needs no CORS, as the server sign-in page does. The `<img>` also falls back to the inbuxa logo on error.
Checked in headless Chromium against the built console, with a stand-in server whose `/logo` redirects to an image on another origin that sends no CORS headers:
- main: inbuxa logo (the bug)
- this branch: the custom image (312x328)
- this branch, `/logo` 404 (no logo set): inbuxa logo
typecheck, lint, i18n:check, notice-check and build pass; 1096 tests.
The console fetched /logo and showed the response as a blob. For a logo
set as an https URL the server answers /logo with a redirect to that
URL, and a fetch only follows a redirect to another site when the site
sends CORS headers, which most image hosts don't. The fetch failed and
the console fell back to the inbuxa logo, while the server's sign-in
page, which uses a plain image, showed the custom one.
Load /logo as an image instead: an image follows the redirect without
CORS. The <img> also falls back to the inbuxa logo if the custom one
stops loading later.
Fixes#225
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #225, reported in community t/304.
The console fetched
/logo; for a URL logo the server redirects/logoto that URL, and a cross-origin fetch needs CORS from the image host, so it fell back to the inbuxa logo. It now loads/logoas an image, which needs no CORS, as the server sign-in page does. The<img>also falls back to the inbuxa logo on error.Checked in headless Chromium against the built console, with a stand-in server whose
/logoredirects to an image on another origin that sends no CORS headers:/logo404 (no logo set): inbuxa logotypecheck, lint, i18n:check, notice-check and build pass; 1096 tests.