The command bar (Ctrl+K) only kept results whose view is a schema object the account may read. The console's own pages (CustomComponent/...) aren't schema objects, so none of them were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds, Store Check and the rest.
Search now uses the sidebar's own check (isLinkVisible in src/lib/layout.ts), so a page is found exactly when the sidebar shows it, with the same permission and edition rules. Those results say Open rather than List.
Tests: regression cases in src/lib/globalSearch.test.ts (Deleted Accounts found with sysAccount, hidden without it, a page this console doesn't know stays hidden). Every ci.yml step passes locally: typecheck, lint, i18n:check, 1072 tests, the tool tests, build, notice check.
The command bar (Ctrl+K) only kept results whose view is a schema object the account may read. The console's own pages (`CustomComponent/...`) aren't schema objects, so none of them were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds, Store Check and the rest.
Search now uses the sidebar's own check (`isLinkVisible` in `src/lib/layout.ts`), so a page is found exactly when the sidebar shows it, with the same permission and edition rules. Those results say Open rather than List.
Tests: regression cases in `src/lib/globalSearch.test.ts` (Deleted Accounts found with `sysAccount`, hidden without it, a page this console doesn't know stays hidden). Every ci.yml step passes locally: typecheck, lint, i18n:check, 1072 tests, the tool tests, build, notice check.
Fixes #192.
The command bar kept only results whose view is a schema object the account may read, so none of the console's own pages (CustomComponent/...) were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds and the rest. It now asks the sidebar's own check (isLinkVisible), so a page is found exactly when the sidebar shows it. Those results say Open rather than List.
Fixes#192.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The command bar (Ctrl+K) only kept results whose view is a schema object the account may read. The console's own pages (
CustomComponent/...) aren't schema objects, so none of them were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds, Store Check and the rest.Search now uses the sidebar's own check (
isLinkVisibleinsrc/lib/layout.ts), so a page is found exactly when the sidebar shows it, with the same permission and edition rules. Those results say Open rather than List.Tests: regression cases in
src/lib/globalSearch.test.ts(Deleted Accounts found withsysAccount, hidden without it, a page this console doesn't know stays hidden). Every ci.yml step passes locally: typecheck, lint, i18n:check, 1072 tests, the tool tests, build, notice check.Fixes #192.