Search: find the console's own pages, such as Deleted Accounts #193

Merged
jcoffey-dev merged 1 commits from fix/search-deleted-accounts into main 2026-11-11 18:51:05 +00:00
Owner

The command bar (Ctrl+K) only kept results whose view is a schema object the account may read. The console's own pages (CustomComponent/...) aren't schema objects, so none of them were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds, Store Check and the rest.

Search now uses the sidebar's own check (isLinkVisible in src/lib/layout.ts), so a page is found exactly when the sidebar shows it, with the same permission and edition rules. Those results say Open rather than List.

Tests: regression cases in src/lib/globalSearch.test.ts (Deleted Accounts found with sysAccount, hidden without it, a page this console doesn't know stays hidden). Every ci.yml step passes locally: typecheck, lint, i18n:check, 1072 tests, the tool tests, build, notice check.

Fixes #192.

The command bar (Ctrl+K) only kept results whose view is a schema object the account may read. The console's own pages (`CustomComponent/...`) aren't schema objects, so none of them were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds, Store Check and the rest. Search now uses the sidebar's own check (`isLinkVisible` in `src/lib/layout.ts`), so a page is found exactly when the sidebar shows it, with the same permission and edition rules. Those results say Open rather than List. Tests: regression cases in `src/lib/globalSearch.test.ts` (Deleted Accounts found with `sysAccount`, hidden without it, a page this console doesn't know stays hidden). Every ci.yml step passes locally: typecheck, lint, i18n:check, 1072 tests, the tool tests, build, notice check. Fixes #192.
jcoffey-dev added 1 commit 2026-11-11 18:34:47 +00:00
Search: find the console's own pages, such as Deleted Accounts
ci / build (pull_request) Skipped
ci / publish (pull_request) Skipped
ci / notices (pull_request) Successful in 59s
github/ci (branch) GitHub Actions
ci / github (pull_request) Successful in 2m26s
416be161c9
The command bar kept only results whose view is a schema object the account may read, so none of the console's own pages (CustomComponent/...) were ever found: Deleted Accounts, Shared Mailboxes, Legal Holds and the rest. It now asks the sidebar's own check (isLinkVisible), so a page is found exactly when the sidebar shows it. Those results say Open rather than List.

Fixes #192.
jcoffey-dev merged commit 0a6e07ff4e into main 2026-11-11 18:51:05 +00:00
jcoffey-dev deleted branch fix/search-deleted-accounts 2026-11-11 18:51:06 +00:00
Sign in to join this conversation.