jcoffey-dev
bf70ba9df0
ihasmail called itself "2.0" on the About page and "2.0.0" from
/api/health, both hardcoded, in four places that had drifted from each
other and from anything meaningful. A build now says what it is:
ihasmail v2.16.57
| | |
| | the pull request the commit came from
| the Stalwart generation this build targets -- 0.16
ihasmail's own major
The first two are the version in the root package.json, so there is a
single place to bump them, and 16 becomes 17 when ihasmail moves to
Stalwart 0.17. Dropping 0.15 is what makes that middle number honest:
while two generations were supported it could not have been either.
The pull request number comes from git at build time and is never
written back into the tree. It cannot be: it does not exist until the
pull request has merged, so a committed version would always describe a
merge that had not happened yet, and every open branch would collide on
the same line. A commit that did not come through a pull request carries
the last number plus its own short SHA -- 2.16.57+g1fa6578 -- which says
it is past that pull request rather than quietly claiming to be it.
.dockerignore excludes .git on purpose, so an image build cannot work
any of this out. It takes --build-arg IHASMAIL_VERSION instead, which
the build stage bakes into the bundle and the runtime stage keeps as an
environment variable for the server. Left out, it falls back to the base
version from package.json rather than failing -- so a version with no PR
number on it means whoever built the image did not pass one.
scripts/ is copied into the runtime image because the server resolves
its version through it. There is no git in there to ask, which is the
fallback's whole purpose.
Verified: 2.16.57 in the bundle and from /api/health on a dev checkout;
the same after a real docker build --build-arg, from inside the
container; and 2.16.0 rather than a crash when the arg is left off.
Note for deploying: ihasmail-deploy.sh on the host builds without the
argument and will produce 2.16.0 until it passes
--build-arg IHASMAIL_VERSION="$(node scripts/version.mjs)".
52 lines
3.0 KiB
TypeScript
52 lines
3.0 KiB
TypeScript
import { useSession } from "@/store/session";
|
|
import { client } from "@/jmap/client";
|
|
import { DEFAULT_SOURCE_URL } from "@/lib/source";
|
|
import { APP_VERSION } from "@/lib/version";
|
|
|
|
export function AboutSettings() {
|
|
const session = useSession((s) => s.session);
|
|
const caps = Object.keys(session?.capabilities ?? {});
|
|
// A deployment running modified code should offer its own source, not ours.
|
|
const sourceUrl = session?.ihasmail?.sourceUrl ?? DEFAULT_SOURCE_URL;
|
|
return (
|
|
<div>
|
|
<h1>About ihasmail</h1>
|
|
<p className="lead">A fast, friendly, open-source webmail for <a href="https://stalw.art" target="_blank" rel="noreferrer">Stalwart Mail Server</a>, built on JMAP.</p>
|
|
<div className="row" style={{ gap: 16, alignItems: "center", marginBottom: 16 }}>
|
|
<img src="/img/logo.png" alt="ihasmail" width={96} />
|
|
<div>
|
|
<div style={{ fontWeight: 700, fontSize: "1.2em" }}>ihasmail v{APP_VERSION}</div>
|
|
<div className="hint">AGPL-3.0-or-later · <a href={sourceUrl} target="_blank" rel="noreferrer">{sourceUrl.replace(/^https?:\/\//, "")}</a></div>
|
|
</div>
|
|
</div>
|
|
<h2>Server</h2>
|
|
<table className="sessions-table">
|
|
<tbody>
|
|
<tr><td>Signed in as</td><td>{session?.username}</td></tr>
|
|
<tr><td>Stalwart</td><td>{describeServer(session?.ihasmail?.server)}</td></tr>
|
|
<tr><td>Accounts</td><td>{Object.values(session?.accounts ?? {}).map((a) => a.name).join(", ")}</td></tr>
|
|
<tr><td>Max upload</td><td>{Math.round(client.maxSizeUpload / 1048576)} MB</td></tr>
|
|
<tr><td>Image privacy proxy</td><td>{session?.ihasmail?.imageProxy ? "enabled" : "disabled"}</td></tr>
|
|
</tbody>
|
|
</table>
|
|
<p className="hint" style={{ marginTop: 6 }}>Stalwart does not publish its version number to mail clients, so ihasmail reports the edition where the server gives one. ihasmail requires 0.16 or newer, and sign-in refuses anything older.</p>
|
|
<p className="hint">The middle number of ihasmail's own version is the Stalwart generation it is built for: <strong>v2.16.x</strong> targets Stalwart 0.16. The last is the pull request it was built from, and a trailing <code>+g</code> and short commit means the build is past that pull request rather than exactly it.</p>
|
|
<h2>Server capabilities</h2>
|
|
<div className="row wrap gap-4">
|
|
{caps.map((c) => <span key={c} className="chip mono" style={{ fontSize: ".78em" }}>{c.replace("urn:ietf:params:jmap:", "")}</span>)}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Stalwart deliberately withholds its version from clients (it reports a fixed
|
|
* "1.0.0" wherever it publishes one at all), so the edition is all there is to
|
|
* show. The generation used to be reported here too, back when ihasmail spoke
|
|
* to both 0.15 and 0.16; it requires 0.16 now, so signing in at all is the
|
|
* answer to that question.
|
|
*/
|
|
function describeServer(server: { edition?: string | null } | undefined): string {
|
|
return server?.edition ? `0.16 or newer (${server.edition})` : "0.16 or newer";
|
|
}
|