Files
stalwart-migrator/internal/stalwartapi/principal.go
T
jcoffey-dev c29140b6b3 Refuse multi-tenant installs in preflight, not after the service is stopped
A second live attempt failed in the same shape as the first: preflight
clean, settings dumped and converted, then a failure during recovery-mode
migration with the mail server already stopped.

    created Tenant (1)
    created Domain (9)
    create Account restore-13: invalidForeignKey | Object id: Domain#d

migrate_v016.py carries the Tenant and the Domains but emits every Account
with a null tenantId, so the account references a tenant-owned domain while
belonging to no tenant and the foreign key is rejected. That is Stalwart's
converter and there is nothing this tool can do about it: a multi-tenant
install has to be migrated by hand until the converter handles tenants.

What this tool got wrong was the timing. Tenant principals are one API call
away and were readable the entire time the server was running. Preflight now
queries them and fails before anything is touched, with an explanation of
exactly what would otherwise fail and when.

This is the same lesson as the stalwart-cli check: knowable in advance,
discovered after a production mail server had been stopped, twice. Any
dependency of the conversion belongs in preflight, not in the phase that
consumes it.

Also makes the external-tool checks advisory during `rehearse`, which never
invokes stalwart-cli - refusing to run read-only reconnaissance because the
operator lacks a tool that reconnaissance would tell them to get was
backwards.
2026-08-23 23:51:43 -07:00

232 lines
8.4 KiB
Go

// SPDX-FileCopyrightText: 2026 LINUXexpert-org
// SPDX-License-Identifier: GPL-3.0-or-later
package stalwartapi
import (
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"net/url"
"sort"
"strings"
)
// Stalwart 0.15.x - the version this tool migrates *from* - has no
// urn:stalwart:jmap capability and no JMAP management endpoint: POST /api
// returns 404 there. Its management API is REST, at GET /api/principal,
// and that is the only way to enumerate the pre-migration directory.
//
// This was found by running preflight against a real 0.15.5 instance, not
// from documentation: the published schema reference documents 0.16, and
// following it alone produced a tool that could not read the source
// version it exists to migrate. The shapes below were confirmed against
// that live server.
//
// GET /api/principal?types=individual&limit=100&page=1
// {"data":{"items":[{"id":4,"type":"individual","name":"alice",
// "emails":["[email protected]"],"usedQuota":9207}],
// "total":3}}
//
// Two limits of the 0.15 side are worth stating plainly, because they
// decide what the post-migration comparison can actually assert:
//
// - There is no per-mailbox message count anywhere in this API, and the
// impersonation mechanism 0.16 offers (the `<target>%<impersonator>`
// composite login MailboxSnapshot uses) returns 401 on 0.15.5. So a
// pre-migration snapshot cannot carry message counts, and a
// before/after comparison of them is impossible for the boundary
// migration this tool is built for.
// - What both versions do expose per account is used quota in bytes
// (`usedQuota` here, `usedDiskQuota` on 0.16's x:Account). That is a
// real content measure - it moves when mail is lost - so it is what
// the integrity comparison uses across the boundary.
const restPrincipalPageSize = 100
// stalwartManagementCapability is advertised by instances whose management
// API is the JMAP one (0.16+). Its absence is what distinguishes a 0.15.x
// instance, and is a positive signal rather than an inference from a failed
// call.
const stalwartManagementCapability = "urn:stalwart:jmap"
// hasRESTManagement reports whether this instance serves the v0.15.x REST
// management API, by asking it for a single principal.
//
// This replaced a capability check, which cannot work: *neither* version
// advertises urn:stalwart:jmap. A real 0.15.5 doesn't, and a fully
// migrated, fully configured 0.16.14 doesn't either - verified against
// both. Dispatching on the capability sent 0.16 instances down the 0.15
// REST path, where every call 404s.
//
// So the client asks what the instance actually serves instead. 0.15.x
// answers GET /api/principal with a principal list; 0.16.14 returns 404
// for that path and serves JMAP management objects at the endpoint its
// session document advertises. A cheap probe is less elegant than a
// declared capability and has the considerable advantage of being true.
func (c *Client) hasRESTManagement(ctx context.Context) (bool, error) {
endpoint := strings.TrimRight(c.BaseURL, "/") + "/api/principal?limit=1"
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return false, err
}
req.SetBasicAuth(c.Username, c.Password)
resp, err := c.httpClient().Do(req)
if err != nil {
return false, fmt.Errorf("stalwartapi: probe %s: %w", endpoint, err)
}
defer resp.Body.Close()
io.Copy(io.Discard, io.LimitReader(resp.Body, 1<<16))
switch resp.StatusCode {
case http.StatusOK:
return true, nil
case http.StatusNotFound:
return false, nil
case http.StatusUnauthorized, http.StatusForbidden:
// The path exists but these credentials can't use it. Say so here
// rather than falling through to the other API and reporting a
// confusing error from there instead.
return false, fmt.Errorf("stalwartapi: %s returned %s - the credentials are not accepted for management operations", endpoint, resp.Status)
default:
return false, nil
}
}
type restPrincipal struct {
ID int `json:"id"`
Type string `json:"type"`
Name string `json:"name"`
Emails []string `json:"emails"`
UsedQuota int64 `json:"usedQuota"`
}
type restPrincipalPage struct {
Data struct {
Items []restPrincipal `json:"items"`
Total int `json:"total"`
} `json:"data"`
}
// restPrincipals fetches every principal of the given type, following the
// API's 1-based page/limit pagination rather than assuming one request
// returns everything - an install with more accounts than the page size
// would otherwise be silently truncated, and a truncated "before" snapshot
// would make the post-migration comparison claim more than it checked.
func (c *Client) restPrincipals(ctx context.Context, principalType string) ([]restPrincipal, error) {
var all []restPrincipal
for page := 1; ; page++ {
q := url.Values{}
if principalType != "" {
q.Set("types", principalType)
}
q.Set("limit", fmt.Sprint(restPrincipalPageSize))
q.Set("page", fmt.Sprint(page))
endpoint := strings.TrimRight(c.BaseURL, "/") + "/api/principal?" + q.Encode()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
if err != nil {
return nil, err
}
req.SetBasicAuth(c.Username, c.Password)
resp, err := c.httpClient().Do(req)
if err != nil {
return nil, fmt.Errorf("stalwartapi: list principals: %w", err)
}
body, readErr := io.ReadAll(io.LimitReader(resp.Body, 1<<20))
resp.Body.Close()
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("stalwartapi: GET %s returned %s: %s", endpoint, resp.Status, strings.TrimSpace(string(body)))
}
if readErr != nil {
return nil, fmt.Errorf("stalwartapi: read principal list: %w", readErr)
}
var parsed restPrincipalPage
if err := json.Unmarshal(body, &parsed); err != nil {
return nil, fmt.Errorf("stalwartapi: parse principal list: %w", err)
}
all = append(all, parsed.Data.Items...)
if len(parsed.Data.Items) == 0 || len(all) >= parsed.Data.Total {
return all, nil
}
}
}
// principalSnapshotREST builds a Snapshot from the 0.15.x REST management
// API. MailboxCounts is deliberately left empty: see this file's opening
// comment for why counts cannot be obtained from a 0.15 instance at all.
func (c *Client) principalSnapshotREST(ctx context.Context) (*Snapshot, error) {
individuals, err := c.restPrincipals(ctx, "individual")
if err != nil {
return nil, err
}
domainPrincipals, err := c.restPrincipals(ctx, "domain")
if err != nil {
return nil, err
}
snap := &Snapshot{
AccountCount: len(individuals),
UsedQuota: make(map[string]int64, len(individuals)),
}
for _, p := range individuals {
snap.UsedQuota[accountKey(p)] = p.UsedQuota
}
domainSet := map[string]bool{}
for _, d := range domainPrincipals {
if d.Name != "" {
domainSet[d.Name] = true
}
}
// Fall back to the domains implied by account addresses if the
// instance has no explicit domain principals.
for _, p := range individuals {
for _, email := range p.Emails {
if at := strings.LastIndex(email, "@"); at >= 0 && at+1 < len(email) {
domainSet[email[at+1:]] = true
}
}
}
for d := range domainSet {
snap.Domains = append(snap.Domains, d)
}
sort.Strings(snap.Domains)
return snap, nil
}
// accountKey identifies an account the same way both API generations can:
// by its primary email address where it has one, falling back to the bare
// login name. The v0.16 migration rewrites bare names into addresses, which
// is exactly why the comparison side matches on local part as well.
func accountKey(p restPrincipal) string {
if len(p.Emails) > 0 && p.Emails[0] != "" {
return p.Emails[0]
}
return p.Name
}
// TenantNames returns the tenant principals on a v0.15.x instance.
//
// Multi-tenancy has to be detected before a migration starts, because
// Stalwart's own converter does not survive it: it emits the Tenant and the
// Domains correctly and then every Account with `tenantId: null`, so the
// account references a tenant-owned domain while belonging to no tenant and
// the apply is rejected with `invalidForeignKey`. Observed on a real
// migration, at the point where the mail server was already stopped.
func (c *Client) TenantNames(ctx context.Context) ([]string, error) {
tenants, err := c.restPrincipals(ctx, "tenant")
if err != nil {
return nil, err
}
names := make([]string, 0, len(tenants))
for _, t := range tenants {
if t.Name != "" {
names = append(names, t.Name)
}
}
sort.Strings(names)
return names, nil
}