Fix three defects a full VM migration exposed
Ran a complete 0.15.5 -> 0.16.14 migration of the smoke VM, driving the
phases in the order the real pipeline will. It worked - all mail intact and
readable afterwards, all ten listeners up, cutover executed for the first
time ever and checkpoint resume exercised - and it exposed three defects.
1. The converted config was installed root-owned while the service runs as
its own user. Stalwart crash-looped 28 times on "Failed to read data
store settings: Permission denied", minutes after the mistake and
nowhere near it. This is the same ownership trap that retired the
rollback implementation, in a new place: writing files as root is the
natural thing for a tool running as root to do, and it is wrong every
time the service is not root.
Cutover now installs the config itself, copying ownership and mode from
the config being replaced.
2. v0.16.14 does not serve /api - the endpoint stalwartapi assumed.
Confirmed against a fully migrated, fully configured, serving instance
rather than a sandbox: /api, /api/principal and /jmap/ all 404. The JMAP
endpoint is the one the session document advertises, which is what RFC
8620 discovery is for.
The client now discovers it, re-basing the advertised path onto the
operator's host: a real instance advertises its canonical public URL
("https://mail.smoke.test/jmap/") which frequently isn't reachable from
where this tool runs. The session is authoritative about the path; the
operator is authoritative about the host.
3. Dispatching on the urn:stalwart:jmap capability was wrong, because
NEITHER version advertises it - not 0.15.5, and not a fully migrated
0.16.14. That sent 0.16 instances down the 0.15 REST path where every
call 404s. The client probes what the instance actually serves instead.
Less elegant than a declared capability, with the advantage of being
true.
Also: a JMAP "forbidden" now explains itself. An account holding the admin
role before the migration was refused x:Account/query afterwards, and a
bare "forbidden" gives an operator nowhere to start. Whether the role
failed to carry or v0.16 wants different permissions was not isolated, and
that question is recorded as open - it gates quota recalculation and any
post-migration validation.
Verified against both live instances: the 0.15.5 reports 3 accounts and its
domain over REST, and the migrated 0.16.14 routes to JMAP, finds the right
endpoint, and returns the explained refusal.
This commit is contained in:
@@ -388,3 +388,63 @@ func TestRunSchedulesOneQuotaTaskPerAccountAndWaits(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// A full migration crash-looped 28 times on "Failed to read data store
|
||||
// settings: Permission denied" because the converted config was written as
|
||||
// root while the service runs as its own user. The failure surfaced minutes
|
||||
// later in the journal, not at the moment of the mistake, which is what
|
||||
// makes it worth a test rather than care.
|
||||
func TestRunInstallsTheConfigWithOwnershipTheServiceCanRead(t *testing.T) {
|
||||
store, rs, opts := migratedRun(t)
|
||||
dir := t.TempDir()
|
||||
|
||||
// The config being replaced, standing in for the one the old version
|
||||
// ran with - restrictive mode, so a naive copy would lock the service
|
||||
// out of its own config.
|
||||
oldConfig := filepath.Join(dir, "config.toml")
|
||||
if err := os.WriteFile(oldConfig, []byte("[server]\n"), 0o640); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
converted := filepath.Join(dir, "converted.json")
|
||||
if err := os.WriteFile(converted, []byte(`{"@type":"RocksDb","path":"/opt/stalwart/data"}`), 0o600); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
installed := filepath.Join(dir, "config.json")
|
||||
|
||||
opts.ConfigSource = converted
|
||||
opts.ConfigPath = installed
|
||||
opts.ConfigOwnerReference = oldConfig
|
||||
|
||||
report, err := Run(context.Background(), store, rs, opts)
|
||||
if err != nil {
|
||||
t.Fatalf("Run: %v\n%s", err, report)
|
||||
}
|
||||
if got := readFile(t, installed); !strings.Contains(got, "RocksDb") {
|
||||
t.Errorf("installed config = %q, want the converted one", got)
|
||||
}
|
||||
info, err := os.Stat(installed)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// Mode comes from the file being replaced, not from the source's 0600.
|
||||
if info.Mode().Perm() != 0o640 {
|
||||
t.Errorf("installed config mode = %v, want 0640 copied from the old config", info.Mode().Perm())
|
||||
}
|
||||
// The unit must point at the installed config, not the scratch copy.
|
||||
if unit := readFile(t, opts.ServiceUnitPath); !strings.Contains(unit, installed) {
|
||||
t.Errorf("unit does not reference the installed config:\n%s", unit)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRunSkipsConfigInstallWhenThereIsNothingToInstall(t *testing.T) {
|
||||
store, rs, opts := migratedRun(t)
|
||||
report, err := Run(context.Background(), store, rs, opts)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for _, res := range report.Results {
|
||||
if res.Name == "install-config" && res.Status != StatusSkipped {
|
||||
t.Errorf("install-config = %s, want skip when no ConfigSource is given", res.Status)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user