jcoffey-dev
bd6a605d61
Takes the flat module count from 66 to 42, continuing what admin/ and
calendar/ started.
lib/mailbox/ archiveDate, emptyFolder, folderMove, labelTree,
mailboxName, mailboxRoute
lib/sieve/ sieve, sieveApply, sieveFolders
lib/input/ keyboard, swipe, touch, listSelection, dropUpload
lib/notify/ notify, webpush, webpushEnable
lib/sw/ swCache, swFacts, staleBuild
lib/text/ html, markdown, text, emlName
FOUR THINGS THE FILENAMES GET WRONG, each checked by reading the file
rather than trusting what it is called:
- appFolder is not a mailbox. It is the `ihasmail` folder in JMAP
*Files*, where the client keeps signature images and synced settings.
It stays flat.
- format holds no formatting of text. It re-exports the date and clock
formatters, so it belongs with dates/datetime, not with text/.
- preview is the file viewer deciding what it can show without
downloading, and source is where to point someone asking for this
instance's AGPL source. Neither is about text.
- notify is not Web Push. It is the tab title, the favicon badge and
the new-mail sound -- in-app notification, which is why it sits with
webpush rather than under sw/ with the service worker's own concerns.
threadScroll stays flat too: it decides where a conversation opens, which
is view state rather than a gesture, and input/ is honest only if
everything in it interprets something the reader did.
No behavior change. Almost every reference was on the @/ alias; eight
relative imports in files that did not move, or that moved away from a
sibling, needed rewriting by hand.
69 lines
2.5 KiB
TypeScript
69 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { navSwipeThreshold, swipeNavDirection, swipeThreshold, lockAxis } from "@/lib/input/touch";
|
|
|
|
describe("navSwipeThreshold", () => {
|
|
it("asks for more travel than a row swipe does, at every width", () => {
|
|
// Not because the consequence is bigger -- stepping back undoes it -- but
|
|
// because this gesture reveals nothing on the way and offers no Undo
|
|
// after, so the distance is the only chance to not mean it.
|
|
for (const width of [320, 360, 414, 768, 1024]) {
|
|
expect(navSwipeThreshold(width)).toBeGreaterThan(swipeThreshold(width));
|
|
}
|
|
});
|
|
|
|
it("is a share of the width, bounded at both ends", () => {
|
|
expect(navSwipeThreshold(360)).toBe(108);
|
|
expect(navSwipeThreshold(200)).toBe(80); // floor
|
|
expect(navSwipeThreshold(1000)).toBe(180); // ceiling
|
|
});
|
|
});
|
|
|
|
describe("swipeNavDirection", () => {
|
|
const W = 400; // threshold is 120 at this width
|
|
|
|
it("goes forward when the finger drags left, the way pages turn", () => {
|
|
expect(swipeNavDirection(-200, W)).toBe(1);
|
|
});
|
|
|
|
it("goes back when the finger drags right", () => {
|
|
expect(swipeNavDirection(200, W)).toBe(-1);
|
|
});
|
|
|
|
it("does nothing short of the threshold, in either direction", () => {
|
|
expect(swipeNavDirection(-60, W)).toBe(0);
|
|
expect(swipeNavDirection(60, W)).toBe(0);
|
|
expect(swipeNavDirection(0, W)).toBe(0);
|
|
});
|
|
|
|
it("fires exactly at the threshold and not a pixel before", () => {
|
|
const at = navSwipeThreshold(W);
|
|
expect(swipeNavDirection(-at, W)).toBe(1);
|
|
expect(swipeNavDirection(-(at - 1), W)).toBe(0);
|
|
expect(swipeNavDirection(at, W)).toBe(-1);
|
|
expect(swipeNavDirection(at - 1, W)).toBe(0);
|
|
});
|
|
|
|
it("scales with the width, so a tablet asks for more than a phone", () => {
|
|
// The same 120px drag commits on a narrow screen and does not on a wide one.
|
|
expect(swipeNavDirection(-120, 360)).toBe(1);
|
|
expect(swipeNavDirection(-120, 1024)).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe("the axis lock this shares with the row swipe", () => {
|
|
it("keeps a mostly-vertical drag as a scroll, which is what the day grid needs", () => {
|
|
// The day view scrolls through the hours; a scroll misread as a swipe
|
|
// throws the reader into another day.
|
|
expect(lockAxis(20, 30)).toBe("y");
|
|
expect(lockAxis(30, 25)).toBe("y");
|
|
});
|
|
|
|
it("commits to sideways only when it is clearly sideways", () => {
|
|
expect(lockAxis(40, 10)).toBe("x");
|
|
});
|
|
|
|
it("is undecided until the drag has moved at all", () => {
|
|
expect(lockAxis(2, 2)).toBeNull();
|
|
});
|
|
});
|