ihasmail spoke to two generations of Stalwart that are less alike than their version numbers suggest: 0.16 replaced the REST management API with JMAP registry objects, changed the shape of FileNode, split its rights up, and moved configuration into the store. Carrying both meant 34 branch points across nine files, a 92-line compatibility shim whose only job was telling them apart, a parallel REST implementation of every credential operation, and a mock that had to model both. The branches were not the real cost. The cost was that a wrong answer about which generation had answered always had somewhere to fall back to, so it failed quietly rather than loudly: one capability looked for in the wrong place downgraded every real 0.16 server onto the 0.15 path, which posted the current password to an endpoint 0.16 had removed, reported the wrong generation on About, and ran Files on the older code. It reached production and was recorded as verified when it was not. The mock mirrored the same wrong placement, which is why the tests agreed. Removed: the filenode compatibility shim, the dual "registry" | "legacy" backend in account.ts, the pre-0.16 generation in AccountInfo and everything that read it, the mock's LEGACY mode and dev:mock:legacy, and the three test files that existed only to pin 0.15 behaviour. Sign-in now refuses an older server by name, once, rather than letting Files, the account locale and credentials each fail in their own way with nothing connecting them. It says the credentials were fine -- someone hitting this has typed a correct password, and telling them otherwise sends them round in circles -- and names the tag to build from. Four tests cover it, including that no session cookie is minted and that bad credentials on such a server are still a plain 401. Two fallbacks went that were not strictly about 0.15, and both for the same reason the removal is happening. Files no longer answers a refused filter or sort by fetching every node in the account, which would hide a real fault behind a performance cliff nobody would notice. And the app folder lookups now filter on parentId/isTopLevel alone and match names client-side, since `name` is not a filter Stalwart is known to implement and one it does not know fails the whole query rather than being ignored. The last release that runs on 0.15 is tagged stalwart-0.15-support. Verified against the mock end to end: sign-in, the Files tree on the 0.16 path with the app folder hidden, and self-service credentials over the registry. 226 web + 75 server tests pass; typecheck and build clean.
74 lines
3.2 KiB
TypeScript
74 lines
3.2 KiB
TypeScript
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
/**
|
|
* ihasmail requires Stalwart 0.16 or newer. Sign-in is where that is enforced,
|
|
* and it matters that it is enforced *there*: the alternative is signing
|
|
* someone in and letting Files, the account locale and self-service
|
|
* credentials each fail in their own way, with nothing to connect the three or
|
|
* to say what the real problem is.
|
|
*
|
|
* The refusal also has to keep two things apart that look the same from the
|
|
* outside. Bad credentials are a 401 the user can fix by typing again; an
|
|
* unsupported server is not, and telling someone their password is wrong when
|
|
* it is not would send them round in circles.
|
|
*/
|
|
|
|
const PORT = 18799;
|
|
process.env.MOCK_PORT = String(PORT);
|
|
process.env.MOCK_USER = "[email protected]";
|
|
process.env.MOCK_PASS = "demo-password";
|
|
process.env.MOCK_NO_REGISTRY = "1"; // a server without urn:stalwart:jmap
|
|
process.env.STALWART_URL = `http://127.0.0.1:${PORT}`;
|
|
process.env.APP_SECRET = "test-secret-for-login-guard";
|
|
|
|
const mock = await import("./mock/index.js");
|
|
const { createApp } = await import("./app.js");
|
|
|
|
const app = createApp();
|
|
const HEADERS = { "content-type": "application/json", "x-requested-with": "ihasmail" };
|
|
|
|
async function login(body: unknown): Promise<{ status: number; body: any; setCookie: string | null }> {
|
|
const res = await app.request("/api/auth/login", { method: "POST", headers: HEADERS, body: JSON.stringify(body) });
|
|
const text = await res.text();
|
|
return { status: res.status, body: text ? JSON.parse(text) : null, setCookie: res.headers.get("set-cookie") };
|
|
}
|
|
|
|
before(() => {
|
|
assert.equal(process.env.MOCK_NO_REGISTRY, "1");
|
|
});
|
|
|
|
after(() => {
|
|
(mock as { server?: { close(): void } }).server?.close();
|
|
});
|
|
|
|
test("a server without the registry is refused, with good credentials", async () => {
|
|
const res = await login({ username: "[email protected]", password: "demo-password" });
|
|
assert.equal(res.status, 501);
|
|
assert.equal(res.body.error, "unsupported_server");
|
|
});
|
|
|
|
test("the message says the credentials were fine, and names the way out", async () => {
|
|
const { body } = await login({ username: "[email protected]", password: "demo-password" });
|
|
// Someone hitting this has typed a correct password. Saying so is the
|
|
// difference between "upgrade your server" and "try your password again".
|
|
assert.match(body.message, /credentials are fine/i);
|
|
assert.match(body.message, /0\.16/);
|
|
assert.match(body.message, /stalwart-0\.15-support/, "the tag to build from if they cannot upgrade");
|
|
});
|
|
|
|
test("no session is minted for a server we cannot talk to", async () => {
|
|
// A cookie here would leave a signed-in session against a server every
|
|
// other request is going to fail on.
|
|
const res = await login({ username: "[email protected]", password: "demo-password" });
|
|
assert.equal(res.setCookie, null);
|
|
});
|
|
|
|
test("bad credentials on such a server are still a 401, not the server error", async () => {
|
|
// The upstream session request fails first, and that answer is the honest
|
|
// one: we never got far enough to learn what the server supports.
|
|
const res = await login({ username: "[email protected]", password: "wrong-password" });
|
|
assert.equal(res.status, 401);
|
|
assert.notEqual(res.body.error, "unsupported_server");
|
|
});
|