coffey-labs/ihasmail
1
2 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity Sponsor

Settings: the test notification shows in the tab you're in #51

Merged
jcoffey-dev merged 1 commits from fix/test-notification into main 2026-10-09 23:34:03 +00:00
Conversation 0 Commits 1 Files Changed 3
+52 -4
jcoffey-dev commented 2026-10-09 23:21:46 +00:00
Owner
Copy link
Copy source

Fixes #48. Thanks again @dwofford, spot on.

Notifications are held back while you're looking at the tab, and the test button is always pressed in that tab, so you only ever got the sound. The test now skips that check; new mail doesn't.

Fixes #48. Thanks again @dwofford, spot on. Notifications are held back while you're looking at the tab, and the test button is always pressed in that tab, so you only ever got the sound. The test now skips that check; new mail doesn't.
jcoffey-dev added 1 commit 2026-10-09 23:21:46 +00:00
Settings: the test notification shows in the tab you're in
ci / node (pull_request) Skipped
Details
ci / version (pull_request) Skipped
Details
ci / docker-build (pull_request) Skipped
Details
ci / publish (pull_request) Skipped
Details
github/ci (branch) GitHub Actions
Details
ci / github (pull_request) Successful in 2m43s
Details
28822cd264 
showNotification holds back new-mail notifications for a visible,
focused tab, and the Test notification button is always pressed in one,
so the test never appeared (only its sound played). The button now
passes force, which skips that check; new mail keeps it.

Fixes #48
jcoffey-dev merged commit aee79a591d into main 2026-10-09 23:34:03 +00:00
jcoffey-dev deleted branch fix/test-notification 2026-10-09 23:34:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Dependency updates
 documentation
Docs, README or site copy
 duplicate
Already tracked elsewhere
 enhancement
New feature or improvement
 good first issue
Good for newcomers
 help wanted
Contributions welcome
 invalid
Not a valid issue
 needs info
Waiting on the reporter for details
 question
Needs an answer, not a code change
 security
Security issue or hardening
 translation
New language or translation fixes
 wontfix
Will not be worked on
priority
p1
High priority
priority
p2
Medium priority
priority
p3
Low priority
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jcoffey-dev (John Coffey)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coffey-labs/ihasmail#51